98865 2012-10-09 23:35:28 -0700 Tests failure on Chromium Mac after r130821 2012-10-10 19:47:06 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac Unspecified RESOLVED FIXED P2 Normal --- 1 enrica leviw adele bashi eric leviw mitz tony webkit.review.bot oldest_to_newest 738620 0 enrica 2012-10-09 23:35:28 -0700 The following tests are still failing on Mac Chromium. [ Mac ]fast/lists/003-vertical.html [Failure] [ Mac ]fast/text/international/vertical-text-glyph-test.html [Failure] [ Mac ]fast/text/shaping/shaping-selection-rect.html [Failure] even after disabling the optimization for HarfBuzz. Updated TextExpectations. 738653 1 abarth 2012-10-10 00:03:53 -0700 *** Bug 98867 has been marked as a duplicate of this bug. *** 738690 2 mitz 2012-10-10 00:48:57 -0700 Enrica and I think that this is related to Chromium’s use of HarfBuzz on Mac. It’s also possible, though seems unlikely, that it’s related to sub-pixel layout. 739075 3 tony 2012-10-10 10:30:39 -0700 If the tests are still failing, should we re-enable the optimization for harfbuzz-ng platforms? Maybe bashi has time to look into these failures. 739089 4 leviw 2012-10-10 10:33:17 -0700 This isn't a sub-pixel issue. The differences here are in the float values in the line box tree. My money is on HarfBuzz as well :) Thanks for helping us track this. 739095 5 enrica 2012-10-10 10:35:31 -0700 I think this is a good plan. To re-enable the optimization, all that needs to be done is remove the #if USE(HARFBUZZ_NG) and the remove the UNUSED_PARAMETER at the beginning of setLogicalWidthForTextRun 739456 6 168109 leviw 2012-10-10 18:03:08 -0700 Created attachment 168109 Patch 739477 7 168109 enrica 2012-10-10 18:35:56 -0700 Comment on attachment 168109 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=168109&action=review > Source/WebCore/rendering/RenderBlockLineLayout.cpp:715 > +#if !(PLATFORM(CHROMIUM) && OS(DARWIN)) I think you want this to be #if (PLATFORM(CHROMIUM) && OS(DARWIN)) otherwise you get a compilation error 739529 8 168109 webkit.review.bot 2012-10-10 19:47:03 -0700 Comment on attachment 168109 Patch Clearing flags on attachment: 168109 Committed r131000: <http://trac.webkit.org/changeset/131000> 739530 9 webkit.review.bot 2012-10-10 19:47:06 -0700 All reviewed patches have been landed. Closing bug. 168109 2012-10-10 18:03:08 -0700 2012-10-10 19:47:03 -0700 Patch bug-98865-20121010180206.patch text/plain 3472 leviw SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMDk4NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEwLTEwICBMZXZpIFdl aW50cmF1YiAgPGxldml3QGNocm9taXVtLm9yZz4KKworICAgICAgICBUZXN0cyBmYWlsdXJlIG9u IENocm9taXVtIE1hYyBhZnRlciByMTMwODIxCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD05ODg2NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFVwZGF0aW5nIHRoZSBjaGVjayBmb3IgVVNFKEhBUkZCVVpaX05H KSB0byBjaGVjayBmb3IgTWFjIENocm9taXVtLCBhcyB0aGUgSEFSRkJVWlpfTkcgZmxhZyBpc24n dAorICAgICAgICBhY3R1YWxseSBzZXQsIGRlc3BpdGUgdXMgdXNpbmcgSGFyZmJ1enouIFRoaXMg dW5icmVha3MgQ2hyb21pdW0gTWFjIGFzIHdlIGRpYWdub3NlIHRoZSByb290CisgICAgICAgIGNh dXNlIG9mIHRoaXMgaXNzdWUuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQmxvY2tMaW5l TGF5b3V0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnNldExvZ2ljYWxXaWR0aEZvclRleHRSdW4p OgorCiAyMDEyLTEwLTEwICBNT1JJVEEgSGFqaW1lICA8bW9ycml0YUBnb29nbGUuY29tPgogCiAg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTY2NApJbmRl eDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrTGluZUxheW91dC5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrTGluZUxheW91 dC5jcHAJKHJldmlzaW9uIDEzMDk2NSkKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJCbG9ja0xpbmVMYXlvdXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03MTIsNyArNzEyLDcgQEAg cHVibGljOgogc3RhdGljIGlubGluZSB2b2lkIHNldExvZ2ljYWxXaWR0aEZvclRleHRSdW4oUm9v dElubGluZUJveCogbGluZUJveCwgQmlkaVJ1biogcnVuLCBSZW5kZXJUZXh0KiByZW5kZXJlciwg ZmxvYXQgeFBvcywgY29uc3QgTGluZUluZm8mIGxpbmVJbmZvLAogICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgR2x5cGhPdmVyZmxvd0FuZEZhbGxiYWNrRm9udHNN YXAmIHRleHRCb3hEYXRhTWFwLCBWZXJ0aWNhbFBvc2l0aW9uQ2FjaGUmIHZlcnRpY2FsUG9zaXRp b25DYWNoZSwgV29yZE1lYXN1cmVtZW50cyYgd29yZE1lYXN1cmVtZW50cykKIHsKLSNpZiBVU0Uo SEFSRkJVWlpfTkcpCisjaWYgIShQTEFURk9STShDSFJPTUlVTSkgJiYgT1MoREFSV0lOKSkKICAg ICBVTlVTRURfUEFSQU0od29yZE1lYXN1cmVtZW50cyk7CiAjZW5kaWYKICAgICBIYXNoU2V0PGNv bnN0IFNpbXBsZUZvbnREYXRhKj4gZmFsbGJhY2tGb250czsKQEAgLTc0MCw3ICs3NDAsNyBAQCBz dGF0aWMgaW5saW5lIHZvaWQgc2V0TG9naWNhbFdpZHRoRm9yVGV4CiAgICAgfQogICAgIGZsb2F0 IG1lYXN1cmVkV2lkdGggPSAwOwogCi0jaWYgIVVTRShIQVJGQlVaWl9ORykKKyNpZiAhKFBMQVRG T1JNKENIUk9NSVVNKSAmJiBPUyhEQVJXSU4pKQogICAgIGJvb2wga2VybmluZ0lzRW5hYmxlZCA9 IGZvbnQudHlwZXNldHRpbmdGZWF0dXJlcygpICYgS2VybmluZzsKICAgICAKICAgICAvLyBTaW5j ZSB3ZSBkb24ndCBjYWNoZSBnbHlwaCBvdmVyZmxvd3MsIHdlIG5lZWQgdG8gcmUtbWVhc3VyZSB0 aGUgcnVuIGlmCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMzA5ODcpCisrKyBMYXlvdXRUZXN0cy9DaGFu Z2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAxMi0xMC0xMCAgTGV2aSBX ZWludHJhdWIgIDxsZXZpd0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgVGVzdHMgZmFpbHVyZSBv biBDaHJvbWl1bSBNYWMgYWZ0ZXIgcjEzMDgyMQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTg4NjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBSZW1vdmluZyBmYWlsaW5nIHRlc3QgZW50cmllcy4KKworICAg ICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL1Rlc3RFeHBlY3RhdGlvbnM6CisKIDIwMTItMTAtMTAg IE1PUklUQSBIYWppbWUgIDxtb3JyaXRhQGdvb2dsZS5jb20+CiAKICAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk1NjY0CkluZGV4OiBMYXlvdXRUZXN0cy9w bGF0Zm9ybS9jaHJvbWl1bS9UZXN0RXhwZWN0YXRpb25zCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRl c3RzL3BsYXRmb3JtL2Nocm9taXVtL1Rlc3RFeHBlY3RhdGlvbnMJKHJldmlzaW9uIDEzMDk2NSkK KysrIExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL1Rlc3RFeHBlY3RhdGlvbnMJKHdvcmtp bmcgY29weSkKQEAgLTQwNDIsOCArNDA0Miw0IEBAIHdlYmtpdC5vcmcvYi85ODY4NiBlZGl0aW5n L3Bhc3RlYm9hcmQvZGEKIHdlYmtpdC5vcmcvYi85ODY5OSBbIExpb24gXSBmYXN0L3dyaXRpbmct bW9kZS92ZXJ0aWNhbC1zdWJzdC1mb250LXZlcnQtbm8tZGZsdC5odG1sIFsgQ3Jhc2ggXQogd2Vi a2l0Lm9yZy9iLzk4ODExIFsgTWFjIF0gZmFzdC90cmFuc2Zvcm1zL3RyYW5zZm9ybWVkLWZvY3Vz ZWQtdGV4dC1pbnB1dC5odG1sIFsgUGFzcyBJbWFnZU9ubHlGYWlsdXJlIF0KIAotd2Via2l0Lm9y Zy9iLzk4ODY3IFsgTWFjIF0gZmFzdC9saXN0cy8wMDMtdmVydGljYWwuaHRtbCBbIEltYWdlT25s eUZhaWx1cmUgXQotd2Via2l0Lm9yZy9iLzk4ODY3IFsgTWFjIF0gZmFzdC90ZXh0L2ludGVybmF0 aW9uYWwvdmVydGljYWwtdGV4dC1nbHlwaC10ZXN0Lmh0bWwgWyBGYWlsdXJlIEltYWdlT25seUZh aWx1cmUgXQotd2Via2l0Lm9yZy9iLzk4ODY3IFsgTWFjIF0gZmFzdC90ZXh0L3NoYXBpbmcvc2hh cGluZy1zZWxlY3Rpb24tcmVjdC5odG1sIFsgRmFpbHVyZSBJbWFnZU9ubHlGYWlsdXJlIF0KLQog d2Via2l0Lm9yZy9iLzk4OTQ4IFsgTGludXggRGVidWcgXSBodHRwL3Rlc3RzL21lZGlhL21lZGlh LXNvdXJjZS92aWRlby1tZWRpYS1zb3VyY2UtcGxheS5odG1sIFsgUEFTUyBDUkFTSCBdCg==