98860 2012-10-09 23:00:30 -0700 REGRESSION(r130838): The patch is causing X errors (=> crashes) on GTK 64-bit Release builder (Requested by zdobersek on #webkit). 2012-10-10 00:44:51 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 98873 98789 1 webkit.review.bot webkit.review.bot mrobinson zan oldest_to_newest 738581 0 webkit.review.bot 2012-10-09 23:00:30 -0700 http://trac.webkit.org/changeset/130838 broke the build: The patch is causing X errors (=> crashes) on GTK 64-bit Release builder (Requested by zdobersek on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 738584 1 167926 webkit.review.bot 2012-10-09 23:01:07 -0700 Created attachment 167926 ROLLOUT of r130838 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 738589 2 zan 2012-10-09 23:05:50 -0700 http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release/r130842%20(29609)/results.html An example of stderr output of a crashing test: STDERR: The program 'DumpRenderTree' received an X Window System error. STDERR: This probably reflects a bug in the program. STDERR: The error was 'BadValue (integer parameter out of range for operation)'. STDERR: (Details: serial 2988 error_code 2 request_code 25 minor_code 0) STDERR: (Note to programmers: normally, X errors are reported asynchronously; STDERR: that is, you will receive the error a while after causing it. STDERR: To debug your program, run it with the GDK_SYNCHRONIZE environment STDERR: variable to change this behavior. You can then get a meaningful STDERR: backtrace from your debugger if you break on the gdk_x_error() function.) STDERR: 738592 3 167926 webkit.review.bot 2012-10-09 23:10:04 -0700 Comment on attachment 167926 ROLLOUT of r130838 Clearing flags on attachment: 167926 Committed r130853: <http://trac.webkit.org/changeset/130853> 738593 4 webkit.review.bot 2012-10-09 23:10:07 -0700 All reviewed patches have been landed. Closing bug. 738671 5 webkit.review.bot 2012-10-10 00:24:28 -0700 Re-opened since this is blocked by bug 98873 167926 2012-10-09 23:01:07 -0700 2012-10-09 23:10:04 -0700 ROLLOUT of r130838 bug-98860-20121010060736.patch text/plain 3467 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwODUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0 ay9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggNzk2N2Y2ZTZl MGE2OTVjZDQyMjUzNGFlZDI2NDQ1MjJlYWU5NDc0My4uM2Q5OTRiNjM0NDMxOTE5NWZmMjY0OTAz ZDcxOTUxYTExMzA2ODU3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEy LTEwLTA5ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KKworICAg ICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTMwODM4LgorICAgICAgICBodHRwOi8vdHJh Yy53ZWJraXQub3JnL2NoYW5nZXNldC8xMzA4MzgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTk4ODYwCisKKyAgICAgICAgVGhlIHBhdGNoIGlzIGNhdXNp bmcgWCBlcnJvcnMgKD0+IGNyYXNoZXMpIG9uIEdUSyA2NC1iaXQKKyAgICAgICAgUmVsZWFzZSBi dWlsZGVyIChSZXF1ZXN0ZWQgYnkgemRvYmVyc2VrIG9uICN3ZWJraXQpLgorCisgICAgICAgICog d2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwOgorICAgICAgICAocmVzaXplV2ViVmlld0Zyb21BbGxv Y2F0aW9uKToKKyAgICAgICAgKHdlYmtpdF93ZWJfdmlld19zaXplX2FsbG9jYXRlKToKKyAgICAg ICAgKHdlYmtpdFdlYlZpZXdNYXApOgorCiAyMDEyLTEwLTA5ICBEYW5pZWwgRHJha2UgIDxkc2RA bGFwdG9wLm9yZz4KIAogICAgICAgICBbR1RLXSBQbHVnaW5zIGRvbid0IGRpc3BsYXkKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcCBiL1NvdXJj ZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcAppbmRleCA1YWMwNDg0MmQ1Zjg3 NmY3Mjc2Y2UwNmI0YmZkOGZiNTE2MzQ1ODA1Li41NTUxNzFhYTFjYjZkZTMzM2EwY2Y2M2NiM2Fh Mzk0ZjM5NGEwNDBkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0 d2Vidmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcu Y3BwCkBAIC04NDksMjEgKzg0OSwxNyBAQCBzdGF0aWMgdm9pZCB1cGRhdGVDaGlsZEFsbG9jYXRp b25Gcm9tUGVuZGluZ0FsbG9jYXRpb24oR3RrV2lkZ2V0KiBjaGlsZCwgdm9pZCopCiAgICAgKmFs bG9jYXRpb24gPSBJbnRSZWN0KCk7CiB9CiAKLXN0YXRpYyB2b2lkIHJlc2l6ZVdlYlZpZXdGcm9t QWxsb2NhdGlvbihXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3LCBHdGtBbGxvY2F0aW9uKiBhbGxvY2F0 aW9uLCBib29sIHNpemVDaGFuZ2VkKQorc3RhdGljIHZvaWQgcmVzaXplV2ViVmlld0Zyb21BbGxv Y2F0aW9uKFdlYktpdFdlYlZpZXcqIHdlYlZpZXcsIEd0a0FsbG9jYXRpb24qIGFsbG9jYXRpb24p CiB7CiAgICAgUGFnZSogcGFnZSA9IGNvcmUod2ViVmlldyk7CiAgICAgSW50U2l6ZSBvbGRTaXpl OwotICAgIEZyYW1lVmlldyogZnJhbWVWaWV3ID0gcGFnZS0+bWFpbkZyYW1lKCktPnZpZXcoKTsK LSAgICBpZiAoc2l6ZUNoYW5nZWQgJiYgZnJhbWVWaWV3KSB7CisgICAgaWYgKEZyYW1lVmlldyog ZnJhbWVWaWV3ID0gcGFnZS0+bWFpbkZyYW1lKCktPnZpZXcoKSkgewogICAgICAgICBvbGRTaXpl ID0gZnJhbWVWaWV3LT5zaXplKCk7CiAgICAgICAgIGZyYW1lVmlldy0+cmVzaXplKGFsbG9jYXRp b24tPndpZHRoLCBhbGxvY2F0aW9uLT5oZWlnaHQpOwogICAgIH0KIAogICAgIGd0a19jb250YWlu ZXJfZm9yYWxsKEdUS19DT05UQUlORVIod2ViVmlldyksIHVwZGF0ZUNoaWxkQWxsb2NhdGlvbkZy b21QZW5kaW5nQWxsb2NhdGlvbiwgMCk7CiAKLSAgICBpZiAoIXNpemVDaGFuZ2VkKQotICAgICAg ICByZXR1cm47Ci0KICAgICBXZWJLaXQ6OkNocm9tZUNsaWVudCogY2hyb21lQ2xpZW50ID0gc3Rh dGljX2Nhc3Q8V2ViS2l0OjpDaHJvbWVDbGllbnQqPihwYWdlLT5jaHJvbWUoKS0+Y2xpZW50KCkp OwogICAgIGNocm9tZUNsaWVudC0+d2lkZ2V0U2l6ZUNoYW5nZWQob2xkU2l6ZSwgSW50U2l6ZShh bGxvY2F0aW9uLT53aWR0aCwgYWxsb2NhdGlvbi0+aGVpZ2h0KSk7CiAgICAgY2hyb21lQ2xpZW50 LT5hZGp1c3RtZW50V2F0Y2hlcigpLT51cGRhdGVBZGp1c3RtZW50c0Zyb21TY3JvbGxiYXJzKCk7 CkBAIC04NzMsMTYgKzg2OSwxNyBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX3ZpZXdfc2l6ZV9h bGxvY2F0ZShHdGtXaWRnZXQqIHdpZGdldCwgR3RrQWxsb2NhdGlvbiogYWxsbwogewogICAgIEd0 a0FsbG9jYXRpb24gb2xkQWxsb2NhdGlvbjsKICAgICBndGtfd2lkZ2V0X2dldF9hbGxvY2F0aW9u KHdpZGdldCwgJm9sZEFsbG9jYXRpb24pOwotICAgIGJvb2wgc2l6ZUNoYW5nZWQgPSBhbGxvY2F0 aW9uLT53aWR0aCAhPSBvbGRBbGxvY2F0aW9uLndpZHRoIHx8IGFsbG9jYXRpb24tPmhlaWdodCAh PSBvbGRBbGxvY2F0aW9uLmhlaWdodDsKIAogICAgIEdUS19XSURHRVRfQ0xBU1Mod2Via2l0X3dl Yl92aWV3X3BhcmVudF9jbGFzcyktPnNpemVfYWxsb2NhdGUod2lkZ2V0LCBhbGxvY2F0aW9uKTsK KyAgICBpZiAoYWxsb2NhdGlvbi0+d2lkdGggPT0gb2xkQWxsb2NhdGlvbi53aWR0aCAmJiBhbGxv Y2F0aW9uLT5oZWlnaHQgPT0gb2xkQWxsb2NhdGlvbi5oZWlnaHQpCisgICAgICAgIHJldHVybjsK IAogICAgIFdlYktpdFdlYlZpZXcqIHdlYlZpZXcgPSBXRUJLSVRfV0VCX1ZJRVcod2lkZ2V0KTsK LSAgICBpZiAoc2l6ZUNoYW5nZWQgJiYgIWd0a193aWRnZXRfZ2V0X21hcHBlZCh3aWRnZXQpKSB7 CisgICAgaWYgKCFndGtfd2lkZ2V0X2dldF9tYXBwZWQod2lkZ2V0KSkgewogICAgICAgICB3ZWJW aWV3LT5wcml2LT5uZWVkc1Jlc2l6ZU9uTWFwID0gdHJ1ZTsKICAgICAgICAgcmV0dXJuOwogICAg IH0KLSAgICByZXNpemVXZWJWaWV3RnJvbUFsbG9jYXRpb24od2ViVmlldywgYWxsb2NhdGlvbiwg c2l6ZUNoYW5nZWQpOworICAgIHJlc2l6ZVdlYlZpZXdGcm9tQWxsb2NhdGlvbih3ZWJWaWV3LCBh bGxvY2F0aW9uKTsKIH0KIAogc3RhdGljIHZvaWQgd2Via2l0V2ViVmlld01hcChHdGtXaWRnZXQq IHdpZGdldCkKQEAgLTg5NSw3ICs4OTIsNyBAQCBzdGF0aWMgdm9pZCB3ZWJraXRXZWJWaWV3TWFw KEd0a1dpZGdldCogd2lkZ2V0KQogCiAgICAgR3RrQWxsb2NhdGlvbiBhbGxvY2F0aW9uOwogICAg IGd0a193aWRnZXRfZ2V0X2FsbG9jYXRpb24od2lkZ2V0LCAmYWxsb2NhdGlvbik7Ci0gICAgcmVz aXplV2ViVmlld0Zyb21BbGxvY2F0aW9uKHdlYlZpZXcsICZhbGxvY2F0aW9uLCB0cnVlKTsKKyAg ICByZXNpemVXZWJWaWV3RnJvbUFsbG9jYXRpb24od2ViVmlldywgJmFsbG9jYXRpb24pOwogICAg IHdlYlZpZXctPnByaXYtPm5lZWRzUmVzaXplT25NYXAgPSBmYWxzZTsKIH0KIAo=