98858 2012-10-09 22:17:59 -0700 [Chromium] Fix harfbuzz-ng related code after r130231 2012-10-09 23:23:35 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bashi bashi senorblanco tkent webkit.review.bot oldest_to_newest 738555 0 bashi 2012-10-09 22:17:59 -0700 r130231 didn't replace some first/second with key/value of harfbuzz-ng related code. 738558 1 167925 bashi 2012-10-09 22:20:30 -0700 Created attachment 167925 Patch 738561 2 bashi 2012-10-09 22:21:09 -0700 Kent-san, could you do rubber-stamp review? It's trivial fix. 738566 3 167925 tkent 2012-10-09 22:32:42 -0700 Comment on attachment 167925 Patch ok 738567 4 bashi 2012-10-09 22:33:20 -0700 Thanks! 738608 5 167925 webkit.review.bot 2012-10-09 23:23:32 -0700 Comment on attachment 167925 Patch Clearing flags on attachment: 167925 Committed r130854: <http://trac.webkit.org/changeset/130854> 738609 6 webkit.review.bot 2012-10-09 23:23:35 -0700 All reviewed patches have been landed. Closing bug. 167925 2012-10-09 22:20:30 -0700 2012-10-09 23:23:31 -0700 Patch bug-98858-20121010141929.patch text/plain 3051 bashi U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwODQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDExMTE5NTM4NzU5OGUw OWJiNmI0MjVjNGE4NzFmM2VjYjlmMGVhNS4uMTY3MmFmNzBkNzA1NTg2YTA1YWY4NDIxMjQxNjQz MWM5MWUzZjczNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTEwLTA5ICBLZW5p Y2hpIElzaGliYXNoaSAgPGJhc2hpQGNocm9taXVtLm9yZz4KKworICAgICAgICBbQ2hyb21pdW1d IEZpeCBoYXJmYnV6ei1uZyByZWxhdGVkIGNvZGUgYWZ0ZXIgcjEzMDIzMQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTg4NTgKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZXBsYWNlIGZpcnN0L3NlY29uZCB3 aXRoIGtleS92YWx1ZS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIE5vIGNoYW5nZXMgaW4gYmVo YXZpb3IuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9oYXJmYnV6ei9uZy9IYXJmQnV6 ek5HRmFjZVNraWEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6aGFyZmJ1enpHZXRHbHlwaCk6Cisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9TaW1wbGVGb250RGF0YVNraWEuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6U2ltcGxlRm9udERhdGE6OmNhblJlbmRlckNvbWJpbmluZ0NoYXJh Y3RlclNlcXVlbmNlKToKKwogMjAxMi0xMC0wOSAgS2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgU2hvdWxkIHJlamVjdCBpbnZhbGlkIGRhdGVzIGNvbnN0cnVjdGVk IHdpdGggbXVsdGlwbGUgZmllbGRzIFVJCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9oYXJmYnV6ei9uZy9IYXJmQnV6ek5HRmFjZVNraWEuY3BwIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvaGFyZmJ1enovbmcvSGFyZkJ1enpOR0ZhY2VTa2lh LmNwcAppbmRleCA1ZjljM2ZiZThkYTA2YWQ0NDdhZTNkODRhYzYyMjU0YzJhZmU5NWQzLi42ZDUx ZjQ3YjA1OWEzOTUxYmVjNmZmZGZjNGRlNmY5MjUyZjg1Yjk2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9oYXJmYnV6ei9uZy9IYXJmQnV6ek5HRmFjZVNraWEu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2hhcmZidXp6L25nL0hh cmZCdXp6TkdGYWNlU2tpYS5jcHAKQEAgLTk0LDEwICs5NCwxMCBAQCBzdGF0aWMgaGJfYm9vbF90 IGhhcmZidXp6R2V0R2x5cGgoaGJfZm9udF90KiBoYkZvbnQsIHZvaWQqIGZvbnREYXRhLCBoYl9j b2RlcG9pbgogICAgICAgICBwYWludC0+c2V0VGV4dEVuY29kaW5nKFNrUGFpbnQ6OmtVVEYzMl9U ZXh0RW5jb2RpbmcpOwogICAgICAgICB1aW50MTZfdCBnbHlwaDE2OwogICAgICAgICBwYWludC0+ dGV4dFRvR2x5cGhzKCZ1bmljb2RlLCBzaXplb2YoaGJfY29kZXBvaW50X3QpLCAmZ2x5cGgxNik7 Ci0gICAgICAgIHJlc3VsdC5pdGVyYXRvci0+c2Vjb25kID0gZ2x5cGgxNjsKKyAgICAgICAgcmVz dWx0Lml0ZXJhdG9yLT52YWx1ZSA9IGdseXBoMTY7CiAgICAgICAgICpnbHlwaCA9IGdseXBoMTY7 CiAgICAgfQotICAgICpnbHlwaCA9IHJlc3VsdC5pdGVyYXRvci0+c2Vjb25kOworICAgICpnbHlw aCA9IHJlc3VsdC5pdGVyYXRvci0+dmFsdWU7CiAgICAgcmV0dXJuICEhKmdseXBoOwogfQogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL1NpbXBsZUZv bnREYXRhU2tpYS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL1Np bXBsZUZvbnREYXRhU2tpYS5jcHAKaW5kZXggN2RmNjhmZDgwYjBjOTM4MWUyZTliYWFjZWRlMjkw ZTdmZTI4Yzk3Yi4uNGQzMmM3NGRiZjYzYzUyOWJiNGI5YTAxOWI5NjBjYWFhYWMzMTM3NSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9TaW1wbGVGb250 RGF0YVNraWEuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEv U2ltcGxlRm9udERhdGFTa2lhLmNwcApAQCAtMjY1LDcgKzI2NSw3IEBAIGJvb2wgU2ltcGxlRm9u dERhdGE6OmNhblJlbmRlckNvbWJpbmluZ0NoYXJhY3RlclNlcXVlbmNlKGNvbnN0IFVDaGFyKiBj aGFyYWN0ZXJzCiAKICAgICBXVEY6Okhhc2hNYXA8U3RyaW5nLCBib29sPjo6QWRkUmVzdWx0IGFk ZFJlc3VsdCA9IG1fY29tYmluaW5nQ2hhcmFjdGVyU2VxdWVuY2VTdXBwb3J0LT5hZGQoU3RyaW5n KGNoYXJhY3RlcnMsIGxlbmd0aCksIGZhbHNlKTsKICAgICBpZiAoIWFkZFJlc3VsdC5pc05ld0Vu dHJ5KQotICAgICAgICByZXR1cm4gYWRkUmVzdWx0Lml0ZXJhdG9yLT5zZWNvbmQ7CisgICAgICAg IHJldHVybiBhZGRSZXN1bHQuaXRlcmF0b3ItPnZhbHVlOwogCiAgICAgVUVycm9yQ29kZSBlcnJv ciA9IFVfWkVST19FUlJPUjsKICAgICBWZWN0b3I8VUNoYXIsIDQ+IG5vcm1hbGl6ZWRDaGFyYWN0 ZXJzKGxlbmd0aCk7CkBAIC0yNzgsNyArMjc4LDcgQEAgYm9vbCBTaW1wbGVGb250RGF0YTo6Y2Fu UmVuZGVyQ29tYmluaW5nQ2hhcmFjdGVyU2VxdWVuY2UoY29uc3QgVUNoYXIqIGNoYXJhY3RlcnMK ICAgICBtX3BsYXRmb3JtRGF0YS5zZXR1cFBhaW50KCZwYWludCk7CiAgICAgcGFpbnQuc2V0VGV4 dEVuY29kaW5nKFNrUGFpbnQ6OmtVVEYxNl9UZXh0RW5jb2RpbmcpOwogICAgIGlmIChwYWludC50 ZXh0VG9HbHlwaHMoJm5vcm1hbGl6ZWRDaGFyYWN0ZXJzWzBdLCBub3JtYWxpemVkTGVuZ3RoICog MiwgMCkpIHsKLSAgICAgICAgYWRkUmVzdWx0Lml0ZXJhdG9yLT5zZWNvbmQgPSB0cnVlOworICAg ICAgICBhZGRSZXN1bHQuaXRlcmF0b3ItPnZhbHVlID0gdHJ1ZTsKICAgICAgICAgcmV0dXJuIHRy dWU7CiAgICAgfQogICAgIHJldHVybiBmYWxzZTsK