98854 2012-10-09 21:37:38 -0700 Initialize $written variable in load-and-stall.php script 2012-10-09 23:02:54 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 noel.gordon noel.gordon tkent webkit.review.bot oldest_to_newest 738511 0 noel.gordon 2012-10-09 21:37:38 -0700 Initialize $written variable in load-sand-stall.php script 738513 1 167915 noel.gordon 2012-10-09 21:38:15 -0700 Created attachment 167915 Patch 738516 2 167916 noel.gordon 2012-10-09 21:41:08 -0700 Created attachment 167916 Patch 738574 3 167916 tkent 2012-10-09 22:41:11 -0700 Comment on attachment 167916 Patch AFAIK $written is initialized as 0 implicitly. Adding the initialization is good for code readability. 738576 4 noel.gordon 2012-10-09 22:47:01 -0700 Indeed. All bets are off if you include a script in another, however :( 738585 5 167916 webkit.review.bot 2012-10-09 23:02:50 -0700 Comment on attachment 167916 Patch Clearing flags on attachment: 167916 Committed r130852: <http://trac.webkit.org/changeset/130852> 738586 6 webkit.review.bot 2012-10-09 23:02:54 -0700 All reviewed patches have been landed. Closing bug. 167915 2012-10-09 21:38:15 -0700 2012-10-09 21:41:04 -0700 Patch bug-98854-20121010153715.patch text/plain 1229 noel.gordon U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwNjEzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMTc0MGQ3M2NlMzgyYjlhOGU1ZmEz MTQwNzA1ZDEwNjg1ZGU0MjZlOC4uZTg2YWVhMGRmMTM1YzBlYjgwMjI3MTc3M2Q0ZTJkZTBlZDcx MGJjMCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDExIEBACisyMDEyLTEwLTA5ICBOb2VsIEdvcmRvbiAgPG5v ZWwuZ29yZG9uQGdtYWlsLmNvbT4KKworICAgICAgICBJbml0aWFsaXplICR3cml0dGVuIHZhcmlh YmxlIGluIGxvYWQtYW5kLXN0YWxsLnBocCBzY3JpcHQKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGh0dHAvdGVzdHMvcmVzb3VyY2VzL2xvYWQtYW5k LXN0YWxsLnBocDoKKwogMjAxMi0xMC0wNyAgTmljayBDYXJ0ZXIgIDxuaWNrQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBbY2hyb21pdW1dIENyYXNoIGluIFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXJD aHJvbWl1bTo6c2V0Q29udGVudHNUb0ltYWdlCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRw L3Rlc3RzL3Jlc291cmNlcy9sb2FkLWFuZC1zdGFsbC5waHAgYi9MYXlvdXRUZXN0cy9odHRwL3Rl c3RzL3Jlc291cmNlcy9sb2FkLWFuZC1zdGFsbC5waHAKaW5kZXggNDUzMDQ4MWY0NzE4OWUyN2Fm ZTU2MWJjMzBiMDBiMTVkZWQyNTM2NS4uNjgzYmE5OTMzZTE0OWQ1ODhkNGU2ZDRmY2QwOTVkZDUw YjU0MTg5OSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9yZXNvdXJjZXMvbG9h ZC1hbmQtc3RhbGwucGhwCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvcmVzb3VyY2VzL2xv YWQtYW5kLXN0YWxsLnBocApAQCAtMTYsNyArMTYsNyBAQCBpZiAoaXNzZXQoJHN0YWxsQXQpICYm IGlzc2V0KCRzdGFsbEZvcikpIHsKICAgICAkc3RhbGxGb3IgPSAoaW50KSRzdGFsbEZvcjsKICAg ICBpZiAoJHN0YWxsQXQgPiBmaWxlc2l6ZSgkbmFtZSkpCiAgICAgICAgIGRpZSgiSW5jb3JyZWN0 IHZhbHVlIGZvciBzdGFsbEF0LiIpOwotCisgICAgJHdyaXR0ZW4gPSAwOwogICAgIHdoaWxlICgk d3JpdHRlbiA8ICRzdGFsbEF0KSB7CiAgICAgICAgICR3cml0ZSA9IDEwMjQ7CiAgICAgICAgIGlm ICgkd3JpdGUgPiAkc3RhbGxBdCAtICR3cml0dGVuKQo= 167916 2012-10-09 21:41:08 -0700 2012-10-09 23:02:50 -0700 Patch bug-98854-20121010154007.patch text/plain 1284 noel.gordon U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwNjEzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMTc0MGQ3M2NlMzgyYjlhOGU1ZmEz MTQwNzA1ZDEwNjg1ZGU0MjZlOC4uMDM5YjFjNzc0MTY1ZDVlMTAwNGYyMTU1YzBiMDMwM2UxNjIw Zjg0NCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEyLTEwLTA5ICBOb2VsIEdvcmRvbiAgPG5v ZWwuZ29yZG9uQGdtYWlsLmNvbT4KKworICAgICAgICBJbml0aWFsaXplICR3cml0dGVuIHZhcmlh YmxlIGluIGxvYWQtYW5kLXN0YWxsLnBocCBzY3JpcHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4ODU0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBodHRwL3Rlc3RzL3Jlc291cmNlcy9sb2FkLWFuZC1z dGFsbC5waHA6CisKIDIwMTItMTAtMDcgIE5pY2sgQ2FydGVyICA8bmlja0BjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgW2Nocm9taXVtXSBDcmFzaCBpbiBXZWJDb3JlOjpHcmFwaGljc0xheWVyQ2hy b21pdW06OnNldENvbnRlbnRzVG9JbWFnZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90 ZXN0cy9yZXNvdXJjZXMvbG9hZC1hbmQtc3RhbGwucGhwIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0 cy9yZXNvdXJjZXMvbG9hZC1hbmQtc3RhbGwucGhwCmluZGV4IDQ1MzA0ODFmNDcxODllMjdhZmU1 NjFiYzMwYjAwYjE1ZGVkMjUzNjUuLjY4M2JhOTkzM2UxNDlkNTg4ZDRlNmQ0ZmNkMDk1ZGQ1MGI1 NDE4OTkgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvcmVzb3VyY2VzL2xvYWQt YW5kLXN0YWxsLnBocAorKysgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3Jlc291cmNlcy9sb2Fk LWFuZC1zdGFsbC5waHAKQEAgLTE2LDcgKzE2LDcgQEAgaWYgKGlzc2V0KCRzdGFsbEF0KSAmJiBp c3NldCgkc3RhbGxGb3IpKSB7CiAgICAgJHN0YWxsRm9yID0gKGludCkkc3RhbGxGb3I7CiAgICAg aWYgKCRzdGFsbEF0ID4gZmlsZXNpemUoJG5hbWUpKQogICAgICAgICBkaWUoIkluY29ycmVjdCB2 YWx1ZSBmb3Igc3RhbGxBdC4iKTsKLQorICAgICR3cml0dGVuID0gMDsKICAgICB3aGlsZSAoJHdy aXR0ZW4gPCAkc3RhbGxBdCkgewogICAgICAgICAkd3JpdGUgPSAxMDI0OwogICAgICAgICBpZiAo JHdyaXRlID4gJHN0YWxsQXQgLSAkd3JpdHRlbikK