98852 2012-10-09 21:30:43 -0700 [EFL] Add background color to the radio button theme. 2012-10-17 00:05:54 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bw80.lee bw80.lee eric gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 738505 0 bw80.lee 2012-10-09 21:30:43 -0700 Need to modify theme. 741929 1 168673 bw80.lee 2012-10-15 04:12:45 -0700 Created attachment 168673 Patch 741970 2 168690 bw80.lee 2012-10-15 05:37:52 -0700 Created attachment 168690 test radio button status with white and black background. 742340 3 eric 2012-10-15 13:06:08 -0700 Attachment 168673 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/efl/ChangeLog', u'Source/Web..." exit_code: 1 Source/WebKit/efl/DefaultTheme/widget/radio/img_radio_bg_enabled.png:0: Have to enable auto props in the subversion config file (/Users/eseidel/.subversion/config "enable-auto-props = yes"). Have to set the svn:mime-type in the subversion config file (/Users/eseidel/.subversion/config "*.png = svn:mime-type=image/png"). [image/png] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 743861 4 bw80.lee 2012-10-16 22:35:45 -0700 (In reply to comment #3) > Attachment 168673 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/efl/ChangeLog', u'Source/Web..." exit_code: 1 > Source/WebKit/efl/DefaultTheme/widget/radio/img_radio_bg_enabled.png:0: Have to enable auto props in the subversion config file (/Users/eseidel/.subversion/config "enable-auto-props = yes"). Have to set the svn:mime-type in the subversion config file (/Users/eseidel/.subversion/config "*.png = svn:mime-type=image/png"). [image/png] [5] > Total errors found: 1 in 3 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. This looks a problem of the style-bot. (The style-bot need to set some features for svn to ~/.subversion/config file) 743923 5 168673 webkit.review.bot 2012-10-17 00:05:50 -0700 Comment on attachment 168673 Patch Clearing flags on attachment: 168673 Committed r131554: <http://trac.webkit.org/changeset/131554> 743924 6 webkit.review.bot 2012-10-17 00:05:54 -0700 All reviewed patches have been landed. Closing bug. 168673 2012-10-15 04:12:45 -0700 2012-10-17 00:05:49 -0700 Patch bug-98852-20121015201133.patch text/plain 4879 bw80.lee U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxMjkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm bC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggZWFhMjMxNjQz ZjVjN2MxNmRkMWU5MmRkYTQ1YzA4ZGYyNTcwM2QxNS4uNmJhNTY1ZTdkMTdjZGMzOTdhYTRjM2Yw NzMwMjgwNWY1MjNiMjFlYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEy LTEwLTE1ICBCeXVuZ3dvbyBMZWUgIDxidzgwLmxlZUBzYW1zdW5nLmNvbT4KKworICAgICAgICBb RUZMXSBBZGQgYmFja2dyb3VuZCBjb2xvciB0byB0aGUgcmFkaW8gYnV0dG9uIHRoZW1lLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTg4NTIKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBCYWNrZ3JvdW5kIGNv bG9yIGlzIGFkZGVkIHRvIHRoZSByYWRpbyBidXR0b24gdGhlbWUgZm9yIGlkZW50aWZ5aW5nCisg ICAgICAgIHJhZGlvIGJ1dHRvbiBzdGF0dXMgZWFzaWx5LgorCisgICAgICAgIFJhZGlvIGJ1dHRv biB0aGVtZSB1c2VzIGltYWdlcyB3aGljaCBoYXMgdHJhbnNwYXJlbnQgYmFja2dyb3VuZC4KKwor ICAgICAgICBXaGVuIHRoZSBiYWNrZ3JvdW5kIG9mIHJhZGlvIGJ1dHRvbiBpcyBibGFjaywgY2hl Y2tlZC91bmNoZWNrZWQgc3RhdHVzCisgICAgICAgIGNhbm5vdCBiZSBkaXN0aW5ndWlzaGVkIGJl Y2F1c2UgY2hlY2sgbWFyayBjb2xvciBpcyBibGFjay4KKworICAgICAgICBBbmQgaXQgaXMgaGFy ZCB0byBpZGVudGlmeSB3aGV0aGVyIHRoZSByYWRpbyBidXR0b24gaXMgZGlzYWJsZWQgb3Igbm90 LAorICAgICAgICBiZWNhdXNlIHRoZXJlIGlzIG5vIGJhY2tncm91bmQgY29sb3IgaW4gdGhlIHJh ZGlvIGJ1dHRvbiB0aGVtZS4KKworICAgICAgICAqIERlZmF1bHRUaGVtZS93aWRnZXQvcmFkaW8v aW1nX3JhZGlvX2JnX2Rpc2FibGVkLnBuZzogQWRkZWQuCisgICAgICAgICogRGVmYXVsdFRoZW1l L3dpZGdldC9yYWRpby9pbWdfcmFkaW9fYmdfZW5hYmxlZC5wbmc6IEFkZGVkLgorICAgICAgICAq IERlZmF1bHRUaGVtZS93aWRnZXQvcmFkaW8vcmFkaW8uZWRjOgorCiAyMDEyLTEwLTE0ICBTYW0g V2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgTWFrZSBVc2VyU2NyaXB0IGFuZCBV c2VyU3R5bGVTaGVldCB2YWx1ZSBvYmplY3RzIHRoYXQgYXJlIGNvcHlhYmxlCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L2VmbC9EZWZhdWx0VGhlbWUvd2lkZ2V0L3JhZGlvL2ltZ19yYWRpb19i Z19kaXNhYmxlZC5wbmcgYi9Tb3VyY2UvV2ViS2l0L2VmbC9EZWZhdWx0VGhlbWUvd2lkZ2V0L3Jh ZGlvL2ltZ19yYWRpb19iZ19kaXNhYmxlZC5wbmcKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXgg MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYWE4OTdjZmIzODg3MDAy NDE1ZTE4Nzg0YzMzOTE3YzViYjAyOWI4MApHSVQgYmluYXJ5IHBhdGNoCmxpdGVyYWwgMjgwCnpj bWVBU0BOPyhvbEh5YHVWQnEhaWEwdnBeSlJyPSQxfC04dVcxYSZrI15OQSVDeCYoQldMXlJ9WSlS aGtFKTQlYwp6YUtZWj9sWXRfZjFzOypiMz1HYERBazRAeFltTmpea2lFcHkqT21QYTdlQU0hO0g4 TUx4aj47QW8tVTNkOHQwU3UKemVFJVdLRVVqJlBgMlBPP2xIMmxQelJoUmt7X3YkWUF0ZzA2P1o/ O09gcGwwZmlfMSZpdE4oTVpweUl2Tm55JG5ICnpyeFlneXheIzNtekk9Y0dLWn5mYmZxe1hIXkBl fXsqV2Emfmx2d1VOK2J6SipDP1FFZmtjWFNNJmhjVzs1dl8wRQp6YGpiK1U1KXUqJHpIJXdBSUM7 Jm9XOCUhMjZCfVFDZjRgcTZYTj9YSTwzVTNVKTE2aFZoTVA3eU95WHgpfEg0bz0KVTwmV00/cGNA JUhVSHgzdklWQ2chMDBCNT5aMiRsTwoKbGl0ZXJhbCAwCkhjbVY/ZDAwMDAxCgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9lZmwvRGVmYXVsdFRoZW1lL3dpZGdldC9yYWRpby9pbWdfcmFkaW9f YmdfZW5hYmxlZC5wbmcgYi9Tb3VyY2UvV2ViS2l0L2VmbC9EZWZhdWx0VGhlbWUvd2lkZ2V0L3Jh ZGlvL2ltZ19yYWRpb19iZ19lbmFibGVkLnBuZwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi40NmVmMzVkMWFiZGYzNGQy MWM4OWM5NWZjZGJlZGIwYjc5NDhhMmU3CkdJVCBiaW5hcnkgcGF0Y2gKbGl0ZXJhbCAyNjEKemNt ZUFTQE4/KG9sSHlgdVZCcSFpYTB2cF5KUnI9JDF8LTh1VzFhJmsjXk5BJUN4JihCV0xeUn1ZKVJo a0UpNCVjCnphS1laP2xZdF9mMXM7KmIzPUdgREFrNEB4WW1Oal5raUVweSpPbVBhN2VBTXxqPnUr bkNaSkhPcjtCNVYjYChMRwp6SGdYK3U1TVdKenp2KzZ7K0t3T3A/PGNEJk4rZUl8QGEkPTdkS2tm ZG48ZUA2NzMxfClsU0Z3UFo0SVNYQTNZPEgKelBAZHM+XzQ2eGJ5JW8jZiZSY0FCcHZyUSlfaCpG Xz9SKWtsMzdfbUBHdShYZnNpS1ZpQ3ZuSGZ5RDYqbypxMSRHCnp4VX1iPVJQTUheNzVZMiZefFNh fCV6ZUsmYU10eGpDIWdFcCtkUGx5Yjh9aj81JEdUV1BnZyZlYnhzTFEwS0BAYgpBX3k3T14KCmxp dGVyYWwgMApIY21WP2QwMDAwMQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0RlZmF1 bHRUaGVtZS93aWRnZXQvcmFkaW8vcmFkaW8uZWRjIGIvU291cmNlL1dlYktpdC9lZmwvRGVmYXVs dFRoZW1lL3dpZGdldC9yYWRpby9yYWRpby5lZGMKaW5kZXggZjA3YjliMjdlYzI0NGJhZjRiNTBl NmFmMGU2MTUyZGNhODA5YTAxZC4uZWMwMTQ2MzRlNmI2YmJlZDVhNzc5MTg1YzBhYzIxZTZmMDNm OGEwNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvRGVmYXVsdFRoZW1lL3dpZGdldC9y YWRpby9yYWRpby5lZGMKKysrIGIvU291cmNlL1dlYktpdC9lZmwvRGVmYXVsdFRoZW1lL3dpZGdl dC9yYWRpby9yYWRpby5lZGMKQEAgLTI0LDYgKzI0LDggQEAKICAgICAgIG1pbjogMTIgMTI7CiAK ICAgICAgIGltYWdlcyB7CisgICAgICAgICBpbWFnZTogIndpZGdldC9yYWRpby9pbWdfcmFkaW9f YmdfZW5hYmxlZC5wbmciIENPTVA7CisgICAgICAgICBpbWFnZTogIndpZGdldC9yYWRpby9pbWdf cmFkaW9fYmdfZGlzYWJsZWQucG5nIiBDT01QOwogICAgICAgICAgaW1hZ2U6ICJ3aWRnZXQvcmFk aW8vaW1nX3JhZGlvX29uLnBuZyIgQ09NUDsKICAgICAgICAgIGltYWdlOiAid2lkZ2V0L3JhZGlv L2ltZ19yYWRpb19vZmYucG5nIiBDT01QOwogICAgICAgICAgaW1hZ2U6ICJ3aWRnZXQvcmFkaW8v aW1nX3JhZGlvX29uX2ZvY3VzLnBuZyIgQ09NUDsKQEAgLTQyLDYgKzQ0LDcgQEAKICAgICAgICAg ICBwdWJsaWMgc2hvdygpIHsKICAgICAgICAgICAgICAgaWYgKGdldF9pbnQoaXNFbmFibGVkKSA9 PSAxKSB7CiAgICAgICAgICAgICAgICAgICBzZXRfc3RhdGUoUEFSVDoicmFkaW9fYnV0dG9uIiwg ImRlZmF1bHQiLCAwLjApOworICAgICAgICAgICAgICAgICAgc2V0X3N0YXRlKFBBUlQ6ImJnIiwg ImVuYWJsZWQiLCAwLjApOwogICAgICAgICAgICAgICAgICAgaWYgKGdldF9pbnQoaXNDaGVja2Vk KSA9PSAxKSB7CiAgICAgICAgICAgICAgICAgICAgICAgc2V0X3N0YXRlKFBBUlQ6InJhZGlvX2J1 dHRvbiIsICJlbmFibGVkX2NoZWNrZWQiLCAwLjApOwogICAgICAgICAgICAgICAgICAgICAgIGlm IChnZXRfaW50KGlzRm9jdXNlZCkgPT0gMSkKQEAgLTU4LDYgKzYxLDcgQEAKICAgICAgICAgICAg ICAgfQogICAgICAgICAgICAgICBlbHNlIHsKICAgICAgICAgICAgICAgICAgIHNldF9zdGF0ZShQ QVJUOiJyYWRpb19idXR0b24iLCAiZGlzYWJsZWQiLCAwLjApOworICAgICAgICAgICAgICAgICAg c2V0X3N0YXRlKFBBUlQ6ImJnIiwgImRpc2FibGVkIiwgMC4wKTsKICAgICAgICAgICAgICAgICAg IGlmIChnZXRfaW50KGlzQ2hlY2tlZCkgPT0gMSkKICAgICAgICAgICAgICAgICAgICAgICBzZXRf c3RhdGUoUEFSVDoicmFkaW9fYnV0dG9uIiwgImRpc2FibGVkX2NoZWNrZWQiLCAwLjApOwogICAg ICAgICAgICAgICB9CkBAIC02Niw2ICs3MCwyOSBAQAogCiAgICAgICBwYXJ0cyB7CiAgICAgICAg ICBwYXJ0IHsKKyAgICAgICAgICAgIG5hbWU6ICJiZyI7CisgICAgICAgICAgICB0eXBlOiBJTUFH RTsKKyAgICAgICAgICAgIGRlc2NyaXB0aW9uIHsKKyAgICAgICAgICAgICAgIHN0YXRlOiAiZGVm YXVsdCIgMC4wOworICAgICAgICAgICAgICAgbWluOiAxMiAxMjsKKyAgICAgICAgICAgICAgIG1h eDogMTIgMTI7CisgICAgICAgICAgICAgICBpbWFnZSB7CisgICAgICAgICAgICAgICAgICBub3Jt YWw6ICJ3aWRnZXQvcmFkaW8vaW1nX3JhZGlvX2JnX2VuYWJsZWQucG5nIjsKKyAgICAgICAgICAg ICAgIH0KKyAgICAgICAgICAgIH0KKyAgICAgICAgICAgIGRlc2NyaXB0aW9uIHsKKyAgICAgICAg ICAgICAgIHN0YXRlOiAiZW5hYmxlZCIgMC4wOworICAgICAgICAgICAgICAgaW5oZXJpdDogImRl ZmF1bHQiIDAuMDsKKyAgICAgICAgICAgIH0KKyAgICAgICAgICAgIGRlc2NyaXB0aW9uIHsKKyAg ICAgICAgICAgICAgIHN0YXRlOiAiZGlzYWJsZWQiIDAuMDsKKyAgICAgICAgICAgICAgIGluaGVy aXQ6ICJkZWZhdWx0IiAwLjA7CisgICAgICAgICAgICAgICBpbWFnZSB7CisgICAgICAgICAgICAg ICAgICBub3JtYWw6ICJ3aWRnZXQvcmFkaW8vaW1nX3JhZGlvX2JnX2Rpc2FibGVkLnBuZyI7Cisg ICAgICAgICAgICAgICB9CisgICAgICAgICAgICB9CisgICAgICAgICB9CisgICAgICAgICBwYXJ0 IHsKICAgICAgICAgICAgIG5hbWU6ICJyYWRpb19idXR0b24iOwogICAgICAgICAgICAgdHlwZTog SU1BR0U7CiAgICAgICAgICAgICBkZXNjcmlwdGlvbiB7Cg== 168690 2012-10-15 05:37:52 -0700 2012-10-15 05:37:52 -0700 test radio button status with white and black background. test_radio.html text/html 555 bw80.lee PGh0bWw+PGJvZHk+PGgxPlRlc3QgcmFkaW88L2gxPgogICAgPGRpdiBzdHlsZT0iYmFja2dyb3Vu ZC1jb2xvcjp3aGl0ZTsiIHdpZHRoPTgwMD4KICAgICAgICA8aW5wdXQgdHlwZT0icmFkaW8iLz4K ICAgICAgICA8aW5wdXQgdHlwZT0icmFkaW8iIGRpc2FibGVkPSJkaXNhYmxlZCIvPgogICAgICAg IDxpbnB1dCB0eXBlPSJyYWRpbyIgY2hlY2tlZD0iY2hlY2tlZCIvPgogICAgICAgIDxpbnB1dCB0 eXBlPSJyYWRpbyIgZGlzYWJsZWQ9ImRpc2FibGVkIiBjaGVja2VkPSJjaGVja2VkIi8+CiAgICA8 L2Rpdj4KICAgIDxkaXYgc3R5bGU9ImJhY2tncm91bmQtY29sb3I6YmxhY2s7Ij4KICAgICAgICA8 aW5wdXQgdHlwZT0icmFkaW8iLz4KICAgICAgICA8aW5wdXQgdHlwZT0icmFkaW8iIGRpc2FibGVk PSJkaXNhYmxlZCIvPgogICAgICAgIDxpbnB1dCB0eXBlPSJyYWRpbyIgY2hlY2tlZD0iY2hlY2tl ZCIvPgogICAgICAgIDxpbnB1dCB0eXBlPSJyYWRpbyIgZGlzYWJsZWQ9ImRpc2FibGVkIiBjaGVj a2VkPSJjaGVja2VkIi8+CiAgICA8L2Rpdj4KPC9ib2R5PjwvaHRtbD4K