98830 2012-10-09 15:46:20 -0700 [BlackBerry] NetworkJob missing m_frame checks 2012-10-09 18:23:09 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joenotcharles webkit-unassigned mifenton rwlbuis webkit.review.bot oldest_to_newest 738273 0 joenotcharles 2012-10-09 15:46:20 -0700 m_frame can be null, and m_frame->page() can return null. There are a few places in NetworkJob that don't check for this. 738278 1 167868 joenotcharles 2012-10-09 15:50:13 -0700 Created attachment 167868 fix 738405 2 167868 webkit.review.bot 2012-10-09 18:23:07 -0700 Comment on attachment 167868 fix Clearing flags on attachment: 167868 Committed r130834: <http://trac.webkit.org/changeset/130834> 738406 3 webkit.review.bot 2012-10-09 18:23:09 -0700 All reviewed patches have been landed. Closing bug. 167868 2012-10-09 15:50:13 -0700 2012-10-09 18:23:07 -0700 fix 0001-Check-for-null-m_frame-in-NetworkJob.patch text/plain 2873 joenotcharles RnJvbSA5NTM2ZTI0ZTViZmVjODEyYzk3MmIwM2I1NWZiYjNjYTI2NWRlYmM1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb2UgTWFzb24gPGptYXNvbkByaW0uY29tPgpEYXRlOiBUdWUs IDkgT2N0IDIwMTIgMTg6NDc6MzAgLTA0MDAKU3ViamVjdDogW1BBVENIXSBDaGVjayBmb3IgbnVs bCBtX2ZyYW1lIGluIE5ldHdvcmtKb2IKIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD05ODgzMAoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpQUiAyMjAwMjUKCiog cGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05ldHdvcmtKb2IuY3BwOgooV2ViQ29yZTo6TmV0 d29ya0pvYjo6c2VuZFJlcXVlc3RXaXRoQ3JlZGVudGlhbHMpOgooV2ViQ29yZTo6TmV0d29ya0pv Yjo6c3RvcmVDcmVkZW50aWFscyk6Ci0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAg ICAgICAgICAgICAgICAgICAgICAgfCAgIDEzICsrKysrKysrKysrKysKIC4uLi9wbGF0Zm9ybS9u ZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya0pvYi5jcHAgICAgIHwgICAgNiArKysrKy0KIDIgZmls ZXMgY2hhbmdlZCwgMTggaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5k ZXggNmE1MGY0My4uMjFlNGQxOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEw LTA5ICBKb2UgTWFzb24gIDxqbWFzb25AcmltLmNvbT4KKworICAgICAgICBDaGVjayBmb3IgbnVs bCBtX2ZyYW1lIGluIE5ldHdvcmtKb2IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTk4ODMwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgUFIgMjIwMDI1CisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2Js YWNrYmVycnkvTmV0d29ya0pvYi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpOZXR3b3JrSm9iOjpz ZW5kUmVxdWVzdFdpdGhDcmVkZW50aWFscyk6CisgICAgICAgIChXZWJDb3JlOjpOZXR3b3JrSm9i OjpzdG9yZUNyZWRlbnRpYWxzKToKKwogMjAxMi0xMC0wNSAgSm9lIE1hc29uICA8am1hc29uQHJp bS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIEZpeCByZWdyZXNzaW9uIGluIHByb3h5IGF1 dGgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJy eS9OZXR3b3JrSm9iLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2ti ZXJyeS9OZXR3b3JrSm9iLmNwcAppbmRleCA1NjA1ODhhLi4xMjNmOTY2IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya0pvYi5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05ldHdvcmtK b2IuY3BwCkBAIC03NzUsNiArNzc1LDkgQEAgYm9vbCBOZXR3b3JrSm9iOjpzZW5kUmVxdWVzdFdp dGhDcmVkZW50aWFscyhQcm90ZWN0aW9uU3BhY2VTZXJ2ZXJUeXBlIHR5cGUsIFByb3QKICAgICAg ICAgICAgIGlmIChtX2hhbmRsZS0+Zmlyc3RSZXF1ZXN0KCkudGFyZ2V0VHlwZSgpICE9IFJlc291 cmNlUmVxdWVzdDo6VGFyZ2V0SXNNYWluRnJhbWUgJiYgQmxhY2tCZXJyeTo6UGxhdGZvcm06OlNl dHRpbmdzOjppbnN0YW5jZSgpLT5pc0Nocm9tZVByb2Nlc3MoKSkKICAgICAgICAgICAgICAgICBy ZXR1cm4gZmFsc2U7CiAKKyAgICAgICAgICAgIGlmICghbV9mcmFtZSB8fCAhbV9mcmFtZS0+cGFn ZSgpKQorICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKwogICAgICAgICAgICAgbV9oYW5k bGUtPmdldEludGVybmFsKCktPm1fY3VycmVudFdlYkNoYWxsZW5nZSA9IEF1dGhlbnRpY2F0aW9u Q2hhbGxlbmdlKCk7CiAgICAgICAgICAgICBtX2ZyYW1lLT5wYWdlKCktPmNocm9tZSgpLT5jbGll bnQoKS0+cGxhdGZvcm1QYWdlQ2xpZW50KCktPmF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlKG5ld1VS TCwgcHJvdGVjdGlvblNwYWNlLCBDcmVkZW50aWFsKCksIHRoaXMpOwogICAgICAgICAgICAgcmV0 dXJuIHRydWU7CkBAIC04MDcsNyArODEwLDggQEAgdm9pZCBOZXR3b3JrSm9iOjpzdG9yZUNyZWRl bnRpYWxzKCkKICAgICBpZiAoY2hhbGxlbmdlLnByb3RlY3Rpb25TcGFjZSgpLnNlcnZlclR5cGUo KSA9PSBQcm90ZWN0aW9uU3BhY2VQcm94eUhUVFApIHsKICAgICAgICAgQmxhY2tCZXJyeTo6UGxh dGZvcm06OlNldHRpbmdzOjppbnN0YW5jZSgpLT5zZXRQcm94eUNyZWRlbnRpYWwoY2hhbGxlbmdl LnByb3Bvc2VkQ3JlZGVudGlhbCgpLnVzZXIoKS51dGY4KCkuZGF0YSgpLAogICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNoYWxs ZW5nZS5wcm9wb3NlZENyZWRlbnRpYWwoKS5wYXNzd29yZCgpLnV0ZjgoKS5kYXRhKCkpOwotICAg ICAgICBtX2ZyYW1lLT5wYWdlKCktPmNocm9tZSgpLT5jbGllbnQoKS0+cGxhdGZvcm1QYWdlQ2xp ZW50KCktPnN5bmNQcm94eUNyZWRlbnRpYWwoY2hhbGxlbmdlLnByb3Bvc2VkQ3JlZGVudGlhbCgp KTsKKyAgICAgICAgaWYgKG1fZnJhbWUgJiYgbV9mcmFtZS0+cGFnZSgpKQorICAgICAgICAgICAg bV9mcmFtZS0+cGFnZSgpLT5jaHJvbWUoKS0+Y2xpZW50KCktPnBsYXRmb3JtUGFnZUNsaWVudCgp LT5zeW5jUHJveHlDcmVkZW50aWFsKGNoYWxsZW5nZS5wcm9wb3NlZENyZWRlbnRpYWwoKSk7CiAg ICAgfQogfQogCi0tIAoxLjcuNS40Cgo=