98828 2012-10-09 15:35:32 -0700 Fix coding style of layout test fast/dom/timer-throttling-hidden-page.html 2012-10-09 16:51:25 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cmuppala cmuppala cmuppala ojan webkit.review.bot oldest_to_newest 738265 0 cmuppala 2012-10-09 15:35:32 -0700 Remove tab characters and use spaces exclusively. Fix placement of braces according to WebKit coding style. Rename variables previousT, d and t to more appropriate previousTime, date and time respectively. 738275 1 167866 cmuppala 2012-10-09 15:46:56 -0700 Created attachment 167866 Patch 738283 2 167866 ojan 2012-10-09 15:56:25 -0700 Comment on attachment 167866 Patch Much better. Thanks! 738330 3 167866 webkit.review.bot 2012-10-09 16:49:03 -0700 Comment on attachment 167866 Patch Clearing flags on attachment: 167866 Committed r130827: <http://trac.webkit.org/changeset/130827> 738331 4 webkit.review.bot 2012-10-09 16:49:06 -0700 All reviewed patches have been landed. Closing bug. 738334 5 cmuppala 2012-10-09 16:51:25 -0700 (In reply to comment #2) > (From update of attachment 167866 [details]) > Much better. Thanks! Thanks for pointing these out. 167866 2012-10-09 15:46:56 -0700 2012-10-09 16:49:03 -0700 Patch bug-98828-20121009154556.patch text/plain 4983 cmuppala U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwODIwCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMzg0YjJlMTcwMzBjYmM0MDk5ZWEx OWJlM2ZlNGYwMWM3M2EzNWFlNC4uODEwZmE5YzhiNTMwM2E0YTYxM2NkMDI1NzEzNjNkZTcwMmYw YTQ1NiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEwLTA5ICBLaXJhbiBNdXBwYWxhICA8 Y211cHBhbGFAYXBwbGUuY29tPgorCisgICAgICAgIEZpeCBjb2Rpbmcgc3R5bGUgb2YgbGF5b3V0 IHRlc3QgZmFzdC9kb20vdGltZXItdGhyb3R0bGluZy1oaWRkZW4tcGFnZS5odG1sCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05ODgyOAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlcGxhY2VkIHRhYiBjaGFy YWN0ZXJzIHdpdGggc3BhY2VzLCBmaXhlZCBwb3NpdGlvbiBvZiBicmFjZXMgYW5kIHJlbmFtZWQK KyAgICAgICAgdmFyaWFibGVzIHRvIGJlIG1vcmUgZXhwbGFuYXRvcnkuCisKKyAgICAgICAgKiBm YXN0L2RvbS90aW1lci10aHJvdHRsaW5nLWhpZGRlbi1wYWdlLmh0bWw6CisKIDIwMTItMTAtMDkg IEFsZXhhbmRlciBTaGFsYW1vdiAgPGFsZXhhbmRlci5zaGFsYW1vdkBpbnRlbC5jb20+CiAKICAg ICAgICAgQ1NTIFN0eWxlIGlzIG5vdCByZWNhbGN1bGF0ZWQgd2hlbiBtZWRpYSBhdHRyaWJ1dGUg b2Ygc3R5bGUgZWxlbWVudCBpcyBjaGFuZ2VkCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0 L2RvbS90aW1lci10aHJvdHRsaW5nLWhpZGRlbi1wYWdlLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0 L2RvbS90aW1lci10aHJvdHRsaW5nLWhpZGRlbi1wYWdlLmh0bWwKaW5kZXggYjEyOGVlNDVhZjc3 NTI5M2UxZjY2MDMxMzQ2MDBjYzdmYjQ2OGJhOC4uOTVmYmUyYTc3ZmIyMjIxZDhlY2E2YzM0ZjBl ZjVkNWVhZTE3NWIyOSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vdGltZXItdGhy b3R0bGluZy1oaWRkZW4tcGFnZS5odG1sCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL3RpbWVy LXRocm90dGxpbmctaGlkZGVuLXBhZ2UuaHRtbApAQCAtNSw3ICs1LDcgQEAKICAgICAgICAgZGVz Y3JpcHRpb24oJzxhIGhyZWY9Imh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD05ODQ3NCI+QnVnIDk4NDc0PC9hPjogVGhyb3R0bGUgRE9NIHRpbWVycyBvbiBoaWRkZW4gcGFn ZXMuJyk7CiAKICAgICAgICAgdmFyIGpzVGVzdElzQXN5bmMgPSB0cnVlOwotCXZhciBwcmV2aW91 c1QgPSBuZXcgRGF0ZSgpLmdldFRpbWUoKTsKKyAgICAgICAgdmFyIHByZXZpb3VzVGltZSA9IG5l dyBEYXRlKCkuZ2V0VGltZSgpOwogICAgICAgICB2YXIgdGltZXJDb3VudCA9IDA7CiAgICAgICAg IHZhciBmaXJzdFRpbWVyV2hpbGVIaWRkZW4gPSB0cnVlOwogICAgICAgICB2YXIgaXNQYWdlVmlz aWJsZSA9IHRydWU7CkBAIC0xMyw1OSArMTMsNTggQEAKICAgICAgICAgdmFyIHRvbGVyYW5jZSA9 IDIwOwogICAgICAgICB2YXIgdGltZXJBbGlnbm1lbnRJbnRlcnZhbCA9IDEwMDA7CiAKLQlmdW5j dGlvbiB0ZXN0VGltZXIoKSB7Ci0JICAgIHZhciBkID0gbmV3IERhdGUoKTsKLQkgICAgdmFyIHQg PSBkLmdldFRpbWUoKTsKKyAgICAgICAgZnVuY3Rpb24gdGVzdFRpbWVyKCkKKyAgICAgICAgewor ICAgICAgICAgICAgdmFyIGRhdGUgPSBuZXcgRGF0ZSgpOworICAgICAgICAgICAgdmFyIHRpbWUg PSBkYXRlLmdldFRpbWUoKTsKICAgICAgICAgICAgIGlmICghaXNQYWdlVmlzaWJsZSkgewogICAg ICAgICAgICAgICAgIGlmIChmaXJzdFRpbWVyV2hpbGVIaWRkZW4pIHsKLSAgICAgIAkgICAgICAg ICAgICBmaXJzdFRpbWVySW50ZXJ2YWxXaGlsZVBhZ2VIaWRkZW4gPSB0IC0gcHJldmlvdXNUOwor ICAgICAgICAgICAgICAgICAgICBmaXJzdFRpbWVySW50ZXJ2YWxXaGlsZVBhZ2VIaWRkZW4gPSB0 aW1lIC0gcHJldmlvdXNUaW1lOwogICAgICAgICAgICAgICAgICAgICB2YXIgbWluVmFsdWUgPSB0 aW1lb3V0SW50ZXJ2YWwgLSB0b2xlcmFuY2U7Ci0JICAgICAgICAgICAgc2hvdWxkQmVHcmVhdGVy VGhhbk9yRXF1YWwoImZpcnN0VGltZXJJbnRlcnZhbFdoaWxlUGFnZUhpZGRlbiIsIG1pblZhbHVl LnRvU3RyaW5nKCkpOwotCSAgICAgICAgICAgIHZhciBtYXhWYWx1ZSA9IHRpbWVvdXRJbnRlcnZh bCArIHRpbWVyQWxpZ25tZW50SW50ZXJ2YWwgKyB0b2xlcmFuY2U7CisgICAgICAgICAgICAgICAg ICAgIHNob3VsZEJlR3JlYXRlclRoYW5PckVxdWFsKCJmaXJzdFRpbWVySW50ZXJ2YWxXaGlsZVBh Z2VIaWRkZW4iLCBtaW5WYWx1ZS50b1N0cmluZygpKTsKKyAgICAgICAgICAgICAgICAgICAgdmFy IG1heFZhbHVlID0gdGltZW91dEludGVydmFsICsgdGltZXJBbGlnbm1lbnRJbnRlcnZhbCArIHRv bGVyYW5jZTsKICAgICAgICAgICAgICAgICAgICAgc2hvdWxkQmVUcnVlKCJmaXJzdFRpbWVySW50 ZXJ2YWxXaGlsZVBhZ2VIaWRkZW4gPD0gIiArIG1heFZhbHVlKTsKICAgICAgICAgICAgICAgICAg ICAgZmlyc3RUaW1lcldoaWxlSGlkZGVuID0gZmFsc2U7CiAgICAgICAgICAgICAgICAgfSBlbHNl IHsKLSAgICAgIAkgICAgICAgICAgICB0aW1lckludGVydmFsV2hpbGVQYWdlSGlkZGVuID0gdCAt IHByZXZpb3VzVDsKKyAgICAgICAgICAgICAgICAgICAgdGltZXJJbnRlcnZhbFdoaWxlUGFnZUhp ZGRlbiA9IHRpbWUgLSBwcmV2aW91c1RpbWU7CiAgICAgICAgICAgICAgICAgICAgIHNob3VsZEJl Q2xvc2VUbygidGltZXJJbnRlcnZhbFdoaWxlUGFnZUhpZGRlbiIsIHRpbWVyQWxpZ25tZW50SW50 ZXJ2YWwsIHRvbGVyYW5jZSk7CiAgICAgICAgICAgICAgICAgfQotICAgICAgICAgICAgfQotICAg ICAgICAgICAgZWxzZSB7Ci0gICAgICAgICAgICAgICAgdGltZXJJbnRlcnZhbFdoaWxlUGFnZVZp c2libGUgPSB0IC0gcHJldmlvdXNUOworICAgICAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAg ICAgICB0aW1lckludGVydmFsV2hpbGVQYWdlVmlzaWJsZSA9IHRpbWUgLSBwcmV2aW91c1RpbWU7 CiAgICAgICAgICAgICAgICAgc2hvdWxkQmVDbG9zZVRvKCJ0aW1lckludGVydmFsV2hpbGVQYWdl VmlzaWJsZSIsIHRpbWVvdXRJbnRlcnZhbCwgdG9sZXJhbmNlKTsKICAgICAgICAgICAgIH0KIAog ICAgICAgICAgICAgdGltZXJDb3VudCsrOwotCSAgICBwcmV2aW91c1QgPSB0OworICAgICAgICAg ICAgcHJldmlvdXNUaW1lID0gdGltZTsKIAogICAgICAgICAgICAgaWYgKHRpbWVyQ291bnQgPT0g MSkgewogICAgICAgICAgICAgICAgIHRlc3RSdW5uZXIuc2V0UGFnZVZpc2liaWxpdHkoImhpZGRl biIpOwotCSAgICAgICAgaXNQYWdlVmlzaWJsZSA9IGZhbHNlOwotCSAgICB9IGVsc2UgaWYgKHRp bWVyQ291bnQgPT0gMykgeworICAgICAgICAgICAgICAgIGlzUGFnZVZpc2libGUgPSBmYWxzZTsK KyAgICAgICAgICAgIH0gZWxzZSBpZiAodGltZXJDb3VudCA9PSAzKSB7CiAgICAgICAgICAgICAg ICAgdGVzdFJ1bm5lci5yZXNldFBhZ2VWaXNpYmlsaXR5KCk7CiAgICAgICAgICAgICAgICAgaXNQ YWdlVmlzaWJsZSA9IHRydWU7CiAgICAgICAgICAgICB9IGVsc2UgaWYgKHRpbWVyQ291bnQgPj0g NCl7CiAgICAgICAgICAgICAgICAgZmluaXNoSlNUZXN0KCk7Ci0JICAgICAgICByZXR1cm47Cisg ICAgICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICAgICAgfQogICAgICAgICAgICAgc2V0VGlt ZW91dCh0ZXN0VGltZXIsIHRpbWVvdXRJbnRlcnZhbCk7Ci0JfQorICAgICAgICB9CiAKLSAgICAg ICAgZnVuY3Rpb24gcnVuVGVzdCgpIHsKLQkgICAgaWYgKCF3aW5kb3cudGVzdFJ1bm5lcikgewot CSAgICAgICAgZGVidWcoJ1RoaXMgdGVzdCByZXF1aXJlcyB0ZXN0UnVubmVyJyk7Ci0JICAgICAg ICByZXR1cm47CisgICAgICAgIGZ1bmN0aW9uIHJ1blRlc3QoKQorICAgICAgICB7CisgICAgICAg ICAgICBpZiAoIXdpbmRvdy50ZXN0UnVubmVyKSB7CisgICAgICAgICAgICAgICAgZGVidWcoJ1Ro aXMgdGVzdCByZXF1aXJlcyB0ZXN0UnVubmVyJyk7CisgICAgICAgICAgICAgICAgcmV0dXJuOwog ICAgICAgICAgICAgfQotCSAgICB2YXIgdGltZW91dEludGVydmFsU3BhbnMgPSBkb2N1bWVudC5n ZXRFbGVtZW50c0J5Q2xhc3NOYW1lKCd0aW1lb3V0SW50ZXJ2YWwnKTsKLSAgICAgICAgICAgIGZv ciAodmFyIGkgPSAwOyBpIDwgdGltZW91dEludGVydmFsU3BhbnMubGVuZ3RoOyBpKyspIHsKLQkg ICAgICAgIHRpbWVvdXRJbnRlcnZhbFNwYW5zW2ldLmlubmVyVGV4dCA9IHRpbWVvdXRJbnRlcnZh bDsKLQkgICAgfQorICAgICAgICAgICAgdmFyIHRpbWVvdXRJbnRlcnZhbFNwYW5zID0gZG9jdW1l bnQuZ2V0RWxlbWVudHNCeUNsYXNzTmFtZSgndGltZW91dEludGVydmFsJyk7CisgICAgICAgICAg ICBmb3IgKHZhciBpID0gMDsgaSA8IHRpbWVvdXRJbnRlcnZhbFNwYW5zLmxlbmd0aDsgaSsrKQor ICAgICAgICAgICAgICAgIHRpbWVvdXRJbnRlcnZhbFNwYW5zW2ldLmlubmVyVGV4dCA9IHRpbWVv dXRJbnRlcnZhbDsKIAotCSAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnYWxpZ25tZW50SW50 ZXJ2YWwnKS5pbm5lclRleHQgPSB0aW1lckFsaWdubWVudEludGVydmFsIC8gMTAwMDsKKyAgICAg ICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdhbGlnbm1lbnRJbnRlcnZhbCcpLmlubmVy VGV4dCA9IHRpbWVyQWxpZ25tZW50SW50ZXJ2YWwgLyAxMDAwOwogCiAgICAgICAgICAgICB0ZXN0 UnVubmVyLmR1bXBBc1RleHQoKTsKICAgICAgICAgICAgIHNldFRpbWVvdXQodGVzdFRpbWVyLCB0 aW1lb3V0SW50ZXJ2YWwpOwogICAgICAgICB9Ci0KICAgICA8L3NjcmlwdD4KIDwvaGVhZD4KIDxi b2R5IG9ubG9hZD0icnVuVGVzdCgpIj4K