98827 2012-10-09 15:31:58 -0700 [chromium] Add drop events for plugins 2012-10-09 16:28:57 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sadrul sadrul abarth dglazkov fishd jamesr tkent+wkapi webkit.review.bot oldest_to_newest 738262 0 sadrul 2012-10-09 15:31:58 -0700 [chromium] Add drop events for plugins 738264 1 167863 sadrul 2012-10-09 15:34:32 -0700 Created attachment 167863 Patch 738266 2 sadrul 2012-10-09 15:36:12 -0700 Hi! This is an 'oops CL' to add some parts I missed in the last patch (sorry). I have updated the test accordingly. 738267 3 webkit.review.bot 2012-10-09 15:36:37 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 738279 4 167863 abarth 2012-10-09 15:50:26 -0700 Comment on attachment 167863 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167863&action=review > LayoutTests/platform/chromium/plugins/drag-events.html:12 > +<embed id="plugin" type="application/x-webkit-test-webplugin" contentEditable></embed> woah, a contenteditable embed. That's crazy talk! 738311 5 167863 webkit.review.bot 2012-10-09 16:28:54 -0700 Comment on attachment 167863 Patch Clearing flags on attachment: 167863 Committed r130825: <http://trac.webkit.org/changeset/130825> 738312 6 webkit.review.bot 2012-10-09 16:28:57 -0700 All reviewed patches have been landed. Closing bug. 167863 2012-10-09 15:34:32 -0700 2012-10-09 16:28:54 -0700 Patch bug-98827-20121009183332.patch text/plain 6298 sadrul U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwNzEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDRlMGQ4Zjc0NGIxMWViMjZiMTE3ZmJlNDAwN2JiYjVkMGJjZGFmYjMuLmRiZjVjZTQ2ZjJhOTBh MDUyOGRmOTc1NDQ0MjM1ZTYxYjA5ZWIzYWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTItMTAtMDkgIFNhZHJ1bCBIYWJpYiBDaG93ZGh1cnkgIDxzYWRy dWxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gQWRkIGRyb3AgZXZlbnQgZm9y IHBsdWdpbnMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD05ODgyNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEFkZCBjb252ZXJzaW9uIGZvciBkcm9wIGV2ZW50cy4KKworICAgICAgICAqIHB1YmxpYy9XZWJE cmFnU3RhdHVzLmg6CisgICAgICAgICogc3JjL1dlYlBsdWdpbkNvbnRhaW5lckltcGwuY3BwOgor ICAgICAgICAoV2ViS2l0OjpXZWJQbHVnaW5Db250YWluZXJJbXBsOjpoYW5kbGVEcmFnRXZlbnQp OgorCiAyMDEyLTEwLTA4ICBBbGVjIEZsZXR0ICA8YWxlY2ZsZXR0QGNocm9taXVtLm9yZz4KIAog ICAgICAgICBJbmRleGVkREI6IHJlbW92ZSBhdXRvZ2VuZXJhdGVkIG9iamVjdFN0b3JlL2luZGV4 IGlkIGNvZGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkRy YWdTdGF0dXMuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkRyYWdTdGF0dXMu aAppbmRleCBhYzY0NzIyNzQ4OWQ2NzBjNDAxYzM2MGQzMGNhZWUwODRjNjRmYzcwLi5mYjQ5MGQz ODMyOGI2ZTYyYTFjN2Q3OGQwYjViMDY3MDZlYzc0NGU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3B1YmxpYy9XZWJEcmFnU3RhdHVzLmgKKysrIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9wdWJsaWMvV2ViRHJhZ1N0YXR1cy5oCkBAIC0zNyw3ICszNyw4IEBAIGVudW0gV2Vi RHJhZ1N0YXR1cyB7CiAgICAgV2ViRHJhZ1N0YXR1c1Vua25vd24gPSAwLAogICAgIFdlYkRyYWdT dGF0dXNFbnRlciwKICAgICBXZWJEcmFnU3RhdHVzT3ZlciwKLSAgICBXZWJEcmFnU3RhdHVzTGVh dmUKKyAgICBXZWJEcmFnU3RhdHVzTGVhdmUsCisgICAgV2ViRHJhZ1N0YXR1c0Ryb3AKIH07CiAK IH0gLy8gbmFtZXNwYWNlIFdlYktpdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9zcmMvV2ViUGx1Z2luQ29udGFpbmVySW1wbC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3NyYy9XZWJQbHVnaW5Db250YWluZXJJbXBsLmNwcAppbmRleCAwODlhOWEzN2EzZTZjMDExZTMw NmE2MDc2N2ZkNGYzYjNlMTY2NTY3Li4xY2ViMzA2MzI2ODM5NjZlYzg5MTdiOTI0OWMyNTMwZTgw Njc0NTdiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQbHVnaW5D b250YWluZXJJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQbHVn aW5Db250YWluZXJJbXBsLmNwcApAQCAtNzE5LDYgKzcxOSw4IEBAIHZvaWQgV2ViUGx1Z2luQ29u dGFpbmVySW1wbDo6aGFuZGxlRHJhZ0V2ZW50KE1vdXNlRXZlbnQqIGV2ZW50KQogICAgICAgICBk cmFnU3RhdHVzID0gV2ViRHJhZ1N0YXR1c0xlYXZlOwogICAgIGVsc2UgaWYgKGV2ZW50LT50eXBl KCkgPT0gZXZlbnROYW1lcygpLmRyYWdvdmVyRXZlbnQpCiAgICAgICAgIGRyYWdTdGF0dXMgPSBX ZWJEcmFnU3RhdHVzT3ZlcjsKKyAgICBlbHNlIGlmIChldmVudC0+dHlwZSgpID09IGV2ZW50TmFt ZXMoKS5kcm9wRXZlbnQpCisgICAgICAgIGRyYWdTdGF0dXMgPSBXZWJEcmFnU3RhdHVzRHJvcDsK IAogICAgIGlmIChkcmFnU3RhdHVzID09IFdlYkRyYWdTdGF0dXNVbmtub3duKQogICAgICAgICBy ZXR1cm47CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5k ZXggOTNkNjA3MTQ2Mjc5MmQyMWJkMmVlZGJhMWFkZjk0MzYyMjU2MDVjMi4uY2U3YTU4MDljMDVi MzZjMGFmODRlODNhZTU3NGM5ZTQ2MTQzYTdlZCAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9n CisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEwLTA5ICBTYWRy dWwgSGFiaWIgQ2hvd2RodXJ5ICA8c2FkcnVsQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hy b21pdW1dIEFkZCBkcm9wIGV2ZW50IGZvciBwbHVnaW5zLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTg4MjcKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGUgdGhlIHRlc3QgcGx1Z2luIHRvIHJlY2Vp dmUgZHJvcCBldmVudHMuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0 V2ViUGx1Z2luLmNwcDoKKyAgICAgICAgKFRlc3RXZWJQbHVnaW46OmhhbmRsZURyYWdTdGF0dXNV cGRhdGUpOgorCiAyMDEyLTEwLTA4ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIHJlc3VsdHMuaHRtbCBhbmQgZ2FyZGVuLW8tbWF0aWMgYXJlIGlnbm9yaW5n IElNQUdFIGZhaWx1cmVzIHdoZW4gZXhwZWN0ZWQgdG8gRkFJTApkaWZmIC0tZ2l0IGEvVG9vbHMv RHVtcFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFdlYlBsdWdpbi5jcHAgYi9Ub29scy9EdW1wUmVu ZGVyVHJlZS9jaHJvbWl1bS9UZXN0V2ViUGx1Z2luLmNwcAppbmRleCA3MTE5MmIzYTUxZmM4NmRm ZDMxMjVlMmQzZTQyZGEyMTg5ZTYzMTYzLi5kNjYyMzk4NjU0NGI5ZGQ3YzkyZTRjYzljNWFkMmUx ZTk3YzFjMTI4IDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0 V2ViUGx1Z2luLmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0V2Vi UGx1Z2luLmNwcApAQCAtNDc2LDYgKzQ3Niw5IEBAIGJvb2wgVGVzdFdlYlBsdWdpbjo6aGFuZGxl RHJhZ1N0YXR1c1VwZGF0ZShXZWJLaXQ6OldlYkRyYWdTdGF0dXMgZHJhZ1N0YXR1cywgY29uCiAg ICAgY2FzZSBXZWJLaXQ6OldlYkRyYWdTdGF0dXNMZWF2ZToKICAgICAgICAgZHJhZ1N0YXR1c05h bWUgPSAiRHJhZ0xlYXZlIjsKICAgICAgICAgYnJlYWs7CisgICAgY2FzZSBXZWJLaXQ6OldlYkRy YWdTdGF0dXNEcm9wOgorICAgICAgICBkcmFnU3RhdHVzTmFtZSA9ICJEcmFnRHJvcCI7CisgICAg ICAgIGJyZWFrOwogICAgIGNhc2UgV2ViS2l0OjpXZWJEcmFnU3RhdHVzVW5rbm93bjoKICAgICAg ICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CiAgICAgfQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDFjYzg4MzUxZTc2ZWViYzZl ZDlmMzMxOWFmNjUzOWM3MGI1MGIxMWYuLmQwMDc2ZDYzOTM4MzExMjZkZTJiM2E1ZGRlOGYwOGM0 M2ZiYTJiODcgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMi0xMC0wOSAgU2FkcnVsIEhhYmli IENob3dkaHVyeSAgPHNhZHJ1bEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBB ZGQgZHJvcCBldmVudCBmb3IgcGx1Z2lucy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTk4ODI3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVXBkYXRlZCB0aGUgdGVzdCB0byB2ZXJpZnkgdGhhdCBhIHBsdWdp biBjYW4gcmVjZWl2ZSBkcm9wIGV2ZW50cy4gTm90ZQorICAgICAgICB0aGF0IHRoZSBwbHVnaW4g bmVlZHMgY29udGVudEVkaXRhYmxlIHNldCB0byB0cnVlLgorCisgICAgICAgICogcGxhdGZvcm0v Y2hyb21pdW0vcGx1Z2lucy9kcmFnLWV2ZW50cy1leHBlY3RlZC50eHQ6CisgICAgICAgICogcGxh dGZvcm0vY2hyb21pdW0vcGx1Z2lucy9kcmFnLWV2ZW50cy5odG1sOgorCiAyMDEyLTEwLTA4ICBE aXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIHJlc3VsdHMuaHRt bCBhbmQgZ2FyZGVuLW8tbWF0aWMgYXJlIGlnbm9yaW5nIElNQUdFIGZhaWx1cmVzIHdoZW4gZXhw ZWN0ZWQgdG8gRkFJTApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0v cGx1Z2lucy9kcmFnLWV2ZW50cy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9j aHJvbWl1bS9wbHVnaW5zL2RyYWctZXZlbnRzLWV4cGVjdGVkLnR4dAppbmRleCAxYjQ2OTUxYzVj OWQ4ZmEzMjdkNWUyMmE0OWVlOWM5OWJlYzg2ZDlhLi4yNjE0M2VmNzIwN2VkMzQzZWUxMmM0YjEy NjQwZDBmMTliMzgzNDRjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1 bS9wbHVnaW5zL2RyYWctZXZlbnRzLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9jaHJvbWl1bS9wbHVnaW5zL2RyYWctZXZlbnRzLWV4cGVjdGVkLnR4dApAQCAtMyw1ICsz LDggQEAgUGx1Z2luIHJlY2VpdmVkIGV2ZW50OiBNb3VzZU1vdmUKIFBsdWdpbiByZWNlaXZlZCBl dmVudDogRHJhZ0VudGVyCiBQbHVnaW4gcmVjZWl2ZWQgZXZlbnQ6IERyYWdPdmVyCiBQbHVnaW4g cmVjZWl2ZWQgZXZlbnQ6IERyYWdMZWF2ZQorUGx1Z2luIHJlY2VpdmVkIGV2ZW50OiBEcmFnRW50 ZXIKK1BsdWdpbiByZWNlaXZlZCBldmVudDogRHJhZ092ZXIKK1BsdWdpbiByZWNlaXZlZCBldmVu dDogRHJhZ0Ryb3AKIAogU29tZSB0ZXh0IHRvIGRyYWcKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L3BsYXRmb3JtL2Nocm9taXVtL3BsdWdpbnMvZHJhZy1ldmVudHMuaHRtbCBiL0xheW91dFRlc3Rz L3BsYXRmb3JtL2Nocm9taXVtL3BsdWdpbnMvZHJhZy1ldmVudHMuaHRtbAppbmRleCBkZTAxYTEw Zjk4ZGUwMmJmMDVkNzM0YzBhMDRlODhiODc3YTU1OTA4Li5jNTkxNGRhMmE2ODViOTI5YTU0MTQy MjE5YWM4ZmYwYjA4YmU3ZDBmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJv bWl1bS9wbHVnaW5zL2RyYWctZXZlbnRzLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0v Y2hyb21pdW0vcGx1Z2lucy9kcmFnLWV2ZW50cy5odG1sCkBAIC05LDggKzksOCBAQAogPC9oZWFk PgogCiA8Ym9keSBvbmxvYWQ9InRlc3QoKTsiPgotPGVtYmVkIGlkPSJwbHVnaW4iIHR5cGU9ImFw cGxpY2F0aW9uL3gtd2Via2l0LXRlc3Qtd2VicGx1Z2luIj48L2VtYmVkPgotPGRpdiBjb250ZW50 ZWRpdGFibGUgaWQ9J3RleHQnPjxzcGFuPlNvbWUgdGV4dCB0byBkcmFnPC9zcGFuPjwvZGl2Pgor PGVtYmVkIGlkPSJwbHVnaW4iIHR5cGU9ImFwcGxpY2F0aW9uL3gtd2Via2l0LXRlc3Qtd2VicGx1 Z2luIiBjb250ZW50RWRpdGFibGU+PC9lbWJlZD4KKzxkaXYgaWQ9J3RleHQnPjxzcGFuPlNvbWUg dGV4dCB0byBkcmFnPC9zcGFuPjwvZGl2PgogPHNjcmlwdD4KIAogZnVuY3Rpb24gdGVzdCgpIHsK QEAgLTMwLDYgKzMwLDcgQEAgZnVuY3Rpb24gdGVzdCgpIHsKICAgICAgICAgdmFyIHN0YXJ0WCA9 IGRpdi5vZmZzZXRMZWZ0ICsgZGl2LmZpcnN0Q2hpbGQub2Zmc2V0V2lkdGggLyA1OwogICAgICAg ICB2YXIgc3RhcnRZID0gZGl2Lm9mZnNldFRvcCArIGRpdi5vZmZzZXRIZWlnaHQgLyAyOzsKIAor ICAgICAgICAvLyBEcmFnIGludG8gdGhlIHBsdWdpbiBhbmQgZHJhZyBvdXQgYmVmb3JlIGRyb3Bw aW5nLgogICAgICAgICBldmVudFNlbmRlci5kcmFnTW9kZSA9IHRydWU7CiAgICAgICAgIGV2ZW50 U2VuZGVyLm1vdXNlTW92ZVRvKHN0YXJ0WCwgc3RhcnRZKTsKICAgICAgICAgZXZlbnRTZW5kZXIu bW91c2VEb3duKCk7CkBAIC0zNyw2ICszOCw3IEBAIGZ1bmN0aW9uIHRlc3QoKSB7CiAgICAgICAg IGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKHBvc2l0aW9uWCwgcG9zaXRpb25ZKTsKICAgICAgICAg ZXZlbnRTZW5kZXIubW91c2VNb3ZlVG8ocG9zaXRpb25YICsgMiwgcG9zaXRpb25ZKTsKICAgICAg ICAgZXZlbnRTZW5kZXIubW91c2VNb3ZlVG8oc3RhcnRYLCBzdGFydFkpOworICAgICAgICBldmVu dFNlbmRlci5tb3VzZU1vdmVUbyhwb3NpdGlvblgsIHBvc2l0aW9uWSk7CiAgICAgICAgIGV2ZW50 U2VuZGVyLm1vdXNlVXAoKTsKICAgICB9CiB9Cg==