98819 2012-10-09 13:18:53 -0700 [BlackBerry] Define WTF_USE_EXPORT_MACROS in cmake rather than Platform.h 2012-10-10 11:12:52 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yong.li.webkit webkit-unassigned benjamin gyuyoung.kim laszlo.gombos rakuco rwlbuis tonikitoo webkit.review.bot oldest_to_newest 738126 0 yong.li.webkit 2012-10-09 13:18:53 -0700 Define WTF_USE_EXTRA_MACROS in cmake rather than Platform.h, and make it depend on SHARED_CORE 738162 1 167842 yong.li.webkit 2012-10-09 13:55:14 -0700 Created attachment 167842 the patch 738412 2 laszlo.gombos 2012-10-09 18:29:19 -0700 As the WebKit project does not have a common build-system, I find it more readable and manageable to keep these build rules in C/C++ (shared) code rather than moving them to a port specific build file. Having said that it is probably time to break up Platform.h into smaller files (e.g. config-blackberry.h). Related discussion at bug 97250. 738947 3 yong.li.webkit 2012-10-10 07:38:25 -0700 (In reply to comment #2) > As the WebKit project does not have a common build-system, I find it more readable and manageable to keep these build rules in C/C++ (shared) code rather than moving them to a port specific build file. > > Having said that it is probably time to break up Platform.h into smaller files (e.g. config-blackberry.h). > > Related discussion at bug 97250. Thanks for the info. For some stable macros (using JIT or some features), probably it is better to define them in the .h file. But I feel this symbol exporting stuff should better be decided by the build system 738969 4 167842 rwlbuis 2012-10-10 08:23:40 -0700 Comment on attachment 167842 the patch Looks good. 738990 5 167842 webkit.review.bot 2012-10-10 08:48:41 -0700 Comment on attachment 167842 the patch Clearing flags on attachment: 167842 Committed r130909: <http://trac.webkit.org/changeset/130909> 738991 6 webkit.review.bot 2012-10-10 08:48:45 -0700 All reviewed patches have been landed. Closing bug. 739146 7 yong.li.webkit 2012-10-10 11:12:52 -0700 Oops, just found a typo in the title... 167842 2012-10-09 13:55:14 -0700 2012-10-10 08:48:41 -0700 the patch 98819.patch text/plain 2320 yong.li.webkit ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBiMWI3Y2VhLi4zMmU2MzMx IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTItMTAtMDkgIFlvbmcgTGkgIDx5b2xpQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVy cnldIERlZmluZSBXVEZfVVNFX0VYVFJBX01BQ1JPUyBpbiBjbWFrZSByYXRoZXIgdGhhbiBQbGF0 Zm9ybS5oCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05 ODgxOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFu ZCBtYWtlIGl0IGRlcGVuZCBvbiBTSEFSRURfQ09SRQorICAgICAgICBSSU0gUFIjIDIyMTMzOS4K KworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zQmxhY2tCZXJyeS5jbWFrZToKKwogMjAx Mi0xMC0wOSAgU2ltb24gUGVuYSAgPHNwZW5hQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10g QWRkIHN1cHBvcnQgZm9yIHJ1bm5pbmcgSmF2YVNjcmlwdCBmcm9tIEdSZXNvdXJjZXMKZGlmZiAt LWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKaW5kZXgg YTRjMTE5ZS4uODQyNjQwZSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cKKysrIGIv U291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0xMC0wOSAgWW9uZyBM aSAgPHlvbGlAcmltLmNvbT4KKworICAgICAgICBbQmxhY2tCZXJyeV0gRGVmaW5lIFdURl9VU0Vf RVhUUkFfTUFDUk9TIGluIGNtYWtlIHJhdGhlciB0aGFuIFBsYXRmb3JtLmgKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4ODE5CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQW5kIG1ha2UgaXQgZGVwZW5kIG9u IFNIQVJFRF9DT1JFCisgICAgICAgIFJJTSBQUiMgMjIxMzM5LgorCisgICAgICAgICogd3RmL1Bs YXRmb3JtLmg6CisKIDIwMTItMTAtMDggIEJlbmphbWluIFBvdWxhaW4gIDxiZW5qYW1pbkB3ZWJr aXQub3JnPgogCiAgICAgICAgIEdlbmVyYWxpemUgbW92aW5nIFVSTENvbXBvbmVudCdzIGJlZ2lu IHBvc2l0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oIGIvU291cmNl L1dURi93dGYvUGxhdGZvcm0uaAppbmRleCA2OTJmOGE2Li45Y2I3MmVmIDEwMDY0NAotLS0gYS9T b3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgK QEAgLTExMDksNyArMTEwOSw3IEBACiAgICBzaW5jZSBtb3N0IHBvcnRzIHRyeSB0byBzdXBwb3J0 IHN1Yi1wcm9qZWN0IGluZGVwZW5kZW5jZSwgYWRkaW5nIG5ldyBoZWFkZXJzCiAgICB0byBXVEYg Y2F1c2VzIG1hbnkgcG9ydHMgdG8gYnJlYWssIGFuZCBzbyB0aGlzIHdheSB3ZSBjYW4gYWRkcmVz cyB0aGUgYnVpbGQKICAgIGJyZWFrYWdlcyBvbmUgcG9ydCBhdCBhIHRpbWUuICovCi0jaWYgIWRl ZmluZWQoV1RGX1VTRV9FWFBPUlRfTUFDUk9TKSAmJiAoUExBVEZPUk0oTUFDKSB8fCBQTEFURk9S TShRVCkgfHwgUExBVEZPUk0oV1gpIHx8IFBMQVRGT1JNKEJMQUNLQkVSUlkpKQorI2lmICFkZWZp bmVkKFdURl9VU0VfRVhQT1JUX01BQ1JPUykgJiYgKFBMQVRGT1JNKE1BQykgfHwgUExBVEZPUk0o UVQpIHx8IFBMQVRGT1JNKFdYKSkKICNkZWZpbmUgV1RGX1VTRV9FWFBPUlRfTUFDUk9TIDEKICNl bmRpZgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0JsYWNrQmVycnkuY21ha2Ug Yi9Tb3VyY2UvY21ha2UvT3B0aW9uc0JsYWNrQmVycnkuY21ha2UKaW5kZXggZmJhN2QxNy4uYjk0 NjAxNCAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL09wdGlvbnNCbGFja0JlcnJ5LmNtYWtlCisr KyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQmxhY2tCZXJyeS5jbWFrZQpAQCAtMTksNiArMTksMTAg QEAgQUREX0RFRklOSVRJT05TKC1EV1RGX1VTRV9QVEhSRUFEUz0xKQogU0VUKFdURl9VU0VfT1BF TlRZUEVfU0FOSVRJWkVSIDEpCiBBRERfREVGSU5JVElPTlMoLURXVEZfVVNFX09QRU5UWVBFX1NB TklUSVpFUj0xKQogCitJRiAoU0hBUkVEX0NPUkUpCisgICAgQUREX0RFRklOSVRJT05TKC1EV1RG X1VTRV9FWFBPUlRfTUFDUk9TPTEpCitFTkRJRigpCisKIElGIChFTkFCTEVfR0xFUzIpCiAgICAg U0VUKFdURl9VU0VfQUNDRUxFUkFURURfQ09NUE9TSVRJTkcgMSkKICAgICBBRERfREVGSU5JVElP TlMoLURXVEZfVVNFX0FDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HPTEpCg==