98810 2012-10-09 12:00:38 -0700 webkit-patch rebaseline-expectations doesn't work w/o failures specified 2012-10-09 15:19:38 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dpranke dpranke abarth jchaffraix ojan tony webkit.review.bot oldest_to_newest 738025 0 dpranke 2012-10-09 12:00:38 -0700 webkit-patch rebaseline-expectations doesn't work w/o failures specified 738027 1 167807 dpranke 2012-10-09 12:01:21 -0700 Created attachment 167807 Patch 738055 2 167807 ojan 2012-10-09 12:21:06 -0700 Comment on attachment 167807 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167807&action=review > Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:872 > + return self._model.get_test_set(REBASELINE, IMAGE) | self._model.get_test_set(REBASELINE, FAIL) | self._model.get_test_set(REBASELINE, PASS) Can you just use self._model.get_test_set("REBASELINE")? In addition to the fixme to get rid of get_test_set, I worry that we'll eventually do the cleanup to not mark skip/rebaseline tests as pass, but just have the expectation be skip/rebaseline. Then this code will break again. 738068 3 dpranke 2012-10-09 12:26:53 -0700 (In reply to comment #2) > (From update of attachment 167807 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=167807&action=review > > > Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:872 > > + return self._model.get_test_set(REBASELINE, IMAGE) | self._model.get_test_set(REBASELINE, FAIL) | self._model.get_test_set(REBASELINE, PASS) > > Can you just use self._model.get_test_set("REBASELINE")? > Oh, yeah, I guess you can. I was thinking (a) that you had to have expectations, and (b) that we wouldn't want to rebaseline something if it was marked Crash or Timeout, but perhaps that's overly paranoid. > In addition to the fixme to get rid of get_test_set, I worry that we'll eventually do the cleanup to not mark skip/rebaseline tests as pass, but just have the expectation be skip/rebaseline. Then this code will break again. But the test should catch it if it breaks again, right? 738071 4 167807 ojan 2012-10-09 12:28:00 -0700 Comment on attachment 167807 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167807&action=review >>> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:872 >>> + return self._model.get_test_set(REBASELINE, IMAGE) | self._model.get_test_set(REBASELINE, FAIL) | self._model.get_test_set(REBASELINE, PASS) >> >> Can you just use self._model.get_test_set("REBASELINE")? >> >> In addition to the fixme to get rid of get_test_set, I worry that we'll eventually do the cleanup to not mark skip/rebaseline tests as pass, but just have the expectation be skip/rebaseline. Then this code will break again. > > Oh, yeah, I guess you can. I was thinking (a) that you had to have expectations, and (b) that we wouldn't want to rebaseline something if it was marked Crash or Timeout, but perhaps that's overly paranoid. Yeah, I think that's overly paranoid. If you add rebaseline, you're asking for it I think. 738172 5 167845 dpranke 2012-10-09 14:09:18 -0700 Created attachment 167845 just get all of the tests marked for rebaselining 738247 6 167845 webkit.review.bot 2012-10-09 15:19:34 -0700 Comment on attachment 167845 just get all of the tests marked for rebaselining Clearing flags on attachment: 167845 Committed r130819: <http://trac.webkit.org/changeset/130819> 738248 7 webkit.review.bot 2012-10-09 15:19:38 -0700 All reviewed patches have been landed. Closing bug. 167807 2012-10-09 12:01:21 -0700 2012-10-09 14:09:16 -0700 Patch bug-98810-20121009120022.patch text/plain 2962 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwNzE1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTNkNjA3MTQ2Mjc5MmQyMWJkMmVlZGJhMWFkZjk0MzYy MjU2MDVjMi4uM2Q3MmY2MTY5YmU5NjYxZDgzYzkzMjI5NDQ2NDExMjQ0YmIwMjMwYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDEyLTEwLTA5ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIHdlYmtpdC1wYXRjaCByZWJhc2VsaW5lLWV4cGVjdGF0aW9ucyBkb2Vzbid0IHdvcmsg dy9vIGZhaWx1cmVzIHNwZWNpZmllZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9OTg4MTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBJZiB5b3UgdHJ5IHRvIG1hcmsgYSB0ZXN0IGFzIGZvby5odG1sIFsgUmVi YXNlbGluZSBdIGl0IHdhc24ndAorICAgICAgICBnZXR0aW5nIHBpY2tlZCB1cCBmb3IgcmViYXNl bGluaW5nOyB3ZSBuZWVkZWQgdG8gdGhpbmsgdGhlIHRlc3QKKyAgICAgICAgd2FzIGZhaWxpbmcu CisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9tb2RlbHMvdGVzdF9l eHBlY3RhdGlvbnMucHk6CisgICAgICAgIChUZXN0RXhwZWN0YXRpb25zLmdldF9yZWJhc2VsaW5p bmdfZmFpbHVyZXMpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL21v ZGVscy90ZXN0X2V4cGVjdGF0aW9uc191bml0dGVzdC5weToKKyAgICAgICAgKFJlYmFzZWxpbmlu Z1Rlc3QudGVzdF9nZXRfcmViYXNlbGluaW5nX2ZhaWx1cmVzKToKKwogMjAxMi0xMC0wOCAgRGly ayBQcmFua2UgIDxkcHJhbmtlQGNocm9taXVtLm9yZz4KIAogICAgICAgICByZXN1bHRzLmh0bWwg YW5kIGdhcmRlbi1vLW1hdGljIGFyZSBpZ25vcmluZyBJTUFHRSBmYWlsdXJlcyB3aGVuIGV4cGVj dGVkIHRvIEZBSUwKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL21vZGVscy90ZXN0X2V4cGVjdGF0aW9ucy5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv bGF5b3V0X3Rlc3RzL21vZGVscy90ZXN0X2V4cGVjdGF0aW9ucy5weQppbmRleCAzMmJlNDc2NGZi N2NjZmI5YTg2YjFkMTg1NGI3YmZjYTFmZTVkYjY3Li43MGM0YjhiN2NhZjFjYzI3ZDM4ZjIwZTdk YTQyMDhhNjJlYWFiMThlIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91 dF90ZXN0cy9tb2RlbHMvdGVzdF9leHBlY3RhdGlvbnMucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9sYXlvdXRfdGVzdHMvbW9kZWxzL3Rlc3RfZXhwZWN0YXRpb25zLnB5CkBAIC04Njks NyArODY5LDcgQEAgY2xhc3MgVGVzdEV4cGVjdGF0aW9ucyhvYmplY3QpOgogICAgICAgICByZXR1 cm4gc2VsZi5fbW9kZWwKIAogICAgIGRlZiBnZXRfcmViYXNlbGluaW5nX2ZhaWx1cmVzKHNlbGYp OgotICAgICAgICByZXR1cm4gc2VsZi5fbW9kZWwuZ2V0X3Rlc3Rfc2V0KFJFQkFTRUxJTkUsIElN QUdFKSB8IHNlbGYuX21vZGVsLmdldF90ZXN0X3NldChSRUJBU0VMSU5FLCBGQUlMKQorICAgICAg ICByZXR1cm4gc2VsZi5fbW9kZWwuZ2V0X3Rlc3Rfc2V0KFJFQkFTRUxJTkUsIElNQUdFKSB8IHNl bGYuX21vZGVsLmdldF90ZXN0X3NldChSRUJBU0VMSU5FLCBGQUlMKSB8IHNlbGYuX21vZGVsLmdl dF90ZXN0X3NldChSRUJBU0VMSU5FLCBQQVNTKQogCiAgICAgIyBGSVhNRTogQ2hhbmdlIHRoZSBj YWxsc2l0ZXMgdG8gdXNlIFRlc3RFeHBlY3RhdGlvbnNNb2RlbCBhbmQgcmVtb3ZlLgogICAgIGRl ZiBnZXRfZXhwZWN0YXRpb25zKHNlbGYsIHRlc3QpOgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbW9kZWxzL3Rlc3RfZXhwZWN0YXRpb25zX3VuaXR0ZXN0 LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbW9kZWxzL3Rlc3RfZXhw ZWN0YXRpb25zX3VuaXR0ZXN0LnB5CmluZGV4IGUxY2QwNDI1ZmFkYmVkODJkMzIzYjkyYWJiNmY2 ODRmMzAzNGViMjQuLmMzZmMwMjY1ODEwODU5NDM0NTg1MmZkYzdjMmU1NGY5M2E2MTQyNjIgMTAw NjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL21vZGVscy90ZXN0 X2V4cGVjdGF0aW9uc191bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xh eW91dF90ZXN0cy9tb2RlbHMvdGVzdF9leHBlY3RhdGlvbnNfdW5pdHRlc3QucHkKQEAgLTUyNCw5 ICs1MjQsMTEgQEAgY2xhc3MgUmViYXNlbGluaW5nVGVzdChCYXNlKToKICAgICAgICAgICAgICAg ICAgICAgICAgICAgJ0J1Zyh6KSBmYWlsdXJlcy9leHBlY3RlZC9jcmFzaC5odG1sXG4nLAogICAg ICAgICAgICAgICAgICAgICAgICAgICAnJykKIAorICAgIGRlZiB0ZXN0X2dldF9yZWJhc2VsaW5p bmdfZmFpbHVyZXMoc2VsZik6CisgICAgICAgICMgTWFrZSBzdXJlIHdlIGZpbmQgYSB0ZXN0IGFz IG5lZWRpbmcgYSByZWJhc2VsaW5lIGV2ZW4gaWYgaXQgaXMgbm90IG1hcmtlZCBhcyBhIGZhaWx1 cmUuCisgICAgICAgIHNlbGYucGFyc2VfZXhwKCdCdWcoeCkgZmFpbHVyZXMvZXhwZWN0ZWQvdGV4 dC5odG1sIFsgUmViYXNlbGluZSBdXG4nKQorICAgICAgICBzZWxmLmFzc2VydEVxdWFsKGxlbihz ZWxmLl9leHAuZ2V0X3JlYmFzZWxpbmluZ19mYWlsdXJlcygpKSwgMSkKIAotCi0gICAgZGVmIHRl c3Rfbm9fZ2V0X3JlYmFzZWxpbmluZ19mYWlsdXJlcyhzZWxmKToKICAgICAgICAgc2VsZi5wYXJz ZV9leHAoc2VsZi5nZXRfYmFzaWNfZXhwZWN0YXRpb25zKCkpCiAgICAgICAgIHNlbGYuYXNzZXJ0 RXF1YWwobGVuKHNlbGYuX2V4cC5nZXRfcmViYXNlbGluaW5nX2ZhaWx1cmVzKCkpLCAwKQogCg== 167845 2012-10-09 14:09:18 -0700 2012-10-09 15:19:34 -0700 just get all of the tests marked for rebaselining bug-98810-20121009140819.patch text/plain 2865 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwNzE1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTNkNjA3MTQ2Mjc5MmQyMWJkMmVlZGJhMWFkZjk0MzYy MjU2MDVjMi4uM2Q3MmY2MTY5YmU5NjYxZDgzYzkzMjI5NDQ2NDExMjQ0YmIwMjMwYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDEyLTEwLTA5ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIHdlYmtpdC1wYXRjaCByZWJhc2VsaW5lLWV4cGVjdGF0aW9ucyBkb2Vzbid0IHdvcmsg dy9vIGZhaWx1cmVzIHNwZWNpZmllZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9OTg4MTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBJZiB5b3UgdHJ5IHRvIG1hcmsgYSB0ZXN0IGFzIGZvby5odG1sIFsgUmVi YXNlbGluZSBdIGl0IHdhc24ndAorICAgICAgICBnZXR0aW5nIHBpY2tlZCB1cCBmb3IgcmViYXNl bGluaW5nOyB3ZSBuZWVkZWQgdG8gdGhpbmsgdGhlIHRlc3QKKyAgICAgICAgd2FzIGZhaWxpbmcu CisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9tb2RlbHMvdGVzdF9l eHBlY3RhdGlvbnMucHk6CisgICAgICAgIChUZXN0RXhwZWN0YXRpb25zLmdldF9yZWJhc2VsaW5p bmdfZmFpbHVyZXMpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL21v ZGVscy90ZXN0X2V4cGVjdGF0aW9uc191bml0dGVzdC5weToKKyAgICAgICAgKFJlYmFzZWxpbmlu Z1Rlc3QudGVzdF9nZXRfcmViYXNlbGluaW5nX2ZhaWx1cmVzKToKKwogMjAxMi0xMC0wOCAgRGly ayBQcmFua2UgIDxkcHJhbmtlQGNocm9taXVtLm9yZz4KIAogICAgICAgICByZXN1bHRzLmh0bWwg YW5kIGdhcmRlbi1vLW1hdGljIGFyZSBpZ25vcmluZyBJTUFHRSBmYWlsdXJlcyB3aGVuIGV4cGVj dGVkIHRvIEZBSUwKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL21vZGVscy90ZXN0X2V4cGVjdGF0aW9ucy5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv bGF5b3V0X3Rlc3RzL21vZGVscy90ZXN0X2V4cGVjdGF0aW9ucy5weQppbmRleCAzMmJlNDc2NGZi N2NjZmI5YTg2YjFkMTg1NGI3YmZjYTFmZTVkYjY3Li5iNDhjNWI5MzNjZDM1YmQzYTQ0OWZkNzZi Y2I2NmQ3ZjIyODlkODlhIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91 dF90ZXN0cy9tb2RlbHMvdGVzdF9leHBlY3RhdGlvbnMucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9sYXlvdXRfdGVzdHMvbW9kZWxzL3Rlc3RfZXhwZWN0YXRpb25zLnB5CkBAIC04Njks NyArODY5LDcgQEAgY2xhc3MgVGVzdEV4cGVjdGF0aW9ucyhvYmplY3QpOgogICAgICAgICByZXR1 cm4gc2VsZi5fbW9kZWwKIAogICAgIGRlZiBnZXRfcmViYXNlbGluaW5nX2ZhaWx1cmVzKHNlbGYp OgotICAgICAgICByZXR1cm4gc2VsZi5fbW9kZWwuZ2V0X3Rlc3Rfc2V0KFJFQkFTRUxJTkUsIElN QUdFKSB8IHNlbGYuX21vZGVsLmdldF90ZXN0X3NldChSRUJBU0VMSU5FLCBGQUlMKQorICAgICAg ICByZXR1cm4gc2VsZi5fbW9kZWwuZ2V0X3Rlc3Rfc2V0KFJFQkFTRUxJTkUpCiAKICAgICAjIEZJ WE1FOiBDaGFuZ2UgdGhlIGNhbGxzaXRlcyB0byB1c2UgVGVzdEV4cGVjdGF0aW9uc01vZGVsIGFu ZCByZW1vdmUuCiAgICAgZGVmIGdldF9leHBlY3RhdGlvbnMoc2VsZiwgdGVzdCk6CmRpZmYgLS1n aXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9tb2RlbHMvdGVzdF9leHBl Y3RhdGlvbnNfdW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0 cy9tb2RlbHMvdGVzdF9leHBlY3RhdGlvbnNfdW5pdHRlc3QucHkKaW5kZXggZTFjZDA0MjVmYWRi ZWQ4MmQzMjNiOTJhYmI2ZjY4NGYzMDM0ZWIyNC4uYzNmYzAyNjU4MTA4NTk0MzQ1ODUyZmRjN2My ZTU0ZjkzYTYxNDI2MiAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvbW9kZWxzL3Rlc3RfZXhwZWN0YXRpb25zX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL21vZGVscy90ZXN0X2V4cGVjdGF0aW9uc191bml0 dGVzdC5weQpAQCAtNTI0LDkgKzUyNCwxMSBAQCBjbGFzcyBSZWJhc2VsaW5pbmdUZXN0KEJhc2Up OgogICAgICAgICAgICAgICAgICAgICAgICAgICAnQnVnKHopIGZhaWx1cmVzL2V4cGVjdGVkL2Ny YXNoLmh0bWxcbicsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICcnKQogCisgICAgZGVmIHRl c3RfZ2V0X3JlYmFzZWxpbmluZ19mYWlsdXJlcyhzZWxmKToKKyAgICAgICAgIyBNYWtlIHN1cmUg d2UgZmluZCBhIHRlc3QgYXMgbmVlZGluZyBhIHJlYmFzZWxpbmUgZXZlbiBpZiBpdCBpcyBub3Qg bWFya2VkIGFzIGEgZmFpbHVyZS4KKyAgICAgICAgc2VsZi5wYXJzZV9leHAoJ0J1Zyh4KSBmYWls dXJlcy9leHBlY3RlZC90ZXh0Lmh0bWwgWyBSZWJhc2VsaW5lIF1cbicpCisgICAgICAgIHNlbGYu YXNzZXJ0RXF1YWwobGVuKHNlbGYuX2V4cC5nZXRfcmViYXNlbGluaW5nX2ZhaWx1cmVzKCkpLCAx KQogCi0KLSAgICBkZWYgdGVzdF9ub19nZXRfcmViYXNlbGluaW5nX2ZhaWx1cmVzKHNlbGYpOgog ICAgICAgICBzZWxmLnBhcnNlX2V4cChzZWxmLmdldF9iYXNpY19leHBlY3RhdGlvbnMoKSkKICAg ICAgICAgc2VsZi5hc3NlcnRFcXVhbChsZW4oc2VsZi5fZXhwLmdldF9yZWJhc2VsaW5pbmdfZmFp bHVyZXMoKSksIDApCiAK