98808 2012-10-09 11:42:00 -0700 Compilation problem in debug build on MIPS 2012-10-10 11:23:11 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 0 kilvadyb webkit-unassigned fpizlo fu gergely ggaren mark.lam palfia webkit.review.bot oldest_to_newest 738004 0 kilvadyb 2012-10-09 11:42:00 -0700 Renaming RegisterFile to JSStack (https://bugs.webkit.org/show_bug.cgi?id=98717) caused a compilation problem in debug build on MIPS (and very likely on ARM_THUMB2) as in ASSERT conditions structure field name "registerFile" was replaced with type name "JSStack" and it should be "stack". 738030 1 167810 kilvadyb 2012-10-09 12:03:56 -0700 Created attachment 167810 Fix the replaced member name. Very likely the same problem appears in the ARM_THUMB2 #ifdef block at line #799 738158 2 mark.lam 2012-10-09 13:50:12 -0700 (In reply to comment #1) > Created an attachment (id=167810) [details] > Fix the replaced member name. > > Very likely the same problem appears in the ARM_THUMB2 #ifdef block at line #799 Yes, both the ARM_THUMB2 and MIPS cases have the typo. The (struct JITStackFrame, JSStack) should be (struct JITStackFrame, stack) as you pointed out. Can you please fix the ARM_THUMB2 case as well in your patch? Thanks. 738725 3 167955 kilvadyb 2012-10-10 01:25:21 -0700 Created attachment 167955 Fix the replaced member name. Typo fixed in ARM_THUMB2 block also. REGISTER_FILE_OFFSET macro could be renamed to STACK_OFFSET or STACK_FRAME_OFFSET as well. 738740 4 167955 fpizlo 2012-10-10 01:40:58 -0700 Comment on attachment 167955 Fix the replaced member name. You should rebase this patch. But it looks good. 738755 5 167961 kilvadyb 2012-10-10 02:20:07 -0700 Created attachment 167961 Fix the replaced member name. Applied to current master branch. 739143 6 ap 2012-10-10 11:09:47 -0700 Since you already had an r+, you could have put Filip's name in ChangeLog of the rebased patch. 739153 7 167961 webkit.review.bot 2012-10-10 11:23:08 -0700 Comment on attachment 167961 Fix the replaced member name. Clearing flags on attachment: 167961 Committed r130935: <http://trac.webkit.org/changeset/130935> 739154 8 webkit.review.bot 2012-10-10 11:23:11 -0700 All reviewed patches have been landed. Closing bug. 167810 2012-10-09 12:03:56 -0700 2012-10-10 01:25:21 -0700 Fix the replaced member name. name_fix.diff text/plain 1706 kilvadyb ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGNkZjE4OTcuLjY1YjlkNjcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTEwLTA5ICBCYWxhenMgS2lsdmFk eSAgPGtpbHZhZHliQGhvbWVqaW5uaS5jb20+CisKKyAgICAgICAgUmVnaXN0ZXJGaWxlIHRvIEpT U3RhY2sgcmVuYW1lIGZpeCBmb3IgYSBzdHJ1Y3QgbWVtYmVyLgorCisgICAgICAgIENvbXBpbGF0 aW9uIHByb2JsZW0gaW4gZGVidWcgYnVpbGQgb24gTUlQUworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTg4MDgKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbiBBU1NFUlQgY29uZGl0aW9ucyBzdHJ1Y3R1cmUg ZmllbGQgbmFtZSAicmVnaXN0ZXJGaWxlIiB3YXMgcmVwbGFjZWQKKyAgICAgICAgICAgICAgIHdp dGggdHlwZSBuYW1lICJKU1N0YWNrIiBhbmQgaXQgc2hvdWxkIGJlICJzdGFjayIuCisKKyAgICAg ICAgKiBqaXQvSklUU3R1YnMuY3BwOgorICAgICAgICAoSlNDOjpKSVRUaHVua3M6OkpJVFRodW5r cyk6IHN0cnVjdHVyZSBtZW1iZXIgbmFtZSBmaXguCisKIDIwMTItMTAtMDkgIE1pY2hhZWwgU2Fi b2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CiAKICAgICAgICAgQWZ0ZXIgcjEzMDM0NCwgT3BhcXVl SlNTdHJpbmc6OmlkZW50aWZpZXIoKSBhZGRzIHdyYXBwZWQgU3RyaW5nIHRvIGlkZW50aWZpZXIg dGFibGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUU3R1YnMuY3Bw IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRTdHVicy5jcHAKaW5kZXggN2RmYmExMy4u NzVkN2IzZCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRTdHVicy5j cHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRTdHVicy5jcHAKQEAgLTgxNSw3 ICs4MTUsNyBAQCBKSVRUaHVua3M6OkpJVFRodW5rcyhKU0dsb2JhbERhdGEqIGdsb2JhbERhdGEp CiAgICAgQVNTRVJUKE9CSkVDVF9PRkZTRVRPRihzdHJ1Y3QgSklUU3RhY2tGcmFtZSwgcHJlc2Vy dmVkUzIpID09IFBSRVNFUlZFRF9TMl9PRkZTRVQpOwogICAgIEFTU0VSVChPQkpFQ1RfT0ZGU0VU T0Yoc3RydWN0IEpJVFN0YWNrRnJhbWUsIHByZXNlcnZlZFJldHVybkFkZHJlc3MpID09IFBSRVNF UlZFRF9SRVRVUk5fQUREUkVTU19PRkZTRVQpOwogICAgIEFTU0VSVChPQkpFQ1RfT0ZGU0VUT0Yo c3RydWN0IEpJVFN0YWNrRnJhbWUsIHRodW5rUmV0dXJuQWRkcmVzcykgPT0gVEhVTktfUkVUVVJO X0FERFJFU1NfT0ZGU0VUKTsKLSAgICBBU1NFUlQoT0JKRUNUX09GRlNFVE9GKHN0cnVjdCBKSVRT dGFja0ZyYW1lLCBKU1N0YWNrKSA9PSBSRUdJU1RFUl9GSUxFX09GRlNFVCk7CisgICAgQVNTRVJU KE9CSkVDVF9PRkZTRVRPRihzdHJ1Y3QgSklUU3RhY2tGcmFtZSwgc3RhY2spID09IFJFR0lTVEVS X0ZJTEVfT0ZGU0VUKTsKICAgICBBU1NFUlQoT0JKRUNUX09GRlNFVE9GKHN0cnVjdCBKSVRTdGFj a0ZyYW1lLCBnbG9iYWxEYXRhKSA9PSBHTE9CQUxfREFUQV9PRkZTRVQpOwogCiAjZW5kaWY= 167955 2012-10-10 01:25:21 -0700 2012-10-10 02:21:35 -0700 Fix the replaced member name. name_fix.diff text/plain 2271 kilvadyb ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGNkZjE4OTcuLjE5ZTFkZTUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTEwLTEwICBCYWxhenMgS2lsdmFk eSAgPGtpbHZhZHliQGhvbWVqaW5uaS5jb20+CisKKyAgICAgICAgUmVnaXN0ZXJGaWxlIHRvIEpT U3RhY2sgcmVuYW1lIGZpeCBmb3IgYSBzdHJ1Y3QgbWVtYmVyLgorCisgICAgICAgIENvbXBpbGF0 aW9uIHByb2JsZW0gaW4gZGVidWcgYnVpbGQgb24gTUlQUworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTg4MDgKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbiBBU1NFUlQgY29uZGl0aW9ucyBzdHJ1Y3R1cmUg ZmllbGQgbmFtZSAicmVnaXN0ZXJGaWxlIiB3YXMgcmVwbGFjZWQgCisgICAgICAgIHdpdGggdHlw ZSBuYW1lICJKU1N0YWNrIiBhbmQgaXQgc2hvdWxkIGJlICJzdGFjayIuCisKKyAgICAgICAgKiBq aXQvSklUU3R1YnMuY3BwOgorICAgICAgICAoSlNDOjpKSVRUaHVua3M6OkpJVFRodW5rcyk6IHN0 cnVjdHVyZSBtZW1iZXIgbmFtZSBmaXguCisKIDIwMTItMTAtMDkgIE1pY2hhZWwgU2Fib2ZmICA8 bXNhYm9mZkBhcHBsZS5jb20+CiAKICAgICAgICAgQWZ0ZXIgcjEzMDM0NCwgT3BhcXVlSlNTdHJp bmc6OmlkZW50aWZpZXIoKSBhZGRzIHdyYXBwZWQgU3RyaW5nIHRvIGlkZW50aWZpZXIgdGFibGUK ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUU3R1YnMuY3BwIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRTdHVicy5jcHAKaW5kZXggN2RmYmExMy4uMGEwMDE4 MCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRTdHVicy5jcHAKKysr IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRTdHVicy5jcHAKQEAgLTc5Niw3ICs3OTYs NyBAQCBKSVRUaHVua3M6OkpJVFRodW5rcyhKU0dsb2JhbERhdGEqIGdsb2JhbERhdGEpCiAgICAg QVNTRVJUKE9CSkVDVF9PRkZTRVRPRihzdHJ1Y3QgSklUU3RhY2tGcmFtZSwgcHJlc2VydmVkUjEw KSA9PSBQUkVTRVJWRURfUjEwX09GRlNFVCk7CiAgICAgQVNTRVJUKE9CSkVDVF9PRkZTRVRPRihz dHJ1Y3QgSklUU3RhY2tGcmFtZSwgcHJlc2VydmVkUjExKSA9PSBQUkVTRVJWRURfUjExX09GRlNF VCk7CiAKLSAgICBBU1NFUlQoT0JKRUNUX09GRlNFVE9GKHN0cnVjdCBKSVRTdGFja0ZyYW1lLCBK U1N0YWNrKSA9PSBSRUdJU1RFUl9GSUxFX09GRlNFVCk7CisgICAgQVNTRVJUKE9CSkVDVF9PRkZT RVRPRihzdHJ1Y3QgSklUU3RhY2tGcmFtZSwgc3RhY2spID09IFJFR0lTVEVSX0ZJTEVfT0ZGU0VU KTsKICAgICAvLyBUaGUgZmlmdGggYXJndW1lbnQgaXMgdGhlIGZpcnN0IGl0ZW0gYWxyZWFkeSBv biB0aGUgc3RhY2suCiAgICAgQVNTRVJUKE9CSkVDVF9PRkZTRVRPRihzdHJ1Y3QgSklUU3RhY2tG cmFtZSwgdW51c2VkMSkgPT0gRklSU1RfU1RBQ0tfQVJHVU1FTlQpOwogCkBAIC04MTUsNyArODE1 LDcgQEAgSklUVGh1bmtzOjpKSVRUaHVua3MoSlNHbG9iYWxEYXRhKiBnbG9iYWxEYXRhKQogICAg IEFTU0VSVChPQkpFQ1RfT0ZGU0VUT0Yoc3RydWN0IEpJVFN0YWNrRnJhbWUsIHByZXNlcnZlZFMy KSA9PSBQUkVTRVJWRURfUzJfT0ZGU0VUKTsKICAgICBBU1NFUlQoT0JKRUNUX09GRlNFVE9GKHN0 cnVjdCBKSVRTdGFja0ZyYW1lLCBwcmVzZXJ2ZWRSZXR1cm5BZGRyZXNzKSA9PSBQUkVTRVJWRURf UkVUVVJOX0FERFJFU1NfT0ZGU0VUKTsKICAgICBBU1NFUlQoT0JKRUNUX09GRlNFVE9GKHN0cnVj dCBKSVRTdGFja0ZyYW1lLCB0aHVua1JldHVybkFkZHJlc3MpID09IFRIVU5LX1JFVFVSTl9BRERS RVNTX09GRlNFVCk7Ci0gICAgQVNTRVJUKE9CSkVDVF9PRkZTRVRPRihzdHJ1Y3QgSklUU3RhY2tG cmFtZSwgSlNTdGFjaykgPT0gUkVHSVNURVJfRklMRV9PRkZTRVQpOworICAgIEFTU0VSVChPQkpF Q1RfT0ZGU0VUT0Yoc3RydWN0IEpJVFN0YWNrRnJhbWUsIHN0YWNrKSA9PSBSRUdJU1RFUl9GSUxF X09GRlNFVCk7CiAgICAgQVNTRVJUKE9CSkVDVF9PRkZTRVRPRihzdHJ1Y3QgSklUU3RhY2tGcmFt ZSwgZ2xvYmFsRGF0YSkgPT0gR0xPQkFMX0RBVEFfT0ZGU0VUKTsKIAogI2VuZGlm 167961 2012-10-10 02:20:07 -0700 2012-10-10 11:23:08 -0700 Fix the replaced member name. name_fix.diff text/plain 1680 kilvadyb ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGYxMjJjN2UuLjBhOTJlYTMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTEwLTEwICBCYWxhenMgS2lsdmFk eSAgPGtpbHZhZHliQGhvbWVqaW5uaS5jb20+CisKKyAgICAgICAgUmVnaXN0ZXJGaWxlIHRvIEpT U3RhY2sgcmVuYW1lIGZpeCBmb3IgYSBzdHJ1Y3QgbWVtYmVyLgorCisgICAgICAgIENvbXBpbGF0 aW9uIHByb2JsZW0gaW4gZGVidWcgYnVpbGQgb24gTUlQUworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTg4MDgKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbiBBU1NFUlQgY29uZGl0aW9ucyBzdHJ1Y3R1cmUg ZmllbGQgbmFtZSAicmVnaXN0ZXJGaWxlIiB3YXMgcmVwbGFjZWQKKyAgICAgICAgd2l0aCB0eXBl IG5hbWUgIkpTU3RhY2siIGFuZCBpdCBzaG91bGQgYmUgInN0YWNrIi4KKworICAgICAgICAqIGpp dC9KSVRTdHVicy5jcHA6CisgICAgICAgIChKU0M6OkpJVFRodW5rczo6SklUVGh1bmtzKTogc3Ry dWN0dXJlIG1lbWJlciBuYW1lIGZpeC4KKwogMjAxMi0xMC0xMCAgUGV0ZXIgR2FsICA8Z2FscGV0 ZXJAaW5mLnUtc3plZ2VkLmh1PgogCiAgICAgICAgIEFkZCBtb3ZlRG91YmxlVG9JbnRzIGFuZCBt b3ZlSW50c1RvRG91YmxlIHRvIE1hY3JvQXNzZW1ibGVyQVJNCmRpZmYgLS1naXQgYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvaml0L0pJVFN0dWJzLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9q aXQvSklUU3R1YnMuY3BwCmluZGV4IDk4NjQ2YjYuLjFhMmM2NTQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUU3R1YnMuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9qaXQvSklUU3R1YnMuY3BwCkBAIC04MTYsNyArODE2LDcgQEAgSklUVGh1bmtzOjpKSVRU aHVua3MoSlNHbG9iYWxEYXRhKiBnbG9iYWxEYXRhKQogICAgIEFTU0VSVChPQkpFQ1RfT0ZGU0VU T0Yoc3RydWN0IEpJVFN0YWNrRnJhbWUsIHByZXNlcnZlZFMyKSA9PSBQUkVTRVJWRURfUzJfT0ZG U0VUKTsKICAgICBBU1NFUlQoT0JKRUNUX09GRlNFVE9GKHN0cnVjdCBKSVRTdGFja0ZyYW1lLCBw cmVzZXJ2ZWRSZXR1cm5BZGRyZXNzKSA9PSBQUkVTRVJWRURfUkVUVVJOX0FERFJFU1NfT0ZGU0VU KTsKICAgICBBU1NFUlQoT0JKRUNUX09GRlNFVE9GKHN0cnVjdCBKSVRTdGFja0ZyYW1lLCB0aHVu a1JldHVybkFkZHJlc3MpID09IFRIVU5LX1JFVFVSTl9BRERSRVNTX09GRlNFVCk7Ci0gICAgQVNT RVJUKE9CSkVDVF9PRkZTRVRPRihzdHJ1Y3QgSklUU3RhY2tGcmFtZSwgSlNTdGFjaykgPT0gUkVH SVNURVJfRklMRV9PRkZTRVQpOworICAgIEFTU0VSVChPQkpFQ1RfT0ZGU0VUT0Yoc3RydWN0IEpJ VFN0YWNrRnJhbWUsIHN0YWNrKSA9PSBSRUdJU1RFUl9GSUxFX09GRlNFVCk7CiAgICAgQVNTRVJU KE9CSkVDVF9PRkZTRVRPRihzdHJ1Y3QgSklUU3RhY2tGcmFtZSwgZ2xvYmFsRGF0YSkgPT0gR0xP QkFMX0RBVEFfT0ZGU0VUKTsKIAogI2VuZGlm