98805 2012-10-09 11:36:54 -0700 Add tests to testapi for null OpaqueJSStrings 2012-10-09 18:18:56 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 98300 1 msaboff msaboff webkit.review.bot oldest_to_newest 737994 0 msaboff 2012-10-09 11:36:54 -0700 There isn't sufficient testing for the handling of null OpaqueJSStrings. This is evident from the changes to OpaqueJSString in r130344 from https://bugs.webkit.org/show_bug.cgi?id=98300 and its follow-ons. 738094 1 167824 msaboff 2012-10-09 12:49:53 -0700 Created attachment 167824 Patch 738374 2 167824 ggaren 2012-10-09 17:52:10 -0700 Comment on attachment 167824 Patch r=me 738398 3 167824 webkit.review.bot 2012-10-09 18:18:53 -0700 Comment on attachment 167824 Patch Clearing flags on attachment: 167824 Committed r130832: <http://trac.webkit.org/changeset/130832> 738399 4 webkit.review.bot 2012-10-09 18:18:56 -0700 All reviewed patches have been landed. Closing bug. 167824 2012-10-09 12:49:53 -0700 2012-10-09 18:18:53 -0700 Patch 98805.patch text/plain 3142 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTMwNzk1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDEyLTEwLTA5ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIEFkZCB0ZXN0cyB0byB0ZXN0YXBpIGZvciBudWxsIE9wYXF1ZUpTU3RyaW5ncworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTg4MDUKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCB0ZXN0cyB0aGF0 IGNoZWNrIHRoYXQgT3BhcXVlSlNTdHJpbmcsIHdoaWNoIGlzIHdyYXBwZWQgdmlhIEpTU3RyaW5n UmVmLCBwcm9wZXJseSByZXR1cm5zCisgICAgICAgIG51bGwgc3RyaW5ncyBhbmQgdGhhdCBhIG51 bGwgc3RyaW5nIGluIGEgSlNTdHJpbmdSZWYgd2lsbCByZXR1cm4gYSBOVUxMIEpTQ2hhciogYW5k IDAgbGVuZ3RoCisgICAgICAgIHZpYSB0aGUgSlNTdHJpbmdHZXRDaGFyYWN0ZXJzUHRyKCkgYW5k IEpTU3RyaW5nR2V0TGVuZ3RoKCkgQVBJcyByZXNwZWN0aXZlbHkuIEFkZGVkIGEgY2hlY2sgdGhh dCAKKyAgICAgICAgSlNWYWx1ZU1ha2VGcm9tSlNPTlN0cmluZygpIHByb3Blcmx5IGhhbmRsZXMg YSBudWxsIHN0cmluZyBhcyB3ZWxsLgorCisgICAgICAgICogQVBJL3Rlc3RzL3Rlc3RhcGkuYzoK KyAgICAgICAgKG1haW4pOgorCiAyMDEyLTEwLTA5ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZA YXBwbGUuY29tPgogCiAgICAgICAgIEFmdGVyIHIxMzAzNDQsIE9wYXF1ZUpTU3RyaW5nOjppZGVu dGlmaWVyKCkgYWRkcyB3cmFwcGVkIFN0cmluZyB0byBpZGVudGlmaWVyIHRhYmxlCkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL3Rlc3RzL3Rlc3RhcGkuYwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL3Rlc3RzL3Rlc3RhcGkuYwkocmV2aXNpb24gMTMwNzYx KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS90ZXN0cy90ZXN0YXBpLmMJKHdvcmtpbmcg Y29weSkKQEAgLTExMzEsNiArMTEzMSwyMiBAQCBpbnQgbWFpbihpbnQgYXJnYywgY2hhciogYXJn dltdKQogICAgIEFTU0VSVChKU1ZhbHVlR2V0VHlwZShjb250ZXh0LCBqc0NGRW1wdHlTdHJpbmcp ID09IGtKU1R5cGVTdHJpbmcpOwogICAgIEFTU0VSVChKU1ZhbHVlR2V0VHlwZShjb250ZXh0LCBq c0NGRW1wdHlTdHJpbmdXaXRoQ2hhcmFjdGVycykgPT0ga0pTVHlwZVN0cmluZyk7CiAKKyAgICBK U1N0cmluZ1JlZiBudWxsU3RyaW5nID0gSlNTdHJpbmdDcmVhdGVXaXRoVVRGOENTdHJpbmcoMCk7 CisgICAgY29uc3QgSlNDaGFyKiBjaGFyYWN0ZXJzID0gSlNTdHJpbmdHZXRDaGFyYWN0ZXJzUHRy KG51bGxTdHJpbmcpOworICAgIGlmIChjaGFyYWN0ZXJzKSB7CisgICAgICAgIHByaW50ZigiRkFJ TDogRGlkbid0IHJldHVybiBudWxsIHdoZW4gYWNjZXNzaW5nIGNoYXJhY3RlciBwb2ludGVyIG9m IGEgbnVsbCBTdHJpbmcuXG4iKTsKKyAgICAgICAgZmFpbGVkID0gMTsKKyAgICB9IGVsc2UKKyAg ICAgICAgcHJpbnRmKCJQQVNTOiByZXR1cm5lZCBudWxsIHdoZW4gYWNjZXNzaW5nIGNoYXJhY3Rl ciBwb2ludGVyIG9mIGEgbnVsbCBTdHJpbmcuXG4iKTsKKworICAgIHNpemVfdCBsZW5ndGggPSBK U1N0cmluZ0dldExlbmd0aChudWxsU3RyaW5nKTsKKyAgICBpZiAobGVuZ3RoKSB7CisgICAgICAg IHByaW50ZigiRkFJTDogRGlkbid0IHJldHVybiAwIGxlbmd0aCBmb3IgbnVsbCBTdHJpbmcuXG4i KTsKKyAgICAgICAgZmFpbGVkID0gMTsKKyAgICB9IGVsc2UKKyAgICAgICAgcHJpbnRmKCJQQVNT OiByZXR1cm5lZCAwIGxlbmd0aCBmb3IgbnVsbCBTdHJpbmcuXG4iKTsKKyAgICBKU1N0cmluZ1Jl bGVhc2UobnVsbFN0cmluZyk7CisKICAgICBKU09iamVjdFJlZiBwcm9wZXJ0eUNhdGNoYWxscyA9 IEpTT2JqZWN0TWFrZShjb250ZXh0LCBQcm9wZXJ0eUNhdGNoYWxsc19jbGFzcyhjb250ZXh0KSwg TlVMTCk7CiAgICAgSlNTdHJpbmdSZWYgcHJvcGVydHlDYXRjaGFsbHNTdHJpbmcgPSBKU1N0cmlu Z0NyZWF0ZVdpdGhVVEY4Q1N0cmluZygiUHJvcGVydHlDYXRjaGFsbHMiKTsKICAgICBKU09iamVj dFNldFByb3BlcnR5KGNvbnRleHQsIGdsb2JhbE9iamVjdCwgcHJvcGVydHlDYXRjaGFsbHNTdHJp bmcsIHByb3BlcnR5Q2F0Y2hhbGxzLCBrSlNQcm9wZXJ0eUF0dHJpYnV0ZU5vbmUsIE5VTEwpOwpA QCAtMTIwOCw2ICsxMjI0LDE1IEBAIGludCBtYWluKGludCBhcmdjLCBjaGFyKiBhcmd2W10pCiAg ICAgfSBlbHNlCiAgICAgICAgIHByaW50ZigiUEFTUzogUmV0cmlldmVkIHByaXZhdGUgcHJvcGVy dHkuXG4iKTsKIAorICAgIEpTU3RyaW5nUmVmIG51bGxKU09OID0gSlNTdHJpbmdDcmVhdGVXaXRo VVRGOENTdHJpbmcoMCk7CisgICAgSlNWYWx1ZVJlZiBudWxsSlNPTk9iamVjdCA9IEpTVmFsdWVN YWtlRnJvbUpTT05TdHJpbmcoY29udGV4dCwgbnVsbEpTT04pOworICAgIGlmIChudWxsSlNPTk9i amVjdCkgeworICAgICAgICBwcmludGYoIkZBSUw6IERpZCBub3QgcGFyc2UgbnVsbCBTdHJpbmcg YXMgSlNPTiBjb3JyZWN0bHlcbiIpOworICAgICAgICBmYWlsZWQgPSAxOworICAgIH0gZWxzZQor ICAgICAgICBwcmludGYoIlBBU1M6IFBhcnNlZCBudWxsIFN0cmluZyBhcyBKU09OIGNvcnJlY3Rs eS5cbiIpOworICAgIEpTU3RyaW5nUmVsZWFzZShudWxsSlNPTik7CisKICAgICBKU1N0cmluZ1Jl ZiB2YWxpZEpTT04gPSBKU1N0cmluZ0NyZWF0ZVdpdGhVVEY4Q1N0cmluZygie1wiYVByb3BlcnR5 XCI6dHJ1ZX0iKTsKICAgICBKU1ZhbHVlUmVmIGpzb25PYmplY3QgPSBKU1ZhbHVlTWFrZUZyb21K U09OU3RyaW5nKGNvbnRleHQsIHZhbGlkSlNPTik7CiAgICAgSlNTdHJpbmdSZWxlYXNlKHZhbGlk SlNPTik7Cg==