98802 2012-10-09 11:28:46 -0700 Use computeLogical* methods instead of updateLogical* methods in RenderImage 2012-10-09 13:38:52 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tony tony eric ojan webkit.review.bot oldest_to_newest 737974 0 tony 2012-10-09 11:28:46 -0700 Use computeLogical* methods instead of updateLogical* methods in RenderImage 737980 1 167798 tony 2012-10-09 11:31:40 -0700 Created attachment 167798 Patch 738139 2 tony 2012-10-09 13:33:50 -0700 This is a pretty small code cleanup. 738141 3 167798 eric 2012-10-09 13:34:58 -0700 Comment on attachment 167798 Patch OK. 738147 4 167798 webkit.review.bot 2012-10-09 13:38:49 -0700 Comment on attachment 167798 Patch Clearing flags on attachment: 167798 Committed r130806: <http://trac.webkit.org/changeset/130806> 738148 5 webkit.review.bot 2012-10-09 13:38:52 -0700 All reviewed patches have been landed. Closing bug. 167798 2012-10-09 11:31:40 -0700 2012-10-09 13:38:49 -0700 Patch bug-98802-20121009113041.patch text/plain 2463 tony U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwNzc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjQxMjM2OTljNGMxMDg0 NDljYjVlZDM2Yjk2MWU0MjI0ZDhhZTcxMi4uNzg2MGYyNDYzNWZlYjgwZTQ3N2M0ZmI0YzVlNDg1 NWZkNGEzOTUyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTEwLTA5ICBUb255 IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgVXNlIGNvbXB1dGVMb2dpY2Fs KiBtZXRob2RzIGluc3RlYWQgb2YgdXBkYXRlTG9naWNhbCogbWV0aG9kcyBpbiBSZW5kZXJJbWFn ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTg4MDIK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSB3ZXJl IHN0b3JpbmcgdGhlIG9sZCB2YWx1ZXMgb2Ygd2lkdGgvaGVpZ2h0LCBjYWxsaW5nIHVwZGF0ZUxv Z2ljYWx7V2lkdGgsSGVpZ2h0fSwgdGhlbiByZXN0b3JpbmcKKyAgICAgICAgdGhlIG9sZCB2YWx1 ZXMuICBJbnN0ZWFkLCB1c2UgdGhlIGNvbXB1dGVMb2dpY2Fse1dpZHRoLEhlaWdodH0gbWV0aG9k cyBzbyB3ZSBkb24ndCBoYXZlIHRvIG92ZXJ3cml0ZQorICAgICAgICB0aGUgY3VycmVudCB2YWx1 ZXMuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCB0aGlzIGlzIGp1c3QgYSByZWZhY3RvcmluZy4K KworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJJbWFnZS5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpSZW5kZXJJbWFnZTo6aW1hZ2VEaW1lbnNpb25zQ2hhbmdlZCk6CisKIDIwMTItMTAtMDkgIFBy YXZpbiBEICA8cHJhdmluZC4yazRAZ21haWwuY29tPgogCiAgICAgICAgIG1heC13aWR0aCBwcm9w ZXJ0eSBpcyBkb2VzIG5vdCBvdmVycmlkaW5nIHRoZSB3aWR0aCBwcm9wZXJ0aWVzIGZvciBjc3Mg dGFibGVzKGRpc3BsYXk6dGFibGUpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVySW1hZ2UuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckltYWdl LmNwcAppbmRleCBkYTg3YTUyMGY3YzkzMjUxNzI1NTAxYTU5YmIzMzkyNmNmNTY4NDQ4Li5lOTRm YTNlYmRhNDRiYTIzNzRkNGNhNDVlNzUxZDhjNWExNTRlMmE5IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySW1hZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJJbWFnZS5jcHAKQEAgLTIxOSwyMiArMjE5LDE5IEBAIHZvaWQgUmVuZGVy SW1hZ2U6OmltYWdlRGltZW5zaW9uc0NoYW5nZWQoYm9vbCBpbWFnZVNpemVDaGFuZ2VkLCBjb25z dCBJbnRSZWN0KiByCiAKICAgICBib29sIHNob3VsZFJlcGFpbnQgPSB0cnVlOwogICAgIGlmIChp bnRyaW5zaWNTaXplQ2hhbmdlZCkgewotICAgICAgICAvLyBsZXRzIHNlZSBpZiB3ZSBuZWVkIHRv IHJlbGF5b3V0IGF0IGFsbC4uCi0gICAgICAgIExheW91dFVuaXQgb2xkd2lkdGggPSB3aWR0aCgp OwotICAgICAgICBMYXlvdXRVbml0IG9sZGhlaWdodCA9IGhlaWdodCgpOwogICAgICAgICBpZiAo IXByZWZlcnJlZExvZ2ljYWxXaWR0aHNEaXJ0eSgpKQogICAgICAgICAgICAgc2V0UHJlZmVycmVk TG9naWNhbFdpZHRoc0RpcnR5KHRydWUpOwotICAgICAgICB1cGRhdGVMb2dpY2FsV2lkdGgoKTsK LSAgICAgICAgdXBkYXRlTG9naWNhbEhlaWdodCgpOworICAgICAgICBMb2dpY2FsRXh0ZW50Q29t cHV0ZWRWYWx1ZXMgY29tcHV0ZWRWYWx1ZXM7CisgICAgICAgIGNvbXB1dGVMb2dpY2FsV2lkdGhJ blJlZ2lvbihjb21wdXRlZFZhbHVlcyk7CisgICAgICAgIExheW91dFVuaXQgbmV3V2lkdGggPSBj b21wdXRlZFZhbHVlcy5tX2V4dGVudDsKKyAgICAgICAgY29tcHV0ZUxvZ2ljYWxIZWlnaHQoaGVp Z2h0KCksIDAsIGNvbXB1dGVkVmFsdWVzKTsKKyAgICAgICAgTGF5b3V0VW5pdCBuZXdIZWlnaHQg PSBjb21wdXRlZFZhbHVlcy5tX2V4dGVudDsKIAotICAgICAgICBpZiAoaW1hZ2VTaXplQ2hhbmdl ZCB8fCB3aWR0aCgpICE9IG9sZHdpZHRoIHx8IGhlaWdodCgpICE9IG9sZGhlaWdodCkgeworICAg ICAgICBpZiAoaW1hZ2VTaXplQ2hhbmdlZCB8fCB3aWR0aCgpICE9IG5ld1dpZHRoIHx8IGhlaWdo dCgpICE9IG5ld0hlaWdodCkgewogICAgICAgICAgICAgc2hvdWxkUmVwYWludCA9IGZhbHNlOwog ICAgICAgICAgICAgaWYgKCFzZWxmTmVlZHNMYXlvdXQoKSkKICAgICAgICAgICAgICAgICBzZXRO ZWVkc0xheW91dCh0cnVlKTsKICAgICAgICAgfQotCi0gICAgICAgIHNldFdpZHRoKG9sZHdpZHRo KTsKLSAgICAgICAgc2V0SGVpZ2h0KG9sZGhlaWdodCk7CiAgICAgfQogCiAgICAgaWYgKHNob3Vs ZFJlcGFpbnQpIHsK