98801 2012-10-09 11:27:10 -0700 After r130344, OpaqueJSString::string() shouldn't directly return the wrapped String 2012-10-10 11:07:57 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 98300 1 msaboff msaboff darin oldest_to_newest 737973 0 msaboff 2012-10-09 11:27:10 -0700 After r130344, OpaqueJSString has an internal String member that it returns directly via OpaqueJSString::string(). If this string should not be turned into an identifier, as OpaqueJSString is meant to be thread safe. 738075 1 167819 msaboff 2012-10-09 12:30:18 -0700 Created attachment 167819 Patch 738377 2 167819 ggaren 2012-10-09 17:54:06 -0700 Comment on attachment 167819 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167819&action=review r=me > Source/JavaScriptCore/API/OpaqueJSString.cpp:50 > + // Return a copy of the wrapped string, because the caller may make it an Identifier. > + if (m_string.is8Bit()) > + return String(m_string.characters8(), m_string.length()); > + return String(m_string.characters16(), m_string.length()); This could be String::isolatedCopy() instead. 739138 3 msaboff 2012-10-10 11:07:57 -0700 Committed r130931: <http://trac.webkit.org/changeset/130931> 167819 2012-10-09 12:30:18 -0700 2012-10-09 17:54:06 -0700 Patch 98801.patch text/plain 2291 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTMwNzg0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDEyLTEwLTA5ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIEFmdGVyIHIxMzAzNDQsIE9wYXF1ZUpTU3RyaW5nOjpzdHJpbmcoKSBzaG91bGRuJ3QgZGly ZWN0bHkgcmV0dXJuIHRoZSB3cmFwcGVkIFN0cmluZworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTg4MDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBSZXR1cm4gYSBjb3B5IG9mIHRoZSB3cmFwcGVkIFN0cmlu ZyBzbyB0aGF0IHRoZSB3cmFwcGVkIHN0cmluZyBjYW5ub3QgYmUgdHVybmVkIGludG8gCisgICAg ICAgIGFuIElkZW50aWZpZXIuCisKKyAgICAgICAgKiBBUEkvT3BhcXVlSlNTdHJpbmcuY3BwOgor ICAgICAgICAoT3BhcXVlSlNTdHJpbmc6OnN0cmluZyk6CisgICAgICAgICogQVBJL09wYXF1ZUpT U3RyaW5nLmg6CisgICAgICAgIChPcGFxdWVKU1N0cmluZyk6CisKIDIwMTItMTAtMDkgIE1pY2hh ZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CiAKICAgICAgICAgQWZ0ZXIgcjEzMDM0NCwg T3BhcXVlSlNTdHJpbmc6OmlkZW50aWZpZXIoKSBhZGRzIHdyYXBwZWQgU3RyaW5nIHRvIGlkZW50 aWZpZXIgdGFibGUKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvT3BhcXVlSlNTdHJp bmcuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvT3BhcXVlSlNT dHJpbmcuY3BwCShyZXZpc2lvbiAxMzA3NjEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJ L09wYXF1ZUpTU3RyaW5nLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzksNiArMzksMTcgQEAgUGFz c1JlZlB0cjxPcGFxdWVKU1N0cmluZz4gT3BhcXVlSlNTdHJpbgogICAgIHJldHVybiAwOwogfQog CitTdHJpbmcgT3BhcXVlSlNTdHJpbmc6OnN0cmluZygpIGNvbnN0Cit7CisgICAgaWYgKCF0aGlz IHx8ICFtX3N0cmluZy5sZW5ndGgoKSkKKyAgICAgICAgcmV0dXJuIFN0cmluZygpOworCisgICAg Ly8gUmV0dXJuIGEgY29weSBvZiB0aGUgd3JhcHBlZCBzdHJpbmcsIGJlY2F1c2UgdGhlIGNhbGxl ciBtYXkgbWFrZSBpdCBhbiBJZGVudGlmaWVyLgorICAgIGlmIChtX3N0cmluZy5pczhCaXQoKSkK KyAgICAgICAgcmV0dXJuIFN0cmluZyhtX3N0cmluZy5jaGFyYWN0ZXJzOCgpLCBtX3N0cmluZy5s ZW5ndGgoKSk7CisgICAgcmV0dXJuIFN0cmluZyhtX3N0cmluZy5jaGFyYWN0ZXJzMTYoKSwgbV9z dHJpbmcubGVuZ3RoKCkpOworfQorCiBJZGVudGlmaWVyIE9wYXF1ZUpTU3RyaW5nOjppZGVudGlm aWVyKEpTR2xvYmFsRGF0YSogZ2xvYmFsRGF0YSkgY29uc3QKIHsKICAgICBpZiAoIXRoaXMgfHwg IW1fc3RyaW5nLmxlbmd0aCgpKQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9PcGFx dWVKU1N0cmluZy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvT3Bh cXVlSlNTdHJpbmcuaAkocmV2aXNpb24gMTMwNzYxKQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L0FQSS9PcGFxdWVKU1N0cmluZy5oCSh3b3JraW5nIGNvcHkpCkBAIC01MSw3ICs1MSw3IEBAIHN0 cnVjdCBPcGFxdWVKU1N0cmluZyA6IHB1YmxpYyBUaHJlYWRTYWYKICAgICBjb25zdCBVQ2hhciog Y2hhcmFjdGVycygpIHsgcmV0dXJuICEhdGhpcyA/IG1fc3RyaW5nLmNoYXJhY3RlcnMoKSA6IDA7 IH0KICAgICB1bnNpZ25lZCBsZW5ndGgoKSB7IHJldHVybiAhIXRoaXMgPyBtX3N0cmluZy5sZW5n dGgoKSA6IDA7IH0KIAotICAgIFN0cmluZyBzdHJpbmcoKSBjb25zdCB7IHJldHVybiAhIXRoaXMg PyBtX3N0cmluZyA6IFN0cmluZygpOyB9OworICAgIFN0cmluZyBzdHJpbmcoKSBjb25zdDsKICAg ICBKU0M6OklkZW50aWZpZXIgaWRlbnRpZmllcihKU0M6OkpTR2xvYmFsRGF0YSopIGNvbnN0Owog CiBwcml2YXRlOgo=