9880 2006-07-12 11:45:35 -0700 Memory leaks running DOM-Hanoi 2006-07-13 08:49:04 -0700 1 1 1 Unclassified WebKit WebCore Misc. 420+ Mac OS X 10.4 RESOLVED FIXED http://metasploit.com/users/hdm/tools/domhanoi/domhanoi.html P2 Normal --- 1 ap ap darin ddkilzer oldest_to_newest 49476 0 ap 2006-07-12 11:45:35 -0700 Technically, these are not leaks, but the effect is similar :) When running certain non-stop browser tests, such as DOM-Hanoi (see bug URL), Safari memory usage grows fast, because Obj-C autoreleased objects do not get a chance to be collected. I suspect they may fill the address space before the test actually finishes, but I was not patient enough to stand the paging. All such allocations are made inside FrameMac::setStatusBarText(), so I gave this method an autorelease pool of its own. 49477 1 9409 ap 2006-07-12 11:47:22 -0700 Created attachment 9409 proposed patch 49501 2 9409 darin 2006-07-12 14:25:31 -0700 Comment on attachment 9409 proposed patch Looks good. r=me But are there any other calls besides "set status bar text" that need an autorelease pool for the same reason? 49558 3 ap 2006-07-12 21:17:21 -0700 (In reply to comment #2) > But are there any other calls besides "set status bar text" that need an > autorelease pool for the same reason? This patch fixes all DOM-Hanoi "leaks". Perhaps, other tests will uncover more? 49560 4 ddkilzer 2006-07-12 21:23:17 -0700 Darin, should this patch be committed now, or should it wait until after the stabilization period? 49566 5 darin 2006-07-12 21:43:40 -0700 (In reply to comment #4) > Darin, should this patch be committed now, or should it wait until after the > stabilization period? I think it's good to land this now. 49665 6 ap 2006-07-13 08:49:04 -0700 Committed revision 15405. 9409 2006-07-12 11:47:22 -0700 2006-07-12 14:25:31 -0700 proposed patch 9880r1_patch.txt text/plain 766 ap SW5kZXg6IFdlYkNvcmUvYnJpZGdlL21hYy9GcmFtZU1hYy5tbQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJD b3JlL2JyaWRnZS9tYWMvRnJhbWVNYWMubW0JKHJldmlzaW9uIDE1MzkzKQorKysgV2ViQ29yZS9i cmlkZ2UvbWFjL0ZyYW1lTWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC02MTAsOSArNjEwLDE1IEBA IHZvaWQgRnJhbWVNYWM6OnNldFN0YXR1c0JhclRleHQoY29uc3QgU3QKICAgICBTdHJpbmcgdGV4 dCA9IHN0YXR1czsKICAgICB0ZXh0LnJlcGxhY2UoJ1xcJywgYmFja3NsYXNoQXNDdXJyZW5jeVN5 bWJvbCgpKTsKICAgICAKKyAgICAvLyBXZSB3YW50IHRoZSB0ZW1wb3JhcmllcyBhbGxvY2F0ZWQg aGVyZSB0byBiZSByZWxlYXNlZCBldmVuIGJlZm9yZSByZXR1cm5pbmcgdG8gdGhlIAorICAgIC8v IGV2ZW50IGxvb3A7IHNlZSA8aHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVn LmNnaT9pZD05ODgwPi4KKyAgICBOU0F1dG9yZWxlYXNlUG9vbCogbG9jYWxQb29sID0gW1tOU0F1 dG9yZWxlYXNlUG9vbCBhbGxvY10gaW5pdF07CisKICAgICBCRUdJTl9CTE9DS19PQkpDX0VYQ0VQ VElPTlM7CiAgICAgW19icmlkZ2Ugc2V0U3RhdHVzVGV4dDp0ZXh0XTsKICAgICBFTkRfQkxPQ0tf T0JKQ19FWENFUFRJT05TOworCisgICAgW2xvY2FsUG9vbCByZWxlYXNlXTsKIH0KIAogdm9pZCBG cmFtZU1hYzo6c2NoZWR1bGVDbG9zZSgpCg==