<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>98790</bug_id>
          
          <creation_ts>2012-10-09 10:13:14 -0700</creation_ts>
          <short_desc>[EFL][WK2] Add APIs to get/set the DNS prefetching</short_desc>
          <delta_ts>2012-10-10 05:13:05 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit EFL</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Jinwoo Song">jinwoo7.song</reporter>
          <assigned_to name="Jinwoo Song">jinwoo7.song</assigned_to>
          <cc>cdumez</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>lucas.de.marchi</cc>
    
    <cc>rakuco</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>737905</commentid>
    <comment_count>0</comment_count>
    <who name="Jinwoo Song">jinwoo7.song</who>
    <bug_when>2012-10-09 10:13:14 -0700</bug_when>
    <thetext>Add ewk_settings_enable_DNS_prefetching_get/set APIs to WebKit2/Efl.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>737921</commentid>
    <comment_count>1</comment_count>
      <attachid>167778</attachid>
    <who name="Jinwoo Song">jinwoo7.song</who>
    <bug_when>2012-10-09 10:37:09 -0700</bug_when>
    <thetext>Created attachment 167778
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>738489</commentid>
    <comment_count>2</comment_count>
      <attachid>167778</attachid>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2012-10-09 21:12:30 -0700</bug_when>
    <thetext>Comment on attachment 167778
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167778&amp;action=review

LGTM.

&gt; Source/WebKit2/ChangeLog:8
&gt; +        Added setting APIs for DNS prefetching and a unit test.

Added -&gt; Add.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>738534</commentid>
    <comment_count>3</comment_count>
      <attachid>167778</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2012-10-09 21:57:35 -0700</bug_when>
    <thetext>Comment on attachment 167778
Patch

Sorry but this is missing unit tests. We should not land new APIs without unit tests.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>738535</commentid>
    <comment_count>4</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2012-10-09 21:58:28 -0700</bug_when>
    <thetext>(In reply to comment #3)
&gt; (From update of attachment 167778 [details])
&gt; Sorry but this is missing unit tests. We should not land new APIs without unit tests.

arg... never mind me. There are unit tests :)
Go ahead then.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>738542</commentid>
    <comment_count>5</comment_count>
      <attachid>167778</attachid>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2012-10-09 22:06:31 -0700</bug_when>
    <thetext>Comment on attachment 167778
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167778&amp;action=review

&gt; Source/WebKit2/UIProcess/API/efl/ewk_settings.h:206
&gt; + * @param settings settings object to get DNS prefetching.

We don&apos;t use &apos;.&apos; at @param.

&gt; Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp:154
&gt; +    ASSERT_TRUE(ewk_settings_DNS_prefetching_enabled_set(settings, EINA_TRUE));

We decided to use standard boolean in test case.

&gt; Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp:157
&gt; +    ASSERT_TRUE(ewk_settings_DNS_prefetching_enabled_set(settings, EINA_FALSE));

ditto.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>738772</commentid>
    <comment_count>6</comment_count>
    <who name="Jinwoo Song">jinwoo7.song</who>
    <bug_when>2012-10-10 03:01:45 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; (From update of attachment 167778 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=167778&amp;action=review
&gt; 
&gt; LGTM.
&gt; 
&gt; &gt; Source/WebKit2/ChangeLog:8
&gt; &gt; +        Added setting APIs for DNS prefetching and a unit test.
&gt; 
&gt; Added -&gt; Add.

Fixed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>738773</commentid>
    <comment_count>7</comment_count>
    <who name="Jinwoo Song">jinwoo7.song</who>
    <bug_when>2012-10-10 03:02:02 -0700</bug_when>
    <thetext>(In reply to comment #5)
&gt; (From update of attachment 167778 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=167778&amp;action=review
&gt; 
&gt; &gt; Source/WebKit2/UIProcess/API/efl/ewk_settings.h:206
&gt; &gt; + * @param settings settings object to get DNS prefetching.
&gt; 
&gt; We don&apos;t use &apos;.&apos; at @param.
&gt; 
&gt; &gt; Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp:154
&gt; &gt; +    ASSERT_TRUE(ewk_settings_DNS_prefetching_enabled_set(settings, EINA_TRUE));
&gt; 
&gt; We decided to use standard boolean in test case.
&gt; 
&gt; &gt; Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp:157
&gt; &gt; +    ASSERT_TRUE(ewk_settings_DNS_prefetching_enabled_set(settings, EINA_FALSE));
&gt; 
&gt; ditto.

Fixed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>738775</commentid>
    <comment_count>8</comment_count>
      <attachid>167965</attachid>
    <who name="Jinwoo Song">jinwoo7.song</who>
    <bug_when>2012-10-10 03:04:13 -0700</bug_when>
    <thetext>Created attachment 167965
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>738800</commentid>
    <comment_count>9</comment_count>
      <attachid>167965</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-10-10 03:41:22 -0700</bug_when>
    <thetext>Comment on attachment 167965
Patch

Clearing flags on attachment: 167965

Committed r130882: &lt;http://trac.webkit.org/changeset/130882&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>738801</commentid>
    <comment_count>10</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-10-10 03:41:26 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>738851</commentid>
    <comment_count>11</comment_count>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2012-10-10 05:09:56 -0700</bug_when>
    <thetext>Sorry for chiming in late. Isn&apos;t it better to use `dns&apos; instead of `DNS&apos;? We normally don&apos;t uppercase abbreviations in our APIs.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>738852</commentid>
    <comment_count>12</comment_count>
    <who name="Jinwoo Song">jinwoo7.song</who>
    <bug_when>2012-10-10 05:13:05 -0700</bug_when>
    <thetext>(In reply to comment #11)
&gt; Sorry for chiming in late. Isn&apos;t it better to use `dns&apos; instead of `DNS&apos;? We normally don&apos;t uppercase abbreviations in our APIs.

I didn&apos;t catch that. Then I&apos;ll change it in https://bugs.webkit.org/show_bug.cgi?id=98793. Thanks. :)</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>167778</attachid>
            <date>2012-10-09 10:37:09 -0700</date>
            <delta_ts>2012-10-10 03:04:07 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-98790-20121010023616.patch</filename>
            <type>text/plain</type>
            <size>4545</size>
            <attacher name="Jinwoo Song">jinwoo7.song</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwNjk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYWE5NjU1ODU4ZGY3NmYx
NmE2YWNiOTYxYmUwMDRiN2UzYmYzM2YzNy4uZDk1YTBhNDg3NjkxMTJjYzYyYmIyZTEyMTgxYjQ1
NTIyYzI0N2MzOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTEwLTA5ICBKaW53
b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXVtXSzJd
IEFkZCBBUElzIHRvIGdldC9zZXQgdGhlIEROUyBwcmVmZXRjaGluZworICAgICAgICBodHRwczov
L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTg3OTAKKworICAgICAgICBSZXZpZXdl
ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCBzZXR0aW5nIEFQSXMgZm9yIERO
UyBwcmVmZXRjaGluZyBhbmQgYSB1bml0IHRlc3QuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJ
L2VmbC9ld2tfc2V0dGluZ3MuY3BwOgorICAgICAgICAoZXdrX3NldHRpbmdzX0ROU19wcmVmZXRj
aGluZ19lbmFibGVkX3NldCk6CisgICAgICAgIChld2tfc2V0dGluZ3NfRE5TX3ByZWZldGNoaW5n
X2VuYWJsZWRfZ2V0KToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9ld2tfc2V0dGluZ3Mu
aDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3azJfc2V0dGluZ3Mu
Y3BwOgorICAgICAgICAoVEVTVF9GKToKKwogMjAxMi0xMC0wOCAgU2ltb24gRnJhc2VyICA8c2lt
b24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBUcnkgdG8gZml4IFdpbmRvd3MgYnVpbGQg
YnkgZXhwb3J0aW5nIEZyYW1lOjpsYXllclRyZWVBc1RleHQoKS4KZGlmZiAtLWdpdCBhL1NvdXJj
ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19zZXR0aW5ncy5jcHAgYi9Tb3VyY2UvV2Vi
S2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfc2V0dGluZ3MuY3BwCmluZGV4IGQyNjAzNzdjNmI5
ZDljNmUyNjAzYjY3ZTkyOTYyZTY4NDQwMTYwYjAuLjhkMzViNDljYzI1NWNlZGQ5NTk1NDNiNWEw
YjFiZTdkYjA5ODQzZDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv
ZWZsL2V3a19zZXR0aW5ncy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9l
ZmwvZXdrX3NldHRpbmdzLmNwcApAQCAtMTMyLDMgKzEzMiwxOSBAQCBFaW5hX0Jvb2wgZXdrX3Nl
dHRpbmdzX2VuYWJsZV9mcmFtZV9mbGF0dGVuaW5nX2dldChjb25zdCBFd2tfU2V0dGluZ3MqIHNl
dHRpbmdzKQogCiAgICAgcmV0dXJuIFdLUHJlZmVyZW5jZXNHZXRGcmFtZUZsYXR0ZW5pbmdFbmFi
bGVkKHNldHRpbmdzLT5wcmVmZXJlbmNlcy5nZXQoKSk7CiB9CisKK0VpbmFfQm9vbCBld2tfc2V0
dGluZ3NfRE5TX3ByZWZldGNoaW5nX2VuYWJsZWRfc2V0KEV3a19TZXR0aW5ncyogc2V0dGluZ3Ms
IEVpbmFfQm9vbCBlbmFibGUpCit7CisgICAgRUlOQV9TQUZFVFlfT05fTlVMTF9SRVRVUk5fVkFM
KHNldHRpbmdzLCBmYWxzZSk7CisKKyAgICBXS1ByZWZlcmVuY2VzU2V0RE5TUHJlZmV0Y2hpbmdF
bmFibGVkKHNldHRpbmdzLT5wcmVmZXJlbmNlcy5nZXQoKSwgZW5hYmxlKTsKKworICAgIHJldHVy
biB0cnVlOworfQorCitFaW5hX0Jvb2wgZXdrX3NldHRpbmdzX0ROU19wcmVmZXRjaGluZ19lbmFi
bGVkX2dldChjb25zdCBFd2tfU2V0dGluZ3MqIHNldHRpbmdzKQoreworICAgIEVJTkFfU0FGRVRZ
X09OX05VTExfUkVUVVJOX1ZBTChzZXR0aW5ncywgZmFsc2UpOworCisgICAgcmV0dXJuIFdLUHJl
ZmVyZW5jZXNHZXRETlNQcmVmZXRjaGluZ0VuYWJsZWQoc2V0dGluZ3MtPnByZWZlcmVuY2VzLmdl
dCgpKTsKK30KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3
a19zZXR0aW5ncy5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3NldHRp
bmdzLmgKaW5kZXggODY2NmZhMWI2ZTZiYTYyZjQxZTU5NTllODkyY2VhMzVhMzc3OGU0MS4uNjUy
MzY0YzM1ZWIxN2U2YzM3MTA1MzRjMmQ2YzE4ZmYyZDgwOTI4MyAxMDA2NDQKLS0tIGEvU291cmNl
L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3NldHRpbmdzLmgKKysrIGIvU291cmNlL1dl
YktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3NldHRpbmdzLmgKQEAgLTE4Myw2ICsxODMsMzMg
QEAgRUFQSSBFaW5hX0Jvb2wgZXdrX3NldHRpbmdzX2VuYWJsZV9mcmFtZV9mbGF0dGVuaW5nX3Nl
dChFd2tfU2V0dGluZ3MgKnNldHRpbmdzLAogICovCiBFQVBJIEVpbmFfQm9vbCBld2tfc2V0dGlu
Z3NfZW5hYmxlX2ZyYW1lX2ZsYXR0ZW5pbmdfZ2V0KGNvbnN0IEV3a19TZXR0aW5ncyAqc2V0dGlu
Z3MpOwogCisvKioKKyAqIEVuYWJsZXMvZGlzYWJsZXMgRE5TIHByZWZldGNoaW5nLgorICoKKyAq
IEJ5IGRlZmF1bHQsIEROUyBwcmVmZXRjaGluZyBpcyBkaXNhYmxlZC4KKyAqCisgKiBAcGFyYW0g
c2V0dGluZ3Mgc2V0dGluZ3Mgb2JqZWN0IHRvIHNldCBETlMgcHJlZmV0Y2hpbmcKKyAqIEBwYXJh
bSBlbmFibGUgQGMgRUlOQV9UUlVFIHRvIGVuYWJsZSBETlMgcHJlZmV0Y2hpbmcgb3IKKyAqICAg
ICAgICAgICAgICAgQGMgRUlOQV9GQUxTRSB0byBkaXNhYmxlCisgKgorICogQHJldHVybiBAYyBF
SU5BX1RSVUUgb24gc3VjY2VzcyBvciBAYyBFSU5BX0ZBTFNFIG9uIGZhaWx1cmUKKyAqCisgKiBA
c2VlIGV3a19zZXR0aW5nc19ETlNfcHJlZmV0Y2hpbmdfZW5hYmxlZF9nZXQoKQorICovCitFQVBJ
IEVpbmFfQm9vbCBld2tfc2V0dGluZ3NfRE5TX3ByZWZldGNoaW5nX2VuYWJsZWRfc2V0KEV3a19T
ZXR0aW5ncyAqc2V0dGluZ3MsIEVpbmFfQm9vbCBlbmFibGUpOworCisvKioKKyAqIFJldHVybnMg
d2hldGhlciBETlMgcHJlZmV0Y2hpbmcgaXMgZW5hYmxlZCBvciBub3QuCisgKgorICogRE5TIHBy
ZWZldGNoaW5nIGlzIGFuIGF0dGVtcHQgdG8gcmVzb2x2ZSBkb21haW4gbmFtZXMgYmVmb3JlIGEg
dXNlciB0cmllcyB0byBmb2xsb3cgYSBsaW5rLgorICoKKyAqIEBwYXJhbSBzZXR0aW5ncyBzZXR0
aW5ncyBvYmplY3QgdG8gZ2V0IEROUyBwcmVmZXRjaGluZy4KKyAqCisgKiBAcmV0dXJuIEBjIEVJ
TkFfVFJVRSBpZiBETlMgcHJlZmV0Y2hpbmcgaXMgZW5hYmxlZAorICogICAgICAgICBAYyBFSU5B
X0ZBTFNFIGlmIG5vdCBvciBvbiBmYWlsdXJlCisgKi8KK0VBUEkgRWluYV9Cb29sIGV3a19zZXR0
aW5nc19ETlNfcHJlZmV0Y2hpbmdfZW5hYmxlZF9nZXQoY29uc3QgRXdrX1NldHRpbmdzICpzZXR0
aW5ncyk7CisKICNpZmRlZiBfX2NwbHVzcGx1cwogfQogI2VuZGlmCmRpZmYgLS1naXQgYS9Tb3Vy
Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3azJfc2V0dGluZ3MuY3Bw
IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX3NldHRp
bmdzLmNwcAppbmRleCA1NjJmNzc2MjZiZjZhMjQzZDcyNGYyZTAxZTcxNTJjODY0MWU4OGMwLi44
NGVjMjViOGQ4ZjU0NGU5ZjMzNzU2NGJmNDRiZmU4NzY3NDZmNzNlIDEwMDY0NAotLS0gYS9Tb3Vy
Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3azJfc2V0dGluZ3MuY3Bw
CisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL3Rlc3RfZXdrMl9z
ZXR0aW5ncy5jcHAKQEAgLTE0NCwzICsxNDQsMTYgQEAgVEVTVF9GKEVXSzJVbml0VGVzdEJhc2Us
IGV3a19zZXR0aW5nc19lbmFibGVfZnJhbWVfZmxhdHRlbmluZ19zZXQpCiAgICAgd2FpdFVudGls
VGl0bGVDaGFuZ2VkVG8oIjIwMCIpOyAvLyB3aWR0aCBvZiBpZnJhbWUgdGFnLgogICAgIEFTU0VS
VF9TVFJFUSgiMjAwIiwgZXdrX3ZpZXdfdGl0bGVfZ2V0KHdlYlZpZXcoKSkpOwogfQorCitURVNU
X0YoRVdLMlVuaXRUZXN0QmFzZSwgZXdrX3NldHRpbmdzX0ROU19wcmVmZXRjaGluZ19lbmFibGVk
KQoreworICAgIEV3a19TZXR0aW5ncyogc2V0dGluZ3MgPSBld2tfdmlld19zZXR0aW5nc19nZXQo
d2ViVmlldygpKTsKKworICAgIC8vIEROUyBwcmVmZWNoaW5nIGlzIGRpc2FibGVkIGJ5IGRlZmF1
bHQuCisgICAgQVNTRVJUX0ZBTFNFKGV3a19zZXR0aW5nc19ETlNfcHJlZmV0Y2hpbmdfZW5hYmxl
ZF9nZXQoc2V0dGluZ3MpKTsKKyAgICBBU1NFUlRfVFJVRShld2tfc2V0dGluZ3NfRE5TX3ByZWZl
dGNoaW5nX2VuYWJsZWRfc2V0KHNldHRpbmdzLCBFSU5BX1RSVUUpKTsKKyAgICBBU1NFUlRfVFJV
RShld2tfc2V0dGluZ3NfRE5TX3ByZWZldGNoaW5nX2VuYWJsZWRfZ2V0KHNldHRpbmdzKSk7CisK
KyAgICBBU1NFUlRfVFJVRShld2tfc2V0dGluZ3NfRE5TX3ByZWZldGNoaW5nX2VuYWJsZWRfc2V0
KHNldHRpbmdzLCBFSU5BX0ZBTFNFKSk7CisgICAgQVNTRVJUX0ZBTFNFKGV3a19zZXR0aW5nc19E
TlNfcHJlZmV0Y2hpbmdfZW5hYmxlZF9nZXQoc2V0dGluZ3MpKTsKK30K
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>167965</attachid>
            <date>2012-10-10 03:04:13 -0700</date>
            <delta_ts>2012-10-10 03:41:22 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-98790-20121010190311.patch</filename>
            <type>text/plain</type>
            <size>4527</size>
            <attacher name="Jinwoo Song">jinwoo7.song</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwODUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNmVmOThmMzVhZTFhMjY1
M2Y2MTIzMTc0OWY4ZGRhODc3MzA0MWQ3MC4uNDQ0NWYzYjc0ZjVhNTFiMGFhNjVmMWQ4ZTQyM2E1
MWYwYjE2ZDgzNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTEwLTEwICBKaW53
b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXVtXSzJd
IEFkZCBBUElzIHRvIGdldC9zZXQgdGhlIEROUyBwcmVmZXRjaGluZworICAgICAgICBodHRwczov
L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTg3OTAKKworICAgICAgICBSZXZpZXdl
ZCBieSBMYXN6bG8gR29tYm9zLgorCisgICAgICAgIEFkZCBzZXR0aW5nIEFQSXMgZm9yIEROUyBw
cmVmZXRjaGluZyBhbmQgYSB1bml0IHRlc3QuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2Vm
bC9ld2tfc2V0dGluZ3MuY3BwOgorICAgICAgICAoZXdrX3NldHRpbmdzX0ROU19wcmVmZXRjaGlu
Z19lbmFibGVkX3NldCk6CisgICAgICAgIChld2tfc2V0dGluZ3NfRE5TX3ByZWZldGNoaW5nX2Vu
YWJsZWRfZ2V0KToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9ld2tfc2V0dGluZ3MuaDoK
KyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3azJfc2V0dGluZ3MuY3Bw
OgorICAgICAgICAoVEVTVF9GKToKKwogMjAxMi0xMC0wOSAgQnl1bmd3b28gTGVlICA8Ync4MC5s
ZWVAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VGTF1bV0syXSBDaGFuZ2UgcGFyYW1ldGVyIGFu
ZCByZXR1cm4gdHlwZSBvZiBsb2FkVXJsU3luYygpLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp
dDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3NldHRpbmdzLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJ
UHJvY2Vzcy9BUEkvZWZsL2V3a19zZXR0aW5ncy5jcHAKaW5kZXggZDI2MDM3N2M2YjlkOWM2ZTI2
MDNiNjdlOTI5NjJlNjg0NDAxNjBiMC4uOGQzNWI0OWNjMjU1Y2VkZDk1OTU0M2I1YTBiMWJlN2Ri
MDk4NDNkOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdr
X3NldHRpbmdzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tf
c2V0dGluZ3MuY3BwCkBAIC0xMzIsMyArMTMyLDE5IEBAIEVpbmFfQm9vbCBld2tfc2V0dGluZ3Nf
ZW5hYmxlX2ZyYW1lX2ZsYXR0ZW5pbmdfZ2V0KGNvbnN0IEV3a19TZXR0aW5ncyogc2V0dGluZ3Mp
CiAKICAgICByZXR1cm4gV0tQcmVmZXJlbmNlc0dldEZyYW1lRmxhdHRlbmluZ0VuYWJsZWQoc2V0
dGluZ3MtPnByZWZlcmVuY2VzLmdldCgpKTsKIH0KKworRWluYV9Cb29sIGV3a19zZXR0aW5nc19E
TlNfcHJlZmV0Y2hpbmdfZW5hYmxlZF9zZXQoRXdrX1NldHRpbmdzKiBzZXR0aW5ncywgRWluYV9C
b29sIGVuYWJsZSkKK3sKKyAgICBFSU5BX1NBRkVUWV9PTl9OVUxMX1JFVFVSTl9WQUwoc2V0dGlu
Z3MsIGZhbHNlKTsKKworICAgIFdLUHJlZmVyZW5jZXNTZXRETlNQcmVmZXRjaGluZ0VuYWJsZWQo
c2V0dGluZ3MtPnByZWZlcmVuY2VzLmdldCgpLCBlbmFibGUpOworCisgICAgcmV0dXJuIHRydWU7
Cit9CisKK0VpbmFfQm9vbCBld2tfc2V0dGluZ3NfRE5TX3ByZWZldGNoaW5nX2VuYWJsZWRfZ2V0
KGNvbnN0IEV3a19TZXR0aW5ncyogc2V0dGluZ3MpCit7CisgICAgRUlOQV9TQUZFVFlfT05fTlVM
TF9SRVRVUk5fVkFMKHNldHRpbmdzLCBmYWxzZSk7CisKKyAgICByZXR1cm4gV0tQcmVmZXJlbmNl
c0dldEROU1ByZWZldGNoaW5nRW5hYmxlZChzZXR0aW5ncy0+cHJlZmVyZW5jZXMuZ2V0KCkpOwor
fQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3NldHRp
bmdzLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfc2V0dGluZ3MuaApp
bmRleCA4NjY2ZmExYjZlNmJhNjJmNDFlNTk1OWU4OTJjZWEzNWEzNzc4ZTQxLi4yODM5MDZhZGM0
YzE0YWI0NTUxYjQ3NjlkYzAzZjg0MDEzYzdiM2EwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0
Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfc2V0dGluZ3MuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9V
SVByb2Nlc3MvQVBJL2VmbC9ld2tfc2V0dGluZ3MuaApAQCAtMTgzLDYgKzE4MywzMyBAQCBFQVBJ
IEVpbmFfQm9vbCBld2tfc2V0dGluZ3NfZW5hYmxlX2ZyYW1lX2ZsYXR0ZW5pbmdfc2V0KEV3a19T
ZXR0aW5ncyAqc2V0dGluZ3MsCiAgKi8KIEVBUEkgRWluYV9Cb29sIGV3a19zZXR0aW5nc19lbmFi
bGVfZnJhbWVfZmxhdHRlbmluZ19nZXQoY29uc3QgRXdrX1NldHRpbmdzICpzZXR0aW5ncyk7CiAK
Ky8qKgorICogRW5hYmxlcy9kaXNhYmxlcyBETlMgcHJlZmV0Y2hpbmcuCisgKgorICogQnkgZGVm
YXVsdCwgRE5TIHByZWZldGNoaW5nIGlzIGRpc2FibGVkLgorICoKKyAqIEBwYXJhbSBzZXR0aW5n
cyBzZXR0aW5ncyBvYmplY3QgdG8gc2V0IEROUyBwcmVmZXRjaGluZworICogQHBhcmFtIGVuYWJs
ZSBAYyBFSU5BX1RSVUUgdG8gZW5hYmxlIEROUyBwcmVmZXRjaGluZyBvcgorICogICAgICAgICAg
ICAgICBAYyBFSU5BX0ZBTFNFIHRvIGRpc2FibGUKKyAqCisgKiBAcmV0dXJuIEBjIEVJTkFfVFJV
RSBvbiBzdWNjZXNzIG9yIEBjIEVJTkFfRkFMU0Ugb24gZmFpbHVyZQorICoKKyAqIEBzZWUgZXdr
X3NldHRpbmdzX0ROU19wcmVmZXRjaGluZ19lbmFibGVkX2dldCgpCisgKi8KK0VBUEkgRWluYV9C
b29sIGV3a19zZXR0aW5nc19ETlNfcHJlZmV0Y2hpbmdfZW5hYmxlZF9zZXQoRXdrX1NldHRpbmdz
ICpzZXR0aW5ncywgRWluYV9Cb29sIGVuYWJsZSk7CisKKy8qKgorICogUmV0dXJucyB3aGV0aGVy
IEROUyBwcmVmZXRjaGluZyBpcyBlbmFibGVkIG9yIG5vdC4KKyAqCisgKiBETlMgcHJlZmV0Y2hp
bmcgaXMgYW4gYXR0ZW1wdCB0byByZXNvbHZlIGRvbWFpbiBuYW1lcyBiZWZvcmUgYSB1c2VyIHRy
aWVzIHRvIGZvbGxvdyBhIGxpbmsuCisgKgorICogQHBhcmFtIHNldHRpbmdzIHNldHRpbmdzIG9i
amVjdCB0byBnZXQgRE5TIHByZWZldGNoaW5nCisgKgorICogQHJldHVybiBAYyBFSU5BX1RSVUUg
aWYgRE5TIHByZWZldGNoaW5nIGlzIGVuYWJsZWQKKyAqICAgICAgICAgQGMgRUlOQV9GQUxTRSBp
ZiBub3Qgb3Igb24gZmFpbHVyZQorICovCitFQVBJIEVpbmFfQm9vbCBld2tfc2V0dGluZ3NfRE5T
X3ByZWZldGNoaW5nX2VuYWJsZWRfZ2V0KGNvbnN0IEV3a19TZXR0aW5ncyAqc2V0dGluZ3MpOwor
CiAjaWZkZWYgX19jcGx1c3BsdXMKIH0KICNlbmRpZgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp
dDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX3NldHRpbmdzLmNwcCBiL1NvdXJj
ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL3Rlc3RfZXdrMl9zZXR0aW5ncy5jcHAK
aW5kZXggNTYyZjc3NjI2YmY2YTI0M2Q3MjRmMmUwMWU3MTUyYzg2NDFlODhjMC4uNmUxM2YxMTIy
MWEwZDAzODliMDU0ZmYxY2Q3ODMyNjI4MjQ2ZGMwYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp
dDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX3NldHRpbmdzLmNwcAorKysgYi9T
b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3azJfc2V0dGluZ3Mu
Y3BwCkBAIC0xNDQsMyArMTQ0LDE2IEBAIFRFU1RfRihFV0syVW5pdFRlc3RCYXNlLCBld2tfc2V0
dGluZ3NfZW5hYmxlX2ZyYW1lX2ZsYXR0ZW5pbmdfc2V0KQogICAgIHdhaXRVbnRpbFRpdGxlQ2hh
bmdlZFRvKCIyMDAiKTsgLy8gd2lkdGggb2YgaWZyYW1lIHRhZy4KICAgICBBU1NFUlRfU1RSRVEo
IjIwMCIsIGV3a192aWV3X3RpdGxlX2dldCh3ZWJWaWV3KCkpKTsKIH0KKworVEVTVF9GKEVXSzJV
bml0VGVzdEJhc2UsIGV3a19zZXR0aW5nc19ETlNfcHJlZmV0Y2hpbmdfZW5hYmxlZCkKK3sKKyAg
ICBFd2tfU2V0dGluZ3MqIHNldHRpbmdzID0gZXdrX3ZpZXdfc2V0dGluZ3NfZ2V0KHdlYlZpZXco
KSk7CisKKyAgICAvLyBETlMgcHJlZmVjaGluZyBpcyBkaXNhYmxlZCBieSBkZWZhdWx0LgorICAg
IEFTU0VSVF9GQUxTRShld2tfc2V0dGluZ3NfRE5TX3ByZWZldGNoaW5nX2VuYWJsZWRfZ2V0KHNl
dHRpbmdzKSk7CisgICAgQVNTRVJUX1RSVUUoZXdrX3NldHRpbmdzX0ROU19wcmVmZXRjaGluZ19l
bmFibGVkX3NldChzZXR0aW5ncywgdHJ1ZSkpOworICAgIEFTU0VSVF9UUlVFKGV3a19zZXR0aW5n
c19ETlNfcHJlZmV0Y2hpbmdfZW5hYmxlZF9nZXQoc2V0dGluZ3MpKTsKKworICAgIEFTU0VSVF9U
UlVFKGV3a19zZXR0aW5nc19ETlNfcHJlZmV0Y2hpbmdfZW5hYmxlZF9zZXQoc2V0dGluZ3MsIGZh
bHNlKSk7CisgICAgQVNTRVJUX0ZBTFNFKGV3a19zZXR0aW5nc19ETlNfcHJlZmV0Y2hpbmdfZW5h
YmxlZF9nZXQoc2V0dGluZ3MpKTsKK30K
</data>

          </attachment>
      

    </bug>

</bugzilla>