98789 2012-10-09 10:10:30 -0700 [GTK] Plugin don't display 2012-10-10 00:39:46 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 98860 0 dsd webkit-unassigned cgarcia mrobinson webkit.review.bot zan oldest_to_newest 737901 0 dsd 2012-10-09 10:10:30 -0700 Since webkitgtk-1.9.90, plugins don't display properly. Testing <embed src="foo.ogg" width="100" height="100" /> with totem-mozplugin installed to handle such requests, using GtkLauncher. Reproduced on systems with and without OpenGL support available. When the page is loaded, the audio starts playing, but the video can't be seen - its all white. Moving the window around the screen doesn't cause any change. Maximizing the window causes the video to suddenly appear. Tracked this down; the regression was introduced by r126182 in bug #90085. 737912 1 mrobinson 2012-10-09 10:18:45 -0700 I can't test plugins easily, but could you check if removing the early-return in webkit_web_view_size_allocate fixes the issue? 737920 2 dsd 2012-10-09 10:37:07 -0700 Thanks for the fast response. Commenting out the first return statement in webkit_web_view_size_allocate() (as follows) avoids the issue. if (allocation->width == oldAllocation.width && allocation->height == oldAllocation.height) /*return*/; 737924 3 mrobinson 2012-10-09 10:40:31 -0700 Do you mind writing a patch that takes the same approach as webkitWebViewBaseSizeAllocate from ~/WebKit/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp? 737928 4 cgarcia 2012-10-09 10:45:02 -0700 This is probably because you always have to allocate the children in size allocate. You can probably still avoid resizing the frame view if the size hasn't changed, but even if the size it's the same, the coords might have changed, so children need to be allocated. 738101 5 167828 dsd 2012-10-09 12:58:15 -0700 Created attachment 167828 Patch 738111 6 167828 mrobinson 2012-10-09 13:05:14 -0700 Comment on attachment 167828 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167828&action=review > Source/WebKit/gtk/webkit/webkitwebview.cpp:-875 > - gtk_widget_get_allocation(widget, &oldAllocation); > - > GTK_WIDGET_CLASS(webkit_web_view_parent_class)->size_allocate(widget, allocation); > - if (allocation->width == oldAllocation.width && allocation->height == oldAllocation.height) > - return; I think this is the wrong fix. Instead of simply ignoring whether or not the size has changed, you should pass the information to resizeWebViewFromAllocation and only keep the call to gtk_container_forall(GTK_CONTAINER(webView), updateChildAllocationFromPendingAllocation, 0); when the size hasn't changed. Please see the WebKitWebViewBase for an example. 738259 7 167861 dsd 2012-10-09 15:29:27 -0700 Created attachment 167861 Patch 738435 8 167861 webkit.review.bot 2012-10-09 19:11:34 -0700 Comment on attachment 167861 Patch Clearing flags on attachment: 167861 Committed r130838: <http://trac.webkit.org/changeset/130838> 738436 9 webkit.review.bot 2012-10-09 19:11:38 -0700 All reviewed patches have been landed. Closing bug. 738582 10 webkit.review.bot 2012-10-09 23:00:35 -0700 Re-opened since this is blocked by bug 98860 738628 11 zan 2012-10-09 23:43:32 -0700 (In reply to comment #10) > Re-opened since this is blocked by bug 98860 Sigh ... The rollout didn't help, the crashes are still there. Sorry for all the noise, I'll get this patch back into the tree. 738686 12 zan 2012-10-10 00:39:46 -0700 (In reply to comment #11) > (In reply to comment #10) > > Re-opened since this is blocked by bug 98860 > > Sigh ... The rollout didn't help, the crashes are still there. Sorry for all the noise, I'll get this patch back into the tree. Rolled back in in r130867. http://trac.webkit.org/changeset/130867 167828 2012-10-09 12:58:15 -0700 2012-10-09 15:29:19 -0700 Patch bug-98789-20121009155715.patch text/plain 1705 dsd SW5kZXg6IFNvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L2d0ay9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMDc5NykKKysrIFNvdXJjZS9XZWJLaXQv Z3RrL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTEwLTA5 ICBEYW5pZWwgRHJha2UgIDxkc2RAbGFwdG9wLm9yZz4KKworICAgICAgICBbR1RLXSBQbHVnaW5z IGRvbid0IGRpc3BsYXkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTk4Nzg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgRml4IGEgcmVjZW50IHJlZ3Jlc3Npb24gd2hlcmUgcGx1Z2luIGNvbnRlbnQgd2FzIG5v dCBiZWluZyBkaXNwbGF5ZWQuCisgICAgICAgIEJyaW5naW5nIHdlYmtpdF93ZWJfdmlld19zaXpl X2FsbG9jYXRlIGluIGxpbmUgd2l0aCB0aGUgV2ViS2l0MgorICAgICAgICBlcXVpdmFsZW50IHNv bHZlcyB0aGUgaXNzdWU6IHRoZSB3ZWIgdmlldyBtdXN0IGJlIHJlc2l6ZWQgZHVyaW5nCisgICAg ICAgIHNpemVfYWxsb2NhdGUgZXZlbiB3aGVuIHRoZSBhbGxvY2F0aW9uIGRvZXMgbm90IGNoYW5n ZS4KKworICAgICAgICAqIHdlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcDoKKyAgICAgICAgKHdlYmtp dF93ZWJfdmlld19zaXplX2FsbG9jYXRlKToKKwogMjAxMi0xMC0wNyAgQ2FpbyBNYXJjZWxvIGRl IE9saXZlaXJhIEZpbGhvICA8Y2Fpby5vbGl2ZWlyYUBvcGVuYm9zc2Eub3JnPgogCiAgICAgICAg IFJlbmFtZSBmaXJzdC9zZWNvbmQgdG8ga2V5L3ZhbHVlIGluIEhhc2hNYXAgaXRlcmF0b3JzCklu ZGV4OiBTb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCShyZXZpc2lv biAxMzA3OTcpCisrKyBTb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTg2NywxMiArODY3LDcgQEAgc3RhdGljIHZvaWQgcmVzaXplV2Vi Vmlld0Zyb21BbGxvY2F0aW9uKAogCiBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX3ZpZXdfc2l6ZV9h bGxvY2F0ZShHdGtXaWRnZXQqIHdpZGdldCwgR3RrQWxsb2NhdGlvbiogYWxsb2NhdGlvbikKIHsK LSAgICBHdGtBbGxvY2F0aW9uIG9sZEFsbG9jYXRpb247Ci0gICAgZ3RrX3dpZGdldF9nZXRfYWxs b2NhdGlvbih3aWRnZXQsICZvbGRBbGxvY2F0aW9uKTsKLQogICAgIEdUS19XSURHRVRfQ0xBU1Mo d2Via2l0X3dlYl92aWV3X3BhcmVudF9jbGFzcyktPnNpemVfYWxsb2NhdGUod2lkZ2V0LCBhbGxv Y2F0aW9uKTsKLSAgICBpZiAoYWxsb2NhdGlvbi0+d2lkdGggPT0gb2xkQWxsb2NhdGlvbi53aWR0 aCAmJiBhbGxvY2F0aW9uLT5oZWlnaHQgPT0gb2xkQWxsb2NhdGlvbi5oZWlnaHQpCi0gICAgICAg IHJldHVybjsKIAogICAgIFdlYktpdFdlYlZpZXcqIHdlYlZpZXcgPSBXRUJLSVRfV0VCX1ZJRVco d2lkZ2V0KTsKICAgICBpZiAoIWd0a193aWRnZXRfZ2V0X21hcHBlZCh3aWRnZXQpKSB7Cg== 167861 2012-10-09 15:29:27 -0700 2012-10-09 19:11:34 -0700 Patch bug-98789-20121009182825.patch text/plain 3492 dsd SW5kZXg6IFNvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L2d0ay9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMDgyMCkKKysrIFNvdXJjZS9XZWJLaXQv Z3RrL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEyLTEwLTA5 ICBEYW5pZWwgRHJha2UgIDxkc2RAbGFwdG9wLm9yZz4KKworICAgICAgICBbR1RLXSBQbHVnaW5z IGRvbid0IGRpc3BsYXkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTk4Nzg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgRml4IGEgcmVjZW50IHJlZ3Jlc3Npb24gd2hlcmUgcGx1Z2luIGNvbnRlbnQgd2FzIG5v dCBiZWluZyBkaXNwbGF5ZWQuCisgICAgICAgIEJyaW5naW5nIHdlYmtpdF93ZWJfdmlld19zaXpl X2FsbG9jYXRlIGluIGxpbmUgd2l0aCB0aGUgV2ViS2l0MgorICAgICAgICBlcXVpdmFsZW50IHNv bHZlcyB0aGUgaXNzdWUuCisKKyAgICAgICAgKiB3ZWJraXQvd2Via2l0d2Vidmlldy5jcHA6Cisg ICAgICAgIChyZXNpemVXZWJWaWV3RnJvbUFsbG9jYXRpb24pOiBwYXNzIGFsbG9jYXRpb24gcmVx dWVzdCB0byBjaGlsZHJlbgorICAgICAgICBldmVuIHdoZW4gdGhlIGFsbG9jYXRpb24gc2l6ZSBk b2VzIG5vdCBjaGFuZ2UuCisgICAgICAgICh3ZWJraXRfd2ViX3ZpZXdfc2l6ZV9hbGxvY2F0ZSk6 IGRvbid0IGJhaWwgdG9vIGVhcmx5IGlmIHRoZQorICAgICAgICBhbGxvY2F0aW9uIHNpemUgZG9l cyBub3QgY2hhbmdlLgorCiAyMDEyLTEwLTA3ICBDYWlvIE1hcmNlbG8gZGUgT2xpdmVpcmEgRmls aG8gIDxjYWlvLm9saXZlaXJhQG9wZW5ib3NzYS5vcmc+CiAKICAgICAgICAgUmVuYW1lIGZpcnN0 L3NlY29uZCB0byBrZXkvdmFsdWUgaW4gSGFzaE1hcCBpdGVyYXRvcnMKSW5kZXg6IFNvdXJjZS9X ZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAJKHJldmlzaW9uIDEzMDc5NykKKysr IFNvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcAkod29ya2luZyBjb3B5 KQpAQCAtODQ5LDE3ICs4NDksMjEgQEAgc3RhdGljIHZvaWQgdXBkYXRlQ2hpbGRBbGxvY2F0aW9u RnJvbVBlbgogICAgICphbGxvY2F0aW9uID0gSW50UmVjdCgpOwogfQogCi1zdGF0aWMgdm9pZCBy ZXNpemVXZWJWaWV3RnJvbUFsbG9jYXRpb24oV2ViS2l0V2ViVmlldyogd2ViVmlldywgR3RrQWxs b2NhdGlvbiogYWxsb2NhdGlvbikKK3N0YXRpYyB2b2lkIHJlc2l6ZVdlYlZpZXdGcm9tQWxsb2Nh dGlvbihXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3LCBHdGtBbGxvY2F0aW9uKiBhbGxvY2F0aW9uLCBi b29sIHNpemVDaGFuZ2VkKQogewogICAgIFBhZ2UqIHBhZ2UgPSBjb3JlKHdlYlZpZXcpOwogICAg IEludFNpemUgb2xkU2l6ZTsKLSAgICBpZiAoRnJhbWVWaWV3KiBmcmFtZVZpZXcgPSBwYWdlLT5t YWluRnJhbWUoKS0+dmlldygpKSB7CisgICAgRnJhbWVWaWV3KiBmcmFtZVZpZXcgPSBwYWdlLT5t YWluRnJhbWUoKS0+dmlldygpOworICAgIGlmIChzaXplQ2hhbmdlZCAmJiBmcmFtZVZpZXcpIHsK ICAgICAgICAgb2xkU2l6ZSA9IGZyYW1lVmlldy0+c2l6ZSgpOwogICAgICAgICBmcmFtZVZpZXct PnJlc2l6ZShhbGxvY2F0aW9uLT53aWR0aCwgYWxsb2NhdGlvbi0+aGVpZ2h0KTsKICAgICB9CiAK ICAgICBndGtfY29udGFpbmVyX2ZvcmFsbChHVEtfQ09OVEFJTkVSKHdlYlZpZXcpLCB1cGRhdGVD aGlsZEFsbG9jYXRpb25Gcm9tUGVuZGluZ0FsbG9jYXRpb24sIDApOwogCisgICAgaWYgKCFzaXpl Q2hhbmdlZCkKKyAgICAgICAgcmV0dXJuOworCiAgICAgV2ViS2l0OjpDaHJvbWVDbGllbnQqIGNo cm9tZUNsaWVudCA9IHN0YXRpY19jYXN0PFdlYktpdDo6Q2hyb21lQ2xpZW50Kj4ocGFnZS0+Y2hy b21lKCktPmNsaWVudCgpKTsKICAgICBjaHJvbWVDbGllbnQtPndpZGdldFNpemVDaGFuZ2VkKG9s ZFNpemUsIEludFNpemUoYWxsb2NhdGlvbi0+d2lkdGgsIGFsbG9jYXRpb24tPmhlaWdodCkpOwog ICAgIGNocm9tZUNsaWVudC0+YWRqdXN0bWVudFdhdGNoZXIoKS0+dXBkYXRlQWRqdXN0bWVudHNG cm9tU2Nyb2xsYmFycygpOwpAQCAtODY5LDE3ICs4NzMsMTYgQEAgc3RhdGljIHZvaWQgd2Via2l0 X3dlYl92aWV3X3NpemVfYWxsb2NhdAogewogICAgIEd0a0FsbG9jYXRpb24gb2xkQWxsb2NhdGlv bjsKICAgICBndGtfd2lkZ2V0X2dldF9hbGxvY2F0aW9uKHdpZGdldCwgJm9sZEFsbG9jYXRpb24p OworICAgIGJvb2wgc2l6ZUNoYW5nZWQgPSBhbGxvY2F0aW9uLT53aWR0aCAhPSBvbGRBbGxvY2F0 aW9uLndpZHRoIHx8IGFsbG9jYXRpb24tPmhlaWdodCAhPSBvbGRBbGxvY2F0aW9uLmhlaWdodDsK IAogICAgIEdUS19XSURHRVRfQ0xBU1Mod2Via2l0X3dlYl92aWV3X3BhcmVudF9jbGFzcyktPnNp emVfYWxsb2NhdGUod2lkZ2V0LCBhbGxvY2F0aW9uKTsKLSAgICBpZiAoYWxsb2NhdGlvbi0+d2lk dGggPT0gb2xkQWxsb2NhdGlvbi53aWR0aCAmJiBhbGxvY2F0aW9uLT5oZWlnaHQgPT0gb2xkQWxs b2NhdGlvbi5oZWlnaHQpCi0gICAgICAgIHJldHVybjsKIAogICAgIFdlYktpdFdlYlZpZXcqIHdl YlZpZXcgPSBXRUJLSVRfV0VCX1ZJRVcod2lkZ2V0KTsKLSAgICBpZiAoIWd0a193aWRnZXRfZ2V0 X21hcHBlZCh3aWRnZXQpKSB7CisgICAgaWYgKHNpemVDaGFuZ2VkICYmICFndGtfd2lkZ2V0X2dl dF9tYXBwZWQod2lkZ2V0KSkgewogICAgICAgICB3ZWJWaWV3LT5wcml2LT5uZWVkc1Jlc2l6ZU9u TWFwID0gdHJ1ZTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KLSAgICByZXNpemVXZWJWaWV3RnJv bUFsbG9jYXRpb24od2ViVmlldywgYWxsb2NhdGlvbik7CisgICAgcmVzaXplV2ViVmlld0Zyb21B bGxvY2F0aW9uKHdlYlZpZXcsIGFsbG9jYXRpb24sIHNpemVDaGFuZ2VkKTsKIH0KIAogc3RhdGlj IHZvaWQgd2Via2l0V2ViVmlld01hcChHdGtXaWRnZXQqIHdpZGdldCkKQEAgLTg5Miw3ICs4OTUs NyBAQCBzdGF0aWMgdm9pZCB3ZWJraXRXZWJWaWV3TWFwKEd0a1dpZGdldCoKIAogICAgIEd0a0Fs bG9jYXRpb24gYWxsb2NhdGlvbjsKICAgICBndGtfd2lkZ2V0X2dldF9hbGxvY2F0aW9uKHdpZGdl dCwgJmFsbG9jYXRpb24pOwotICAgIHJlc2l6ZVdlYlZpZXdGcm9tQWxsb2NhdGlvbih3ZWJWaWV3 LCAmYWxsb2NhdGlvbik7CisgICAgcmVzaXplV2ViVmlld0Zyb21BbGxvY2F0aW9uKHdlYlZpZXcs ICZhbGxvY2F0aW9uLCB0cnVlKTsKICAgICB3ZWJWaWV3LT5wcml2LT5uZWVkc1Jlc2l6ZU9uTWFw ID0gZmFsc2U7CiB9CiAK