98778 2012-10-09 08:58:50 -0700 [Chromium-Android] Color profiles are not supported on Android 2013-04-08 15:17:03 -0700 1 1 1 Unclassified WebKit Images 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 96398 1 peter webkit-unassigned abarth benjamin code.vineet hclam ojan.autocc qinmin schenney skyostil tomhudson webkit.review.bot oldest_to_newest 737833 0 peter 2012-10-09 08:58:50 -0700 Example test: http://trac.webkit.org/export/130746/trunk/LayoutTests/fast/images/png-with-color-profile.html Results: http://build.webkit.org/results/Chromium%20Android%20Release%20(Tests)/r130746%20(1241)/fast/images/png-with-color-profile-diffs.html The relevant tests have been disabled in TestExpectations. 807686 1 182844 code.vineet 2013-01-15 14:20:02 -0800 Created attachment 182844 proposed_patch Color Profiles are now supported on chromium platforms except Android. This patch enables building code for qcm and iccjpeg for android. I have tested basic test case attached in the bug which passes in content shell. Are there any concerns enabling these flags? 807708 2 182844 abarth 2013-01-15 14:45:24 -0800 Comment on attachment 182844 proposed_patch View in context: https://bugs.webkit.org/attachment.cgi?id=182844&action=review > Source/WTF/wtf/Platform.h:489 > +#define WTF_USE_ICCJPEG 1 > +#define WTF_USE_QCMSLIB 1 Should we just bring these out of the #else clause since they're now enabled on all platforms? 807719 3 code.vineet 2013-01-15 14:57:19 -0800 (In reply to comment #2) > (From update of attachment 182844 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=182844&action=review > > > Source/WTF/wtf/Platform.h:489 > > +#define WTF_USE_ICCJPEG 1 > > +#define WTF_USE_QCMSLIB 1 > > Should we just bring these out of the #else clause since they're now enabled on all platforms? Yes. I think we can even pull out #define WTF_USE_SKIA 1 along with above, as this is also defined for all ports for Chromium, in same patch or another. 807805 4 182867 code.vineet 2013-01-15 16:18:32 -0800 Created attachment 182867 updated_patch I have removed the failing tests from TestExpectations, and checked these tests manually in content shell. As I have some issues with setup to run /run-webkit-tests --chromium-android 808057 5 182867 abarth 2013-01-15 22:35:31 -0800 Comment on attachment 182867 updated_patch This patch LGTM, but we might want Peter Beverloo to sign off before landing. 808263 6 peter 2013-01-16 04:14:05 -0800 Hi Vineet, this is awesome, thank you so much! I'll run some performance tests to measure what this means for image decoding time, and will reply with them on the bug once they're complete. I'm also adding Sami and Alpha as they know much more about image decoding performance on Chromium for Android, and might be able to provide additional insights. 813227 7 code.vineet 2013-01-22 11:06:48 -0800 (In reply to comment #6) > Hi Vineet, this is awesome, thank you so much! I'll run some performance tests to measure what this means for image decoding time, and will reply with them on the bug once they're complete. > > I'm also adding Sami and Alpha as they know much more about image decoding performance on Chromium for Android, and might be able to provide additional insights. Hello Peter Beverloo, Did you got chance to run performance tests? I did dry run for the link http://regex.info/blog/2012-03-27/1964 found no glitches, but w/o performance data. If you can point tests which can give perf results I can test that. Thanks. 182844 2013-01-15 14:20:02 -0800 2013-01-15 16:18:32 -0800 proposed_patch qcm_001.patch text/plain 1207 code.vineet SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxMzk3ODYpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAxLTE1ICAgVmluZWV0IENoYXVkaGFyeSAg PHJnZjc0OEBtb3Rvcm9sYS5jb20+CisKKyAgICAgICAgW0Nocm9taXVtLUFuZHJvaWRdIENvbG9y IHByb2ZpbGVzIGFyZSBub3Qgc3VwcG9ydGVkIG9uIEFuZHJvaWQuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05ODc3OAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0Y2ggZW5hYmxlcyBidWlsZGlu ZyBsaWJpY2NqcGVnIGFuZCBsaWJxY20gcmVxdWlyZWQgZm9yCisgICAgICAgIHN1cHBvcnRpbmcg Q29sb3IgUHJvZmlsZXMuCisKKyAgICAgICAgKiB3dGYvUGxhdGZvcm0uaDogRW5hYmxlIFFDTVNM SUIgYW5kIElDQ0pQRUcgZmxhZ3MuCisKIDIwMTMtMDEtMTUgIEFkYW0gQmFydGggIDxhYmFydGhA d2Via2l0Lm9yZz4KIAogICAgICAgICBHZW5lcmFsaXplIERvY3VtZW50V2Vha1JlZmVyZW5jZSBp bnRvIFdURjo6V2Vha1B0cgpJbmRleDogU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCShyZXZpc2lvbiAxMzk3ODQpCisrKyBT b3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCSh3b3JraW5nIGNvcHkpCkBAIC00ODUsNiArNDg1LDgg QEAKICNkZWZpbmUgV1RGX1VTRV9RQ01TTElCIDEKICNlbGlmIE9TKEFORFJPSUQpCiAjZGVmaW5l IFdURl9VU0VfU0tJQSAxCisjZGVmaW5lIFdURl9VU0VfSUNDSlBFRyAxCisjZGVmaW5lIFdURl9V U0VfUUNNU0xJQiAxCiAjZGVmaW5lIFdURl9VU0VfTE9XX1FVQUxJVFlfSU1BR0VfSU5URVJQT0xB VElPTiAxCiAjZGVmaW5lIFdURl9VU0VfTE9XX1FVQUxJVFlfSU1BR0VfTk9fSlBFR19ESVRIRVJJ TkcgMQogI2RlZmluZSBXVEZfVVNFX0xPV19RVUFMSVRZX0lNQUdFX05PX0pQRUdfRkFOQ1lfVVBT QU1QTElORyAxCg== 182867 2013-01-15 16:18:32 -0800 2013-01-15 22:35:31 -0800 updated_patch qcm_003.patch text/plain 3335 code.vineet SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxMzk4MDQpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAxLTE1ICAgVmluZWV0IENoYXVkaGFyeSAg PHJnZjc0OEBtb3Rvcm9sYS5jb20+CisKKyAgICAgICAgW0Nocm9taXVtLUFuZHJvaWRdIENvbG9y IHByb2ZpbGVzIGFyZSBub3Qgc3VwcG9ydGVkIG9uIEFuZHJvaWQuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05ODc3OAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0Y2ggZW5hYmxlcyBidWlsZGlu ZyBjb2RlIG9mIHFjbSBhbmQgaWNjanBlZyBmb3IgYW5kcm9pZCB0bworICAgICAgICBzdXBwb3J0 IENvbG9yIFByb2ZpbGVzLgorCisgICAgICAgIE5vIG5ldyB0ZXN0czogRXhpc3RpbmcgdGVzdCB1 bmRlciBmYXN0L2ltYWdlcyBzaG91bGQgcGFzcyBhZnRlciB0aGVzZQorICAgICAgICBjaGFuZ2Vz LgorCisgICAgICAgICogd3RmL1BsYXRmb3JtLmg6IEVuYWJsZSBRQ01TTElCIGFuZCBJQ0NKUEVH IGZsYWdzLgorCiAyMDEzLTAxLTE1ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgR2VuZXJhbGl6ZSBEb2N1bWVudFdlYWtSZWZlcmVuY2UgaW50byBXVEY6OldlYWtQ dHIKSW5kZXg6IFNvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dURi93dGYvUGxhdGZvcm0uaAkocmV2aXNpb24gMTM5Nzg0KQorKysgU291cmNlL1dURi93dGYv UGxhdGZvcm0uaAkod29ya2luZyBjb3B5KQpAQCAtNDc3LDIxICs0NzcsMTUgQEAKICNkZWZpbmUg V1RGX1VTRV9DQSAxCiAjZW5kaWYKIAotLyogVVNFKFNLSUEpIGZvciBXaW4vTGludXgvTWFjL0Fu ZHJvaWQgKi8KKy8qIFVTRShTS0lBKSwgVVNFKElDQ0pQRUcpIGFuZCBVU0UoUUNNU0xJQikgZm9y IFdpbi9MaW51eC9NYWMvQW5kcm9pZCAqLwogI2lmIFBMQVRGT1JNKENIUk9NSVVNKQotI2lmIE9T KERBUldJTikKICNkZWZpbmUgV1RGX1VTRV9TS0lBIDEKICNkZWZpbmUgV1RGX1VTRV9JQ0NKUEVH IDEKICNkZWZpbmUgV1RGX1VTRV9RQ01TTElCIDEKLSNlbGlmIE9TKEFORFJPSUQpCi0jZGVmaW5l IFdURl9VU0VfU0tJQSAxCisjaWYgT1MoQU5EUk9JRCkKICNkZWZpbmUgV1RGX1VTRV9MT1dfUVVB TElUWV9JTUFHRV9JTlRFUlBPTEFUSU9OIDEKICNkZWZpbmUgV1RGX1VTRV9MT1dfUVVBTElUWV9J TUFHRV9OT19KUEVHX0RJVEhFUklORyAxCiAjZGVmaW5lIFdURl9VU0VfTE9XX1FVQUxJVFlfSU1B R0VfTk9fSlBFR19GQU5DWV9VUFNBTVBMSU5HIDEKLSNlbHNlCi0jZGVmaW5lIFdURl9VU0VfU0tJ QSAxCi0jZGVmaW5lIFdURl9VU0VfSUNDSlBFRyAxCi0jZGVmaW5lIFdURl9VU0VfUUNNU0xJQiAx CiAjZW5kaWYKICNlbmRpZgogCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMzk4MDQpCisrKyBMYXlvdXRU ZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAxMy0wMS0x NSAgIFZpbmVldCBDaGF1ZGhhcnkgIDxyZ2Y3NDhAbW90b3JvbGEuY29tPgorCisgICAgICAgIFtD aHJvbWl1bS1BbmRyb2lkXSBDb2xvciBwcm9maWxlcyBhcmUgbm90IHN1cHBvcnRlZCBvbiBBbmRy b2lkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTg3 NzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1v dmluZyB0ZXN0cyBmb3IgY29sb3ItcHJvZmlsZSBmcm9tIFRlc3RFeHBlY3RhdGlvbnMgYXMgdGhl c2Ugc2hvdWxkCisgICAgICAgIHBhc3Mgbm93IGZvciBjaHJvbWl1bS1hbmRyb2lkCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9UZXN0RXhwZWN0YXRpb25zOiBSZW1vdmVkICotY29sb3It cHJvZmlsZS5odG1sIHRlc3RzLjxGNj4KKwogMjAxMy0wMS0xNSAgQXJuYXVkIFJlbmV2aWVyICA8 YS5yZW5ldmllckBzaXNhLnNhbXN1bmcuY29tPgogCiAgICAgICAgIEFkZCBDYW52YXMgYmxlbmQg bW9kZXMgdG8gQ2Fpcm8KSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL1Rlc3RF eHBlY3RhdGlvbnMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0v VGVzdEV4cGVjdGF0aW9ucwkocmV2aXNpb24gMTM5Nzg0KQorKysgTGF5b3V0VGVzdHMvcGxhdGZv cm0vY2hyb21pdW0vVGVzdEV4cGVjdGF0aW9ucwkod29ya2luZyBjb3B5KQpAQCAtMTgzNCwxMCAr MTgzNCw2IEBAIHdlYmtpdC5vcmcvYi85ODc5NiBbIEFuZHJvaWQgXSBmYXN0L211bHQKIHdlYmtp dC5vcmcvYi85ODc5NiBbIEFuZHJvaWQgXSBmYXN0L211bHRpY29sL3NwYW4vc3Bhbi1hcy1pbW1l ZGlhdGUtY2hpbGQtZ2VuZXJhdGVkLWNvbnRlbnQuaHRtbCBbIEZhaWx1cmUgXQogd2Via2l0Lm9y Zy9iLzk4Nzk2IFsgQW5kcm9pZCBdIGZhc3QvbXVsdGljb2wvc3Bhbi9zcGFuLWFzLWltbWVkaWF0 ZS1jaGlsZC1jb21wbGV4LXNwbGl0dGluZy5odG1sIFsgRmFpbHVyZSBdCiAKLSMgW0Nocm9taXVt LUFuZHJvaWRdIENvbG9yIHByb2ZpbGVzIGFyZSBub3Qgc3VwcG9ydGVkIG9uIEFuZHJvaWQKLXdl YmtpdC5vcmcvYi85ODc3OCBbIEFuZHJvaWQgXSBmYXN0L2ltYWdlcy9wbmctd2l0aC1jb2xvci1w cm9maWxlLmh0bWwgWyBGYWlsdXJlIF0KLXdlYmtpdC5vcmcvYi85ODc3OCBbIEFuZHJvaWQgXSBm YXN0L2ltYWdlcy9qcGVnLXdpdGgtY29sb3ItcHJvZmlsZS5odG1sIFsgRmFpbHVyZSBdCi0KICMg W0Nocm9taXVtLUFuZHJvaWRdIFRvdWNoIGV2ZW50cyBmYWlsIG9uIEFuZHJvaWQKIHdlYmtpdC5v cmcvYi85ODc3OSBbIEFuZHJvaWQgXSBmYXN0L2V2ZW50cy90b3VjaC8gWyBGYWlsdXJlIFBhc3Mg XQogd2Via2l0Lm9yZy9iLzk4Nzc5IFsgQW5kcm9pZCBdIHRvdWNoYWRqdXN0bWVudC90b3VjaC1s aW5rcy1hY3RpdmUuaHRtbCBbIEZhaWx1cmUgXQo=