98760 2012-10-09 08:11:46 -0700 fast/canvas/canvas-fillRect-gradient-shadow.html failing 2012-10-09 19:08:03 -0700 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 naginenis webkit-unassigned mrobinson webkit.review.bot oldest_to_newest 737788 0 naginenis 2012-10-09 08:11:46 -0700 fast/canvas/canvas-fillRect-gradient-shadow.html is failing with the cairo v1.12. The diff is: --- WebKit/WebKitBuild/Debug/layout-test-results/fast/canvas/canvas-fillRect-gradient-shadow-expected.txt +++ WebKit/WebKitBuild/Debug/layout-test-results/fast/canvas/canvas-fillRect-gradient-shadow-actual.txt @@ -79,7 +79,7 @@ PASS d[1] is 0 PASS d[2] is 0 PASS d[3] is smaller than 15 -PASS d[0] is 255 +FAIL d[0] should be 255. Was 0. PASS d[1] is 0 PASS d[2] is 0 PASS d[3] is smaller than 15 It looks like we need to adjust the blur radius higher up in ShadowBlur computation since the test case is using small shadow blur value. Or, we can also fix this by altering the blur value in the test case. http://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/ShadowBlur.cpp#L227 738299 1 167871 naginenis 2012-10-09 16:12:03 -0700 Created attachment 167871 Patch Adjusted the test case to verify the pixel in the middle of the shadow, instead of the outer edge. 738432 2 167871 webkit.review.bot 2012-10-09 19:07:59 -0700 Comment on attachment 167871 Patch Clearing flags on attachment: 167871 Committed r130837: <http://trac.webkit.org/changeset/130837> 738433 3 webkit.review.bot 2012-10-09 19:08:03 -0700 All reviewed patches have been landed. Closing bug. 167871 2012-10-09 16:12:03 -0700 2012-10-09 19:07:59 -0700 Patch 98760.patch text/plain 1434 naginenis ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA1YWQ3YmEwLi5jMWUxYjgxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMTAt MDkgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBpbnRlbC5jb20+CisK KyAgICAgICAgZmFzdC9jYW52YXMvY2FudmFzLWZpbGxSZWN0LWdyYWRpZW50LXNoYWRvdy5odG1s IGZhaWxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTk4NzYwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QWRqdXN0IHRoZSB0ZXN0IGNhc2UgdG8gdmVyaWZ5IHRoZSBwaXhlbCBpbiB0aGUgbWlkZGxlIG9m IHRoZSBzaGFkb3csCisgICAgICAgIGluc3RlYWQgb2YgdGhlIG91dGVyIGVkZ2UsIHRvIG1ha2Ug c3VyZSB0aGF0IHRoZSB0ZXN0IHdpbGwgbm90IGZhaWwKKyAgICAgICAgaW4gY2FzZSBpZiB0aGVy ZSBpcyBhbnkgZWZmZWN0IGFyb3VuZCB0aGUgYm9yZGVycy4KKworICAgICAgICAqIGZhc3QvY2Fu dmFzL3NjcmlwdC10ZXN0cy9jYW52YXMtZmlsbFJlY3QtZ3JhZGllbnQtc2hhZG93LmpzOgorCiAy MDEyLTEwLTA5ICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxyYXBoYWVsLmt1Ym8uZGEuY29zdGFA aW50ZWwuY29tPgogCiAgICAgICAgIFtFRkxdIE1hcmsgc3ZnL3RleHQvc2VsZWN0aW9uLXRyaXBs ZWNsaWNrLnN2ZyBhcyBmbGFreSBvbiBXSzIuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0 L2NhbnZhcy9zY3JpcHQtdGVzdHMvY2FudmFzLWZpbGxSZWN0LWdyYWRpZW50LXNoYWRvdy5qcyBi L0xheW91dFRlc3RzL2Zhc3QvY2FudmFzL3NjcmlwdC10ZXN0cy9jYW52YXMtZmlsbFJlY3QtZ3Jh ZGllbnQtc2hhZG93LmpzCmluZGV4IDA2MTdkMzkuLjFiYTZlZjMgMTAwNjQ0Ci0tLSBhL0xheW91 dFRlc3RzL2Zhc3QvY2FudmFzL3NjcmlwdC10ZXN0cy9jYW52YXMtZmlsbFJlY3QtZ3JhZGllbnQt c2hhZG93LmpzCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY2FudmFzL3NjcmlwdC10ZXN0cy9jYW52 YXMtZmlsbFJlY3QtZ3JhZGllbnQtc2hhZG93LmpzCkBAIC0xOTAsNyArMTkwLDcgQEAgc2hvdWxk QmUoJ2RbMV0nLCAnMCcpOwogc2hvdWxkQmUoJ2RbMl0nLCAnMCcpOwogc2hvdWxkQmVTbWFsbGVy KCdkWzNdJywgJzE1Jyk7CiAKLWQgPSBjdHguZ2V0SW1hZ2VEYXRhKDM1MSwgNzUxLCAxLCAxKS5k YXRhOworZCA9IGN0eC5nZXRJbWFnZURhdGEoMzUwLCA3NTAsIDEsIDEpLmRhdGE7CiBzaG91bGRC ZSgnZFswXScsICcyNTUnKTsKIHNob3VsZEJlKCdkWzFdJywgJzAnKTsKIHNob3VsZEJlKCdkWzJd JywgJzAnKTsK