98757 2012-10-09 07:42:33 -0700 [EFL][WK2] Inform the PageProxy about visibility changes when the view is shown/hidden. 2012-10-09 08:03:47 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rakuco rakuco cdumez gyuyoung.kim kenneth lucas.de.marchi webkit.review.bot oldest_to_newest 737767 0 rakuco 2012-10-09 07:42:33 -0700 [EFL][WK2] Inform the PageProxy about visibility changes when the view is shown/hidden. 737772 1 167755 rakuco 2012-10-09 07:47:27 -0700 Created attachment 167755 Patch 737773 2 167755 kenneth 2012-10-09 07:49:16 -0700 Comment on attachment 167755 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167755&action=review > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:376 > + priv->pageProxy->viewStateDidChange(WebPageProxy::ViewIsVisible); hide -> view is visible? 737775 3 rakuco 2012-10-09 07:52:40 -0700 (In reply to comment #2) > (From update of attachment 167755 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=167755&action=review > > > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:376 > > + priv->pageProxy->viewStateDidChange(WebPageProxy::ViewIsVisible); > > hide -> view is visible? -ENOPARSE :-) There's no WebPageProxy::ViewIsHidden; all the machinery to change the state is inside viewStateDidChange itself, which takes care of setting the visibility to hidden or visibile depending on what WebPageProxy::viewIsVisible() returns. 737776 4 kenneth 2012-10-09 07:53:43 -0700 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 167755 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=167755&action=review > > > > > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:376 > > > + priv->pageProxy->viewStateDidChange(WebPageProxy::ViewIsVisible); > > > > hide -> view is visible? > > -ENOPARSE :-) > > There's no WebPageProxy::ViewIsHidden; all the machinery to change the state is inside viewStateDidChange itself, which takes care of setting the visibility to hidden or visibile depending on what WebPageProxy::viewIsVisible() returns. Oh my, needs a comment anyway! 737778 5 167757 rakuco 2012-10-09 07:57:53 -0700 Created attachment 167757 Patch 737783 6 rakuco 2012-10-09 08:03:47 -0700 Committed r130764: <http://trac.webkit.org/changeset/130764> 167755 2012-10-09 07:47:27 -0700 2012-10-09 07:57:45 -0700 Patch bug-98757-20121009174451.patch text/plain 3113 rakuco SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMDc2MCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMyIEBACisyMDEyLTEwLTA5ICBSYXBoYWVs IEt1Ym8gZGEgQ29zdGEgIDxyYXBoYWVsLmt1Ym8uZGEuY29zdGFAaW50ZWwuY29tPgorCisgICAg ICAgIFtFRkxdW1dLMl0gSW5mb3JtIHRoZSBQYWdlUHJveHkgYWJvdXQgdmlzaWJpbGl0eSBjaGFu Z2VzIHdoZW4gdGhlIHZpZXcgaXMgc2hvd24vaGlkZGVuLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTg3NTcKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTVk4gcjEzMDcyMCBleHBvc2VkIGEgYnVnIGluIG91 ciBjb2RlOiB0aGUgUGFnZVByb3h5IGlzIG5vdAorICAgICAgICBub3RpZmllZCB3aGVuIG9uZSBj YWxscyBldmFzX29iamVjdF9zaG93KCkgb3IgZXZhc19vYmplY3RfaGlkZSgpCisgICAgICAgIG9u IHRoZSB2aWV3LCBzbyB0aGUgdmlzaWJpbGl0eSBpdCBoYXMgd2hlbiB0aGUgV2ViUGFnZVByb3h5 IGlzCisgICAgICAgIGNvbnN0cnVjdGVkIHJlbWFpbmVkIHNldCBmb3JldmVyLgorCisgICAgICAg IFRoaXMgbWFkZSB0aGUgZXdrX2NvbnRleHRfdmlicmF0aW9uX2NsaWVudF9jYWxsYmFja3Nfc2V0 IHVuaXQgdGVzdAorICAgICAgICBzdGFydCBydW5uaW5nIGZvcmV2ZXIsIGJlY2F1c2UgV2ViUGFn ZVByb3h5J3MgY29uc3RydWN0b3Igbm93IHNldHMKKyAgICAgICAgdGhlIHBhZ2UncyB2aXNpYmls aXR5IHRvIGhpZGRlbiBieSB0aGUgZGVmYXVsdCBmb3IgdXMsIHNpbmNlIGl0IGlzCisgICAgICAg IGNhbGxlZCBmcm9tIHdpdGhpbiBld2tfdmlld19zbWFydF9hZGQoKSBhbmQgYmVmb3JlCisgICAg ICAgIGV2YXNfb2JqZWN0X3Nob3coKS4KKworICAgICAgICBXZSBub3cgbGlzdGVuIHRvIHRoZSBF VkFTX0NBTExCQUNLX1NIT1cgYW5kIEVWQVNfQ0FMTEJBQ0tfSElERQorICAgICAgICBjYWxsYmFj a3MgYW5kIHVwZGF0ZSB0aGUgV2ViUGFnZVByb3h5IGFjY29yZGluZ2x5LiBOb3RlIHRoYXQgd2UK KyAgICAgICAgY291bGQgbm90IGRvIHRoaXMgZnJvbSB0aGUgc21hcnRfc2hvdyBhbmQgc21hcnRf aGlkZSBmdW5jdGlvbnMgd2UKKyAgICAgICAgYWxyZWFkeSBoYWQsIHNpbmNlIHRoZXkgYXJlIGNh bGxlZCBiZWZvcmUgdGhlIG9iamVjdCdzIGFjdHVhbAorICAgICAgICB2aXNpYmlsaXR5IGlzIHVw ZGF0ZWQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHA6CisgICAg ICAgIChfZXdrX3ZpZXdfb25fc2hvdyk6CisgICAgICAgIChfZXdrX3ZpZXdfb25faGlkZSk6Cisg ICAgICAgIChfZXdrX3ZpZXdfc21hcnRfYWRkKToKKwogMjAxMi0xMC0wOSAgU2ltb24gUGVuYSAg PHNwZW5hQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gQWRkIHN1cHBvcnQgZm9yIHJ1bm5p bmcgSmF2YVNjcmlwdCBmcm9tIEdSZXNvdXJjZXMKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHAJKHJldmlzaW9uIDEzMDc1NikKKysrIFNvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcAkod29ya2luZyBjb3B5KQpA QCAtMzYyLDYgKzM2MiwyMCBAQCBzdGF0aWMgdm9pZCBfZXdrX3ZpZXdfb25fa2V5X3VwKHZvaWQq IGRhCiAgICAgc21hcnREYXRhLT5hcGktPmtleV91cChzbWFydERhdGEsIHVwRXZlbnQpOwogfQog CitzdGF0aWMgdm9pZCBfZXdrX3ZpZXdfb25fc2hvdyh2b2lkKiBkYXRhLCBFdmFzKiwgRXZhc19P YmplY3QqLCB2b2lkKiAvKmV2ZW50SW5mbyovKQoreworICAgIEV3a19WaWV3X1NtYXJ0X0RhdGEq IHNtYXJ0RGF0YSA9IHN0YXRpY19jYXN0PEV3a19WaWV3X1NtYXJ0X0RhdGEqPihkYXRhKTsKKyAg ICBFV0tfVklFV19QUklWX0dFVF9PUl9SRVRVUk4oc21hcnREYXRhLCBwcml2KTsKKyAgICBwcml2 LT5wYWdlUHJveHktPnZpZXdTdGF0ZURpZENoYW5nZShXZWJQYWdlUHJveHk6OlZpZXdJc1Zpc2li bGUpOworfQorCitzdGF0aWMgdm9pZCBfZXdrX3ZpZXdfb25faGlkZSh2b2lkKiBkYXRhLCBFdmFz KiwgRXZhc19PYmplY3QqLCB2b2lkKiAvKmV2ZW50SW5mbyovKQoreworICAgIEV3a19WaWV3X1Nt YXJ0X0RhdGEqIHNtYXJ0RGF0YSA9IHN0YXRpY19jYXN0PEV3a19WaWV3X1NtYXJ0X0RhdGEqPihk YXRhKTsKKyAgICBFV0tfVklFV19QUklWX0dFVF9PUl9SRVRVUk4oc21hcnREYXRhLCBwcml2KTsK KyAgICBwcml2LT5wYWdlUHJveHktPnZpZXdTdGF0ZURpZENoYW5nZShXZWJQYWdlUHJveHk6OlZp ZXdJc1Zpc2libGUpOworfQorCiAjaWYgRU5BQkxFKFRPVUNIX0VWRU5UUykKIHN0YXRpYyBpbmxp bmUgdm9pZCBfZXdrX3ZpZXdfZmVlZF90b3VjaF9ldmVudF91c2luZ190b3VjaF9wb2ludF9saXN0 X29mX2V2YXMoRXZhc19PYmplY3QqIGV3a1ZpZXcsIEV3a19Ub3VjaF9FdmVudF9UeXBlIHR5cGUp CiB7CkBAIC00ODEsNiArNDk1LDggQEAgc3RhdGljIHZvaWQgX2V3a192aWV3X3NtYXJ0X2FkZChF dmFzX09iagogICAgIENPTk5FQ1QoRVZBU19DQUxMQkFDS19NT1VTRV9XSEVFTCwgX2V3a192aWV3 X29uX21vdXNlX3doZWVsKTsKICAgICBDT05ORUNUKEVWQVNfQ0FMTEJBQ0tfS0VZX0RPV04sIF9l d2tfdmlld19vbl9rZXlfZG93bik7CiAgICAgQ09OTkVDVChFVkFTX0NBTExCQUNLX0tFWV9VUCwg X2V3a192aWV3X29uX2tleV91cCk7CisgICAgQ09OTkVDVChFVkFTX0NBTExCQUNLX1NIT1csIF9l d2tfdmlld19vbl9zaG93KTsKKyAgICBDT05ORUNUKEVWQVNfQ0FMTEJBQ0tfSElERSwgX2V3a192 aWV3X29uX2hpZGUpOwogI3VuZGVmIENPTk5FQ1QKIH0KIAo= 167757 2012-10-09 07:57:53 -0700 2012-10-09 07:59:05 -0700 Patch bug-98757-20121009175519.patch text/plain 3403 rakuco SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMDc2MCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMyIEBACisyMDEyLTEwLTA5ICBSYXBoYWVs IEt1Ym8gZGEgQ29zdGEgIDxyYXBoYWVsLmt1Ym8uZGEuY29zdGFAaW50ZWwuY29tPgorCisgICAg ICAgIFtFRkxdW1dLMl0gSW5mb3JtIHRoZSBQYWdlUHJveHkgYWJvdXQgdmlzaWJpbGl0eSBjaGFu Z2VzIHdoZW4gdGhlIHZpZXcgaXMgc2hvd24vaGlkZGVuLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTg3NTcKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTVk4gcjEzMDcyMCBleHBvc2VkIGEgYnVnIGluIG91 ciBjb2RlOiB0aGUgUGFnZVByb3h5IGlzIG5vdAorICAgICAgICBub3RpZmllZCB3aGVuIG9uZSBj YWxscyBldmFzX29iamVjdF9zaG93KCkgb3IgZXZhc19vYmplY3RfaGlkZSgpCisgICAgICAgIG9u IHRoZSB2aWV3LCBzbyB0aGUgdmlzaWJpbGl0eSBpdCBoYXMgd2hlbiB0aGUgV2ViUGFnZVByb3h5 IGlzCisgICAgICAgIGNvbnN0cnVjdGVkIHJlbWFpbmVkIHNldCBmb3JldmVyLgorCisgICAgICAg IFRoaXMgbWFkZSB0aGUgZXdrX2NvbnRleHRfdmlicmF0aW9uX2NsaWVudF9jYWxsYmFja3Nfc2V0 IHVuaXQgdGVzdAorICAgICAgICBzdGFydCBydW5uaW5nIGZvcmV2ZXIsIGJlY2F1c2UgV2ViUGFn ZVByb3h5J3MgY29uc3RydWN0b3Igbm93IHNldHMKKyAgICAgICAgdGhlIHBhZ2UncyB2aXNpYmls aXR5IHRvIGhpZGRlbiBieSB0aGUgZGVmYXVsdCBmb3IgdXMsIHNpbmNlIGl0IGlzCisgICAgICAg IGNhbGxlZCBmcm9tIHdpdGhpbiBld2tfdmlld19zbWFydF9hZGQoKSBhbmQgYmVmb3JlCisgICAg ICAgIGV2YXNfb2JqZWN0X3Nob3coKS4KKworICAgICAgICBXZSBub3cgbGlzdGVuIHRvIHRoZSBF VkFTX0NBTExCQUNLX1NIT1cgYW5kIEVWQVNfQ0FMTEJBQ0tfSElERQorICAgICAgICBjYWxsYmFj a3MgYW5kIHVwZGF0ZSB0aGUgV2ViUGFnZVByb3h5IGFjY29yZGluZ2x5LiBOb3RlIHRoYXQgd2UK KyAgICAgICAgY291bGQgbm90IGRvIHRoaXMgZnJvbSB0aGUgc21hcnRfc2hvdyBhbmQgc21hcnRf aGlkZSBmdW5jdGlvbnMgd2UKKyAgICAgICAgYWxyZWFkeSBoYWQsIHNpbmNlIHRoZXkgYXJlIGNh bGxlZCBiZWZvcmUgdGhlIG9iamVjdCdzIGFjdHVhbAorICAgICAgICB2aXNpYmlsaXR5IGlzIHVw ZGF0ZWQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHA6CisgICAg ICAgIChfZXdrX3ZpZXdfb25fc2hvdyk6CisgICAgICAgIChfZXdrX3ZpZXdfb25faGlkZSk6Cisg ICAgICAgIChfZXdrX3ZpZXdfc21hcnRfYWRkKToKKwogMjAxMi0xMC0wOSAgU2ltb24gUGVuYSAg PHNwZW5hQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gQWRkIHN1cHBvcnQgZm9yIHJ1bm5p bmcgSmF2YVNjcmlwdCBmcm9tIEdSZXNvdXJjZXMKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHAJKHJldmlzaW9uIDEzMDc1NikKKysrIFNvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcAkod29ya2luZyBjb3B5KQpA QCAtMzYyLDYgKzM2MiwyNCBAQCBzdGF0aWMgdm9pZCBfZXdrX3ZpZXdfb25fa2V5X3VwKHZvaWQq IGRhCiAgICAgc21hcnREYXRhLT5hcGktPmtleV91cChzbWFydERhdGEsIHVwRXZlbnQpOwogfQog CitzdGF0aWMgdm9pZCBfZXdrX3ZpZXdfb25fc2hvdyh2b2lkKiBkYXRhLCBFdmFzKiwgRXZhc19P YmplY3QqLCB2b2lkKiAvKmV2ZW50SW5mbyovKQoreworICAgIEV3a19WaWV3X1NtYXJ0X0RhdGEq IHNtYXJ0RGF0YSA9IHN0YXRpY19jYXN0PEV3a19WaWV3X1NtYXJ0X0RhdGEqPihkYXRhKTsKKyAg ICBFV0tfVklFV19QUklWX0dFVF9PUl9SRVRVUk4oc21hcnREYXRhLCBwcml2KTsKKyAgICBwcml2 LT5wYWdlUHJveHktPnZpZXdTdGF0ZURpZENoYW5nZShXZWJQYWdlUHJveHk6OlZpZXdJc1Zpc2li bGUpOworfQorCitzdGF0aWMgdm9pZCBfZXdrX3ZpZXdfb25faGlkZSh2b2lkKiBkYXRhLCBFdmFz KiwgRXZhc19PYmplY3QqLCB2b2lkKiAvKmV2ZW50SW5mbyovKQoreworICAgIEV3a19WaWV3X1Nt YXJ0X0RhdGEqIHNtYXJ0RGF0YSA9IHN0YXRpY19jYXN0PEV3a19WaWV3X1NtYXJ0X0RhdGEqPihk YXRhKTsKKyAgICBFV0tfVklFV19QUklWX0dFVF9PUl9SRVRVUk4oc21hcnREYXRhLCBwcml2KTsK KworICAgIC8vIFRoaXMgY2FsbCBtYXkgbG9vayB3cm9uZywgYnV0IHdlIHJlYWxseSBuZWVkIHRv IHBhc3MgVmlld0lzVmlzaWJsZSBoZXJlLgorICAgIC8vIHZpZXdTdGF0ZURpZENoYW5nZSgpIGl0 c2VsZiBpcyByZXNwb25zaWJsZSBmb3IgYWN0dWFsbHkgc2V0dGluZyB0aGUgdmlzaWJpbGl0eSB0 byBWaXNpYmxlIG9yIEhpZGRlbgorICAgIC8vIGRlcGVuZGluZyBvbiB3aGF0IFdlYlBhZ2VQcm94 eTo6aXNWaWV3VmlzaWJsZSgpIHJldHVybnMsIHRoaXMgc2ltcGx5IHRyaWdnZXJzIHRoZSBwcm9j ZXNzLgorICAgIHByaXYtPnBhZ2VQcm94eS0+dmlld1N0YXRlRGlkQ2hhbmdlKFdlYlBhZ2VQcm94 eTo6Vmlld0lzVmlzaWJsZSk7Cit9CisKICNpZiBFTkFCTEUoVE9VQ0hfRVZFTlRTKQogc3RhdGlj IGlubGluZSB2b2lkIF9ld2tfdmlld19mZWVkX3RvdWNoX2V2ZW50X3VzaW5nX3RvdWNoX3BvaW50 X2xpc3Rfb2ZfZXZhcyhFdmFzX09iamVjdCogZXdrVmlldywgRXdrX1RvdWNoX0V2ZW50X1R5cGUg dHlwZSkKIHsKQEAgLTQ4MSw2ICs0OTksOCBAQCBzdGF0aWMgdm9pZCBfZXdrX3ZpZXdfc21hcnRf YWRkKEV2YXNfT2JqCiAgICAgQ09OTkVDVChFVkFTX0NBTExCQUNLX01PVVNFX1dIRUVMLCBfZXdr X3ZpZXdfb25fbW91c2Vfd2hlZWwpOwogICAgIENPTk5FQ1QoRVZBU19DQUxMQkFDS19LRVlfRE9X TiwgX2V3a192aWV3X29uX2tleV9kb3duKTsKICAgICBDT05ORUNUKEVWQVNfQ0FMTEJBQ0tfS0VZ X1VQLCBfZXdrX3ZpZXdfb25fa2V5X3VwKTsKKyAgICBDT05ORUNUKEVWQVNfQ0FMTEJBQ0tfU0hP VywgX2V3a192aWV3X29uX3Nob3cpOworICAgIENPTk5FQ1QoRVZBU19DQUxMQkFDS19ISURFLCBf ZXdrX3ZpZXdfb25faGlkZSk7CiAjdW5kZWYgQ09OTkVDVAogfQogCg==