98738 2012-10-09 03:46:34 -0700 REGRESSION (r130640 - r130644): TestCookieManager API test is failing 2012-10-19 02:18:26 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk, Regression P2 Normal --- 1 zan webkit-unassigned cgarcia gustavo mrobinson webkit.review.bot oldest_to_newest 737619 0 zan 2012-10-09 03:46:34 -0700 The TestCookieManager API test case is failing. TEST: ./Tools/gtk/../Scripts/../../WebKitBuild/Release/Programs/WebKit2APITests/TestCookieManager... (pid=7994) /webkit2/WebKitCookieManager/accept-policy: ** ERROR:../../Source/WebKit2/UIProcess/API/gtk/tests/TestCookieManager.cpp:181:void testCookieManagerAcceptPolicy(CookieManagerTest*, gconstpointer): assertion failed (domains[0] == kFirstPartyDomain): ("localhost" == "127.0.0.1") FAIL First occurrence on 64-bit Release builder, r130640-r130644: http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release/builds/29516 First occurrence on 64-bit Debug builder, r130643-r130645: http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug/builds/37403 Perhaps r130643 is to blame, I'm not sure though. http://trac.webkit.org/changeset/130643 737632 1 zan 2012-10-09 04:06:02 -0700 Skipped the specific test case in r130748. http://trac.webkit.org/changeset/130748 746147 2 169580 cgarcia 2012-10-19 02:10:20 -0700 Created attachment 169580 Patch 746150 3 webkit.review.bot 2012-10-19 02:11:43 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 746152 4 cgarcia 2012-10-19 02:18:26 -0700 Committed r131876: <http://trac.webkit.org/changeset/131876> 169580 2012-10-19 02:10:20 -0700 2012-10-19 02:12:07 -0700 Patch wk2-cookies-test.diff text/plain 4017 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBkMTFjNWJlLi4zNTg1YzJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTItMTAtMTkgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFJFR1JFU1NJT04gKHIxMzA2NDAgLSByMTMwNjQ0KTogVGVzdENvb2tpZU1h bmFnZXIgQVBJIHRlc3QgaXMgZmFpbGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9OTg3MzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBGb3Igc29tZSByZWFzb24gdGhlIG9yZGVyIG9mIHRoZSBkb21haW5z IGluIHRoZSBhcnJheSBoYXMgY2hhbmdlZCwKKyAgICAgICAgYnV0IGl0IGRvZXNuJ3QgcmVhbGx5 IG1hdHRlciwgd2hhdCB3ZSB3YW50IHRvIGNoZWNrIGlzIHRoYXQgYm90aAorICAgICAgICBjb29r aWVzIGhhdmUgYmVlbiBhY2NlcHRlZCBhbmQgdGhlIGFycmF5IGNvbnRhaW5zIGJvdGggZG9tYWlu cy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL3Rlc3RzL1Rlc3RDb29raWVNYW5hZ2Vy LmNwcDoKKyAgICAgICAgKHRlc3RDb29raWVNYW5hZ2VyQWNjZXB0UG9saWN5KTogQ2hlY2sgdGhh dCBmaXJzdCBhbmQgdGhpcmQgcGFydHkKKyAgICAgICAgZG9tYWlucyBhcmUgcHJlc2VudCBpbiB0 aGUgZG9tYWlucyBhcnJheS4KKwogMjAxMi0xMC0xOCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxj Z2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgV2ViUGFnZVByb3h5OjpjYW5TaG93TUlNRVR5 cGUoKSBzaG91bGQgcmV0dXJuIGZhbHNlIGZvciBwbHVnaW5zIHdoZW4gdGhleSBhcmUgZGlzYWJs ZWQKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA0 NmJkZDk5Li44MzdmMWU5IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTItMTAtMTkgIENhcmxvcyBHYXJjaWEgQ2Ft cG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIxMzA2NDAg LSByMTMwNjQ0KTogVGVzdENvb2tpZU1hbmFnZXIgQVBJIHRlc3QgaXMgZmFpbGluZworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTg3MzgKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvcnVuLWd0 ay10ZXN0czoKKyAgICAgICAgKFRlc3RSdW5uZXIpOiBVbnNraXAgL3dlYmtpdDIvV2ViS2l0Q29v a2llTWFuYWdlci9hY2NlcHQtcG9saWN5LgorCiAyMDEyLTEwLTE4ICBEaXJrIFByYW5rZSAgPGRw cmFua2VAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIG1ha2UgbW92ZV9vdmVyd3JpdHRlbl9iYXNl bGluZXNfdG8gd29yayBhZ2FpbiB3aGlsZSByZWJhc2VsaW5pbmcKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL3Rlc3RzL1Rlc3RDb29raWVNYW5hZ2VyLmNwcCBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL3Rlc3RzL1Rlc3RDb29raWVNYW5hZ2Vy LmNwcAppbmRleCA5NGFlZWY2Li5hZGM2YjViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL2d0ay90ZXN0cy9UZXN0Q29va2llTWFuYWdlci5jcHAKKysrIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvdGVzdHMvVGVzdENvb2tpZU1hbmFnZXIuY3BwCkBA IC0xMzIsNiArMTMyLDE3IEBAIHB1YmxpYzoKICAgICAgICAgcmV0dXJuIG1fZG9tYWluczsKICAg ICB9CiAKKyAgICBib29sIGhhc0RvbWFpbihjb25zdCBjaGFyKiBkb21haW4pCisgICAgeworICAg ICAgICBpZiAoIW1fZG9tYWlucykKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKworICAgICAg ICBmb3IgKHNpemVfdCBpID0gMDsgbV9kb21haW5zW2ldOyArK2kpCisgICAgICAgICAgICBpZiAo Z19zdHJfZXF1YWwobV9kb21haW5zW2ldLCBkb21haW4pKQorICAgICAgICAgICAgICAgIHJldHVy biB0cnVlOworICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgfQorCiAgICAgdm9pZCBkZWxldGVD b29raWVzRm9yRG9tYWluKGNvbnN0IGNoYXIqIGRvbWFpbikKICAgICB7CiAgICAgICAgIHdlYmtp dF9jb29raWVfbWFuYWdlcl9kZWxldGVfY29va2llc19mb3JfZG9tYWluKG1fY29va2llTWFuYWdl ciwgZG9tYWluKTsKQEAgLTE3OCw4ICsxODksOCBAQCBzdGF0aWMgdm9pZCB0ZXN0Q29va2llTWFu YWdlckFjY2VwdFBvbGljeShDb29raWVNYW5hZ2VyVGVzdCogdGVzdCwgZ2NvbnN0cG9pbnRlcgog ICAgIGRvbWFpbnMgPSB0ZXN0LT5nZXREb21haW5zKCk7CiAgICAgZ19hc3NlcnQoZG9tYWlucyk7 CiAgICAgZ19hc3NlcnRfY21waW50KGdfc3Rydl9sZW5ndGgoZG9tYWlucyksID09LCAyKTsKLSAg ICBnX2Fzc2VydF9jbXBzdHIoZG9tYWluc1swXSwgPT0sIGtGaXJzdFBhcnR5RG9tYWluKTsKLSAg ICBnX2Fzc2VydF9jbXBzdHIoZG9tYWluc1sxXSwgPT0sIGtUaGlyZFBhcnR5RG9tYWluKTsKKyAg ICBnX2Fzc2VydCh0ZXN0LT5oYXNEb21haW4oa0ZpcnN0UGFydHlEb21haW4pKTsKKyAgICBnX2Fz c2VydCh0ZXN0LT5oYXNEb21haW4oa1RoaXJkUGFydHlEb21haW4pKTsKICAgICB0ZXN0LT5kZWxl dGVBbGxDb29raWVzKCk7CiAKICAgICB0ZXN0LT5zZXRBY2NlcHRQb2xpY3koV0VCS0lUX0NPT0tJ RV9QT0xJQ1lfQUNDRVBUX05FVkVSKTsKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvcnVuLWd0 ay10ZXN0cyBiL1Rvb2xzL1NjcmlwdHMvcnVuLWd0ay10ZXN0cwppbmRleCA5YmMxMGE0Li4xMjc2 NTk2IDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3J1bi1ndGstdGVzdHMKKysrIGIvVG9vbHMv U2NyaXB0cy9ydW4tZ3RrLXRlc3RzCkBAIC02OCw3ICs2OCw2IEBAIGNsYXNzIFRlc3RSdW5uZXI6 CiAgICAgICAgIFNraXBwZWRUZXN0KCJXZWJLaXQyQVBJVGVzdHMvVGVzdFdlYktpdFdlYlZpZXci LCAiL3dlYmtpdDIvV2ViS2l0V2ViVmlldy9tb3VzZS10YXJnZXQiLCAiVGVzdCBpcyBmbGFreSBp biBHVEsgTGludXggMzItYml0IFJlbGVhc2UgYm90IiwgODI4NjYpLAogICAgICAgICBTa2lwcGVk VGVzdCgiV2ViS2l0MkFQSVRlc3RzL1Rlc3RSZXNvdXJjZXMiLCAiL3dlYmtpdDIvV2ViS2l0V2Vi Vmlldy9yZXNvdXJjZXMiLCAiVGVzdCBpcyBmbGFreSBpbiBHVEsgTGludXggMzItYml0IFJlbGVh c2UgYm90IiwgODI4NjgpLAogICAgICAgICBTa2lwcGVkVGVzdCgiV2ViS2l0MkFQSVRlc3RzL1Rl c3RXZWJLaXRGaW5kQ29udHJvbGxlciIsICIvd2Via2l0Mi9XZWJLaXRGaW5kQ29udHJvbGxlci9o aWRlIiwgIlRlc3QgIGFsd2F5cyBmYWlscyBpbiBYdmZiIiwgODk4MTApLAotICAgICAgICBTa2lw cGVkVGVzdCgiV2ViS2l0MkFQSVRlc3RzL1Rlc3RDb29raWVNYW5hZ2VyIiwgIi93ZWJraXQyL1dl YktpdENvb2tpZU1hbmFnZXIvYWNjZXB0LXBvbGljeSIsICJUZXN0IGZhaWxzIiwgOTg3MzgpLAog ICAgICAgICBTa2lwcGVkVGVzdCgiVGVzdFdlYktpdEFQSS9UZXN0V2ViS2l0MiIsICJXZWJLaXQy LldLQ29ubmVjdGlvbiIsICJUZXN0cyBmYWlsIGFuZCB0aW1lIG91dCBvdXQiLCA4NDk1OSksCiAg ICAgICAgIFNraXBwZWRUZXN0KCJUZXN0V2ViS2l0QVBJL1Rlc3RXZWJLaXQyIiwgIldlYktpdDIu UmVzdG9yZVNlc3Npb25TdGF0ZUNvbnRhaW5pbmdGb3JtRGF0YSIsICJTZXNzaW9uIFN0YXRlIGlz IG5vdCBpbXBsZW1lbnRlZCBpbiBHVEsrIHBvcnQiLCA4NDk2MCksCiAgICAgICAgIFNraXBwZWRU ZXN0KCJUZXN0V2ViS2l0QVBJL1Rlc3RXZWJLaXQyIiwgIldlYktpdDIuU3BhY2ViYXJTY3JvbGxp bmciLCAiVGVzdCBmYWlscyIsIDg0OTYxKSwK