98731 2012-10-09 02:04:56 -0700 [GTK] Test /webkit2/WebKitWebView/history-cache asserts in debug bot 2012-10-10 04:16:18 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned gustavo mrobinson webkit.review.bot oldest_to_newest 737564 0 cgarcia 2012-10-09 02:04:56 -0700 I think the problem is in the test itself that uses the SingleResourceLoadTest to load a multiresource document. 737568 1 167713 cgarcia 2012-10-09 02:09:06 -0700 Created attachment 167713 Patch I'm unable to reproduce the assertion, so I'm not sure the patch will fix it. 737571 2 cgarcia 2012-10-09 02:10:12 -0700 Btw, the assertion is this one: /webkit2/WebKitWebView/history-cache: ASSERTION FAILED: m_loadState == LoadStateCommitted ../../Source/WebKit2/UIProcess/WebFrameProxy.cpp(176) : void WebKit::WebFrameProxy::didFinishLoad() 737574 3 webkit.review.bot 2012-10-09 02:11:20 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 738829 4 cgarcia 2012-10-10 04:16:18 -0700 Committed r130886: <http://trac.webkit.org/changeset/130886> 167713 2012-10-09 02:09:06 -0700 2012-10-09 08:09:07 -0700 Patch wk2-resources-test-assertion.diff text/plain 4087 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA5ZGYzMzcwLi4xYjVjZWQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTItMTAtMDkgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIFRlc3QgL3dlYmtpdDIvV2ViS2l0V2ViVmlldy9oaXN0b3J5LWNh Y2hlIGFzc2VydHMgaW4gZGVidWcgYm90CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD05ODczMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFRoZSBwcm9ibGVtIGlzIGluIHRoZSB0ZXN0IGl0c2VsZiB0aGF0IGlz IHVzaW5nCisgICAgICAgIFNpbmdsZVJlc291cmNlTG9hZFRlc3QgY2xhc3MgdG8gbG9hZCBhIG11 bHRpcmVzb3VyY2UgZG9jdW1lbnQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay90ZXN0 cy9UZXN0UmVzb3VyY2VzLmNwcDoKKyAgICAgICAgKHRlc3RXZWJWaWV3UmVzb3VyY2VzSGlzdG9y eUNhY2hlKTogTG9hZCBvbmx5IHNpbmdsZSByZXNvdXJjZQorICAgICAgICBkb2N1bWVudHMgYW5k IGNoZWNrIGFsc28gdGhhdCB0aGUgbWFpbiByZXNvdXJjZSBnaXZlbiBpcyB0aGUKKyAgICAgICAg ZXhwZWN0ZWQgb25lLgorICAgICAgICAoc2VydmVyQ2FsbGJhY2spOiBBZGQgYW5vdGhlciBzaW5n bGUgcmVzb3VyY2UgZG9jdW1lbnQuCisKIDIwMTItMTAtMDggIENhcmxvcyBHYXJjaWEgQ2FtcG9z ICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIEFkZCBhIHNldHRpbmcgdG8g ZW5hYmxlL2Rpc2FibGUgc21vb3RoIHNjcm9sbGluZyB0byBXZWJLaXQyIEdUSysgQVBJCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay90ZXN0cy9UZXN0UmVzb3Vy Y2VzLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL3Rlc3RzL1Rlc3RSZXNv dXJjZXMuY3BwCmluZGV4IDAwMjBmMGIuLjIwYjkwYjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL3Rlc3RzL1Rlc3RSZXNvdXJjZXMuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL3Rlc3RzL1Rlc3RSZXNvdXJjZXMuY3BwCkBAIC01 MTIsMjEgKzUxMiwzMSBAQCBzdGF0aWMgdm9pZCB0ZXN0V2ViUmVzb3VyY2VHZXREYXRhKFJlc291 cmNlc1Rlc3QqIHRlc3QsIGdjb25zdHBvaW50ZXIpCiAKIHN0YXRpYyB2b2lkIHRlc3RXZWJWaWV3 UmVzb3VyY2VzSGlzdG9yeUNhY2hlKFNpbmdsZVJlc291cmNlTG9hZFRlc3QqIHRlc3QsIGdjb25z dHBvaW50ZXIpCiB7Ci0gICAgdGVzdC0+bG9hZFVSSShrU2VydmVyLT5nZXRVUklGb3JQYXRoKCIv IikuZGF0YSgpKTsKKyAgICBDU3RyaW5nIGphdmFzY3JpcHRVUkkgPSBrU2VydmVyLT5nZXRVUklG b3JQYXRoKCIvamF2YXNjcmlwdC5odG1sIik7CisgICAgdGVzdC0+bG9hZFVSSShqYXZhc2NyaXB0 VVJJLmRhdGEoKSk7CiAgICAgdGVzdC0+d2FpdFVudGlsUmVzb3VyY2VMb2FkRmluaXNoZWQoKTsK LSAgICBnX2Fzc2VydCh3ZWJraXRfd2ViX3ZpZXdfZ2V0X21haW5fcmVzb3VyY2UodGVzdC0+bV93 ZWJWaWV3KSk7CisgICAgV2ViS2l0V2ViUmVzb3VyY2UqIHJlc291cmNlID0gd2Via2l0X3dlYl92 aWV3X2dldF9tYWluX3Jlc291cmNlKHRlc3QtPm1fd2ViVmlldyk7CisgICAgZ19hc3NlcnQocmVz b3VyY2UpOworICAgIGdfYXNzZXJ0X2NtcHN0cih3ZWJraXRfd2ViX3Jlc291cmNlX2dldF91cmko cmVzb3VyY2UpLCA9PSwgamF2YXNjcmlwdFVSSS5kYXRhKCkpOwogCi0gICAgdGVzdC0+bG9hZFVS SShrU2VydmVyLT5nZXRVUklGb3JQYXRoKCIvamF2YXNjcmlwdC5odG1sIikuZGF0YSgpKTsKKyAg ICBDU3RyaW5nIHNpbXBsZVN0eWxlQ1NTVVJJID0ga1NlcnZlci0+Z2V0VVJJRm9yUGF0aCgiL3Np bXBsZS1zdHlsZS1jc3MuaHRtbCIpOworICAgIHRlc3QtPmxvYWRVUkkoc2ltcGxlU3R5bGVDU1NV UkkuZGF0YSgpKTsKICAgICB0ZXN0LT53YWl0VW50aWxSZXNvdXJjZUxvYWRGaW5pc2hlZCgpOwot ICAgIGdfYXNzZXJ0KHdlYmtpdF93ZWJfdmlld19nZXRfbWFpbl9yZXNvdXJjZSh0ZXN0LT5tX3dl YlZpZXcpKTsKKyAgICByZXNvdXJjZSA9IHdlYmtpdF93ZWJfdmlld19nZXRfbWFpbl9yZXNvdXJj ZSh0ZXN0LT5tX3dlYlZpZXcpOworICAgIGdfYXNzZXJ0KHJlc291cmNlKTsKKyAgICBnX2Fzc2Vy dF9jbXBzdHIod2Via2l0X3dlYl9yZXNvdXJjZV9nZXRfdXJpKHJlc291cmNlKSwgPT0sIHNpbXBs ZVN0eWxlQ1NTVVJJLmRhdGEoKSk7CiAKICAgICB0ZXN0LT5nb0JhY2soKTsKICAgICB0ZXN0LT53 YWl0VW50aWxSZXNvdXJjZUxvYWRGaW5pc2hlZCgpOwotICAgIGdfYXNzZXJ0KHdlYmtpdF93ZWJf dmlld19nZXRfbWFpbl9yZXNvdXJjZSh0ZXN0LT5tX3dlYlZpZXcpKTsKKyAgICByZXNvdXJjZSA9 IHdlYmtpdF93ZWJfdmlld19nZXRfbWFpbl9yZXNvdXJjZSh0ZXN0LT5tX3dlYlZpZXcpOworICAg IGdfYXNzZXJ0KHJlc291cmNlKTsKKyAgICBnX2Fzc2VydF9jbXBzdHIod2Via2l0X3dlYl9yZXNv dXJjZV9nZXRfdXJpKHJlc291cmNlKSwgPT0sIGphdmFzY3JpcHRVUkkuZGF0YSgpKTsKIAogICAg IHRlc3QtPmdvRm9yd2FyZCgpOwogICAgIHRlc3QtPndhaXRVbnRpbFJlc291cmNlTG9hZEZpbmlz aGVkKCk7Ci0gICAgZ19hc3NlcnQod2Via2l0X3dlYl92aWV3X2dldF9tYWluX3Jlc291cmNlKHRl c3QtPm1fd2ViVmlldykpOworICAgIHJlc291cmNlID0gd2Via2l0X3dlYl92aWV3X2dldF9tYWlu X3Jlc291cmNlKHRlc3QtPm1fd2ViVmlldyk7CisgICAgZ19hc3NlcnQocmVzb3VyY2UpOworICAg IGdfYXNzZXJ0X2NtcHN0cih3ZWJraXRfd2ViX3Jlc291cmNlX2dldF91cmkocmVzb3VyY2UpLCA9 PSwgc2ltcGxlU3R5bGVDU1NVUkkuZGF0YSgpKTsKIH0KIAogc3RhdGljIHZvaWQgYWRkQ2FjaGVI VFRQSGVhZGVyc1RvUmVzcG9uc2UoU291cE1lc3NhZ2UqIG1lc3NhZ2UpCkBAIC01NzIsNiArNTgy LDkgQEAgc3RhdGljIHZvaWQgc2VydmVyQ2FsbGJhY2soU291cFNlcnZlciogc2VydmVyLCBTb3Vw TWVzc2FnZSogbWVzc2FnZSwgY29uc3QgY2hhcioKICAgICB9IGVsc2UgaWYgKGdfc3RyX2VxdWFs KHBhdGgsICIvaW52YWxpZC1jc3MuaHRtbCIpKSB7CiAgICAgICAgIHN0YXRpYyBjb25zdCBjaGFy KiBpbnZhbGlkQ1NTSHRtbCA9ICI8aHRtbD48aGVhZD48bGluayByZWw9J3N0eWxlc2hlZXQnIGhy ZWY9Jy9pbnZhbGlkLmNzcycgdHlwZT0ndGV4dC9jc3MnPjwvaGVhZD48Ym9keT48L2h0bWw+IjsK ICAgICAgICAgc291cF9tZXNzYWdlX2JvZHlfYXBwZW5kKG1lc3NhZ2UtPnJlc3BvbnNlX2JvZHks IFNPVVBfTUVNT1JZX1NUQVRJQywgaW52YWxpZENTU0h0bWwsIHN0cmxlbihpbnZhbGlkQ1NTSHRt bCkpOworICAgIH0gZWxzZSBpZiAoZ19zdHJfZXF1YWwocGF0aCwgIi9zaW1wbGUtc3R5bGUtY3Nz Lmh0bWwiKSkgeworICAgICAgICBzdGF0aWMgY29uc3QgY2hhciogc2ltcGxlU3R5bGVDU1NIdG1s ID0gIjxodG1sPjxoZWFkPjxsaW5rIHJlbD0nc3R5bGVzaGVldCcgaHJlZj0nL3NpbXBsZS1zdHls ZS5jc3MnIHR5cGU9J3RleHQvY3NzJz48L2hlYWQ+PGJvZHk+PC9odG1sPiI7CisgICAgICAgIHNv dXBfbWVzc2FnZV9ib2R5X2FwcGVuZChtZXNzYWdlLT5yZXNwb25zZV9ib2R5LCBTT1VQX01FTU9S WV9TVEFUSUMsIHNpbXBsZVN0eWxlQ1NTSHRtbCwgc3RybGVuKHNpbXBsZVN0eWxlQ1NTSHRtbCkp OwogICAgIH0gZWxzZSBpZiAoZ19zdHJfZXF1YWwocGF0aCwgIi9zdHlsZS5jc3MiKSkgewogICAg ICAgICBzb3VwX21lc3NhZ2VfYm9keV9hcHBlbmQobWVzc2FnZS0+cmVzcG9uc2VfYm9keSwgU09V UF9NRU1PUllfU1RBVElDLCBrU3R5bGVDU1MsIHN0cmxlbihrU3R5bGVDU1MpKTsKICAgICAgICAg YWRkQ2FjaGVIVFRQSGVhZGVyc1RvUmVzcG9uc2UobWVzc2FnZSk7Cg==