98726 2012-10-08 23:36:49 -0700 [EFL][EWebLauncher] Add encoding detector option. 2012-10-15 10:06:40 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 61744 1 kangil.han kangil.han gyuyoung.kim kenneth laszlo.gombos lucas.de.marchi rakuco ryuan.choi webkit.review.bot oldest_to_newest 737461 0 kangil.han 2012-10-08 23:36:49 -0700 We need this to test WebCore's encoding detector functionality. 737464 1 167698 kangil.han 2012-10-08 23:43:44 -0700 Created attachment 167698 patch 737508 2 ryuan.choi 2012-10-09 01:08:17 -0700 (In reply to comment #1) > Created an attachment (id=167698) [details] > patch LGTM 737520 3 167698 gyuyoung.kim 2012-10-09 01:21:48 -0700 Comment on attachment 167698 patch View in context: https://bugs.webkit.org/attachment.cgi?id=167698&action=review > Tools/EWebLauncher/main.c:151 > + Eina_Bool enableEncodingDetector; Alphabetical order ? > Tools/EWebLauncher/main.c:917 > + userArgs->enableEncodingDetector = EINA_FALSE; ditto ? > Tools/EWebLauncher/main.c:931 > + ECORE_GETOPT_VALUE_BOOL(userArgs->enableEncodingDetector), ditto ? 737669 4 167735 kangil.han 2012-10-09 04:49:51 -0700 Created attachment 167735 patch Done~ 737670 5 167735 kenneth 2012-10-09 04:51:22 -0700 Comment on attachment 167735 patch View in context: https://bugs.webkit.org/attachment.cgi?id=167735&action=review > Tools/ChangeLog:10 > + > + Added an option to test WebCore's encoding detector functionality on EWebLauncher. > + With this patch, EWebLauncher would display text correctly even if web page wouldn't specify charset information. > + Why isnt this default? and what about WebKit2, isn't that our target? 737675 6 kangil.han 2012-10-09 04:57:22 -0700 (In reply to comment #5) > Why isnt this default? Would you like to enable this functionality by default? > and what about WebKit2, isn't that our target? Yuni Jeong has prepared to create a patch for adding a setting API to enable encoding detector. I will follow up after her in MiniBrowser. :-) 737677 7 kenneth 2012-10-09 04:59:22 -0700 (In reply to comment #6) > (In reply to comment #5) > > Why isnt this default? > > Would you like to enable this functionality by default? Is there any reason not to? When don't you want this? 737678 8 ryuan.choi 2012-10-09 05:03:44 -0700 (In reply to comment #7) > (In reply to comment #6) > > (In reply to comment #5) > > > Why isnt this default? > > > > Would you like to enable this functionality by default? > > Is there any reason not to? When don't you want this? In Bug 61744, it was disabled to pass dom/xhtml/level3/core/documentgetinputencoding01.xhtml 737694 9 kangil.han 2012-10-09 05:27:23 -0700 (In reply to comment #8) > In Bug 61744, it was disabled to pass dom/xhtml/level3/core/documentgetinputencoding01.xhtml Thanks for this information. I didn't know that. :-) 737695 10 gyuyoung.kim 2012-10-09 05:29:32 -0700 (In reply to comment #9) > (In reply to comment #8) > > In Bug 61744, it was disabled to pass dom/xhtml/level3/core/documentgetinputencoding01.xhtml > > Thanks for this information. I didn't know that. :-) Ok, let's decide to land this patch according to Bug 61744 direction. 740651 11 kangil.han 2012-10-11 23:28:49 -0700 (In reply to comment #7) > Is there any reason not to? When don't you want this? Here is interesting result of layout test when enable/disable encoding auto detection by default. If we enable encoding auto detection, then will have additional 125 failed test cases. FYI, this test has been done on my desktop, Ubuntu 12.04 64 bit debug build. Given circumstance, let's use encoding detector as an optional functionality. :) p.s. It seems other ports off this as default. 742131 12 167735 webkit.review.bot 2012-10-15 10:06:35 -0700 Comment on attachment 167735 patch Clearing flags on attachment: 167735 Committed r131312: <http://trac.webkit.org/changeset/131312> 742132 13 webkit.review.bot 2012-10-15 10:06:40 -0700 All reviewed patches have been landed. Closing bug. 167698 2012-10-08 23:43:44 -0700 2012-10-09 04:49:51 -0700 patch eweblauncher_encoding_detector_1.txt text/plain 2971 kangil.han ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA2NDg5 MmMyLi5kYmYwZDRiIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTItMTAtMDggIEthbmdpbCBIYW4gIDxrYW5naWwu aGFuQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdW0VXZWJMYXVuY2hlcl0gQWRkIGVuY29k aW5nIGRldGVjdG9yIG9wdGlvbi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTk4NzI2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQWRkZWQgYW4gb3B0aW9uIHRvIHRlc3QgV2ViQ29yZSdzIGVuY29kaW5nIGRl dGVjdG9yIGZ1bmN0aW9uYWxpdHkgb24gRVdlYkxhdW5jaGVyLgorICAgICAgICBXaXRoIHRoaXMg cGF0Y2gsIEVXZWJMYXVuY2hlciB3b3VsZCBkaXNwbGF5IHRleHQgY29ycmVjdGx5IGV2ZW4gaWYg d2ViIHBhZ2Ugd291bGRuJ3Qgc3BlY2lmeSBjaGFyc2V0IGluZm9ybWF0aW9uLgorCisgICAgICAg ICogRVdlYkxhdW5jaGVyL21haW4uYzoKKyAgICAgICAgKF9Vc2VyX0FyZ3VtZW50cyk6CisgICAg ICAgICh3aW5kb3dDcmVhdGUpOgorICAgICAgICAocGFyc2VVc2VyQXJndW1lbnRzKToKKwogMjAx Mi0xMC0wOCAgUnl1YW4gQ2hvaSAgPHJ5dWFuLmNob2lAc2Ftc3VuZy5jb20+CiAKICAgICAgICAg W0VGTF0gQnVpbGQgQ29udHJvbFRoZW1lIG9ubHkgd2hlbiBuZWNlc3NhcnkKZGlmZiAtLWdpdCBh L1Rvb2xzL0VXZWJMYXVuY2hlci9tYWluLmMgYi9Ub29scy9FV2ViTGF1bmNoZXIvbWFpbi5jCmlu ZGV4IGZlNzEwOGUuLmNhZTM5NTggMTAwNjQ0Ci0tLSBhL1Rvb2xzL0VXZWJMYXVuY2hlci9tYWlu LmMKKysrIGIvVG9vbHMvRVdlYkxhdW5jaGVyL21haW4uYwpAQCAtMTE5LDYgKzExOSw4IEBAIHN0 YXRpYyBjb25zdCBFY29yZV9HZXRvcHQgb3B0aW9ucyA9IHsKICAgICAgICAgICAgICgnZicsICJm bGF0dGVuaW5nIiwgImZyYW1lIGZsYXR0ZW5pbmcuIiwgMCksCiAgICAgICAgIEVDT1JFX0dFVE9Q VF9TVE9SRV9ERUZfQk9PTAogICAgICAgICAgICAgKCdGJywgImZ1bGxzY3JlZW4iLCAiZnVsbHNj cmVlbiBtb2RlLiIsIDApLAorICAgICAgICBFQ09SRV9HRVRPUFRfU1RPUkVfREVGX0JPT0wKKyAg ICAgICAgICAgICgnYycsICJlbmNvZGluZy1kZXRlY3RvciIsICJlbmFibGUvZGlzYWJsZSBlbmNv ZGluZyBkZXRlY3RvciIsIDApLAogICAgICAgICBFQ09SRV9HRVRPUFRfQ0FMTEJBQ0tfQVJHUwog ICAgICAgICAgICAgKCdnJywgImdlb21ldHJ5IiwgImdlb21ldHJ5IHRvIHVzZSBpbiB4Onk6dzpo IGZvcm0uIiwgIlg6WTpXOkgiLAogICAgICAgICAgICAgIGVjb3JlX2dldG9wdF9jYWxsYmFja19n ZW9tZXRyeV9wYXJzZSwgTlVMTCksCkBAIC0xNDYsNiArMTQ4LDcgQEAgdHlwZWRlZiBzdHJ1Y3Qg X1VzZXJfQXJndW1lbnRzIHsKICAgICBjb25zdCBjaGFyICpiYWNraW5nU3RvcmU7CiAgICAgRWlu YV9Cb29sIGlzRmxhdHRlbmluZzsKICAgICBFaW5hX0Jvb2wgaXNGdWxsc2NyZWVuOworICAgIEVp bmFfQm9vbCBlbmFibGVFbmNvZGluZ0RldGVjdG9yOwogICAgIEVpbmFfUmVjdGFuZ2xlIGdlb21l dHJ5OwogICAgIGNvbnN0IGNoYXIgKnRoZW1lOwogICAgIGNvbnN0IGNoYXIgKnVzZXJBZ2VudDsK QEAgLTgzMyw2ICs4MzYsNyBAQCB3aW5kb3dDcmVhdGUoVXNlcl9Bcmd1bWVudHMgKnVzZXJBcmdz KQogCiAgICAgZXdrX3ZpZXdfc2V0dGluZ19sb2NhbF9zdG9yYWdlX2RhdGFiYXNlX3BhdGhfc2V0 KGFwcC0+YnJvd3NlciwgdXNlckFyZ3MtPmRhdGFiYXNlUGF0aCk7CiAgICAgZXdrX3ZpZXdfc2V0 dGluZ19lbmFibGVfZnJhbWVfZmxhdHRlbmluZ19zZXQoYXBwLT5icm93c2VyLCB1c2VyQXJncy0+ aXNGbGF0dGVuaW5nKTsKKyAgICBld2tfdmlld19zZXR0aW5nX2VuY29kaW5nX2RldGVjdG9yX3Nl dChhcHAtPmJyb3dzZXIsIHVzZXJBcmdzLT5lbmFibGVFbmNvZGluZ0RldGVjdG9yKTsKIAogICAg IGFwcC0+dXNlckFyZ3MgPSB1c2VyQXJnczsKICAgICBhcHAtPnVybF9iYXIgPSBOVUxMOwpAQCAt OTEwLDYgKzkxNCw3IEBAIHBhcnNlVXNlckFyZ3VtZW50cyhpbnQgYXJnYywgY2hhciAqYXJndltd LCBVc2VyX0FyZ3VtZW50cyAqdXNlckFyZ3MpCiAgICAgdXNlckFyZ3MtPmJhY2tpbmdTdG9yZSA9 IChjaGFyICopYmFja2luZ1N0b3Jlc1sxXTsKICAgICB1c2VyQXJncy0+aXNGbGF0dGVuaW5nID0g RUlOQV9GQUxTRTsKICAgICB1c2VyQXJncy0+aXNGdWxsc2NyZWVuID0gRUlOQV9GQUxTRTsKKyAg ICB1c2VyQXJncy0+ZW5hYmxlRW5jb2RpbmdEZXRlY3RvciA9IEVJTkFfRkFMU0U7CiAgICAgdXNl ckFyZ3MtPmdlb21ldHJ5LnggPSAwOwogICAgIHVzZXJBcmdzLT5nZW9tZXRyeS55ID0gMDsKICAg ICB1c2VyQXJncy0+Z2VvbWV0cnkudyA9IDA7CkBAIC05MjMsNiArOTI4LDcgQEAgcGFyc2VVc2Vy QXJndW1lbnRzKGludCBhcmdjLCBjaGFyICphcmd2W10sIFVzZXJfQXJndW1lbnRzICp1c2VyQXJn cykKICAgICAgICAgRUNPUkVfR0VUT1BUX1ZBTFVFX1NUUih1c2VyQXJncy0+YmFja2luZ1N0b3Jl KSwKICAgICAgICAgRUNPUkVfR0VUT1BUX1ZBTFVFX0JPT0wodXNlckFyZ3MtPmlzRmxhdHRlbmlu ZyksCiAgICAgICAgIEVDT1JFX0dFVE9QVF9WQUxVRV9CT09MKHVzZXJBcmdzLT5pc0Z1bGxzY3Jl ZW4pLAorICAgICAgICBFQ09SRV9HRVRPUFRfVkFMVUVfQk9PTCh1c2VyQXJncy0+ZW5hYmxlRW5j b2RpbmdEZXRlY3RvciksCiAgICAgICAgIEVDT1JFX0dFVE9QVF9WQUxVRV9QVFJfQ0FTVCh1c2Vy QXJncy0+Z2VvbWV0cnkpLAogICAgICAgICBFQ09SRV9HRVRPUFRfVkFMVUVfU1RSKHVzZXJBcmdz LT50aGVtZSksCiAgICAgICAgIEVDT1JFX0dFVE9QVF9WQUxVRV9TVFIodXNlckFyZ3MtPnVzZXJB Z2VudCksCg== 167735 2012-10-09 04:49:51 -0700 2012-10-15 10:06:35 -0700 patch eweblauncher_encoding_detector_2.txt text/plain 2957 kangil.han ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA2NDg5 MmMyLi5kMWFhOTk3IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTItMTAtMDkgIEthbmdpbCBIYW4gIDxrYW5naWwu aGFuQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdW0VXZWJMYXVuY2hlcl0gQWRkIGVuY29k aW5nIGRldGVjdG9yIG9wdGlvbi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTk4NzI2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgR3l1eW91bmcgS2ltLgor CisgICAgICAgIEFkZGVkIGFuIG9wdGlvbiB0byB0ZXN0IFdlYkNvcmUncyBlbmNvZGluZyBkZXRl Y3RvciBmdW5jdGlvbmFsaXR5IG9uIEVXZWJMYXVuY2hlci4KKyAgICAgICAgV2l0aCB0aGlzIHBh dGNoLCBFV2ViTGF1bmNoZXIgd291bGQgZGlzcGxheSB0ZXh0IGNvcnJlY3RseSBldmVuIGlmIHdl YiBwYWdlIHdvdWxkbid0IHNwZWNpZnkgY2hhcnNldCBpbmZvcm1hdGlvbi4KKworICAgICAgICAq IEVXZWJMYXVuY2hlci9tYWluLmM6CisgICAgICAgIChfVXNlcl9Bcmd1bWVudHMpOgorICAgICAg ICAod2luZG93Q3JlYXRlKToKKyAgICAgICAgKHBhcnNlVXNlckFyZ3VtZW50cyk6CisKIDIwMTIt MTAtMDggIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtF RkxdIEJ1aWxkIENvbnRyb2xUaGVtZSBvbmx5IHdoZW4gbmVjZXNzYXJ5CmRpZmYgLS1naXQgYS9U b29scy9FV2ViTGF1bmNoZXIvbWFpbi5jIGIvVG9vbHMvRVdlYkxhdW5jaGVyL21haW4uYwppbmRl eCBmZTcxMDhlLi5iODQyYmY0IDEwMDY0NAotLS0gYS9Ub29scy9FV2ViTGF1bmNoZXIvbWFpbi5j CisrKyBiL1Rvb2xzL0VXZWJMYXVuY2hlci9tYWluLmMKQEAgLTExNiw2ICsxMTYsOCBAQCBzdGF0 aWMgY29uc3QgRWNvcmVfR2V0b3B0IG9wdGlvbnMgPSB7CiAgICAgICAgIEVDT1JFX0dFVE9QVF9D SE9JQ0UKICAgICAgICAgICAgICgnYicsICJiYWNraW5nLXN0b3JlIiwgImNob29zZSBiYWNraW5n IHN0b3JlIHRvIHVzZS4iLCBiYWNraW5nU3RvcmVzKSwKICAgICAgICAgRUNPUkVfR0VUT1BUX1NU T1JFX0RFRl9CT09MCisgICAgICAgICAgICAoJ2MnLCAiZW5jb2RpbmctZGV0ZWN0b3IiLCAiZW5h YmxlL2Rpc2FibGUgZW5jb2RpbmcgZGV0ZWN0b3IiLCAwKSwKKyAgICAgICAgRUNPUkVfR0VUT1BU X1NUT1JFX0RFRl9CT09MCiAgICAgICAgICAgICAoJ2YnLCAiZmxhdHRlbmluZyIsICJmcmFtZSBm bGF0dGVuaW5nLiIsIDApLAogICAgICAgICBFQ09SRV9HRVRPUFRfU1RPUkVfREVGX0JPT0wKICAg ICAgICAgICAgICgnRicsICJmdWxsc2NyZWVuIiwgImZ1bGxzY3JlZW4gbW9kZS4iLCAwKSwKQEAg LTE0NCw2ICsxNDYsNyBAQCB0eXBlZGVmIHN0cnVjdCBfVXNlcl9Bcmd1bWVudHMgewogICAgIGNv bnN0IGNoYXIgKmVuZ2luZTsKICAgICBFaW5hX0Jvb2wgcXVpdE9wdGlvbjsKICAgICBjb25zdCBj aGFyICpiYWNraW5nU3RvcmU7CisgICAgRWluYV9Cb29sIGVuYWJsZUVuY29kaW5nRGV0ZWN0b3I7 CiAgICAgRWluYV9Cb29sIGlzRmxhdHRlbmluZzsKICAgICBFaW5hX0Jvb2wgaXNGdWxsc2NyZWVu OwogICAgIEVpbmFfUmVjdGFuZ2xlIGdlb21ldHJ5OwpAQCAtODMzLDYgKzgzNiw3IEBAIHdpbmRv d0NyZWF0ZShVc2VyX0FyZ3VtZW50cyAqdXNlckFyZ3MpCiAKICAgICBld2tfdmlld19zZXR0aW5n X2xvY2FsX3N0b3JhZ2VfZGF0YWJhc2VfcGF0aF9zZXQoYXBwLT5icm93c2VyLCB1c2VyQXJncy0+ ZGF0YWJhc2VQYXRoKTsKICAgICBld2tfdmlld19zZXR0aW5nX2VuYWJsZV9mcmFtZV9mbGF0dGVu aW5nX3NldChhcHAtPmJyb3dzZXIsIHVzZXJBcmdzLT5pc0ZsYXR0ZW5pbmcpOworICAgIGV3a192 aWV3X3NldHRpbmdfZW5jb2RpbmdfZGV0ZWN0b3Jfc2V0KGFwcC0+YnJvd3NlciwgdXNlckFyZ3Mt PmVuYWJsZUVuY29kaW5nRGV0ZWN0b3IpOwogCiAgICAgYXBwLT51c2VyQXJncyA9IHVzZXJBcmdz OwogICAgIGFwcC0+dXJsX2JhciA9IE5VTEw7CkBAIC05MDgsNiArOTEyLDcgQEAgcGFyc2VVc2Vy QXJndW1lbnRzKGludCBhcmdjLCBjaGFyICphcmd2W10sIFVzZXJfQXJndW1lbnRzICp1c2VyQXJn cykKICAgICB1c2VyQXJncy0+ZW5naW5lID0gTlVMTDsKICAgICB1c2VyQXJncy0+cXVpdE9wdGlv biA9IEVJTkFfRkFMU0U7CiAgICAgdXNlckFyZ3MtPmJhY2tpbmdTdG9yZSA9IChjaGFyICopYmFj a2luZ1N0b3Jlc1sxXTsKKyAgICB1c2VyQXJncy0+ZW5hYmxlRW5jb2RpbmdEZXRlY3RvciA9IEVJ TkFfRkFMU0U7CiAgICAgdXNlckFyZ3MtPmlzRmxhdHRlbmluZyA9IEVJTkFfRkFMU0U7CiAgICAg dXNlckFyZ3MtPmlzRnVsbHNjcmVlbiA9IEVJTkFfRkFMU0U7CiAgICAgdXNlckFyZ3MtPmdlb21l dHJ5LnggPSAwOwpAQCAtOTIxLDYgKzkyNiw3IEBAIHBhcnNlVXNlckFyZ3VtZW50cyhpbnQgYXJn YywgY2hhciAqYXJndltdLCBVc2VyX0FyZ3VtZW50cyAqdXNlckFyZ3MpCiAgICAgICAgIEVDT1JF X0dFVE9QVF9WQUxVRV9TVFIodXNlckFyZ3MtPmVuZ2luZSksCiAgICAgICAgIEVDT1JFX0dFVE9Q VF9WQUxVRV9CT09MKHVzZXJBcmdzLT5xdWl0T3B0aW9uKSwKICAgICAgICAgRUNPUkVfR0VUT1BU X1ZBTFVFX1NUUih1c2VyQXJncy0+YmFja2luZ1N0b3JlKSwKKyAgICAgICAgRUNPUkVfR0VUT1BU X1ZBTFVFX0JPT0wodXNlckFyZ3MtPmVuYWJsZUVuY29kaW5nRGV0ZWN0b3IpLAogICAgICAgICBF Q09SRV9HRVRPUFRfVkFMVUVfQk9PTCh1c2VyQXJncy0+aXNGbGF0dGVuaW5nKSwKICAgICAgICAg RUNPUkVfR0VUT1BUX1ZBTFVFX0JPT0wodXNlckFyZ3MtPmlzRnVsbHNjcmVlbiksCiAgICAgICAg IEVDT1JFX0dFVE9QVF9WQUxVRV9QVFJfQ0FTVCh1c2VyQXJncy0+Z2VvbWV0cnkpLAo=