98716 2012-10-08 21:18:21 -0700 [EFL] Use ewk_view_paint instead of ewk_view_paint_contents in ewk_view_single. 2012-10-10 03:40:54 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi gyuyoung.kim kenneth laszlo.gombos lucas.de.marchi rakuco tonikitoo webkit.review.bot oldest_to_newest 737384 0 ryuan.choi 2012-10-08 21:18:21 -0700 ewk_view_paint is the wrapper of ScrollView::paint and ewk_view_paint_contents is the wrapper of FrameView::paintContents. Because FrameView::paintContents just draw contents, ewk_view_single should use ewk_view_paint instead of ewk_view_paint_contents like other ports. 737392 1 167683 ryuan.choi 2012-10-08 21:26:01 -0700 Created attachment 167683 Patch 738698 2 167683 kenneth 2012-10-10 00:59:09 -0700 Comment on attachment 167683 Patch why we still working on webkit1? 738731 3 gyuyoung.kim 2012-10-10 01:31:38 -0700 (In reply to comment #2) > (From update of attachment 167683 [details]) > why we still working on webkit1? Though our target is WK2 EFL, WK1 EFL may be used by other applications in future. IMO, we sometimes need to maintain WK1 until we remove this in trunk. 738792 4 167683 ryuan.choi 2012-10-10 03:36:12 -0700 Comment on attachment 167683 Patch Although I am interested in wk1/efl yet, I want to refactor this as one of steps to enable pixel-tests. With this, I can fix DRT and rebase some of pixel tests. 738797 5 167683 webkit.review.bot 2012-10-10 03:40:49 -0700 Comment on attachment 167683 Patch Clearing flags on attachment: 167683 Committed r130881: <http://trac.webkit.org/changeset/130881> 738798 6 webkit.review.bot 2012-10-10 03:40:54 -0700 All reviewed patches have been landed. Closing bug. 167683 2012-10-08 21:26:01 -0700 2012-10-10 03:40:49 -0700 Patch bug-98716-20121009132502.patch text/plain 3667 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwNzAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm bC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggNTkwZjkzNDBi YTM2YTkyNDZlY2UxZTFiMGQzNDhjNjcwY2YzY2RhMS4uOGE5MjRiZDU2OTZiM2NmYmEwMmQ0Nzcw YWZhNjlkZTIyMDIwZTc2YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEy LTEwLTA4ICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKworICAgICAgICBb RUZMXSBVc2UgZXdrX3ZpZXdfcGFpbnQgaW5zdGVhZCBvZiBld2tfdmlld19wYWludF9jb250ZW50 cyBpbiBld2tfdmlld19zaW5nbGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD05ODcxNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIGV3a192aWV3X3BhaW50IGlzIHRoZSB3cmFwcGVyIG9mIFNjcm9sbFZpZXc6 OnBhaW50IGFuZAorICAgICAgICBld2tfdmlld19wYWludF9jb250ZW50cyBpcyB0aGUgd3JhcHBl ciBvZiBGcmFtZVZpZXc6OnBhaW50Q29udGVudHMuCisKKyAgICAgICAgQmVjYXVzZSBGcmFtZVZp ZXc6OnBhaW50Q29udGVudHMganVzdCBkcmF3IGNvbnRlbnRzLAorICAgICAgICBld2tfdmlld19z aW5nbGUgc2hvdWxkIHVzZSBld2tfdmlld19wYWludCBpbnN0ZWFkIG9mIGV3a192aWV3X3BhaW50 X2NvbnRlbnRzCisgICAgICAgIGxpa2Ugb3RoZXIgcG9ydHMuCisKKyAgICAgICAgKiBld2svZXdr X3ZpZXcuY3BwOgorICAgICAgICAoZXdrX3ZpZXdfcGFpbnQpOgorICAgICAgICBNb3ZlZCB1cGRh dGVMYXlvdXRBbmRTdHlsZUlmTmVlZGVkUmVjdXJzaXZlIHRvIHNoYXJlIGV3a192aWV3X3BhaW50 LgorICAgICAgICAqIGV3ay9ld2tfdmlld19zaW5nbGUuY3BwOgorICAgICAgICAoX2V3a192aWV3 X3NpbmdsZV9zbWFydF9yZXBhaW50c19wcm9jZXNzKToKKyAgICAgICAgTW9kaWZpZWQgdG8gY2Fs bCBld2tfdmlld19wYWludC4KKwogMjAxMi0xMC0wNyAgQ2FpbyBNYXJjZWxvIGRlIE9saXZlaXJh IEZpbGhvICA8Y2Fpby5vbGl2ZWlyYUBvcGVuYm9zc2Eub3JnPgogCiAgICAgICAgIFJlbmFtZSBm aXJzdC9zZWNvbmQgdG8ga2V5L3ZhbHVlIGluIEhhc2hNYXAgaXRlcmF0b3JzCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwIGIvU291cmNlL1dlYktpdC9lZmwv ZXdrL2V3a192aWV3LmNwcAppbmRleCBlZjM1NjRkNmNkZTgxNzZmNTM0YzI0NGIxNWQ4NDEzOGRl N2JiMzAyLi4zYmZiYzBlNWE3ZGYwNTEwZGJhZGE1NzAxYjgwZTU1YTgxZmI5YjZkIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKQEAgLTI4NjIsNyArMjg2MiwxNCBAQCB2b2lkIGV3a192 aWV3X3Njcm9sbHNfcHJvY2VzcyhFd2tfVmlld19TbWFydF9EYXRhKiBzbWFydERhdGEpCiAKIEVp bmFfQm9vbCBld2tfdmlld19wYWludChFd2tfVmlld19Qcml2YXRlX0RhdGEqIHByaXYsIGNhaXJv X3QqIGNyLCBjb25zdCBFaW5hX1JlY3RhbmdsZSogYXJlYSkKIHsKKyAgICBFSU5BX1NBRkVUWV9P Tl9OVUxMX1JFVFVSTl9WQUwocHJpdiwgZmFsc2UpOwogICAgIEVJTkFfU0FGRVRZX09OX05VTExf UkVUVVJOX1ZBTChjciwgZmFsc2UpOworICAgIEVJTkFfU0FGRVRZX09OX05VTExfUkVUVVJOX1ZB TChhcmVhLCBmYWxzZSk7CisKKyAgICBXZWJDb3JlOjpGcmFtZVZpZXcqIHZpZXcgPSBwcml2LT5t YWluRnJhbWUtPnZpZXcoKTsKKyAgICBFSU5BX1NBRkVUWV9PTl9OVUxMX1JFVFVSTl9WQUwodmll dywgZmFsc2UpOworCisgICAgdmlldy0+dXBkYXRlTGF5b3V0QW5kU3R5bGVJZk5lZWRlZFJlY3Vy c2l2ZSgpOwogCiAgICAgRXdrX1BhaW50X0NvbnRleHQqIGNvbnRleHQgPSBld2tfcGFpbnRfY29u dGV4dF9uZXcoY3IpOwogICAgIGJvb2wgcmVzdWx0ID0gZXdrX3ZpZXdfcGFpbnQocHJpdiwgY29u dGV4dCwgYXJlYSk7CkBAIC0yOTE4LDggKzI5MjUsNiBAQCBFaW5hX0Jvb2wgZXdrX3ZpZXdfcGFp bnQoRXdrX1ZpZXdfUHJpdmF0ZV9EYXRhKiBwcml2LCBFd2tfUGFpbnRfQ29udGV4dCogY29udGV4 dAogICAgIFdlYkNvcmU6OkZyYW1lVmlldyogdmlldyA9IHByaXYtPm1haW5GcmFtZS0+dmlldygp OwogICAgIEVJTkFfU0FGRVRZX09OX05VTExfUkVUVVJOX1ZBTCh2aWV3LCBmYWxzZSk7CiAKLSAg ICB2aWV3LT51cGRhdGVMYXlvdXRBbmRTdHlsZUlmTmVlZGVkUmVjdXJzaXZlKCk7Ci0KICAgICBl d2tfcGFpbnRfY29udGV4dF9zYXZlKGNvbnRleHQpOwogICAgIGV3a19wYWludF9jb250ZXh0X2Ns aXAoY29udGV4dCwgYXJlYSk7CiAgICAgZXdrX3BhaW50X2NvbnRleHRfcGFpbnQoY29udGV4dCwg dmlldywgYXJlYSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXdf c2luZ2xlLmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlld19zaW5nbGUuY3BwCmlu ZGV4IDJkMDU5N2Q4N2QzYjRjODNjN2M5NzMyN2VhMGI4ZmEyNzNhMmVkMjkuLjI5NGJiYzhlMWM2 YTUwMjk2M2NiYWEwOTNlNTQwYmIyMjBlMWE4ZmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv ZWZsL2V3ay9ld2tfdmlld19zaW5nbGUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9l d2tfdmlld19zaW5nbGUuY3BwCkBAIC0yNjAsMTUgKzI2MCw5IEBAIHN0YXRpYyBFaW5hX0Jvb2wg X2V3a192aWV3X3NpbmdsZV9zbWFydF9yZXBhaW50c19wcm9jZXNzKEV3a19WaWV3X1NtYXJ0X0Rh dGEqIHNtCiAgICAgRXdrX1BhaW50X0NvbnRleHQqIGNvbnRleHQgPSBld2tfcGFpbnRfY29udGV4 dF9mcm9tX2ltYWdlX25ldyhzbWFydERhdGEtPmJhY2tpbmdfc3RvcmUpOwogICAgIGV3a19wYWlu dF9jb250ZXh0X3NhdmUoY29udGV4dCk7CiAKLSAgICBpbnQgc2Nyb2xsWCwgc2Nyb2xsWTsKLSAg ICBld2tfZnJhbWVfc2Nyb2xsX3Bvc19nZXQoc21hcnREYXRhLT5tYWluX2ZyYW1lLCAmc2Nyb2xs WCwgJnNjcm9sbFkpOwotICAgIGlmIChzY3JvbGxYIHx8IHNjcm9sbFkpCi0gICAgICAgIGV3a19w YWludF9jb250ZXh0X3RyYW5zbGF0ZShjb250ZXh0LCAtc2Nyb2xsWCwgLXNjcm9sbFkpOwotCiAg ICAgRWluYV9SZWN0YW5nbGUqIHJlY3Q7CiAgICAgRUlOQV9JVEVSQVRPUl9GT1JFQUNIKGl0ZXJh dG9yLCByZWN0KSB7Ci0gICAgICAgIEVpbmFfUmVjdGFuZ2xlIHNjcm9sbGVkUmVjdCA9IHsgcmVj dC0+eCArIHNjcm9sbFgsIHJlY3QtPnkgKyBzY3JvbGxZLCByZWN0LT53LCByZWN0LT5oIH07Ci0g ICAgICAgIGV3a192aWV3X3BhaW50X2NvbnRlbnRzKHNtYXJ0RGF0YS0+X3ByaXYsIGNvbnRleHQs ICZzY3JvbGxlZFJlY3QpOworICAgICAgICBld2tfdmlld19wYWludChzbWFydERhdGEtPl9wcml2 LCBjb250ZXh0LCByZWN0KTsKICAgICAgICAgZXZhc19vYmplY3RfaW1hZ2VfZGF0YV91cGRhdGVf YWRkKHNtYXJ0RGF0YS0+YmFja2luZ19zdG9yZSwgcmVjdC0+eCwgcmVjdC0+eSwgcmVjdC0+dywg cmVjdC0+aCk7CiAgICAgfQogCg==