98714 2012-10-08 20:44:22 -0700 [Chromium] Add WebElement::hasHTMLTagName, and deprecate hasTagName 2012-10-09 22:07:09 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tkent tkent abarth dglazkov fishd inferno jamesr tkent+wkapi webkit.review.bot oldest_to_newest 737375 0 tkent 2012-10-08 20:44:22 -0700 [Chromium] Add WebElement::hasHTMLTagName, and deprecate hasTagName 737379 1 167679 tkent 2012-10-08 20:50:51 -0700 Created attachment 167679 Patch 737381 2 webkit.review.bot 2012-10-08 20:54:43 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 738525 3 tkent 2012-10-09 21:49:48 -0700 (In reply to comment #2) > Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org Could anyone approve this please? 738536 4 167679 abarth 2012-10-09 21:58:30 -0700 Comment on attachment 167679 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167679&action=review API change LGTM > Source/WebKit/chromium/src/WebElement.cpp:70 > + return HTMLNames::xhtmlNamespaceURI == element->namespaceURI() && equalIgnoringCase(element->tagName(), tagName.operator String()); tagName.operator String() -> String(tagName) might be a prettier way to write this. 738537 5 abarth 2012-10-09 21:59:38 -0700 > Could anyone approve this please? tkent: Given that you're one of our API reviewers, I think it's fine for you to change the API with just a normal review. After all, fishd used to change the API all the time when he was the only API reviewer. :) 738543 6 tkent 2012-10-09 22:07:09 -0700 Committed r130847: <http://trac.webkit.org/changeset/130847> 167679 2012-10-08 20:50:51 -0700 2012-10-09 21:58:30 -0700 Patch bug-98714-20121009124953.patch text/plain 3016 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwNzE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDNmNzhhNTgzZWFjMDQwZmJlM2Q2ODFjNjMxMDg0YjBiOWI4ZjAwODYuLjU5NDEyMDZlNTgzMmM4 ZTViZTA0MDZiMjk4OTgxYjNkMTAzNjM1MjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMTItMTAtMDggIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0u b3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gQWRkIFdlYkVsZW1lbnQ6Omhhc0hUTUxUYWdOYW1l LCBhbmQgZGVwcmVjYXRlIGhhc1RhZ05hbWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTk4NzE0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBwdWJsaWMvV2ViRWxlbWVudC5oOgorICAgICAgICAoV2ViRWxl bWVudCk6CisgICAgICAgIC0gQWRkIGEgY29tbWVudCB0byB0YWdOYW1lKCkuCisgICAgICAgIC0g QWRkIGEgY29tbWVudCB0byBoYXNUYWdOYW1lKCkuCisgICAgICAgIC0gRGVjbGFyZSBoYXNIVE1M VGFnTmFtZSgpLCB3aGljaCBpcyB1c2VmdWwgdG8gY2hlY2sgSFRNTCB0YWdzLgorICAgICAgICAq IHNyYy9XZWJFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViRWxlbWVudDo6aGFzSFRN TFRhZ05hbWUpOiBBZGRlZC4KKwogMjAxMi0xMC0wOCAgRGlyayBQcmFua2UgIDxkcHJhbmtlQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBDaHJvbWl1bSBERVBTIHJvbGwgcjE2MDY1NzoxNjA3NjQu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJFbGVtZW50Lmgg Yi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJFbGVtZW50LmgKaW5kZXggODRjNDNi MjUxYWU1NzZkMzA3NTQ2NDc2ZGI5YmU4ZDNkMTc3NTU0ZS4uNzVlM2FmZjBmZmE3YzNlODM3YzJj MWFlMjcyOTk4OTdkMjE5ZTgzNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9w dWJsaWMvV2ViRWxlbWVudC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dl YkVsZW1lbnQuaApAQCAtNTEsOCArNTEsMTUgQEAgc3RydWN0IFdlYlJlY3Q7CiAKICAgICAgICAg V0VCS0lUX0VYUE9SVCBib29sIGlzRm9ybUNvbnRyb2xFbGVtZW50KCkgY29uc3Q7CiAgICAgICAg IFdFQktJVF9FWFBPUlQgYm9vbCBpc1RleHRGb3JtQ29udHJvbEVsZW1lbnQoKSBjb25zdDsKKyAg ICAgICAgLy8gUmV0dXJucyB0aGUgcXVhbGlmaWVkIG5hbWUsIHdoaWNoIG1heSBjb250YWluIGEg cHJlZml4IGFuZCBhIGNvbG9uLgogICAgICAgICBXRUJLSVRfRVhQT1JUIFdlYlN0cmluZyB0YWdO YW1lKCkgY29uc3Q7CisgICAgICAgIC8vIENoZWNrIGlmIHRoaXMgZWxlbWVudCBoYXMgdGhlIHNw ZWNpZmllZCBxdWFsaWZpZWQgbmFtZS4gVGhpcyBmdW5jdGlvbgorICAgICAgICAvLyBkb2Vzbid0 IG1ha2VzIG11Y2ggc2Vuc2UgYmVjYXVzZSB3ZSBoYXZlIG5vIHdheXMgdG8gY2hlY2sgbmFtZXNw YWNlCisgICAgICAgIC8vIFVSSS4gRG8gbm90IHVzZSB0aGlzLgogICAgICAgICBXRUJLSVRfRVhQ T1JUIGJvb2wgaGFzVGFnTmFtZShjb25zdCBXZWJTdHJpbmcmKSBjb25zdDsKKyAgICAgICAgLy8g Q2hlY2sgaWYgdGhpcyBlbGVtZW50IGhhcyB0aGUgc3BlY2lmaWVkIGxvY2FsIHRhZyBuYW1lLCBh bmQgdGhlIEhUTUwKKyAgICAgICAgLy8gbmFtZXNwYWNlLiBUYWcgbmFtZSBtYXRjaGluZyBpcyBj YXNlLWluc2Vuc2l0aXZlLgorICAgICAgICBXRUJLSVRfRVhQT1JUIGJvb2wgaGFzSFRNTFRhZ05h bWUoY29uc3QgV2ViU3RyaW5nJikgY29uc3Q7CiAgICAgICAgIFdFQktJVF9FWFBPUlQgYm9vbCBo YXNBdHRyaWJ1dGUoY29uc3QgV2ViU3RyaW5nJikgY29uc3Q7CiAgICAgICAgIFdFQktJVF9FWFBP UlQgV2ViU3RyaW5nIGdldEF0dHJpYnV0ZShjb25zdCBXZWJTdHJpbmcmKSBjb25zdDsKICAgICAg ICAgV0VCS0lUX0VYUE9SVCBib29sIHNldEF0dHJpYnV0ZShjb25zdCBXZWJTdHJpbmcmIG5hbWUs IGNvbnN0IFdlYlN0cmluZyYgdmFsdWUpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9zcmMvV2ViRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJF bGVtZW50LmNwcAppbmRleCA3ZDExODY4YjMzOGY2ZDc2YmNlMDMxOGUxMTQ2NjNjYmYzMmI0MGY2 Li41YjU5ZWRiM2IzZjlkNmJiNDE0MDU2ZjVlYjhiNzkzMmIxNmE2ZDFmIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3NyYy9XZWJFbGVtZW50LmNwcApAQCAtNjQsNiArNjQsMTIgQEAgYm9vbCBX ZWJFbGVtZW50OjpoYXNUYWdOYW1lKGNvbnN0IFdlYlN0cmluZyYgdGFnTmFtZSkgY29uc3QKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgdGFnTmFtZS5vcGVyYXRvciBTdHJpbmcoKSk7CiB9 CiAKK2Jvb2wgV2ViRWxlbWVudDo6aGFzSFRNTFRhZ05hbWUoY29uc3QgV2ViU3RyaW5nJiB0YWdO YW1lKSBjb25zdAoreworICAgIGNvbnN0IEVsZW1lbnQqIGVsZW1lbnQgPSBjb25zdFVud3JhcDxF bGVtZW50PigpOworICAgIHJldHVybiBIVE1MTmFtZXM6OnhodG1sTmFtZXNwYWNlVVJJID09IGVs ZW1lbnQtPm5hbWVzcGFjZVVSSSgpICYmIGVxdWFsSWdub3JpbmdDYXNlKGVsZW1lbnQtPnRhZ05h bWUoKSwgdGFnTmFtZS5vcGVyYXRvciBTdHJpbmcoKSk7Cit9CisKIGJvb2wgV2ViRWxlbWVudDo6 aGFzQXR0cmlidXRlKGNvbnN0IFdlYlN0cmluZyYgYXR0ck5hbWUpIGNvbnN0CiB7CiAgICAgcmV0 dXJuIGNvbnN0VW53cmFwPEVsZW1lbnQ+KCktPmhhc0F0dHJpYnV0ZShhdHRyTmFtZSk7Cg==