98707 2012-10-08 17:53:49 -0700 [chromium] Expose background color in WebLayer and WebSolidColorLayer 2012-10-10 21:49:50 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sky husky abarth dglazkov fishd jamesr piman tkent+wkapi webkit.review.bot oldest_to_newest 737275 0 sky 2012-10-08 17:53:49 -0700 So that we can query for current state. 737280 1 167659 sky 2012-10-08 17:56:21 -0700 Created attachment 167659 Fix for 98707: 737286 2 167659 piman 2012-10-08 18:02:37 -0700 Comment on attachment 167659 Fix for 98707: View in context: https://bugs.webkit.org/attachment.cgi?id=167659&action=review > Source/Platform/chromium/public/WebSolidColorLayer.h:43 > + virtual WebColor getBackgroundColor() const = 0; Not needed since you can get it through layer() 737366 3 167659 danakj 2012-10-08 20:15:59 -0700 Comment on attachment 167659 Fix for 98707: View in context: https://bugs.webkit.org/attachment.cgi?id=167659&action=review > Source/Platform/chromium/public/WebLayer.h:122 > + virtual WebColor getBackgroundColor() const = 0; naming nit: just "backgroundColor()" 737812 4 167763 sky 2012-10-09 08:45:39 -0700 Created attachment 167763 Fix v2 getBackgroundColor -> backgroundColor and removes changes to WebSolidColorLayer. 737965 5 jamesr 2012-10-09 11:20:01 -0700 Looks good, we'll just have to wait for the chromium side to land + roll into Source/WebKit/chromium/DEPS 739448 6 webkit.review.bot 2012-10-10 17:56:33 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 739485 7 167763 webkit.review.bot 2012-10-10 18:44:53 -0700 Comment on attachment 167763 Fix v2 Rejecting attachment 167763 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: Core/ChangeLog CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog Failed to merge in the changes. Patch failed at 0001 https://bugs.webkit.org/show_bug.cgi?id=95664 When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. Full output: http://queues.webkit.org/results/14245741 739603 8 167763 webkit.review.bot 2012-10-10 21:49:47 -0700 Comment on attachment 167763 Fix v2 Clearing flags on attachment: 167763 Committed r131013: <http://trac.webkit.org/changeset/131013> 739604 9 webkit.review.bot 2012-10-10 21:49:50 -0700 All reviewed patches have been landed. Closing bug. 167659 2012-10-08 17:56:21 -0700 2012-10-09 10:14:15 -0700 Fix for 98707: patch text/plain 1748 sky SW5kZXg6IFNvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1Bs YXRmb3JtL0NoYW5nZUxvZwkocmV2aXNpb24gMTMwNzA1KQorKysgU291cmNlL1BsYXRmb3JtL0No YW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEyLTEwLTA4ICBTY290 dCBWaW9sZXQgIDxza3lAZ29vZ2xlLmNvbT4KKworICAgICAgICBFeHBvc2UgYmFja2dyb3VuZCBj b2xvciBpbiBXZWJMYXllciBhbmQgV2ViU29saWRDb2xvckxheWVyIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD05ODcwNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogY2hyb21pdW0vcHVibGljL1dlYkxheWVyLmg6CisgICAg ICAgIChXZWJMYXllcik6IEFkZHMgZ2V0QmFja2dyb3VuZENvbG9yLgorICAgICAgICAqIGNocm9t aXVtL3B1YmxpYy9XZWJTb2xpZENvbG9yTGF5ZXIuaDoKKyAgICAgICAgKFdlYlNvbGlkQ29sb3JM YXllcik6IEFkZHMgZ2V0QmFja2dyb3VuZENvbG9yLgorCiAyMDEyLTEwLTA0ICBIYXJhbGQgQWx2 ZXN0cmFuZCAgPGh0YUBnb29nbGUuY29tPgogCiAgICAgICAgIENoYW5nZSBSVENQZWVyQ29ubmVj dGlvbiBHZXRTdGF0cyB0byB1c2UgRGF0ZSB0aW1lc3RhbXAgZm9ybWF0CkluZGV4OiBTb3VyY2Uv UGxhdGZvcm0vY2hyb21pdW0vcHVibGljL1dlYkxheWVyLmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9XZWJMYXllci5oCShyZXZpc2lvbiAxMzA3MDUpCisr KyBTb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vcHVibGljL1dlYkxheWVyLmgJKHdvcmtpbmcgY29w eSkKQEAgLTExOSw2ICsxMTksNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIHNldFVzZVBh cmVudEJhY2tmYWNlVmlzaWJpbGl0eShib29sKSA9IDA7CiAKICAgICB2aXJ0dWFsIHZvaWQgc2V0 QmFja2dyb3VuZENvbG9yKFdlYkNvbG9yKSA9IDA7CisgICAgdmlydHVhbCBXZWJDb2xvciBnZXRC YWNrZ3JvdW5kQ29sb3IoKSBjb25zdCA9IDA7CiAKICAgICAvLyBDbGVhciB0aGUgZmlsdGVycyBp biB1c2UgYnkgcGFzc2luZyBpbiBhIG5ld2x5IGluc3RhbnRpYXRlZAogICAgIC8vIFdlYkZpbHRl ck9wZXJhdGlvbnMgb2JqZWN0LgpJbmRleDogU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1Ymxp Yy9XZWJTb2xpZENvbG9yTGF5ZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvUGxhdGZvcm0vY2hy b21pdW0vcHVibGljL1dlYlNvbGlkQ29sb3JMYXllci5oCShyZXZpc2lvbiAxMzA3MDUpCisrKyBT b3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vcHVibGljL1dlYlNvbGlkQ29sb3JMYXllci5oCSh3b3Jr aW5nIGNvcHkpCkBAIC00MCw2ICs0MCw3IEBAIHB1YmxpYzoKIAogICAgIHZpcnR1YWwgV2ViTGF5 ZXIqIGxheWVyKCkgPSAwOwogICAgIHZpcnR1YWwgdm9pZCBzZXRCYWNrZ3JvdW5kQ29sb3IoV2Vi Q29sb3IpID0gMDsKKyAgICB2aXJ0dWFsIFdlYkNvbG9yIGdldEJhY2tncm91bmRDb2xvcigpIGNv bnN0ID0gMDsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYktpdAo= 167763 2012-10-09 08:45:39 -0700 2012-10-10 21:49:47 -0700 Fix v2 patch text/plain 1140 sky SW5kZXg6IFNvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1Bs YXRmb3JtL0NoYW5nZUxvZwkocmV2aXNpb24gMTMwNzA1KQorKysgU291cmNlL1BsYXRmb3JtL0No YW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDEyLTEwLTA4ICBTY290 dCBWaW9sZXQgIDxza3lAZ29vZ2xlLmNvbT4KKworICAgICAgICBFeHBvc2UgYmFja2dyb3VuZCBj b2xvciBpbiBXZWJMYXllciBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 OTg3MDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IGNocm9taXVtL3B1YmxpYy9XZWJMYXllci5oOgorICAgICAgICAoV2ViTGF5ZXIpOiBBZGRzIGJh Y2tncm91bmRDb2xvci4KKwogMjAxMi0xMC0wNCAgSGFyYWxkIEFsdmVzdHJhbmQgIDxodGFAZ29v Z2xlLmNvbT4KIAogICAgICAgICBDaGFuZ2UgUlRDUGVlckNvbm5lY3Rpb24gR2V0U3RhdHMgdG8g dXNlIERhdGUgdGltZXN0YW1wIGZvcm1hdApJbmRleDogU291cmNlL1BsYXRmb3JtL2Nocm9taXVt L3B1YmxpYy9XZWJMYXllci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1 bS9wdWJsaWMvV2ViTGF5ZXIuaAkocmV2aXNpb24gMTMwNzA1KQorKysgU291cmNlL1BsYXRmb3Jt L2Nocm9taXVtL3B1YmxpYy9XZWJMYXllci5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMTksNiArMTE5 LDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBzZXRVc2VQYXJlbnRCYWNrZmFjZVZpc2li aWxpdHkoYm9vbCkgPSAwOwogCiAgICAgdmlydHVhbCB2b2lkIHNldEJhY2tncm91bmRDb2xvcihX ZWJDb2xvcikgPSAwOworICAgIHZpcnR1YWwgV2ViQ29sb3IgYmFja2dyb3VuZENvbG9yKCkgY29u c3QgPSAwOwogCiAgICAgLy8gQ2xlYXIgdGhlIGZpbHRlcnMgaW4gdXNlIGJ5IHBhc3NpbmcgaW4g YSBuZXdseSBpbnN0YW50aWF0ZWQKICAgICAvLyBXZWJGaWx0ZXJPcGVyYXRpb25zIG9iamVjdC4K