98686 2012-10-08 13:44:18 -0700 editing/pasteboard/data-transfer-item is failing after r130643 2013-01-31 11:43:18 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dpranke webkit-unassigned dcheng jchaffraix kling rniwa tony webkit.review.bot oldest_to_newest 736989 0 dpranke 2012-10-08 13:44:18 -0700 It looks like maybe we just need a new baseline now that kling landed the change in r130588 to change to an ordered collection (maybe the order has changed for the better)? Ryosuke, can you confirm that the change is okay, or let us know if you think there's still a bug here? http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=editing%2Fpasteboard%2Fdata-transfer-items.html https://bugs.webkit.org/show_bug.cgi?id=98406 http://trac.webkit.org/changeset/130643 http://trac.webkit.org/changeset/130588 http://webkit.org/b/98547 737053 1 tony 2012-10-08 14:32:45 -0700 I think this is fine to rebaseline. The order of clipboard types isn't defined. dcheng can confirm. 737060 2 167613 kling 2012-10-08 14:36:07 -0700 Created attachment 167613 Speculative fix 737076 3 rniwa 2012-10-08 14:48:27 -0700 (In reply to comment #1) > I think this is fine to rebaseline. The order of clipboard types isn't defined. dcheng can confirm. I think it needs to preserve the order if it's created by the author script. 737087 4 tony 2012-10-08 14:55:57 -0700 (In reply to comment #3) > (In reply to comment #1) > > I think this is fine to rebaseline. The order of clipboard types isn't defined. dcheng can confirm. > > I think it needs to preserve the order if it's created by the author script. You're right, I think the intent is that it behaves like a list. 737326 5 167613 webkit.review.bot 2012-10-08 18:44:49 -0700 Comment on attachment 167613 Speculative fix Clearing flags on attachment: 167613 Committed r130712: <http://trac.webkit.org/changeset/130712> 737327 6 webkit.review.bot 2012-10-08 18:44:53 -0700 All reviewed patches have been landed. Closing bug. 821771 7 tony 2013-01-31 11:43:18 -0800 Test result updated in http://trac.webkit.org/changeset/141449 . 167613 2012-10-08 14:36:07 -0700 2012-10-08 18:44:49 -0700 Speculative fix bug-98686.diff text/plain 1992 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkYzhhMzU2Li41Mjk4MDM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTgg QEAKIDIwMTItMTAtMDggIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgogCisgICAg ICAgIFJFR1JFU1NJT04ocjEzMDY0Myk6IGVkaXRpbmcvcGFzdGVib2FyZC9kYXRhLXRyYW5zZmVy LWl0ZW0gaXMgZmFpbGluZyBvbiBjaHJvbWl1bS4KKyAgICAgICAgPGh0dHA6Ly93ZWJraXQub3Jn L2IvOTg2ODY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQ2hhbmdlIENocm9taXVtRGF0YU9iamVjdDo6Y3JlYXRlRnJvbVBhc3RlYm9hcmQoKSB0byB1 c2UgYSBMaXN0SGFzaFNldCBpbnN0ZWFkIG9mIGEgSGFzaFNldCBzbyB0aGF0CisgICAgICAgIGl0 ZW0gb3JkZXIgaXMgcHJlc2VydmVkLgorCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vQ2hy b21pdW1EYXRhT2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNocm9taXVtRGF0YU9iamVj dDo6Y3JlYXRlRnJvbVBhc3RlYm9hcmQpOgorCisyMDEyLTEwLTA4ICBBbmRyZWFzIEtsaW5nICA8 a2xpbmdAd2Via2l0Lm9yZz4KKwogICAgICAgICAxLjE4TUIgYmVsb3cgUmVuZGVyVGFibGVTZWN0 aW9uOjpzZXRDYWNoZWRDb2xsYXBzZWRCb3JkZXJWYWx1ZSgpIG9uIE1lbWJ1c3RlcjMuCiAgICAg ICAgIDxodHRwOi8vd2Via2l0Lm9yZy9iLzk4NjcwPgogICAgICAgICA8cmRhcjovL3Byb2JsZW0v MTI0NTQyNzY+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9D aHJvbWl1bURhdGFPYmplY3QuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0v Q2hyb21pdW1EYXRhT2JqZWN0LmNwcAppbmRleCA2ZjY3NTFmLi45YjExZjIzIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9DaHJvbWl1bURhdGFPYmplY3QuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL0Nocm9taXVtRGF0YU9iamVj dC5jcHAKQEAgLTQ4LDEwICs0OCwxMCBAQCBQYXNzUmVmUHRyPENocm9taXVtRGF0YU9iamVjdD4g Q2hyb21pdW1EYXRhT2JqZWN0OjpjcmVhdGVGcm9tUGFzdGVib2FyZCgpCiAgICAgdWludDY0X3Qg c2VxdWVuY2VOdW1iZXIgPSBXZWJLaXQ6OlBsYXRmb3JtOjpjdXJyZW50KCktPmNsaXBib2FyZCgp LT5zZXF1ZW5jZU51bWJlcihjdXJyZW50UGFzdGVib2FyZEJ1ZmZlcigpKTsKICAgICBib29sIGln bm9yZWQ7CiAgICAgV2ViS2l0OjpXZWJWZWN0b3I8V2ViS2l0OjpXZWJTdHJpbmc+IHdlYlR5cGVz ID0gV2ViS2l0OjpQbGF0Zm9ybTo6Y3VycmVudCgpLT5jbGlwYm9hcmQoKS0+cmVhZEF2YWlsYWJs ZVR5cGVzKGN1cnJlbnRQYXN0ZWJvYXJkQnVmZmVyKCksICZpZ25vcmVkKTsKLSAgICBIYXNoU2V0 PFN0cmluZz4gdHlwZXM7CisgICAgTGlzdEhhc2hTZXQ8U3RyaW5nPiB0eXBlczsKICAgICBmb3Ig KHNpemVfdCBpID0gMDsgaSA8IHdlYlR5cGVzLnNpemUoKTsgKytpKQogICAgICAgICB0eXBlcy5h ZGQod2ViVHlwZXNbaV0pOwotICAgIGZvciAoSGFzaFNldDxTdHJpbmc+Ojpjb25zdF9pdGVyYXRv ciBpdCA9IHR5cGVzLmJlZ2luKCk7IGl0ICE9IHR5cGVzLmVuZCgpOyArK2l0KQorICAgIGZvciAo TGlzdEhhc2hTZXQ8U3RyaW5nPjo6Y29uc3RfaXRlcmF0b3IgaXQgPSB0eXBlcy5iZWdpbigpOyBp dCAhPSB0eXBlcy5lbmQoKTsgKytpdCkKICAgICAgICAgZGF0YU9iamVjdC0+bV9pdGVtTGlzdC5h cHBlbmQoQ2hyb21pdW1EYXRhT2JqZWN0SXRlbTo6Y3JlYXRlRnJvbVBhc3RlYm9hcmQoKml0LCBz ZXF1ZW5jZU51bWJlcikpOwogICAgIHJldHVybiBkYXRhT2JqZWN0LnJlbGVhc2UoKTsKIH0K