98681 2012-10-08 12:39:37 -0700 Add missing compile flag for compositing 2012-10-09 10:00:10 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 98720 98315 1 cabanier cabanier donggwan.kim webkit.review.bot zoltan oldest_to_newest 736938 0 cabanier 2012-10-08 12:39:37 -0700 when I enabled compositing on trunk, one of the configuration files was not updated. 736940 1 167589 cabanier 2012-10-08 12:45:56 -0700 Created attachment 167589 first try 736959 2 167589 krit 2012-10-08 13:16:15 -0700 Comment on attachment 167589 first try LGTM. r=me 736991 3 167589 webkit.review.bot 2012-10-08 13:47:38 -0700 Comment on attachment 167589 first try Clearing flags on attachment: 167589 Committed r130680: <http://trac.webkit.org/changeset/130680> 736992 4 webkit.review.bot 2012-10-08 13:47:42 -0700 All reviewed patches have been landed. Closing bug. 737413 5 webkit.review.bot 2012-10-08 22:09:15 -0700 Re-opened since this is blocked by bug 98720 737845 6 167767 cabanier 2012-10-09 09:12:52 -0700 Created attachment 167767 fixed typo 737866 7 167772 cabanier 2012-10-09 09:29:29 -0700 Created attachment 167772 I guess you can't do an EWS if the rollout didn't happen yet :-( 737883 8 167772 zoltan 2012-10-09 09:48:44 -0700 Comment on attachment 167772 I guess you can't do an EWS if the rollout didn't happen yet :-( It looks good now! I'd r+ it. 737892 9 167772 zoltan 2012-10-09 10:00:02 -0700 Comment on attachment 167772 I guess you can't do an EWS if the rollout didn't happen yet :-( Dirk already review it, relanded with typo fix in: http://trac.webkit.org/changeset/130775 167589 2012-10-08 12:45:56 -0700 2012-10-09 09:12:52 -0700 first try patch text/plain 1327 cabanier SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMDY3NCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEwLTA4ICBSaWsgQ2Fi YW5pZXIgIDxjYWJhbmllckBhZG9iZS5jb20+CisKKyAgICAgICAgQWRkIG1pc3NpbmcgY29tcGls ZSBmbGFnIGZvciBjb21wb3NpdGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9OTg2ODEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBUaGlzIGZsYWcgaXMgbmVlZGVkIGluIGNhc2UgdGhlcmUgaXMgYSBkaWZm ZXJlbmNlIGluIEFQSQorICAgICAgICB3aGVuIGNvbXBvc2l0aW5nIGlzIGVuYWJsZWQKKworICAg ICAgICAqIENvbmZpZ3VyYXRpb25zL0ZlYXR1cmVEZWZpbmVzLnhjY29uZmlnOgorCiAyMDEyLTEw LTA4ICBKaW53b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4KIAogICAgICAgICBb RUZMXVtXSzJdIEF2b2lkIHVzZWxlc3MgY29udmVydGluZyB0byBXS1BhZ2UKSW5kZXg6IFNvdXJj ZS9XZWJLaXQyL0NvbmZpZ3VyYXRpb25zL0ZlYXR1cmVEZWZpbmVzLnhjY29uZmlnCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJLaXQyL0NvbmZpZ3VyYXRpb25zL0ZlYXR1cmVEZWZpbmVzLnhjY29u ZmlnCShyZXZpc2lvbiAxMzA2NzQpCisrKyBTb3VyY2UvV2ViS2l0Mi9Db25maWd1cmF0aW9ucy9G ZWF0dXJlRGVmaW5lcy54Y2NvbmZpZwkod29ya2luZyBjb3B5KQpAQCAtMzgsNyArMzgsNyBAQCBF TkFCTEVfQkxPQiA9IEVOQUJMRV9CTE9COwogRU5BQkxFX0NIQU5ORUxfTUVTU0FHSU5HID0gRU5B QkxFX0NIQU5ORUxfTUVTU0FHSU5HOwogRU5BQkxFX0NTUF9ORVhUID0gOwogRU5BQkxFX0NTU19C T1hfREVDT1JBVElPTl9CUkVBSyA9IEVOQUJMRV9DU1NfQk9YX0RFQ09SQVRJT05fQlJFQUs7Ci1F TkFCTEVfQ1NTX0NPTVBPU0lUSU5HID0gOworRU5BQkxFX0NTU19DT01QT1NJVElORyA9IENTU19D T01QT1NJVElORzsKIEVOQUJMRV9DU1NfRVhDTFVTSU9OUyA9IEVOQUJMRV9DU1NfRVhDTFVTSU9O UzsKIEVOQUJMRV9DU1NfRklMVEVSUyA9IEVOQUJMRV9DU1NfRklMVEVSUzsKIEVOQUJMRV9DU1Nf SElFUkFSQ0hJRVMgPSA7Cg== 167767 2012-10-09 09:12:52 -0700 2012-10-09 09:29:29 -0700 fixed typo ProjectPatch text/plain 1334 cabanier SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMDY3NCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEwLTA5ICBSaWsgQ2Fi YW5pZXIgIDxjYWJhbmllckBhZG9iZS5jb20+CisKKyAgICAgICAgQWRkIG1pc3NpbmcgY29tcGls ZSBmbGFnIGZvciBjb21wb3NpdGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9OTg2ODEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBUaGlzIGZsYWcgaXMgbmVlZGVkIGluIGNhc2UgdGhlcmUgaXMgYSBkaWZm ZXJlbmNlIGluIEFQSQorICAgICAgICB3aGVuIGNvbXBvc2l0aW5nIGlzIGVuYWJsZWQKKworICAg ICAgICAqIENvbmZpZ3VyYXRpb25zL0ZlYXR1cmVEZWZpbmVzLnhjY29uZmlnOgorCiAyMDEyLTEw LTA4ICBKaW53b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4KIAogICAgICAgICBb RUZMXVtXSzJdIEF2b2lkIHVzZWxlc3MgY29udmVydGluZyB0byBXS1BhZ2UKSW5kZXg6IFNvdXJj ZS9XZWJLaXQyL0NvbmZpZ3VyYXRpb25zL0ZlYXR1cmVEZWZpbmVzLnhjY29uZmlnCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJLaXQyL0NvbmZpZ3VyYXRpb25zL0ZlYXR1cmVEZWZpbmVzLnhjY29u ZmlnCShyZXZpc2lvbiAxMzA2NzQpCisrKyBTb3VyY2UvV2ViS2l0Mi9Db25maWd1cmF0aW9ucy9G ZWF0dXJlRGVmaW5lcy54Y2NvbmZpZwkod29ya2luZyBjb3B5KQpAQCAtMzgsNyArMzgsNyBAQCBF TkFCTEVfQkxPQiA9IEVOQUJMRV9CTE9COwogRU5BQkxFX0NIQU5ORUxfTUVTU0FHSU5HID0gRU5B QkxFX0NIQU5ORUxfTUVTU0FHSU5HOwogRU5BQkxFX0NTUF9ORVhUID0gOwogRU5BQkxFX0NTU19C T1hfREVDT1JBVElPTl9CUkVBSyA9IEVOQUJMRV9DU1NfQk9YX0RFQ09SQVRJT05fQlJFQUs7Ci1F TkFCTEVfQ1NTX0NPTVBPU0lUSU5HID0gOworRU5BQkxFX0NTU19DT01QT1NJVElORyA9IEVOQUJM RV9DU1NfQ09NUE9TSVRJTkc7CiBFTkFCTEVfQ1NTX0VYQ0xVU0lPTlMgPSBFTkFCTEVfQ1NTX0VY Q0xVU0lPTlM7CiBFTkFCTEVfQ1NTX0ZJTFRFUlMgPSBFTkFCTEVfQ1NTX0ZJTFRFUlM7CiBFTkFC TEVfQ1NTX0hJRVJBUkNISUVTID0gOwo= 167772 2012-10-09 09:29:29 -0700 2012-10-09 10:00:01 -0700 I guess you can't do an EWS if the rollout didn't happen yet :-( ProjectPatch text/plain 1334 cabanier SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMDY3NCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEwLTA5ICBSaWsgQ2Fi YW5pZXIgIDxjYWJhbmllckBhZG9iZS5jb20+CisKKyAgICAgICAgQWRkIG1pc3NpbmcgY29tcGls ZSBmbGFnIGZvciBjb21wb3NpdGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9OTg2ODEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBUaGlzIGZsYWcgaXMgbmVlZGVkIGluIGNhc2UgdGhlcmUgaXMgYSBkaWZm ZXJlbmNlIGluIEFQSQorICAgICAgICB3aGVuIGNvbXBvc2l0aW5nIGlzIGVuYWJsZWQKKworICAg ICAgICAqIENvbmZpZ3VyYXRpb25zL0ZlYXR1cmVEZWZpbmVzLnhjY29uZmlnOgorCiAyMDEyLTEw LTA4ICBKaW53b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4KIAogICAgICAgICBb RUZMXVtXSzJdIEF2b2lkIHVzZWxlc3MgY29udmVydGluZyB0byBXS1BhZ2UKSW5kZXg6IFNvdXJj ZS9XZWJLaXQyL0NvbmZpZ3VyYXRpb25zL0ZlYXR1cmVEZWZpbmVzLnhjY29uZmlnCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJLaXQyL0NvbmZpZ3VyYXRpb25zL0ZlYXR1cmVEZWZpbmVzLnhjY29u ZmlnCShyZXZpc2lvbiAxMzA2NzQpCisrKyBTb3VyY2UvV2ViS2l0Mi9Db25maWd1cmF0aW9ucy9G ZWF0dXJlRGVmaW5lcy54Y2NvbmZpZwkod29ya2luZyBjb3B5KQpAQCAtMzgsNyArMzgsNyBAQCBF TkFCTEVfQkxPQiA9IEVOQUJMRV9CTE9COwogRU5BQkxFX0NIQU5ORUxfTUVTU0FHSU5HID0gRU5B QkxFX0NIQU5ORUxfTUVTU0FHSU5HOwogRU5BQkxFX0NTUF9ORVhUID0gOwogRU5BQkxFX0NTU19C T1hfREVDT1JBVElPTl9CUkVBSyA9IEVOQUJMRV9DU1NfQk9YX0RFQ09SQVRJT05fQlJFQUs7Ci1F TkFCTEVfQ1NTX0NPTVBPU0lUSU5HID0gOworRU5BQkxFX0NTU19DT01QT1NJVElORyA9IEVOQUJM RV9DU1NfQ09NUE9TSVRJTkc7CiBFTkFCTEVfQ1NTX0VYQ0xVU0lPTlMgPSBFTkFCTEVfQ1NTX0VY Q0xVU0lPTlM7CiBFTkFCTEVfQ1NTX0ZJTFRFUlMgPSBFTkFCTEVfQ1NTX0ZJTFRFUlM7CiBFTkFC TEVfQ1NTX0hJRVJBUkNISUVTID0gOwo=