98671 2012-10-08 11:35:03 -0700 Upstream some tweaks for overlay play button on Android 2012-10-08 13:58:43 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 66687 0 qinmin webkit-unassigned abarth cmarcelo eric.carlson feature-media-reviews macpherson menard webkit.review.bot oldest_to_newest 736842 0 qinmin 2012-10-08 11:35:03 -0700 Upstream some tweaks for overlay play button on Android 736848 1 167573 qinmin 2012-10-08 11:38:50 -0700 Created attachment 167573 Patch 736878 2 167573 abarth 2012-10-08 11:51:59 -0700 Comment on attachment 167573 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167573&action=review > Source/WebCore/css/mediaControlsChromiumAndroid.css:93 > + overflow:hidden; Looks like you're missing a space after the : 736903 3 167580 qinmin 2012-10-08 12:02:15 -0700 Created attachment 167580 Patch 736905 4 qinmin 2012-10-08 12:03:42 -0700 Oops. Sorry, fixed, also fixed some other offenders in the same file (In reply to comment #2) > (From update of attachment 167573 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=167573&action=review > > > Source/WebCore/css/mediaControlsChromiumAndroid.css:93 > > + overflow:hidden; > > Looks like you're missing a space after the : 736927 5 167580 abarth 2012-10-08 12:25:08 -0700 Comment on attachment 167580 Patch Thanks! 737007 6 167580 webkit.review.bot 2012-10-08 13:58:39 -0700 Comment on attachment 167580 Patch Clearing flags on attachment: 167580 Committed r130683: <http://trac.webkit.org/changeset/130683> 737008 7 webkit.review.bot 2012-10-08 13:58:43 -0700 All reviewed patches have been landed. Closing bug. 167573 2012-10-08 11:38:50 -0700 2012-10-08 12:02:11 -0700 Patch bug-98671-20121008113753.patch text/plain 1569 qinmin U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwNjQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjE0MTAxOWFjOTRiMjAy ZTZjOGUyZGM1Y2U4MjMyYzBhMWQ5ZTAwNy4uMWE1MjVhNzJlMmEwNTU2NjM2N2M3NDQ4YjVhZTM2 NjZkMWZjODFkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEwLTA4ICBNaW4g UWluICA8cWlubWluQGNocm9taXVtLm9yZz4KKworICAgICAgICBVcHN0cmVhbSBzb21lIHR3ZWFr cyBmb3Igb3ZlcmxheSBwbGF5IGJ1dHRvbiBvbiBBbmRyb2lkCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05ODY3MQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgY2hhbmdlIHN0b3BzIGRpc3BsYXlpbmcg dGhlIG92ZXJsYXkgcGxheSBidXR0b24gaWYgdmlkZW8gaGVpZ2h0IGlzIHRvbyBzbWFsbAorICAg ICAgICBObyB0ZXN0IGZvciB0aGlzLiBXaWxsIHJlYmFzZSBsYXlvdXQgdGVzdCBleHBlY3RhdGlv bnMgZm9yIGFuZHJvaWQgbGF0ZXIuCisKKyAgICAgICAgKiBjc3MvbWVkaWFDb250cm9sc0Nocm9t aXVtQW5kcm9pZC5jc3M6CisgICAgICAgICh2aWRlbzo6LXdlYmtpdC1tZWRpYS1jb250cm9scy1v dmVybGF5LWVuY2xvc3VyZSk6CisKIDIwMTItMTAtMDggIFpvbHRhbiBIb3J2YXRoICA8em9sdGFu QHdlYmtpdC5vcmc+CiAKICAgICAgICAgW1F0XSByMTIyNzIwIGNhdXNlcyBwZXJmb3JtYW5jZSBy ZWdyZXNzaW9uIHdpdGggRGlyZWN0RkIgb24gQVJNdjcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2Nzcy9tZWRpYUNvbnRyb2xzQ2hyb21pdW1BbmRyb2lkLmNzcyBiL1NvdXJjZS9XZWJDb3Jl L2Nzcy9tZWRpYUNvbnRyb2xzQ2hyb21pdW1BbmRyb2lkLmNzcwppbmRleCBkODY5ODFjN2UzMzAy ZTk0NzczYjY1NmEwMmFlMDQ3YmNmOWRkN2I4Li5iN2YyNGJlOTU0Njc5YjAwZmM0Mzg0ODRlYzYx NWI5NTVjZmQ2NGVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvbWVkaWFDb250cm9s c0Nocm9taXVtQW5kcm9pZC5jc3MKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL21lZGlhQ29udHJv bHNDaHJvbWl1bUFuZHJvaWQuY3NzCkBAIC04Niw5ICs4NiwxMSBAQCB2aWRlbzo6LXdlYmtpdC1t ZWRpYS1jb250cm9scy1vdmVybGF5LWVuY2xvc3VyZSB7CiAgICAgLXdlYmtpdC1ib3gtYWxpZ246 Y2VudGVyOwogICAgIC13ZWJraXQtYm94LWZsZXg6MTsKICAgICB3aWR0aDogMTAwJTsKKyAgICBo ZWlnaHQ6IDEwMCU7CiAgICAgbWF4LXdpZHRoOiA4MDBweDsKICAgICB0ZXh0LWluZGVudDogMDsK ICAgICBib3gtc2l6aW5nOiBib3JkZXItYm94OworICAgIG92ZXJmbG93OmhpZGRlbjsKIH0KIAog YXVkaW86Oi13ZWJraXQtbWVkaWEtY29udHJvbHMtbXV0ZS1idXR0b24sIHZpZGVvOjotd2Via2l0 LW1lZGlhLWNvbnRyb2xzLW11dGUtYnV0dG9uIHsK 167580 2012-10-08 12:02:15 -0700 2012-10-08 13:58:39 -0700 Patch bug-98671-20121008120118.patch text/plain 1805 qinmin U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwNjQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjE0MTAxOWFjOTRiMjAy ZTZjOGUyZGM1Y2U4MjMyYzBhMWQ5ZTAwNy4uMWE1MjVhNzJlMmEwNTU2NjM2N2M3NDQ4YjVhZTM2 NjZkMWZjODFkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEwLTA4ICBNaW4g UWluICA8cWlubWluQGNocm9taXVtLm9yZz4KKworICAgICAgICBVcHN0cmVhbSBzb21lIHR3ZWFr cyBmb3Igb3ZlcmxheSBwbGF5IGJ1dHRvbiBvbiBBbmRyb2lkCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05ODY3MQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgY2hhbmdlIHN0b3BzIGRpc3BsYXlpbmcg dGhlIG92ZXJsYXkgcGxheSBidXR0b24gaWYgdmlkZW8gaGVpZ2h0IGlzIHRvbyBzbWFsbAorICAg ICAgICBObyB0ZXN0IGZvciB0aGlzLiBXaWxsIHJlYmFzZSBsYXlvdXQgdGVzdCBleHBlY3RhdGlv bnMgZm9yIGFuZHJvaWQgbGF0ZXIuCisKKyAgICAgICAgKiBjc3MvbWVkaWFDb250cm9sc0Nocm9t aXVtQW5kcm9pZC5jc3M6CisgICAgICAgICh2aWRlbzo6LXdlYmtpdC1tZWRpYS1jb250cm9scy1v dmVybGF5LWVuY2xvc3VyZSk6CisKIDIwMTItMTAtMDggIFpvbHRhbiBIb3J2YXRoICA8em9sdGFu QHdlYmtpdC5vcmc+CiAKICAgICAgICAgW1F0XSByMTIyNzIwIGNhdXNlcyBwZXJmb3JtYW5jZSBy ZWdyZXNzaW9uIHdpdGggRGlyZWN0RkIgb24gQVJNdjcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2Nzcy9tZWRpYUNvbnRyb2xzQ2hyb21pdW1BbmRyb2lkLmNzcyBiL1NvdXJjZS9XZWJDb3Jl L2Nzcy9tZWRpYUNvbnRyb2xzQ2hyb21pdW1BbmRyb2lkLmNzcwppbmRleCBkODY5ODFjN2UzMzAy ZTk0NzczYjY1NmEwMmFlMDQ3YmNmOWRkN2I4Li43ZWM3NGE5OTkwYTgwOWM0ZjM3OTI1MDlkM2U5 YzI5ZmU2ODZhZWQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvbWVkaWFDb250cm9s c0Nocm9taXVtQW5kcm9pZC5jc3MKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL21lZGlhQ29udHJv bHNDaHJvbWl1bUFuZHJvaWQuY3NzCkBAIC04MiwxMyArODIsMTUgQEAgYXVkaW86Oi13ZWJraXQt bWVkaWEtY29udHJvbHMtb3ZlcmxheS1lbmNsb3N1cmUgewogdmlkZW86Oi13ZWJraXQtbWVkaWEt Y29udHJvbHMtb3ZlcmxheS1lbmNsb3N1cmUgewogICAgIGRpc3BsYXk6IC13ZWJraXQtYm94Owog ICAgIC13ZWJraXQtYm94LW9yaWVudDogaG9yaXpvbnRhbDsKLSAgICAtd2Via2l0LWJveC1wYWNr OmNlbnRlcjsKLSAgICAtd2Via2l0LWJveC1hbGlnbjpjZW50ZXI7Ci0gICAgLXdlYmtpdC1ib3gt ZmxleDoxOworICAgIC13ZWJraXQtYm94LXBhY2s6IGNlbnRlcjsKKyAgICAtd2Via2l0LWJveC1h bGlnbjogY2VudGVyOworICAgIC13ZWJraXQtYm94LWZsZXg6IDE7CiAgICAgd2lkdGg6IDEwMCU7 CisgICAgaGVpZ2h0OiAxMDAlOwogICAgIG1heC13aWR0aDogODAwcHg7CiAgICAgdGV4dC1pbmRl bnQ6IDA7CiAgICAgYm94LXNpemluZzogYm9yZGVyLWJveDsKKyAgICBvdmVyZmxvdzogaGlkZGVu OwogfQogCiBhdWRpbzo6LXdlYmtpdC1tZWRpYS1jb250cm9scy1tdXRlLWJ1dHRvbiwgdmlkZW86 Oi13ZWJraXQtbWVkaWEtY29udHJvbHMtbXV0ZS1idXR0b24gewo=