98667 2012-10-08 10:52:14 -0700 [EFL][WK2] Add support for window.close in Minibrowser 2012-10-11 17:42:31 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 98649 1 cdumez cdumez gyuyoung.kim kangil.han kenneth laszlo.gombos lucas.de.marchi tonikitoo webkit.review.bot oldest_to_newest 736799 0 cdumez 2012-10-08 10:52:14 -0700 When calling window.close() from JavaScript, MiniBrowser does not currently close the window as directed. 736802 1 167564 cdumez 2012-10-08 10:58:01 -0700 Created attachment 167564 Patch 736835 2 167564 laszlo.gombos 2012-10-08 11:30:34 -0700 Comment on attachment 167564 Patch LGTM, r+. 736846 3 167564 webkit.review.bot 2012-10-08 11:37:34 -0700 Comment on attachment 167564 Patch Clearing flags on attachment: 167564 Committed r130660: <http://trac.webkit.org/changeset/130660> 736847 4 webkit.review.bot 2012-10-08 11:37:39 -0700 All reviewed patches have been landed. Closing bug. 740472 5 jinwoo7.song 2012-10-11 17:42:31 -0700 *** Bug 93828 has been marked as a duplicate of this bug. *** 167564 2012-10-08 10:58:01 -0700 2012-10-08 11:37:34 -0700 Patch 98667_window_close_minibrowser.patch text/plain 2817 cdumez ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBiOTI4 ZDQwLi42YzFlMDY2IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDUgKzEsMjEgQEAKIDIwMTItMTAtMDggIENocmlzdG9waGUgRHVtZXogIDxj aHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KIAorICAgICAgICBbRUZMXVtXSzJdIEFkZCBzdXBw b3J0IGZvciB3aW5kb3cuY2xvc2UgaW4gTWluaWJyb3dzZXIKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4NjY3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hlbiBjYWxsaW5nIHdpbmRvdy5jbG9zZSgpIGZy b20gSmF2YVNjcmlwdCwgTWluaUJyb3dzZXIKKyAgICAgICAgbm93IGNsb3NlcyB0aGUgZ2l2ZW4g d2luZG93LgorCisgICAgICAgICogTWluaUJyb3dzZXIvZWZsL21haW4uYzoKKyAgICAgICAgKHdp bmRvd19jbG9zZSk6CisgICAgICAgIChvbl9lY29yZV9ldmFzX2RlbGV0ZSk6CisgICAgICAgIChv bl9jbG9zZV93aW5kb3cpOgorICAgICAgICAod2luZG93X2NyZWF0ZSk6CisKKzIwMTItMTAtMDgg IENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKwogICAgICAg ICBbRUZMXSBVc2UgQ3RybCtuIHNob3J0Y3V0IHRvIGNyZWF0ZSBhIG5ldyB3aW5kb3cgaW4gTWlu aUJyb3dzZXIgLyBFV2ViTGF1bmNoZXIKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTk4NjU1CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL01pbmlCcm93c2VyL2Vm bC9tYWluLmMgYi9Ub29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jCmluZGV4IDgzNGVmZjMuLjZl NGE2Y2EgMTAwNjQ0Ci0tLSBhL1Rvb2xzL01pbmlCcm93c2VyL2VmbC9tYWluLmMKKysrIGIvVG9v bHMvTWluaUJyb3dzZXIvZWZsL21haW4uYwpAQCAtOTcsNiArOTcsMTUgQEAgc3RhdGljIHZvaWQg d2luZG93X2ZyZWUoQnJvd3Nlcl9XaW5kb3cgKndpbmRvdykKICAgICBmcmVlKHdpbmRvdyk7CiB9 CiAKK3N0YXRpYyB2b2lkIHdpbmRvd19jbG9zZShCcm93c2VyX1dpbmRvdyAqd2luZG93KQorewor ICAgIHdpbmRvd3MgPSBlaW5hX2xpc3RfcmVtb3ZlKHdpbmRvd3MsIHdpbmRvdyk7CisgICAgd2lu ZG93X2ZyZWUod2luZG93KTsKKworICAgIGlmICghd2luZG93cykKKyAgICAgICAgZWNvcmVfbWFp bl9sb29wX3F1aXQoKTsKK30KKwogc3RhdGljIEVpbmFfQm9vbCBtYWluX3NpZ25hbF9leGl0KHZv aWQgKmRhdGEsIGludCBldl90eXBlLCB2b2lkICpldikKIHsKICAgICBCcm93c2VyX1dpbmRvdyAq d2luZG93OwpAQCAtMTA5LDEzICsxMTgsNyBAQCBzdGF0aWMgRWluYV9Cb29sIG1haW5fc2lnbmFs X2V4aXQodm9pZCAqZGF0YSwgaW50IGV2X3R5cGUsIHZvaWQgKmV2KQogCiBzdGF0aWMgdm9pZCBv bl9lY29yZV9ldmFzX2RlbGV0ZShFY29yZV9FdmFzICplZSkKIHsKLSAgICBCcm93c2VyX1dpbmRv dyAqd2luZG93ID0gYnJvd3Nlcl93aW5kb3dfZmluZChlZSk7Ci0KLSAgICB3aW5kb3dfZnJlZSh3 aW5kb3cpOwotICAgIHdpbmRvd3MgPSBlaW5hX2xpc3RfcmVtb3ZlKHdpbmRvd3MsIHdpbmRvdyk7 Ci0KLSAgICBpZiAoIXdpbmRvd3MpCi0gICAgICAgIGVjb3JlX21haW5fbG9vcF9xdWl0KCk7Cisg ICAgd2luZG93X2Nsb3NlKGJyb3dzZXJfd2luZG93X2ZpbmQoZWUpKTsKIH0KIAogc3RhdGljIHZv aWQgb25fZWNvcmVfZXZhc19yZXNpemUoRWNvcmVfRXZhcyAqZWUpCkBAIC0yMzEsNiArMjM0LDEy IEBAIG9uX25ld193aW5kb3codm9pZCAqdXNlcl9kYXRhLCBFdmFzX09iamVjdCAqd2Vidmlldywg dm9pZCAqZXZlbnRfaW5mbykKIH0KIAogc3RhdGljIHZvaWQKK29uX2Nsb3NlX3dpbmRvdyh2b2lk ICp1c2VyX2RhdGEsIHZvaWQgKmV2ZW50X2luZm8pCit7CisgICAgd2luZG93X2Nsb3NlKChCcm93 c2VyX1dpbmRvdyAqKXVzZXJfZGF0YSk7Cit9CisKK3N0YXRpYyB2b2lkCiBvbl9wcm9ncmVzcyh2 b2lkICp1c2VyX2RhdGEsIEV2YXNfT2JqZWN0ICp3ZWJ2aWV3LCB2b2lkICpldmVudF9pbmZvKQog ewogICAgIEJyb3dzZXJfV2luZG93ICp3aW5kb3cgPSAoQnJvd3Nlcl9XaW5kb3cgKil1c2VyX2Rh dGE7CkBAIC0zMzksNiArMzQ4LDcgQEAgc3RhdGljIEJyb3dzZXJfV2luZG93ICp3aW5kb3dfY3Jl YXRlKGNvbnN0IGNoYXIgKnVybCwgRWluYV9Cb29sIGZyYW1lX2ZsYXR0ZW5pbmcKICAgICBFd2tf U2V0dGluZ3MgKnNldHRpbmdzID0gZXdrX3ZpZXdfc2V0dGluZ3NfZ2V0KHdpbmRvdy0+d2Vidmll dyk7CiAgICAgZXdrX3NldHRpbmdzX2ZpbGVfYWNjZXNzX2Zyb21fZmlsZV91cmxzX2FsbG93ZWRf c2V0KHNldHRpbmdzLCBFSU5BX1RSVUUpOwogCisgICAgZXZhc19vYmplY3Rfc21hcnRfY2FsbGJh Y2tfYWRkKHdpbmRvdy0+d2VidmlldywgImNsb3NlLHdpbmRvdyIsIG9uX2Nsb3NlX3dpbmRvdywg d2luZG93KTsKICAgICBldmFzX29iamVjdF9zbWFydF9jYWxsYmFja19hZGQod2luZG93LT53ZWJ2 aWV3LCAiY3JlYXRlLHdpbmRvdyIsIG9uX25ld193aW5kb3csIHdpbmRvdyk7CiAgICAgZXZhc19v YmplY3Rfc21hcnRfY2FsbGJhY2tfYWRkKHdpbmRvdy0+d2VidmlldywgImRvd25sb2FkLGZhaWxl ZCIsIG9uX2Rvd25sb2FkX2ZhaWxlZCwgd2luZG93KTsKICAgICBldmFzX29iamVjdF9zbWFydF9j YWxsYmFja19hZGQod2luZG93LT53ZWJ2aWV3LCAiZG93bmxvYWQsZmluaXNoZWQiLCBvbl9kb3du bG9hZF9maW5pc2hlZCwgd2luZG93KTsK