98665 2012-10-08 10:40:49 -0700 Remove <wtf/Platform.h> include from header files. 2012-11-05 13:47:19 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All Unspecified RESOLVED FIXED P2 Normal --- 0 dgorbik webkit-unassigned benjamin darin ddkilzer dino joepeck webkit.review.bot oldest_to_newest 736788 0 dgorbik 2012-10-08 10:40:49 -0700 We don't want other clients that include WebKit headers to know about Platform.h. 736795 1 167561 dgorbik 2012-10-08 10:48:53 -0700 Created attachment 167561 Proposed fix 0.1 736797 2 webkit.review.bot 2012-10-08 10:50:25 -0700 Attachment 167561 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/tests/minidom.c'..." exit_code: 1 Source/JavaScriptCore/API/tests/minidom.c:33: Alphabetical sorting problem. [build/include_order] [4] Source/JavaScriptCore/API/tests/testapi.c:32: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style. 736837 3 167561 eric 2012-10-08 11:32:07 -0700 Comment on attachment 167561 Proposed fix 0.1 Agreed! 736941 4 dgorbik 2012-10-08 12:47:55 -0700 Style issues are because wtf/Assertions.h uses macros defined in the Platform.h. That's why they are swapped. Should I put Platform.h include above all other includes? 737119 5 ap 2012-10-08 15:24:58 -0700 <wtf/Platform.h> is normally included through config.h, which is normally the second included file in every .cpp. 743430 6 167561 webkit.review.bot 2012-10-16 12:41:05 -0700 Comment on attachment 167561 Proposed fix 0.1 Rejecting attachment 167561 from commit-queue. dgorbik@apple.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 743524 7 167561 webkit.review.bot 2012-10-16 13:59:11 -0700 Comment on attachment 167561 Proposed fix 0.1 Clearing flags on attachment: 167561 Committed r131496: <http://trac.webkit.org/changeset/131496> 743525 8 webkit.review.bot 2012-10-16 13:59:14 -0700 All reviewed patches have been landed. Closing bug. 743699 9 darin 2012-10-16 16:50:41 -0700 I am puzzled by this change. It does not seem right to me. What good is Assertions.h without Platform.h, since is uses macros in Platform.h? Is this because we have code that wants to use Assertions.h and has its own substitute for Platform.h, code outside WebKit? 743700 10 darin 2012-10-16 16:52:13 -0700 This change needed more discussion before the change was made. Not sure what to do about it now. 743745 11 darin 2012-10-16 17:46:10 -0700 The original philosophy was this: 1) Some headers are designed so they can be used outside WebKit. Those files should not include Platform.h and more importantly should not rely on things defined in Platform.h at all. 2) Other headers are designed for use only inside WebKit. Those files include Platform.h and use it. After this change, it seems like there is a new class of header that can be used outside WebKit, but if used inside WebKit must be included after Platform.h. And presumably "config.h" is supposed to mitigate that problem. But I don’t understand how a header that uses the Platform.h macros can be used outside WebKit without Platform.h. 758750 12 joepeck 2012-11-05 11:42:50 -0800 (In reply to comment #10) > This change needed more discussion before the change was made. Not sure what to do about it now. I agree with Darin here. Assertions.h makes heavy use of WTF / Platform macros. If I just make a test file to include <wtf/Assertions.h> on its own this causes more then 20 errors (clang stops printing errors) #include <wtf/Assertions.h> int main(int argc, char *argv[]) { ASSERT(true); return 0; } Errors look like: #if !COMPILER(MSVC) ~~~~~~~~~^ /Volumes/Data/Build/Debug/usr/local/include/wtf/Assertions.h:58:13: error: token is not a valid binary operator in a preprocessor subexpression #if HAVE(VARIADIC_MACRO) ~~~~^ /Volumes/Data/Build/Debug/usr/local/include/wtf/Assertions.h:85:9: error: token is not a valid binary operator in a preprocessor subexpression /Volumes/Data/Build/Debug/usr/local/include/wtf/Assertions.h:137:1: error: unknown type name 'WTF_EXPORT_PRIVATE' WTF_EXPORT_PRIVATE void WTFReportAssertionFailure(const char* file, int line, const char* function, const char* assertion); ^ /Volumes/Data/Build/Debug/usr/local/include/wtf/Assertions.h:137:20: error: expected unqualified-id In order for this to compile at all I would need to Platform.h and ExportMacros.h. And then be sure to include them before Assertions.h (error prone): #include <wtf/Platform.h> #include <wtf/ExportMacros.h> #include <wtf/Assertions.h> Removing Platform.h from WebCore headers makes sense. But, I think removing Platform.h from Assertions.h may have been a bad idea. Was there further work planned here? 758762 13 167561 ddkilzer 2012-11-05 11:52:02 -0800 Comment on attachment 167561 Proposed fix 0.1 View in context: https://bugs.webkit.org/attachment.cgi?id=167561&action=review >> Source/JavaScriptCore/API/tests/minidom.c:33 >> +#include <wtf/Platform.h> > > Alphabetical sorting problem. [build/include_order] [4] Another way to fix this is to create a a prefix header for the minidom target, or to include the "config.h" header in all of the source files in API/tests. >> Source/JavaScriptCore/API/tests/testapi.c:32 >> +#include <wtf/Platform.h> > > Alphabetical sorting problem. [build/include_order] [4] Another way to fix this is to create a a prefix header for the minidom target, or to include the "config.h" header in all of the source files in API/tests. > Source/WTF/wtf/Assertions.h:-45 > -#include <wtf/Platform.h> This may need to be added back in the short term to address any build failures, although I think this is correct in the long term. (Unless there is a special exception for Assertions.h, although I'm not aware of why that would be the case.) Any project which uses WTF headers needs to know about <wtf/Platform.h> at a project level, which means it should appear in config.h or the project's prefix header. That's true of JavaScriptCore, WebCore, WebKit and WebKit2 since they all include wtf/Platform.h in their project's config.h header (JSC, WebCore) or prefix header (WebKit) or both (WebKit2). > Tools/DumpRenderTree/mac/MockGeolocationProvider.mm:26 > +#include <wtf/Platform.h> Instead of including wtf/Platform.h here, it should include config.h instead: #import "config.h" 758840 14 ap 2012-11-05 13:47:19 -0800 Bug 101244 has a partial rollout of this change. 167561 2012-10-08 10:48:53 -0700 2012-11-05 11:52:02 -0800 Proposed fix 0.1 patch text/plain 6659 dgorbik ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvdGVzdHMvbWluaWRvbS5jIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS90ZXN0cy9taW5pZG9tLmMKaW5kZXggNDNhZTJjMS4u YmQzZTExOSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS90ZXN0cy9taW5p ZG9tLmMKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS90ZXN0cy9taW5pZG9tLmMKQEAg LTMwLDYgKzMwLDcgQEAKICNpbmNsdWRlICJKU1N0cmluZ1JlZi5oIgogI2luY2x1ZGUgPHN0ZGlv Lmg+CiAjaW5jbHVkZSA8c3RkbGliLmg+CisjaW5jbHVkZSA8d3RmL1BsYXRmb3JtLmg+CiAjaW5j bHVkZSA8d3RmL0Fzc2VydGlvbnMuaD4KICNpbmNsdWRlIDx3dGYvVW51c2VkUGFyYW0uaD4KIApk aWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS90ZXN0cy90ZXN0YXBpLmMgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL3Rlc3RzL3Rlc3RhcGkuYwppbmRleCA5MTk3OGJiLi5i OTExZTA4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL3Rlc3RzL3Rlc3Rh cGkuYworKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL3Rlc3RzL3Rlc3RhcGkuYwpAQCAt MjksNiArMjksNyBAQAogI2luY2x1ZGUgIkpTT2JqZWN0UmVmUHJpdmF0ZS5oIgogI2luY2x1ZGUg PG1hdGguaD4KICNkZWZpbmUgQVNTRVJUX0RJU0FCTEVEIDAKKyNpbmNsdWRlIDx3dGYvUGxhdGZv cm0uaD4KICNpbmNsdWRlIDx3dGYvQXNzZXJ0aW9ucy5oPgogI2luY2x1ZGUgPHd0Zi9VbnVzZWRQ YXJhbS5oPgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBjMGViZTM3Li41YTgwYzBhIDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0xMC0wOCAgRGlt YSBHb3JiaWsgIDxkZ29yYmlrQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgUGxhdGZvcm0u aCBpbmNsdWRlIGZyb20gdGhlIGhlYWRlciBmaWxlcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4NjY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgZG9uJ3Qgd2FudCBvdGhlciBjbGllbnRzIHRoYXQg aW5jbHVkZSBXZWJLaXQgaGVhZGVycyB0byBrbm93IGFib3V0IFBsYXRmb3JtLmguCisKKyAgICAg ICAgKiBBUEkvdGVzdHMvbWluaWRvbS5jOgorICAgICAgICAqIEFQSS90ZXN0cy90ZXN0YXBpLmM6 CisKIDIwMTItMTAtMDUgIE1hcmsgSGFobmVuYmVyZyAgPG1oYWhuZW5iZXJnQGFwcGxlLmNvbT4K IAogICAgICAgICBKU0Mgc2hvdWxkIGhhdmUgYSB3YXkgdG8gZ2F0aGVyIGFuZCBsb2cgSGVhcCBt ZW1vcnkgdXNlIGFuZCBwYXVzZSB0aW1lcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi9DaGFuZ2VM b2cgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwppbmRleCBiMDA1ZTMxLi5mNDg3NTkwIDEwMDY0NAot LS0gYS9Tb3VyY2UvV1RGL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE1IEBACisyMDEyLTEwLTA4ICBEaW1hIEdvcmJpayAgPGRnb3JiaWtAYXBwbGUuY29t PgorCisgICAgICAgIFJlbW92ZSBQbGF0Zm9ybS5oIGluY2x1ZGUgZnJvbSB0aGUgaGVhZGVyIGZp bGVzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTg2 NjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBk b24ndCB3YW50IG90aGVyIGNsaWVudHMgdGhhdCBpbmNsdWRlIFdlYktpdCBoZWFkZXJzIHRvIGtu b3cgYWJvdXQgUGxhdGZvcm0uaC4KKworICAgICAgICAqIHd0Zi9Bc3NlcnRpb25zLmg6CisgICAg ICAgICogd3RmL01haW5UaHJlYWQuaDoKKwogMjAxMi0xMC0wNSAgU2ltb24gUGVuYSAgPHNwZW5h QGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gQWRkIHN1cHBvcnQgZm9yIEdCeXRlcyBpbiBH UmVmUHRyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9Bc3NlcnRpb25zLmggYi9Tb3VyY2Uv V1RGL3d0Zi9Bc3NlcnRpb25zLmgKaW5kZXggN2UwNzlhYi4uZjM0N2EyMSAxMDA2NDQKLS0tIGEv U291cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL0Fzc2VydGlv bnMuaApAQCAtNDIsOCArNDIsNiBAQAogICAgaHR0cDovL21zZG4yLm1pY3Jvc29mdC5jb20vZW4t dXMvbGlicmFyeS9tczE3NzQxNShWUy44MCkuYXNweAogKi8KIAotI2luY2x1ZGUgPHd0Zi9QbGF0 Zm9ybS5oPgotCiAjaW5jbHVkZSA8c3RkZGVmLmg+CiAKICNpZiAhQ09NUElMRVIoTVNWQykKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL01haW5UaHJlYWQuaCBiL1NvdXJjZS9XVEYvd3RmL01h aW5UaHJlYWQuaAppbmRleCAyNDIwMDc3Li45YTQwYWQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RG L3d0Zi9NYWluVGhyZWFkLmgKKysrIGIvU291cmNlL1dURi93dGYvTWFpblRocmVhZC5oCkBAIC0z MCw4ICszMCw2IEBACiAjaWZuZGVmIE1haW5UaHJlYWRfaAogI2RlZmluZSBNYWluVGhyZWFkX2gK IAotI2luY2x1ZGUgPHd0Zi9QbGF0Zm9ybS5oPgotCiAjaW5jbHVkZSA8c3RkaW50Lmg+CiAKIG5h bWVzcGFjZSBXVEYgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDI1YzIxNjMuLmViMzczMTUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxOSBAQAorMjAxMi0xMC0wOCAgRGltYSBHb3JiaWsgIDxkZ29yYmlrQGFwcGxl LmNvbT4KKworICAgICAgICBSZW1vdmUgUGxhdGZvcm0uaCBpbmNsdWRlIGZyb20gdGhlIGhlYWRl ciBmaWxlcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTk4NjY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg V2UgZG9uJ3Qgd2FudCBvdGhlciBjbGllbnRzIHRoYXQgaW5jbHVkZSBXZWJLaXQgaGVhZGVycyB0 byBrbm93IGFib3V0IFBsYXRmb3JtLmguCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLgorCisgICAg ICAgICogcGxhdGZvcm0vTWVtb3J5UHJlc3N1cmVIYW5kbGVyLmg6CisgICAgICAgICogcGxhdGZv cm0vZ3JhcGhpY3MvZmlsdGVycy9hcm0vRkVDb21wb3NpdGVBcml0aG1ldGljTkVPTi5oOgorICAg ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvYXJtL0ZFR2F1c3NpYW5CbHVyTkVPTi5o OgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvYXJtL0ZFTGlnaHRpbmdORU9O Lmg6CisKIDIwMTItMTAtMDUgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwu Y29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMzA1NTYgYW5kIHIxMzA1 NjQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9NZW1vcnlQcmVzc3VyZUhh bmRsZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL01lbW9yeVByZXNzdXJlSGFuZGxlci5o CmluZGV4IGRmNjJjYTIuLmQ4OTRmODQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL01lbW9yeVByZXNzdXJlSGFuZGxlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L01lbW9yeVByZXNzdXJlSGFuZGxlci5oCkBAIC0yOCw3ICsyOCw2IEBACiAKICNpbmNsdWRlIDx0 aW1lLmg+CiAjaW5jbHVkZSA8d3RmL0Zhc3RBbGxvY0Jhc2UuaD4KLSNpbmNsdWRlIDx3dGYvUGxh dGZvcm0uaD4KIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL2FybS9GRUNvbXBvc2l0ZUFyaXRobWV0aWNO RU9OLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL2FybS9GRUNv bXBvc2l0ZUFyaXRobWV0aWNORU9OLmgKaW5kZXggNTBmMzRiNy4uMjM1NGRmYyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZmlsdGVycy9hcm0vRkVDb21wb3Np dGVBcml0aG1ldGljTkVPTi5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2ZpbHRlcnMvYXJtL0ZFQ29tcG9zaXRlQXJpdGhtZXRpY05FT04uaApAQCAtMjcsOCArMjcsNiBA QAogI2lmbmRlZiBGRUNvbXBvc2l0ZUFyaXRobWV0aWNORU9OX2gKICNkZWZpbmUgRkVDb21wb3Np dGVBcml0aG1ldGljTkVPTl9oCiAKLSNpbmNsdWRlIDx3dGYvUGxhdGZvcm0uaD4KLQogI2lmIEVO QUJMRShGSUxURVJTKSAmJiBIQVZFKEFSTV9ORU9OX0lOVFJJTlNJQ1MpCiAKICNpbmNsdWRlICJG RUNvbXBvc2l0ZS5oIgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvZmlsdGVycy9hcm0vRkVHYXVzc2lhbkJsdXJORU9OLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9maWx0ZXJzL2FybS9GRUdhdXNzaWFuQmx1ck5FT04uaAppbmRleCA5M2I0 NmNmLi4zOTVjMzBhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9maWx0ZXJzL2FybS9GRUdhdXNzaWFuQmx1ck5FT04uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL2FybS9GRUdhdXNzaWFuQmx1ck5FT04uaApAQCAtMjcs OCArMjcsNiBAQAogI2lmbmRlZiBGRUdhdXNzaWFuQmx1ck5FT05faAogI2RlZmluZSBGRUdhdXNz aWFuQmx1ck5FT05faAogCi0jaW5jbHVkZSA8d3RmL1BsYXRmb3JtLmg+Ci0KICNpZiBFTkFCTEUo RklMVEVSUykgJiYgSEFWRShBUk1fTkVPTl9JTlRSSU5TSUNTKQogCiAjaW5jbHVkZSAiRkVHYXVz c2lhbkJsdXIuaCIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2ZpbHRlcnMvYXJtL0ZFTGlnaHRpbmdORU9OLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9maWx0ZXJzL2FybS9GRUxpZ2h0aW5nTkVPTi5oCmluZGV4IDEzYzk3NWMuLjY4Mjky MmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMv YXJtL0ZFTGlnaHRpbmdORU9OLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvZmlsdGVycy9hcm0vRkVMaWdodGluZ05FT04uaApAQCAtMjcsOCArMjcsNiBAQAogI2lmbmRl ZiBGRUxpZ2h0aW5nTmVvbl9oCiAjZGVmaW5lIEZFTGlnaHRpbmdOZW9uX2gKIAotI2luY2x1ZGUg PHd0Zi9QbGF0Zm9ybS5oPgotCiAjaWYgQ1BVKEFSTV9ORU9OKSAmJiBDUFUoQVJNX1RSQURJVElP TkFMKSAmJiBDT01QSUxFUihHQ0MpCiAKICNpbmNsdWRlICJGRUxpZ2h0aW5nLmgiCmRpZmYgLS1n aXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTM1M2QxNi4uNjk0 ZjAxYiAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE0IEBACisyMDEyLTEwLTA4ICBEaW1hIEdvcmJpayAgPGRnb3JiaWtAYXBwbGUu Y29tPgorCisgICAgICAgIFJlbW92ZSBQbGF0Zm9ybS5oIGluY2x1ZGUgZnJvbSB0aGUgaGVhZGVy IGZpbGVzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 OTg2NjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBX ZSBkb24ndCB3YW50IG90aGVyIGNsaWVudHMgdGhhdCBpbmNsdWRlIFdlYktpdCBoZWFkZXJzIHRv IGtub3cgYWJvdXQgUGxhdGZvcm0uaC4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL21hYy9N b2NrR2VvbG9jYXRpb25Qcm92aWRlci5tbToKKwogMjAxMi0xMC0wNSAgUmljaGFyZCBMYXJvY3F1 ZSAgPHJsYXJvY3F1ZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVGVzdFJlc3VsdHNTZXJ2ZXIg ZG9lcyBub3QgZGlzcGxheSBzeW5jX2ludGVncmF0aW9uX3Rlc3RzIHJlc3VsdHMKZGlmZiAtLWdp dCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL21hYy9Nb2NrR2VvbG9jYXRpb25Qcm92aWRlci5tbSBi L1Rvb2xzL0R1bXBSZW5kZXJUcmVlL21hYy9Nb2NrR2VvbG9jYXRpb25Qcm92aWRlci5tbQppbmRl eCA1MTU2ZDUxLi42Zjc1YjdlIDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9tYWMv TW9ja0dlb2xvY2F0aW9uUHJvdmlkZXIubW0KKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvbWFj L01vY2tHZW9sb2NhdGlvblByb3ZpZGVyLm1tCkBAIC0yMyw5ICsyMyw5IEBACiAgKiBPRiBUSElT IFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFN QUdFLiAKICAqLwogCisjaW5jbHVkZSA8d3RmL1BsYXRmb3JtLmg+CiAjaW1wb3J0ICJNb2NrR2Vv bG9jYXRpb25Qcm92aWRlci5oIgogCi0KIEBpbXBsZW1lbnRhdGlvbiBNb2NrR2VvbG9jYXRpb25Q cm92aWRlcgogCiArIChNb2NrR2VvbG9jYXRpb25Qcm92aWRlciAqKXNoYXJlZAo=