98663 2012-10-08 10:37:51 -0700 [EFL][WK2] EWK2UnitTestBase.ewk_cookie_manager_accept_policy unit test is failing 2012-10-08 13:22:40 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez gyuyoung.kim kenneth laszlo.gombos lucas.de.marchi rakuco tonikitoo webkit.review.bot oldest_to_newest 736786 0 cdumez 2012-10-08 10:37:51 -0700 EWK2UnitTestBase.ewk_cookie_manager_accept_policy unit test is failing: [ RUN ] EWK2UnitTestBase.ewk_cookie_manager_accept_policy /home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:144: Failure Value of: static_cast<char*>(eina_list_nth(hostnames, 0)) Actual: "localhost" Expected: FIRST_PARTY_DOMAIN Which is: "127.0.0.1" 736790 1 167560 cdumez 2012-10-08 10:41:10 -0700 Created attachment 167560 Patch 736820 2 167560 laszlo.gombos 2012-10-08 11:13:47 -0700 Comment on attachment 167560 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167560&action=review Patch generally looks good. > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:119 > +static int sortHostNames(const void* hostName1, const void* hostName2) This function does not really sort. compareHostNames instead ? 736830 3 167571 cdumez 2012-10-08 11:26:13 -0700 Created attachment 167571 Patch Take Laszlo's feedback into consideration. 736888 4 167571 laszlo.gombos 2012-10-08 11:55:44 -0700 Comment on attachment 167571 Patch Thanks. LGTM. 736965 5 167571 webkit.review.bot 2012-10-08 13:22:36 -0700 Comment on attachment 167571 Patch Clearing flags on attachment: 167571 Committed r130677: <http://trac.webkit.org/changeset/130677> 736966 6 webkit.review.bot 2012-10-08 13:22:40 -0700 All reviewed patches have been landed. Closing bug. 167560 2012-10-08 10:41:10 -0700 2012-10-08 11:26:13 -0700 Patch 98663_cookiemanager_utest.patch text/plain 2114 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA5ZGYzMzcwLi41Zjg0ODlhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTItMTAtMDggIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIEVXSzJVbml0VGVzdEJhc2UuZXdrX2Nvb2tpZV9t YW5hZ2VyX2FjY2VwdF9wb2xpY3kgdW5pdCB0ZXN0IGlzIGZhaWxpbmcKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4NjYzCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRVdLMlVuaXRUZXN0QmFzZS5ld2tfY29v a2llX21hbmFnZXJfYWNjZXB0X3BvbGljeSB1bml0IHRlc3Qgd2FzCisgICAgICAgIGZhaWxpbmcg YmVjYXVzZSB0aGUgZWxlbWVudHMgb2YgYSBsaXN0IHdlcmUgY2hlY2tlZCBpbiBhIGdpdmVuCisg ICAgICAgIG9yZGVyIGJ1dCB0aGUgbGlzdCB3YXMgbm90IHNvcnRlZCBiZWZvcmVoYW5kLgorCisg ICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX2Nvb2tpZV9tYW5hZ2Vy LmNwcDoKKyAgICAgICAgKHNvcnRIb3N0TmFtZXMpOgorICAgICAgICAoVEVTVF9GKToKKwogMjAx Mi0xMC0wOCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAg ICAgICAgW0dUS10gQWRkIGEgc2V0dGluZyB0byBlbmFibGUvZGlzYWJsZSBzbW9vdGggc2Nyb2xs aW5nIHRvIFdlYktpdDIgR1RLKyBBUEkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvZWZsL3Rlc3RzL3Rlc3RfZXdrMl9jb29raWVfbWFuYWdlci5jcHAgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3azJfY29va2llX21hbmFnZXIu Y3BwCmluZGV4IDg1NTlmODIuLmRiMzQ4OGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL3Rlc3RfZXdrMl9jb29raWVfbWFuYWdlci5jcHAKKysrIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX2Nvb2tpZV9t YW5hZ2VyLmNwcApAQCAtMTE2LDYgKzExNiwxMSBAQCBzdGF0aWMgaW50IGNvdW50SG9zdG5hbWVz V2l0aENvb2tpZXMoRXdrX0Nvb2tpZV9NYW5hZ2VyKiBtYW5hZ2VyKQogICAgIHJldHVybiBjb3Vu dDsKIH0KIAorc3RhdGljIGludCBzb3J0SG9zdE5hbWVzKGNvbnN0IHZvaWQqIGhvc3ROYW1lMSwg Y29uc3Qgdm9pZCogaG9zdE5hbWUyKQoreworICAgIHJldHVybiBzdHJjbXAoc3RhdGljX2Nhc3Q8 Y29uc3QgY2hhcio+KGhvc3ROYW1lMSksIHN0YXRpY19jYXN0PGNvbnN0IGNoYXIqPihob3N0TmFt ZTIpKTsKK30KKwogVEVTVF9GKEVXSzJVbml0VGVzdEJhc2UsIGV3a19jb29raWVfbWFuYWdlcl9h Y2NlcHRfcG9saWN5KQogewogICAgIE93blB0cjxFV0syVW5pdFRlc3RTZXJ2ZXI+IGh0dHBTZXJ2 ZXIgPSBhZG9wdFB0cihuZXcgRVdLMlVuaXRUZXN0U2VydmVyKTsKQEAgLTE0MSw2ICsxNDYsNyBA QCBURVNUX0YoRVdLMlVuaXRUZXN0QmFzZSwgZXdrX2Nvb2tpZV9tYW5hZ2VyX2FjY2VwdF9wb2xp Y3kpCiAKICAgICBob3N0bmFtZXMgPSBnZXRIb3N0bmFtZXNXaXRoQ29va2llcyhjb29raWVNYW5h Z2VyKTsKICAgICBBU1NFUlRfRVEoMiwgZWluYV9saXN0X2NvdW50KGhvc3RuYW1lcykpOworICAg IGhvc3RuYW1lcyA9IGVpbmFfbGlzdF9zb3J0KGhvc3RuYW1lcywgZWluYV9saXN0X2NvdW50KGhv c3RuYW1lcyksIHNvcnRIb3N0TmFtZXMpOwogICAgIEFTU0VSVF9TVFJFUShGSVJTVF9QQVJUWV9E T01BSU4sIHN0YXRpY19jYXN0PGNoYXIqPihlaW5hX2xpc3RfbnRoKGhvc3RuYW1lcywgMCkpKTsK ICAgICBBU1NFUlRfU1RSRVEoVEhJUkRfUEFSVFlfRE9NQUlOLCBzdGF0aWNfY2FzdDxjaGFyKj4o ZWluYV9saXN0X250aChob3N0bmFtZXMsIDEpKSk7CiAgICAgZnJlZUhvc3ROYW1lcyhob3N0bmFt ZXMpOwo= 167571 2012-10-08 11:26:13 -0700 2012-10-08 13:22:36 -0700 Patch 98663_cookiemanager_utest.patch text/plain 2120 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA5ZGYzMzcwLi41Zjg0ODlhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTItMTAtMDggIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIEVXSzJVbml0VGVzdEJhc2UuZXdrX2Nvb2tpZV9t YW5hZ2VyX2FjY2VwdF9wb2xpY3kgdW5pdCB0ZXN0IGlzIGZhaWxpbmcKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4NjYzCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRVdLMlVuaXRUZXN0QmFzZS5ld2tfY29v a2llX21hbmFnZXJfYWNjZXB0X3BvbGljeSB1bml0IHRlc3Qgd2FzCisgICAgICAgIGZhaWxpbmcg YmVjYXVzZSB0aGUgZWxlbWVudHMgb2YgYSBsaXN0IHdlcmUgY2hlY2tlZCBpbiBhIGdpdmVuCisg ICAgICAgIG9yZGVyIGJ1dCB0aGUgbGlzdCB3YXMgbm90IHNvcnRlZCBiZWZvcmVoYW5kLgorCisg ICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX2Nvb2tpZV9tYW5hZ2Vy LmNwcDoKKyAgICAgICAgKHNvcnRIb3N0TmFtZXMpOgorICAgICAgICAoVEVTVF9GKToKKwogMjAx Mi0xMC0wOCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAg ICAgICAgW0dUS10gQWRkIGEgc2V0dGluZyB0byBlbmFibGUvZGlzYWJsZSBzbW9vdGggc2Nyb2xs aW5nIHRvIFdlYktpdDIgR1RLKyBBUEkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvZWZsL3Rlc3RzL3Rlc3RfZXdrMl9jb29raWVfbWFuYWdlci5jcHAgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3azJfY29va2llX21hbmFnZXIu Y3BwCmluZGV4IDg1NTlmODIuLjIxOGFmY2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL3Rlc3RfZXdrMl9jb29raWVfbWFuYWdlci5jcHAKKysrIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX2Nvb2tpZV9t YW5hZ2VyLmNwcApAQCAtMTE2LDYgKzExNiwxMSBAQCBzdGF0aWMgaW50IGNvdW50SG9zdG5hbWVz V2l0aENvb2tpZXMoRXdrX0Nvb2tpZV9NYW5hZ2VyKiBtYW5hZ2VyKQogICAgIHJldHVybiBjb3Vu dDsKIH0KIAorc3RhdGljIGludCBjb21wYXJlSG9zdE5hbWVzKGNvbnN0IHZvaWQqIGhvc3ROYW1l MSwgY29uc3Qgdm9pZCogaG9zdE5hbWUyKQoreworICAgIHJldHVybiBzdHJjbXAoc3RhdGljX2Nh c3Q8Y29uc3QgY2hhcio+KGhvc3ROYW1lMSksIHN0YXRpY19jYXN0PGNvbnN0IGNoYXIqPihob3N0 TmFtZTIpKTsKK30KKwogVEVTVF9GKEVXSzJVbml0VGVzdEJhc2UsIGV3a19jb29raWVfbWFuYWdl cl9hY2NlcHRfcG9saWN5KQogewogICAgIE93blB0cjxFV0syVW5pdFRlc3RTZXJ2ZXI+IGh0dHBT ZXJ2ZXIgPSBhZG9wdFB0cihuZXcgRVdLMlVuaXRUZXN0U2VydmVyKTsKQEAgLTE0MSw2ICsxNDYs NyBAQCBURVNUX0YoRVdLMlVuaXRUZXN0QmFzZSwgZXdrX2Nvb2tpZV9tYW5hZ2VyX2FjY2VwdF9w b2xpY3kpCiAKICAgICBob3N0bmFtZXMgPSBnZXRIb3N0bmFtZXNXaXRoQ29va2llcyhjb29raWVN YW5hZ2VyKTsKICAgICBBU1NFUlRfRVEoMiwgZWluYV9saXN0X2NvdW50KGhvc3RuYW1lcykpOwor ICAgIGhvc3RuYW1lcyA9IGVpbmFfbGlzdF9zb3J0KGhvc3RuYW1lcywgZWluYV9saXN0X2NvdW50 KGhvc3RuYW1lcyksIGNvbXBhcmVIb3N0TmFtZXMpOwogICAgIEFTU0VSVF9TVFJFUShGSVJTVF9Q QVJUWV9ET01BSU4sIHN0YXRpY19jYXN0PGNoYXIqPihlaW5hX2xpc3RfbnRoKGhvc3RuYW1lcywg MCkpKTsKICAgICBBU1NFUlRfU1RSRVEoVEhJUkRfUEFSVFlfRE9NQUlOLCBzdGF0aWNfY2FzdDxj aGFyKj4oZWluYV9saXN0X250aChob3N0bmFtZXMsIDEpKSk7CiAgICAgZnJlZUhvc3ROYW1lcyho b3N0bmFtZXMpOwo=