98655 2012-10-08 09:32:13 -0700 [EFL] Use Ctrl+n shortcut to create a new window in MiniBrowser / EWebLauncher 2012-10-08 10:13:54 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez gyuyoung.kim kenneth laszlo.gombos lucas.de.marchi rakuco tonikitoo webkit.review.bot oldest_to_newest 736721 0 cdumez 2012-10-08 09:32:13 -0700 Use Ctrl+n shortcut to create a new window in MiniBrowser / EWebLauncher. Currently "F9" is used but "Ctrl+n" is a much more standard shortcut for this action. 736724 1 167546 cdumez 2012-10-08 09:36:57 -0700 Created attachment 167546 Patch 736747 2 167546 kenneth 2012-10-08 09:54:59 -0700 Comment on attachment 167546 Patch Way better 736759 3 167546 webkit.review.bot 2012-10-08 10:13:50 -0700 Comment on attachment 167546 Patch Clearing flags on attachment: 167546 Committed r130652: <http://trac.webkit.org/changeset/130652> 736760 4 webkit.review.bot 2012-10-08 10:13:54 -0700 All reviewed patches have been landed. Closing bug. 167546 2012-10-08 09:36:57 -0700 2012-10-08 10:13:50 -0700 Patch 98655_ctrl_n.patch text/plain 2678 cdumez ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1ZTEx MWQ1Li45ZmZlMTJjIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTItMTAtMDggIENocmlzdG9waGUgRHVtZXogIDxj aHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAgICAgICBbRUZMXSBVc2UgQ3RybCtuIHNo b3J0Y3V0IHRvIGNyZWF0ZSBhIG5ldyB3aW5kb3cgaW4gTWluaUJyb3dzZXIgLyBFV2ViTGF1bmNo ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4NjU1 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlICJD dHJsK24iIHNob3J0Y3V0IGluc3RlYWQgb2YgIkY5IiB0byBvcGVuIGEgbmV3IHdpbmRvdyBpbgor ICAgICAgICBNaW5pQnJvd3NlciBhbmQgRVdlYkxhdW5jaGVyLiBUaGlzIGlzIHRoZSBzaG9ydGN1 dCB0aGF0IGlzCisgICAgICAgIGNvbW1vbmx5IHVzZWQgZm9yIHRoaXMgYWN0aW9uLgorCisgICAg ICAgICogRVdlYkxhdW5jaGVyL21haW4uYzoKKyAgICAgICAgKG9uX2tleV9kb3duKToKKyAgICAg ICAgKiBNaW5pQnJvd3Nlci9lZmwvbWFpbi5jOgorICAgICAgICAob25fa2V5X2Rvd24pOgorCiAy MDEyLTEwLTA4ICBBbmRyZWFzIEtsaW5nICA8a2xpbmdAd2Via2l0Lm9yZz4KIAogICAgICAgICBV c2luZyBmbG9hdC9kb3VibGUgYXMgV1RGIGhhc2ggdGFibGUga2V5IGlzIHVucmVsaWFibGUuCmRp ZmYgLS1naXQgYS9Ub29scy9FV2ViTGF1bmNoZXIvbWFpbi5jIGIvVG9vbHMvRVdlYkxhdW5jaGVy L21haW4uYwppbmRleCBlZWMzYzZjLi5mZTcxMDhlIDEwMDY0NAotLS0gYS9Ub29scy9FV2ViTGF1 bmNoZXIvbWFpbi5jCisrKyBiL1Rvb2xzL0VXZWJMYXVuY2hlci9tYWluLmMKQEAgLTU3Niw4ICs1 NzYsOCBAQCBvbl9rZXlfZG93bih2b2lkICpkYXRhLCBFdmFzICplLCBFdmFzX09iamVjdCAqb2Jq LCB2b2lkICpldmVudF9pbmZvKQogICAgICAgICBpbmZvKCJab29tIGluIChGOCkgd2FzIHByZXNz ZWQuXG4iKTsKICAgICAgICAgaWYgKGN1cnJlbnRab29tTGV2ZWwgPCBNQVhfWk9PTV9MRVZFTCAm JiB6b29tX2xldmVsX3NldChvYmosIGN1cnJlbnRab29tTGV2ZWwgKyAxKSkKICAgICAgICAgICAg IGN1cnJlbnRab29tTGV2ZWwrKzsKLSAgICB9IGVsc2UgaWYgKCFzdHJjbXAoZXYtPmtleSwgIkY5 IikpIHsKLSAgICAgICAgaW5mbygiQ3JlYXRlIG5ldyB3aW5kb3cgKEY5KSB3YXMgcHJlc3NlZC5c biIpOworICAgIH0gZWxzZSBpZiAoIXN0cmNtcChldi0+a2V5LCAibiIpICYmIGN0cmxQcmVzc2Vk KSB7CisgICAgICAgIGluZm8oIkNyZWF0ZSBuZXcgd2luZG93IChDdHJsK24pIHdhcyBwcmVzc2Vk LlxuIik7CiAgICAgICAgIGJyb3dzZXJDcmVhdGUoImh0dHA6Ly93d3cuZ29vZ2xlLmNvbSIsIGFw cC0+dXNlckFyZ3MpOwogICAgIH0gZWxzZSBpZiAoIXN0cmNtcChldi0+a2V5LCAiZyIpICYmIGN0 cmxQcmVzc2VkICkgewogICAgICAgICBFdmFzX0Nvb3JkIHgsIHksIHcsIGg7CmRpZmYgLS1naXQg YS9Ub29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jIGIvVG9vbHMvTWluaUJyb3dzZXIvZWZsL21h aW4uYwppbmRleCBmZTUyZTMyLi5iMmVhYTE1IDEwMDY0NAotLS0gYS9Ub29scy9NaW5pQnJvd3Nl ci9lZmwvbWFpbi5jCisrKyBiL1Rvb2xzL01pbmlCcm93c2VyL2VmbC9tYWluLmMKQEAgLTE0Nyw2 ICsxNDcsOCBAQCBvbl9rZXlfZG93bih2b2lkICpkYXRhLCBFdmFzICplLCBFdmFzX09iamVjdCAq b2JqLCB2b2lkICpldmVudF9pbmZvKQogICAgICAgICBOVUxMCiAgICAgfTsKICAgICBzdGF0aWMg aW50IGN1cnJlbnRFbmNvZGluZyA9IC0xOworICAgIEVpbmFfQm9vbCBjdHJsUHJlc3NlZCA9IGV2 YXNfa2V5X21vZGlmaWVyX2lzX3NldChldmFzX2tleV9tb2RpZmllcl9nZXQoZSksICJDb250cm9s Iik7CisKICAgICBpZiAoIXN0cmNtcChldi0+a2V5LCAiRjEiKSkgewogICAgICAgICBpbmZvKCJC YWNrIChGMSkgd2FzIHByZXNzZWRcbiIpOwogICAgICAgICBpZiAoIWV3a192aWV3X2JhY2sob2Jq KSkKQEAgLTE2NSw4ICsxNjcsOCBAQCBvbl9rZXlfZG93bih2b2lkICpkYXRhLCBFdmFzICplLCBF dmFzX09iamVjdCAqb2JqLCB2b2lkICpldmVudF9pbmZvKQogICAgIH0gZWxzZSBpZiAoIXN0cmNt cChldi0+a2V5LCAiRjYiKSkgewogICAgICAgICBpbmZvKCJTdG9wIChGNikgd2FzIHByZXNzZWQs IHN0b3AgbG9hZGluZy5cbiIpOwogICAgICAgICBld2tfdmlld19zdG9wKG9iaik7Ci0gICAgfSBl bHNlIGlmICghc3RyY21wKGV2LT5rZXksICJGOSIpKSB7Ci0gICAgICAgIGluZm8oIkNyZWF0ZSBu ZXcgd2luZG93IChGOSkgd2FzIHByZXNzZWQuXG4iKTsKKyAgICB9IGVsc2UgaWYgKCFzdHJjbXAo ZXYtPmtleSwgIm4iKSAmJiBjdHJsUHJlc3NlZCkgeworICAgICAgICBpbmZvKCJDcmVhdGUgbmV3 IHdpbmRvdyAoQ3RybCtuKSB3YXMgcHJlc3NlZC5cbiIpOwogICAgICAgICBCcm93c2VyX1dpbmRv dyAqd2luZG93ID0gd2luZG93X2NyZWF0ZShERUZBVUxUX1VSTCwgRUlOQV9GQUxTRSk7CiAgICAg ICAgIHdpbmRvd3MgPSBlaW5hX2xpc3RfYXBwZW5kKHdpbmRvd3MsIHdpbmRvdyk7CiAgICAgfQo=