98649 2012-10-08 06:53:42 -0700 [EFL][WK2] Add support for window.create in Minibrowser 2012-10-08 10:52:14 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 98657 98667 1 cdumez cdumez gyuyoung.kim kenneth laszlo.gombos lucas.de.marchi tonikitoo webkit.review.bot oldest_to_newest 736671 0 cdumez 2012-10-08 06:53:42 -0700 When calling window.create() from JavaScript, MiniBrowser does not currently create a new window as directed. 736674 1 167536 cdumez 2012-10-08 07:00:22 -0700 Created attachment 167536 Patch 736691 2 167536 kenneth 2012-10-08 08:17:46 -0700 Comment on attachment 167536 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167536&action=review > Tools/MiniBrowser/efl/main.c:226 > + Browser_Window *window = window_create(NULL, EINA_FALSE); shouldnt it inherit the flattening? anyway I guess that should be fixed differently because it is quite ugly to pass around like this 736692 3 167536 webkit.review.bot 2012-10-08 08:18:49 -0700 Comment on attachment 167536 Patch Rejecting attachment 167536 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ce', u'--reviewer', u'Kenneth Ro..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue Parsed 2 diffs from patch file(s). patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/MiniBrowser/efl/main.c Hunk #3 FAILED at 357. 1 out of 3 hunks FAILED -- saving rejects to file Tools/MiniBrowser/efl/main.c.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Kenneth Ro..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/14224007 736695 4 167542 cdumez 2012-10-08 08:24:21 -0700 Created attachment 167542 Patch for landing Rebased on master. Could someone please cq+ ? 736722 5 167542 webkit.review.bot 2012-10-08 09:33:26 -0700 Comment on attachment 167542 Patch for landing Clearing flags on attachment: 167542 Committed r130646: <http://trac.webkit.org/changeset/130646> 736723 6 webkit.review.bot 2012-10-08 09:33:30 -0700 All reviewed patches have been landed. Closing bug. 167536 2012-10-08 07:00:22 -0700 2012-10-08 08:24:21 -0700 Patch 98649_window_create_minibrowser.patch text/plain 2327 cdumez ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxYTUy YzA2Li43MzEwZDU0IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMTAtMDggIENocmlzdG9waGUgRHVtZXogIDxj aHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIEFkZCBzdXBw b3J0IGZvciB3aW5kb3cuY3JlYXRlIGluIE1pbmlicm93c2VyCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05ODY0OQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENhbGxpbmcgd2luZG93LmNyZWF0ZSgpIGZyb20g SmF2YVNjcmlwdCBub3cgY3JlYXRlcyBhCisgICAgICAgIG5ldyB3aW5kb3cgaW4gTWluaWJyb3dz ZXIsIGFzIGRpcmVjdGVkLgorCisgICAgICAgICogTWluaUJyb3dzZXIvZWZsL21haW4uYzoKKyAg ICAgICAgKG9uX25ld193aW5kb3cpOgorICAgICAgICAod2luZG93X2NyZWF0ZSk6CisKIDIwMTIt MTAtMDggIEJhbGF6cyBLZWxlbWVuICA8a2JhbGF6c0B3ZWJraXQub3JnPgogCiAgICAgICAgIFtR dF0gUmVlbmFibGUgcGx1Z2luIHRlc3RzCmRpZmYgLS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci9l ZmwvbWFpbi5jIGIvVG9vbHMvTWluaUJyb3dzZXIvZWZsL21haW4uYwppbmRleCA4MzI2MTU0Li4w N2UwNWQxIDEwMDY0NAotLS0gYS9Ub29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jCisrKyBiL1Rv b2xzL01pbmlCcm93c2VyL2VmbC9tYWluLmMKQEAgLTIyMCw2ICsyMjAsMTUgQEAgb25fdXJsX2No YW5nZWQodm9pZCAqdXNlcl9kYXRhLCBFdmFzX09iamVjdCAqd2Vidmlldywgdm9pZCAqZXZlbnRf aW5mbykKIH0KIAogc3RhdGljIHZvaWQKK29uX25ld193aW5kb3codm9pZCAqdXNlcl9kYXRhLCBF dmFzX09iamVjdCAqd2Vidmlldywgdm9pZCAqZXZlbnRfaW5mbykKK3sKKyAgICBFdmFzX09iamVj dCAqKm5ld192aWV3ID0gKEV2YXNfT2JqZWN0ICoqKWV2ZW50X2luZm87CisgICAgQnJvd3Nlcl9X aW5kb3cgKndpbmRvdyA9IHdpbmRvd19jcmVhdGUoTlVMTCwgRUlOQV9GQUxTRSk7CisgICAgKm5l d192aWV3ID0gd2luZG93LT53ZWJ2aWV3OworICAgIHdpbmRvd3MgPSBlaW5hX2xpc3RfYXBwZW5k KHdpbmRvd3MsIHdpbmRvdyk7Cit9CisKK3N0YXRpYyB2b2lkCiBvbl9wcm9ncmVzcyh2b2lkICp1 c2VyX2RhdGEsIEV2YXNfT2JqZWN0ICp3ZWJ2aWV3LCB2b2lkICpldmVudF9pbmZvKQogewogICAg IEJyb3dzZXJfV2luZG93ICp3aW5kb3cgPSAoQnJvd3Nlcl9XaW5kb3cgKil1c2VyX2RhdGE7CkBA IC0zMjgsNiArMzM3LDcgQEAgc3RhdGljIEJyb3dzZXJfV2luZG93ICp3aW5kb3dfY3JlYXRlKGNv bnN0IGNoYXIgKnVybCwgRWluYV9Cb29sIGZyYW1lX2ZsYXR0ZW5pbmcKICAgICBFd2tfU2V0dGlu Z3MgKnNldHRpbmdzID0gZXdrX3ZpZXdfc2V0dGluZ3NfZ2V0KHdpbmRvdy0+d2Vidmlldyk7CiAg ICAgZXdrX3NldHRpbmdzX2ZpbGVfYWNjZXNzX2Zyb21fZmlsZV91cmxzX2FsbG93ZWRfc2V0KHNl dHRpbmdzLCBFSU5BX1RSVUUpOwogCisgICAgZXZhc19vYmplY3Rfc21hcnRfY2FsbGJhY2tfYWRk KHdpbmRvdy0+d2VidmlldywgImNyZWF0ZSx3aW5kb3ciLCBvbl9uZXdfd2luZG93LCB3aW5kb3cp OwogICAgIGV2YXNfb2JqZWN0X3NtYXJ0X2NhbGxiYWNrX2FkZCh3aW5kb3ctPndlYnZpZXcsICJk b3dubG9hZCxmYWlsZWQiLCBvbl9kb3dubG9hZF9mYWlsZWQsIHdpbmRvdyk7CiAgICAgZXZhc19v YmplY3Rfc21hcnRfY2FsbGJhY2tfYWRkKHdpbmRvdy0+d2VidmlldywgImRvd25sb2FkLGZpbmlz aGVkIiwgb25fZG93bmxvYWRfZmluaXNoZWQsIHdpbmRvdyk7CiAgICAgZXZhc19vYmplY3Rfc21h cnRfY2FsbGJhY2tfYWRkKHdpbmRvdy0+d2VidmlldywgImRvd25sb2FkLHJlcXVlc3QiLCBvbl9k b3dubG9hZF9yZXF1ZXN0LCB3aW5kb3cpOwpAQCAtMzQ3LDcgKzM1Nyw4IEBAIHN0YXRpYyBCcm93 c2VyX1dpbmRvdyAqd2luZG93X2NyZWF0ZShjb25zdCBjaGFyICp1cmwsIEVpbmFfQm9vbCBmcmFt ZV9mbGF0dGVuaW5nCiAKICAgICB3aW5kb3ctPnVybF9iYXIgPSB1cmxfYmFyX2FkZCh3aW5kb3ct PndlYnZpZXcsIERFRkFVTFRfV0lEVEgpOwogCi0gICAgZXdrX3ZpZXdfdXJpX3NldCh3aW5kb3ct PndlYnZpZXcsIHVybCk7CisgICAgaWYgKHVybCkKKyAgICAgICAgZXdrX3ZpZXdfdXJpX3NldCh3 aW5kb3ctPndlYnZpZXcsIHVybCk7CiAKICAgICByZXR1cm4gd2luZG93OwogfQo= 167542 2012-10-08 08:24:21 -0700 2012-10-08 09:33:26 -0700 Patch for landing 98649_new_window_minibrowser.patch text/plain 2365 cdumez ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1ZTEx MWQ1Li43YzdjMmIwIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMTAtMDggIENocmlzdG9waGUgRHVtZXogIDxj aHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIEFkZCBzdXBw b3J0IGZvciB3aW5kb3cuY3JlYXRlIGluIE1pbmlicm93c2VyCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05ODY0OQorCisgICAgICAgIFJldmlld2VkIGJ5 IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuLgorCisgICAgICAgIENhbGxpbmcgd2luZG93LmNy ZWF0ZSgpIGZyb20gSmF2YVNjcmlwdCBub3cgY3JlYXRlcyBhCisgICAgICAgIG5ldyB3aW5kb3cg aW4gTWluaWJyb3dzZXIsIGFzIGRpcmVjdGVkLgorCisgICAgICAgICogTWluaUJyb3dzZXIvZWZs L21haW4uYzoKKyAgICAgICAgKG9uX25ld193aW5kb3cpOgorICAgICAgICAod2luZG93X2NyZWF0 ZSk6CisKIDIwMTItMTAtMDggIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgogCiAg ICAgICAgIFVzaW5nIGZsb2F0L2RvdWJsZSBhcyBXVEYgaGFzaCB0YWJsZSBrZXkgaXMgdW5yZWxp YWJsZS4KZGlmZiAtLWdpdCBhL1Rvb2xzL01pbmlCcm93c2VyL2VmbC9tYWluLmMgYi9Ub29scy9N aW5pQnJvd3Nlci9lZmwvbWFpbi5jCmluZGV4IGZlNTJlMzIuLmYzNTM0YjMgMTAwNjQ0Ci0tLSBh L1Rvb2xzL01pbmlCcm93c2VyL2VmbC9tYWluLmMKKysrIGIvVG9vbHMvTWluaUJyb3dzZXIvZWZs L21haW4uYwpAQCAtMjIwLDYgKzIyMCwxNSBAQCBvbl91cmxfY2hhbmdlZCh2b2lkICp1c2VyX2Rh dGEsIEV2YXNfT2JqZWN0ICp3ZWJ2aWV3LCB2b2lkICpldmVudF9pbmZvKQogfQogCiBzdGF0aWMg dm9pZAorb25fbmV3X3dpbmRvdyh2b2lkICp1c2VyX2RhdGEsIEV2YXNfT2JqZWN0ICp3ZWJ2aWV3 LCB2b2lkICpldmVudF9pbmZvKQoreworICAgIEV2YXNfT2JqZWN0ICoqbmV3X3ZpZXcgPSAoRXZh c19PYmplY3QgKiopZXZlbnRfaW5mbzsKKyAgICBCcm93c2VyX1dpbmRvdyAqd2luZG93ID0gd2lu ZG93X2NyZWF0ZShOVUxMLCBFSU5BX0ZBTFNFKTsKKyAgICAqbmV3X3ZpZXcgPSB3aW5kb3ctPndl YnZpZXc7CisgICAgd2luZG93cyA9IGVpbmFfbGlzdF9hcHBlbmQod2luZG93cywgd2luZG93KTsK K30KKworc3RhdGljIHZvaWQKIG9uX3Byb2dyZXNzKHZvaWQgKnVzZXJfZGF0YSwgRXZhc19PYmpl Y3QgKndlYnZpZXcsIHZvaWQgKmV2ZW50X2luZm8pCiB7CiAgICAgQnJvd3Nlcl9XaW5kb3cgKndp bmRvdyA9IChCcm93c2VyX1dpbmRvdyAqKXVzZXJfZGF0YTsKQEAgLTMyOCw2ICszMzcsNyBAQCBz dGF0aWMgQnJvd3Nlcl9XaW5kb3cgKndpbmRvd19jcmVhdGUoY29uc3QgY2hhciAqdXJsLCBFaW5h X0Jvb2wgZnJhbWVfZmxhdHRlbmluZwogICAgIEV3a19TZXR0aW5ncyAqc2V0dGluZ3MgPSBld2tf dmlld19zZXR0aW5nc19nZXQod2luZG93LT53ZWJ2aWV3KTsKICAgICBld2tfc2V0dGluZ3NfZmls ZV9hY2Nlc3NfZnJvbV9maWxlX3VybHNfYWxsb3dlZF9zZXQoc2V0dGluZ3MsIEVJTkFfVFJVRSk7 CiAKKyAgICBldmFzX29iamVjdF9zbWFydF9jYWxsYmFja19hZGQod2luZG93LT53ZWJ2aWV3LCAi Y3JlYXRlLHdpbmRvdyIsIG9uX25ld193aW5kb3csIHdpbmRvdyk7CiAgICAgZXZhc19vYmplY3Rf c21hcnRfY2FsbGJhY2tfYWRkKHdpbmRvdy0+d2VidmlldywgImRvd25sb2FkLGZhaWxlZCIsIG9u X2Rvd25sb2FkX2ZhaWxlZCwgd2luZG93KTsKICAgICBldmFzX29iamVjdF9zbWFydF9jYWxsYmFj a19hZGQod2luZG93LT53ZWJ2aWV3LCAiZG93bmxvYWQsZmluaXNoZWQiLCBvbl9kb3dubG9hZF9m aW5pc2hlZCwgd2luZG93KTsKICAgICBldmFzX29iamVjdF9zbWFydF9jYWxsYmFja19hZGQod2lu ZG93LT53ZWJ2aWV3LCAiZG93bmxvYWQscmVxdWVzdCIsIG9uX2Rvd25sb2FkX3JlcXVlc3QsIHdp bmRvdyk7CkBAIC0zNDcsNyArMzU3LDggQEAgc3RhdGljIEJyb3dzZXJfV2luZG93ICp3aW5kb3df Y3JlYXRlKGNvbnN0IGNoYXIgKnVybCwgRWluYV9Cb29sIGZyYW1lX2ZsYXR0ZW5pbmcKIAogICAg IHdpbmRvdy0+dXJsX2JhciA9IHVybF9iYXJfYWRkKHdpbmRvdy0+d2VidmlldywgREVGQVVMVF9X SURUSCk7CiAKLSAgICBld2tfdmlld191cmxfc2V0KHdpbmRvdy0+d2VidmlldywgdXJsKTsKKyAg ICBpZiAodXJsKQorICAgICAgICBld2tfdmlld191cmxfc2V0KHdpbmRvdy0+d2VidmlldywgdXJs KTsKIAogICAgIHJldHVybiB3aW5kb3c7CiB9Cg==