98647 2012-10-08 06:45:15 -0700 Composited/HW content have the red and blue channels inverted in DRT on Chromium Android 2012-10-25 13:01:22 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 96398 100263 1 peter skyostil alokp bsalomon jamesr senorblanco skyostil tomhudson webkit.review.bot oldest_to_newest 736664 0 peter 2012-10-08 06:45:15 -0700 Composited/HW content have the red and blue channels inverted in DRT on Chromium Android. To list a few examples: * http://build.webkit.org/results/Chromium%20Android%20Release%20(Tests)/r130632%20(1228)/css3/filters/effect-drop-shadow-hw-diffs.html Test: http://trac.webkit.org/export/130632/trunk/LayoutTests/css3/filters/effect-drop-shadow-hw.html * http://build.webkit.org/results/Chromium%20Android%20Release%20(Tests)/r130632%20(1228)/compositing/shadows/shadow-drawing-diffs.html Test: http://trac.webkit.org/export/130632/trunk/LayoutTests/compositing/shadows/shadow-drawing.html This also seems to happen to text content, such as in this result: * http://build.webkit.org/results/Chromium%20Android%20Release%20(Tests)/r130632%20(1228)/compositing/sibling-positioning-diffs.html Test: http://trac.webkit.org/export/130632/trunk/LayoutTests/compositing/sibling-positioning.html Normal images and texts are fine. As a point of interest here, the red and blue channels are being inverted by code in DumpRenderTree itself, but it seems that normal (non-accelerated) screenshots also take this path. http://code.google.com/searchframe#OAMlx_jo-ck/src/third_party/WebKit/Tools/DumpRenderTree/chromium/TestShell.cpp&l=676 Could it be that the SkCanvas in m_webViewHost->canvas() returns BGRA for hardware, RGBA for software paths? 736679 1 bsalomon 2012-10-08 07:13:30 -0700 I don't think it is a Skia issue as the SW skia backend is used for at least the third test (and possibly the second as well). I'd guess it has to do with invoking the compositor. 736789 2 senorblanco 2012-10-08 10:41:07 -0700 I seem to remember Alok ran into a channel swap in the compositor someplace. Don't know if it was related. 737807 3 skyostil 2012-10-09 08:40:13 -0700 I'm guessing there's a mismatch between the compositor's read back pixel format and what Skia/WebViewHost is expecting. We've had a few of these before so it's not entirely unlikely. 750843 4 170652 skyostil 2012-10-25 08:10:12 -0700 Created attachment 170652 Patch 751105 5 170652 jamesr 2012-10-25 12:21:26 -0700 Comment on attachment 170652 Patch Hmm, so the byte order for kARGB_8888 is different on android, or the configuration itself is different? 751127 6 bsalomon 2012-10-25 12:40:28 -0700 The macros SK_R32_SHIFT, SK_G32_SHIFT, etc that define the byte order of Skia's kARGB_8888 are set differently on Android than on other platforms. 751130 7 170652 jamesr 2012-10-25 12:47:22 -0700 Comment on attachment 170652 Patch OK, thanks for the clarification. Patch seems fine but I have a sneaking suspicious that this might not be the only place we have byte order problems. 751135 8 170652 webkit.review.bot 2012-10-25 13:01:18 -0700 Comment on attachment 170652 Patch Clearing flags on attachment: 170652 Committed r132518: <http://trac.webkit.org/changeset/132518> 751136 9 webkit.review.bot 2012-10-25 13:01:22 -0700 All reviewed patches have been landed. Closing bug. 170652 2012-10-25 08:10:12 -0700 2012-10-25 13:01:17 -0700 Patch bug-98647-20121025160845.patch text/plain 2312 skyostil U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMzQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDhkMzY0ZGQ1ZDJhODdkYjYxNmQxYzMxMTljZGYxNmVhM2MxZGE1MjEuLjdhYTY2NDQ3MGQzYTg1 OWFmOTk4YmNjZjExZDMxMjNiOTAwNTRjMmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjEgQEAKKzIwMTItMTAtMjUgIFNhbWkgS3lvc3RpbGEgIDxza3lvc3RpbEBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgQ29tcG9zaXRlZC9IVyBjb250ZW50IGhhdmUgdGhlIHJlZCBh bmQgYmx1ZSBjaGFubmVscyBpbnZlcnRlZCBpbiBEUlQgb24gQ2hyb21pdW0gQW5kcm9pZAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTg2NDcKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWJMYXllclRyZWVW aWV3Ojpjb21wb3NpdGVBbmRSZWFkYmFjaygpIGFsd2F5cyBnaXZlcyBiYWNrIGRhdGEgaW4gQkdS QQorICAgICAgICBvcmRlcmluZyAoaS5lLiwgdGhlIGZpcnN0IGJ5dGUgaW4gbWVtb3J5IGlzIGJs dWUpLiBUaGlzIG1hdGNoZXMgU2tpYSdzCisgICAgICAgIFNrQml0bWFwOjprQVJHQl84ODg4X0Nv bmZpZyBvcmRlcmluZyBvbiBhbGwgcGxhdGZvcm1zIGV4Y2VwdCBBbmRyb2lkLAorICAgICAgICB3 aGVyZSBTa2lhJ3MgbmF0aXZlIGZvcm1hdCBpcyBSR0JBIChpLmUuLCByZWQgY29tZXMgZmlyc3Qg aW4gbWVtb3J5KS4KKworICAgICAgICBUaGlzIG1pc21hdGNoIGNhdXNlcyBsYXlvdXQgdGVzdCBw aXhlbCBjb21wYXJpc29uIGZhaWx1cmVzLiBUaGlzIHBhdGNoCisgICAgICAgIGZpeGVzIHRoZSBw cm9ibGVtIGJ5IHJlb3JkZXJpbmcgdGhlIGNoYW5uZWxzIHJpZ2h0IGFmdGVyIHJlYWRiYWNrLgor CisgICAgICAgICogc3JjL1dlYlZpZXdJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViVmll d0ltcGw6OmRvUGl4ZWxSZWFkYmFja1RvQ2FudmFzKToKKwogMjAxMi0wOS0yNyAgWXVyeSBTZW1p a2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBw cm92aWRlIG1lbW9yeSBpbnN0cnVtZW50YXRpb24gZm9yIExpc3RIYXNoU2V0CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAgYi9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKaW5kZXggMTYyNThhZjM5M2UwMDEwM2Mw ZjE2YWQ3MDc2MDVmZjY3MjA2NWVlOS4uYzVjODM1MTdkNzcyMjA1ODExYWRiYWI0N2U2MDZkYTQ4 NjlmNjI0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0lt cGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcApA QCAtMTc2OSw2ICsxNzY5LDE0IEBAIHZvaWQgV2ViVmlld0ltcGw6OmRvUGl4ZWxSZWFkYmFja1Rv Q2FudmFzKFdlYkNhbnZhcyogY2FudmFzLCBjb25zdCBJbnRSZWN0JiByZWN0CiAgICAgdGFyZ2V0 LnNldENvbmZpZyhTa0JpdG1hcDo6a0FSR0JfODg4OF9Db25maWcsIHJlY3Qud2lkdGgoKSwgcmVj dC5oZWlnaHQoKSwgcmVjdC53aWR0aCgpICogNCk7CiAgICAgdGFyZ2V0LmFsbG9jUGl4ZWxzKCk7 CiAgICAgbV9sYXllclRyZWVWaWV3LT5jb21wb3NpdGVBbmRSZWFkYmFjayh0YXJnZXQuZ2V0UGl4 ZWxzKCksIHJlY3QpOworI2lmICghU0tfUjMyX1NISUZUICYmIFNLX0IzMl9TSElGVCA9PSAxNikK KyAgICAvLyBUaGUgY29tcG9zaXRvciByZWFkYmFjayBhbHdheXMgZ2l2ZXMgYmFjayBwaXhlbHMg aW4gQkdSQSBvcmRlciwgYnV0IGZvcgorICAgIC8vIGV4YW1wbGUgQW5kcm9pZCdzIFNraWEgdXNl cyBSR0JBIG9yZGVyaW5nIHNvIHRoZSByZWQgYW5kIGJsdWUgY2hhbm5lbHMKKyAgICAvLyBuZWVk IHRvIGJlIHN3YXBwZWQuCisgICAgdWludDhfdCogcGl4ZWxzID0gcmVpbnRlcnByZXRfY2FzdDx1 aW50OF90Kj4odGFyZ2V0LmdldFBpeGVscygpKTsKKyAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8 IHRhcmdldC5nZXRTaXplKCk7IGkgKz0gNCkKKyAgICAgICAgc3RkOjpzd2FwKHBpeGVsc1tpXSwg cGl4ZWxzW2kgKyAyXSk7CisjZW5kaWYKICAgICBjYW52YXMtPndyaXRlUGl4ZWxzKHRhcmdldCwg cmVjdC54KCksIHJlY3QueSgpKTsKIH0KICNlbmRpZgo=