98645 2012-10-08 06:33:48 -0700 [Qt] Build with MSVC fails to use nmake instead of make 2012-11-09 01:51:40 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt P2 Normal --- 1 zarvai hausmann dbates hausmann ossy vestbo webkit.review.bot zarvai oldest_to_newest 736656 0 zarvai 2012-10-08 06:33:48 -0700 After switching MSVC build to Qt5-r37 (749b83f337ec82eff305ed8ac85473ad984c84fa) a build error occurred: WebKit is now configured for building. Just run 'make'. Last built revision was unknown, now at revision 130570. Full incremental build needed. Calling 'make -j8 incremental' in C:\WebKitBuildSlave\szeged-windows-1\qt-windows-32bit-release\build\WebKitBuild\Release 'make' is not recognized as an internal or external command, operable program or batch file. Wrong make command is used. It should be nmake instead of make. The problem caused by qmake.conf and webkitdirs.pm. Qt5.0.0-r37-angle\mkspecs\default\qmake.conf contains: QMAKESPEC_ORIGINAL = C:/WebKitBuildSlave/Qt5.0.0-r37-source/qt5/qtbase/mkspecs/win32-msvc2010 include($$QMAKESPEC_ORIGINAL/qmake.conf) WebKit\Tools\Scripts\webkitdirs.pm contains a function called retrieveQMakespecVar. This function parses qmake.conf. It can follow includes, but it can not resolve variables. The workaround for this issue is changing qmake.conf to the old value: QMAKESPEC_ORIGINAL = C:/WebKitBuildSlave/Qt5.0.0beta1-source/qt5/qtbase/mkspecs/win32-msvc2010 include(../win32-msvc2010/qmake.conf) 761611 1 173000 hausmann 2012-11-08 03:51:48 -0800 Created attachment 173000 Patch 761618 2 173003 hausmann 2012-11-08 04:05:15 -0800 Created attachment 173003 Patch 761624 3 ossy 2012-11-08 04:13:36 -0800 It is fixed in Qt - https://bugreports.qt-project.org/browse/QTBUG-27593 So I think we won't need this fix after we use fixed Qt. 761631 4 hausmann 2012-11-08 04:19:24 -0800 (In reply to comment #3) > It is fixed in Qt - https://bugreports.qt-project.org/browse/QTBUG-27593 > So I think we won't need this fix after we use fixed Qt. This is exactly what this patch builds on :). No more default/ but instead the mkspec is coded "into" qmake. We now query it out of qmake with -query QMAKE_XMKSPEC. 761829 5 173003 webkit.review.bot 2012-11-08 08:38:11 -0800 Comment on attachment 173003 Patch Rejecting attachment 173003 from commit-queue. New failing tests: fast/repaint/selection-after-delete.html Full output: http://queues.webkit.org/results/14755937 762663 6 hausmann 2012-11-09 00:37:08 -0800 Committed r134024: <http://trac.webkit.org/changeset/134024> 762701 7 ossy 2012-11-09 01:33:03 -0800 It broke our Windows bot: Calling 'make -j8 incremental' in C:\WebKitBuildSlave\szeged-windows-1\qt-windows-32bit-release\build\WebKitBuild\Release 'make' is not recognized as an internal or external command, operable program or batch file. Zoltán, could you check it? Maybe the workaround and this patch conflicts. 762716 8 hausmann 2012-11-09 01:51:40 -0800 Submitted http://trac.webkit.org/changeset/134032 to accomodate older Qt versions that don't support QMAKE_XSPEC yet but instead do install a "default" folder. 173000 2012-11-08 03:51:48 -0800 2012-11-08 04:05:10 -0800 Patch bug-98645-20121108125033.patch text/plain 1638 hausmann U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzODY2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjIzMjgyYTdkMmQyZDMxZTU4Nzc4NGQyY2RjMGUxYWVk ZGMyNWZjYS4uOTVhMWU4ZDNjMTQ1MDRhMDUyNmYwZjJmYzFiMThlMmM3YjY1ZmM3ZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTExLTA4ICBTaW1vbiBIYXVzbWFubiAgPHNpbW9uLmhhdXNtYW5uQGRpZ2lhLmNv bT4KKworICAgICAgICBbUXRdIE1TVkMgYnVpbGQgdHJ5IHRvIHVzZSBtYWtlIGluc3RlYWQgb2Yg bm1ha2Ugd2l0aCBRdDUtcjM3CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD05ODY0NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIERvbid0IHJlbHkgb24gdGhlICJkZWZhdWx0IiBta3NwZWMgYnV0IGluc3RlYWQg cXVlcnkgdGhlIHRhcmdldAorICAgICAgICBta3NwZWMgdmFyaWFibGUgZnJvbSBxbWFrZSB0byBm aW5kIHRoZSByaWdodCBxbWFrZS5jb25mLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRkaXJz LnBtOgorICAgICAgICAocXRNYWtlQ29tbWFuZCk6CisKIDIwMTItMTEtMDggIFlhZWwgQWhhcm9u ICA8eWFlbC5haGFyb25AaW50ZWwuY29tPgogCiAgICAgICAgIFtFRkxdIFR1cm4gb24gV1RGX1VT RV9USUxFRF9CQUNLSU5HX1NUT1JFIGJ5IGRlZmF1bHQKZGlmZiAtLWdpdCBhL1Rvb2xzL1Njcmlw dHMvd2Via2l0ZGlycy5wbSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQppbmRleCBjMGU3 M2MyNDY3ODkyNTllMTdjNzIwOGZiMzQ3YzA2YTdhMzk0Y2RmLi5iMGQ5Y2UzNDA0YTA2ZTE5YjY2 NDIwNDFjZWQ0YTk0ZjI1YzliODU4IDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRp cnMucG0KKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCkBAIC0xODczLDkgKzE4NzMs MTEgQEAgc3ViIHJldHJpZXZlUU1ha2VzcGVjVmFyCiBzdWIgcXRNYWtlQ29tbWFuZCgkKQogewog ICAgIG15ICgkcW1ha2ViaW4pID0gQF87Ci0gICAgY2hvbXAobXkgJG1rc3BlYyA9IGAkcW1ha2Vi aW4gLXF1ZXJ5IFFUX0hPU1RfREFUQWApOwotICAgICRta3NwZWMgLj0gIi9ta3NwZWNzL2RlZmF1 bHQiOwotICAgIG15ICRjb21waWxlciA9IHJldHJpZXZlUU1ha2VzcGVjVmFyKCIkbWtzcGVjL3Ft YWtlLmNvbmYiLCAiUU1BS0VfQ0MiKTsKKyAgICBjaG9tcChteSAkbWtzcGVjPSBgJHFtYWtlYmlu IC1xdWVyeSBRTUFLRV9YU1BFQ2ApOworICAgIGNob21wKG15ICRta3NwZWNQYXRoID0gYCRxbWFr ZWJpbiAtcXVlcnkgUVRfSE9TVF9EQVRBYCk7CisgICAgJG1rc3BlY1BhdGggLj0gIi9ta3NwZWNz LyI7CisgICAgJG1rc3BlY1BhdGggLj0gJG1rc3BlYzsKKyAgICBteSAkY29tcGlsZXIgPSByZXRy aWV2ZVFNYWtlc3BlY1ZhcigiJG1rc3BlY1BhdGgvcW1ha2UuY29uZiIsICJRTUFLRV9DQyIpOwog CiAgICAgI3ByaW50ICJkZWZhdWx0IHNwZWM6ICIgLiAkbWtzcGVjIC4gIlxuIjsKICAgICAjcHJp bnQgImNvbXBpbGVyIGZvdW5kOiAiIC4gJGNvbXBpbGVyIC4gIlxuIjsK 173003 2012-11-08 04:05:15 -0800 2012-11-08 08:38:11 -0800 Patch bug-98645-20121108130400.patch text/plain 1625 hausmann U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzODc5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTBhMDA0MWY4ZjhkYzRkZTYxNmIwYTdkMzBhODU3ZDNi ZDBhZmI5Yi4uZTUzZDIyYzhiYmExZGEyMDlmNGYxNzcyMDQ3NTc2YTgwYjVhMWU1ZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTExLTA4ICBTaW1vbiBIYXVzbWFubiAgPHNpbW9uLmhhdXNtYW5uQGRpZ2lhLmNv bT4KKworICAgICAgICBbUXRdIEJ1aWxkIHdpdGggTVNWQyBmYWlscyB0byB1c2Ugbm1ha2UgaW5z dGVhZCBvZiBtYWtlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD05ODY0NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIERvbid0IHJlbHkgb24gdGhlICJkZWZhdWx0IiBta3NwZWMgYnV0IGluc3RlYWQgcXVlcnkg dGhlIHRhcmdldAorICAgICAgICBta3NwZWMgdmFyaWFibGUgZnJvbSBxbWFrZSB0byBmaW5kIHRo ZSByaWdodCBxbWFrZS5jb25mLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRkaXJzLnBtOgor ICAgICAgICAocXRNYWtlQ29tbWFuZCk6CisKIDIwMTItMTEtMDggIERvbWluaWsgUsO2dHRzY2hl cyAgPGRvbWluaWsucm90dHNjaGVzQGludGVsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBy b2xsaW5nIG91dCByMTMzODU5LgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJz LnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCmluZGV4IDc2NzcwYjcwNmZhNWFlMjJk NDc3ZmVhMzg3NmUyZmNhZjUyNjFkY2QuLmVhMjZiZTQwNWExYWJkY2E5ZWYwZDIxMTYzNWFkNjU4 MjRmZmE2OGIgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQorKysgYi9U b29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KQEAgLTE4NzMsOSArMTg3MywxMSBAQCBzdWIgcmV0 cmlldmVRTWFrZXNwZWNWYXIKIHN1YiBxdE1ha2VDb21tYW5kKCQpCiB7CiAgICAgbXkgKCRxbWFr ZWJpbikgPSBAXzsKLSAgICBjaG9tcChteSAkbWtzcGVjID0gYCRxbWFrZWJpbiAtcXVlcnkgUVRf SE9TVF9EQVRBYCk7Ci0gICAgJG1rc3BlYyAuPSAiL21rc3BlY3MvZGVmYXVsdCI7Ci0gICAgbXkg JGNvbXBpbGVyID0gcmV0cmlldmVRTWFrZXNwZWNWYXIoIiRta3NwZWMvcW1ha2UuY29uZiIsICJR TUFLRV9DQyIpOworICAgIGNob21wKG15ICRta3NwZWM9IGAkcW1ha2ViaW4gLXF1ZXJ5IFFNQUtF X1hTUEVDYCk7CisgICAgY2hvbXAobXkgJG1rc3BlY1BhdGggPSBgJHFtYWtlYmluIC1xdWVyeSBR VF9IT1NUX0RBVEFgKTsKKyAgICAkbWtzcGVjUGF0aCAuPSAiL21rc3BlY3MvIjsKKyAgICAkbWtz cGVjUGF0aCAuPSAkbWtzcGVjOworICAgIG15ICRjb21waWxlciA9IHJldHJpZXZlUU1ha2VzcGVj VmFyKCIkbWtzcGVjUGF0aC9xbWFrZS5jb25mIiwgIlFNQUtFX0NDIik7CiAKICAgICAjcHJpbnQg ImRlZmF1bHQgc3BlYzogIiAuICRta3NwZWMgLiAiXG4iOwogICAgICNwcmludCAiY29tcGlsZXIg Zm91bmQ6ICIgLiAkY29tcGlsZXIgLiAiXG4iOwo=