98642 2012-10-08 05:01:53 -0700 [Qt][WK2] REGRESSION(r130629): It made touchadjustment/focusout-on-touch.html fail 2012-10-10 05:27:43 -0700 1 1 1 Unclassified WebKit New Bugs 420+ All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 98888 79666 98427 1 ossy jturcotte abecsi cmarcelo jturcotte kenneth menard ossy webkit.review.bot zoltan oldest_to_newest 736628 0 ossy 2012-10-08 05:01:53 -0700 https://trac.webkit.org/changeset/130629 caused the following regression: --- /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/layout-test-results/touchadjustment/focusout-on-touch-expected.txt +++ /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/layout-test-results/touchadjustment/focusout-on-touch-actual.txt @@ -1,3 +1,3 @@ -ALERT: PASS! +ALERT: FAILED, textInput is focused. You should see "ALERT: PASS!" 736640 1 ossy 2012-10-08 05:51:35 -0700 I skipped it by r130635. Please unskip it with the proper fix. 737626 2 167727 jturcotte 2012-10-09 03:55:03 -0700 Created attachment 167727 Patch 738786 3 jturcotte 2012-10-10 03:25:13 -0700 Committed r130879: <http://trac.webkit.org/changeset/130879> 738860 4 ossy 2012-10-10 05:27:43 -0700 (In reply to comment #3) > Committed r130879: <http://trac.webkit.org/changeset/130879> It caused a regression (6 crashes!) https://bugs.webkit.org/show_bug.cgi?id=98888 167727 2012-10-09 03:55:03 -0700 2012-10-09 05:00:08 -0700 Patch bug-98642-20121009125404.patch text/plain 7354 jturcotte U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwNzQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYzA4NGU2MjdlZTZmNjBj ODMxZDQ0ODBjMTBkNTk0ODUwNmJhMTQ2NC4uNWM2NGZhYmMxZDk4YWI0MGVlNWM1MDUzMmU2ZTkz NTAwYjdkZDY5YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTEwLTA5ICBKb2Nl bHluIFR1cmNvdHRlICA8am9jZWx5bi50dXJjb3R0ZUBkaWdpYS5jb20+CisKKyAgICAgICAgW1F0 XVtXSzJdIFJFR1JFU1NJT04ocjEzMDYyOSk6IEl0IG1hZGUgdG91Y2hhZGp1c3RtZW50L2ZvY3Vz b3V0LW9uLXRvdWNoLmh0bWwgZmFpMQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9OTg2NDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBUaGVyZSB3YXMgYW4gZWFybHkgcmV0dXJuIHRoYXQgd291bGQgcHJldmVu dCBnZXN0dXJlIHJlY29nbml0aW9uIGlmIG5vIFBhZ2VWaWV3cG9ydENvbnRyb2xsZXIKKyAgICAg ICAgaGFzIGJlZW4gc2V0IG9uIFF0V2ViUGFnZUV2ZW50SGFuZGxlci4gVGhlIGdlc3R1cmUgcmVj b2duaXplciBhcmUgYWxzbyB1c2VkIHRvIHNlbmQKKyAgICAgICAgR2VzdHVyZUV2ZW50cyB0byBX ZWJDb3JlIHdoaWNoIHRoaXMgbGF5b3V0IHRlc3QgaXMgdXNpbmcuCisKKyAgICAgICAgTWFrZSBz dXJlIHRoYXQgdGhlIGdlc3R1cmUgcmVjb2duaXRpb24gaXMgZG9uZSBldmVuIHdoZW4gbm8gUGFn ZVZpZXdwb3J0Q29udHJvbGxlciBpcyBwcmVzZW50LgorCisgICAgICAgICogVUlQcm9jZXNzL3F0 L1F0V2ViUGFnZUV2ZW50SGFuZGxlci5jcHA6CisgICAgICAgIChXZWJLaXQ6OlF0V2ViUGFnZUV2 ZW50SGFuZGxlcjo6aGFuZGxlSW5wdXRFdmVudCk6CisgICAgICAgIChXZWJLaXQ6OlF0V2ViUGFn ZUV2ZW50SGFuZGxlcjo6ZG9uZVdpdGhUb3VjaEV2ZW50KToKKwogMjAxMi0xMC0wNSAgSm9jZWx5 biBUdXJjb3R0ZSAgPGpvY2VseW4udHVyY290dGVAZGlnaWEuY29tPgogCiAgICAgICAgIFtRdF0g Rml4ICJBU1NFUlRJT04gRkFJTEVEOiAhZG9jdW1lbnQtPmluUGFnZUNhY2hlKCkiIHdoZW4gbG9h ZGluZyBhIHBhZ2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFdl YlBhZ2VFdmVudEhhbmRsZXIuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0V2Vi UGFnZUV2ZW50SGFuZGxlci5jcHAKaW5kZXggMjg3NmJiMmE1NmQ1NTIzZGI3MzcxMzExYjkyMDFl YzRiOTBhMmM4OS4uZmRjOTIzNTVmYTA0MTg1ZDU2MDdjNTg5ZmQyY2RjODU4YWZiMmJhMSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0V2ViUGFnZUV2ZW50SGFuZGxl ci5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0V2ViUGFnZUV2ZW50SGFu ZGxlci5jcHAKQEAgLTQ1MCw3ICs0NTAsMzggQEAgdm9pZCBRdFdlYlBhZ2VFdmVudEhhbmRsZXI6 OmRvbmVXaXRoR2VzdHVyZUV2ZW50KGNvbnN0IFdlYkdlc3R1cmVFdmVudCYgZXZlbnQsIGIKIAog dm9pZCBRdFdlYlBhZ2VFdmVudEhhbmRsZXI6OmhhbmRsZUlucHV0RXZlbnQoY29uc3QgUUlucHV0 RXZlbnQqIGV2ZW50KQogewotICAgIEFTU0VSVChtX3ZpZXdwb3J0Q29udHJvbGxlcik7CisgICAg aWYgKG1fdmlld3BvcnRDb250cm9sbGVyKSB7CisgICAgICAgIHN3aXRjaCAoZXZlbnQtPnR5cGUo KSkgeworICAgICAgICBjYXNlIFFFdmVudDo6TW91c2VCdXR0b25QcmVzczoKKyAgICAgICAgY2Fz ZSBRRXZlbnQ6OlRvdWNoQmVnaW46CisgICAgICAgICAgICBBU1NFUlQoIW1fdmlld3BvcnRDb250 cm9sbGVyLT5wYW5HZXN0dXJlQWN0aXZlKCkpOworICAgICAgICAgICAgQVNTRVJUKCFtX3ZpZXdw b3J0Q29udHJvbGxlci0+cGluY2hHZXN0dXJlQWN0aXZlKCkpOworICAgICAgICAgICAgbV92aWV3 cG9ydENvbnRyb2xsZXItPnRvdWNoQmVnaW4oKTsKKworICAgICAgICAgICAgLy8gVGhlIHBhZ2Ug dmlld3BvcnQgY29udHJvbGxlciBtaWdodCBzdGlsbCBiZSBhbmltYXRpbmcga2luZXRpYyBzY3Jv bGxpbmcgb3IgYSBzY2FsZSBhbmltYXRpb24KKyAgICAgICAgICAgIC8vIHN1Y2ggYXMgZG91Ymxl LXRhcCB0byB6b29tIG9yIHRoZSBib3VuY2UgYmFjayBlZmZlY3QuIEEgdG91Y2ggc3RvcHMgdGhl IGtpbmV0aWMgc2Nyb2xsaW5nCisgICAgICAgICAgICAvLyB3aGVyZSBhcyBpdCBkb2VzIG5vdCBz dG9wIHRoZSBzY2FsZSBhbmltYXRpb24uCisgICAgICAgICAgICAvLyBUaGUgZ2VzdHVyZSByZWNv Z25pemVyIHN0b3BzIHRoZSBraW5ldGljIHNjcm9sbGluZyBhbmltYXRpb24gaWYgbmVlZGVkLgor ICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIGNhc2UgUUV2ZW50OjpNb3VzZU1vdmU6CisgICAg ICAgIGNhc2UgUUV2ZW50OjpUb3VjaFVwZGF0ZToKKyAgICAgICAgICAgIC8vIFRoZSBzY2FsZSBh bmltYXRpb24gY2FuIG9ubHkgYmUgaW50ZXJydXB0ZWQgYnkgYSBwaW5jaCBnZXN0dXJlLCB3aGlj aCB3aWxsIHRoZW4gdGFrZSBvdmVyLgorICAgICAgICAgICAgaWYgKG1fdmlld3BvcnRDb250cm9s bGVyLT5zY2FsZUFuaW1hdGlvbkFjdGl2ZSgpICYmIG1fcGluY2hHZXN0dXJlUmVjb2duaXplci5p c1JlY29nbml6ZWQoKSkKKyAgICAgICAgICAgICAgICBtX3ZpZXdwb3J0Q29udHJvbGxlci0+aW50 ZXJydXB0U2NhbGVBbmltYXRpb24oKTsKKyAgICAgICAgICAgIGJyZWFrOworICAgICAgICBjYXNl IFFFdmVudDo6TW91c2VCdXR0b25SZWxlYXNlOgorICAgICAgICBjYXNlIFFFdmVudDo6VG91Y2hF bmQ6CisgICAgICAgICAgICBtX3ZpZXdwb3J0Q29udHJvbGxlci0+dG91Y2hFbmQoKTsKKyAgICAg ICAgICAgIGJyZWFrOworICAgICAgICBkZWZhdWx0OgorICAgICAgICAgICAgYnJlYWs7CisgICAg ICAgIH0KKworICAgICAgICAvLyBJZiB0aGUgc2NhbGUgYW5pbWF0aW9uIGlzIGFjdGl2ZSB3ZSBk b24ndCBwYXNzIHRoZSBldmVudCB0byB0aGUgcmVjb2duaXplcnMuIEluIHRoZSBmdXR1cmUKKyAg ICAgICAgLy8gd2Ugd291bGQgd2FudCB0byBxdWV1ZSB0aGUgZXZlbnQgaGVyZSBhbmQgcmVwb3N0 IHRoZW4gd2hlbiB0aGUgYW5pbWF0aW9uIGVuZHMuCisgICAgICAgIGlmIChtX3ZpZXdwb3J0Q29u dHJvbGxlci0+c2NhbGVBbmltYXRpb25BY3RpdmUoKSkKKyAgICAgICAgICAgIHJldHVybjsKKyAg ICB9CiAKICAgICBib29sIGlzTW91c2VFdmVudCA9IGZhbHNlOwogCkBAIC00NTgsNDUgKzQ4OSwy MiBAQCB2b2lkIFF0V2ViUGFnZUV2ZW50SGFuZGxlcjo6aGFuZGxlSW5wdXRFdmVudChjb25zdCBR SW5wdXRFdmVudCogZXZlbnQpCiAgICAgY2FzZSBRRXZlbnQ6Ok1vdXNlQnV0dG9uUHJlc3M6CiAg ICAgICAgIGlzTW91c2VFdmVudCA9IHRydWU7CiAgICAgICAgIG1faXNNb3VzZUJ1dHRvblByZXNz ZWQgPSB0cnVlOwotICAgICAgICAvLyBGYWxsIHRocm91Z2guCi0gICAgY2FzZSBRRXZlbnQ6OlRv dWNoQmVnaW46Ci0gICAgICAgIEFTU0VSVCghbV92aWV3cG9ydENvbnRyb2xsZXItPnBhbkdlc3R1 cmVBY3RpdmUoKSk7Ci0gICAgICAgIEFTU0VSVCghbV92aWV3cG9ydENvbnRyb2xsZXItPnBpbmNo R2VzdHVyZUFjdGl2ZSgpKTsKLSAgICAgICAgbV92aWV3cG9ydENvbnRyb2xsZXItPnRvdWNoQmVn aW4oKTsKLQotICAgICAgICAvLyBUaGUgaW50ZXJhY3Rpb24gZW5naW5lIG1pZ2h0IHN0aWxsIGJl IGFuaW1hdGluZyBraW5ldGljIHNjcm9sbGluZyBvciBhIHNjYWxlIGFuaW1hdGlvbgotICAgICAg ICAvLyBzdWNoIGFzIGRvdWJsZS10YXAgdG8gem9vbSBvciB0aGUgYm91bmNlIGJhY2sgZWZmZWN0 LiBBIHRvdWNoIHN0b3BzIHRoZSBraW5ldGljIHNjcm9sbGluZwotICAgICAgICAvLyB3aGVyZSBh cyBpdCBkb2VzIG5vdCBzdG9wIHRoZSBzY2FsZSBhbmltYXRpb24uCi0gICAgICAgIC8vIFRoZSBn ZXN0dXJlIHJlY29nbml6ZXIgc3RvcHMgdGhlIGtpbmV0aWMgc2Nyb2xsaW5nIGFuaW1hdGlvbiBp ZiBuZWVkZWQuCiAgICAgICAgIGJyZWFrOwogICAgIGNhc2UgUUV2ZW50OjpNb3VzZU1vdmU6CiAg ICAgICAgIGlmICghbV9pc01vdXNlQnV0dG9uUHJlc3NlZCkKICAgICAgICAgICAgIHJldHVybjsK LQogICAgICAgICBpc01vdXNlRXZlbnQgPSB0cnVlOwotICAgICAgICAvLyBGYWxsIHRocm91Z2gu Ci0gICAgY2FzZSBRRXZlbnQ6OlRvdWNoVXBkYXRlOgotICAgICAgICAvLyBUaGUgc2NhbGUgYW5p bWF0aW9uIGNhbiBvbmx5IGJlIGludGVycnVwdGVkIGJ5IGEgcGluY2ggZ2VzdHVyZSwgd2hpY2gg d2lsbCB0aGVuIHRha2Ugb3Zlci4KLSAgICAgICAgaWYgKG1fdmlld3BvcnRDb250cm9sbGVyLT5z Y2FsZUFuaW1hdGlvbkFjdGl2ZSgpICYmIG1fcGluY2hHZXN0dXJlUmVjb2duaXplci5pc1JlY29n bml6ZWQoKSkKLSAgICAgICAgICAgIG1fdmlld3BvcnRDb250cm9sbGVyLT5pbnRlcnJ1cHRTY2Fs ZUFuaW1hdGlvbigpOwogICAgICAgICBicmVhazsKICAgICBjYXNlIFFFdmVudDo6TW91c2VCdXR0 b25SZWxlYXNlOgogICAgICAgICBpc01vdXNlRXZlbnQgPSB0cnVlOwogICAgICAgICBtX2lzTW91 c2VCdXR0b25QcmVzc2VkID0gZmFsc2U7Ci0gICAgICAgIC8vIEZhbGwgdGhyb3VnaC4KLSAgICBj YXNlIFFFdmVudDo6VG91Y2hFbmQ6Ci0gICAgICAgIG1fdmlld3BvcnRDb250cm9sbGVyLT50b3Vj aEVuZCgpOwogICAgICAgICBicmVhazsKLSAgICBkZWZhdWx0OgotICAgICAgICBBU1NFUlQoZXZl bnQtPnR5cGUoKSA9PSBRRXZlbnQ6Ok1vdXNlQnV0dG9uRGJsQ2xpY2spOworICAgIGNhc2UgUUV2 ZW50OjpNb3VzZUJ1dHRvbkRibENsaWNrOgogICAgICAgICByZXR1cm47CisgICAgZGVmYXVsdDoK KyAgICAgICAgYnJlYWs7CiAgICAgfQogCi0gICAgLy8gSWYgdGhlIHNjYWxlIGFuaW1hdGlvbiBp cyBhY3RpdmUgd2UgZG9uJ3QgcGFzcyB0aGUgZXZlbnQgdG8gdGhlIHJlY29nbml6ZXJzLiBJbiB0 aGUgZnV0dXJlCi0gICAgLy8gd2Ugd291bGQgd2FudCB0byBxdWV1ZSB0aGUgZXZlbnQgaGVyZSBh bmQgcmVwb3N0IHRoZW4gd2hlbiB0aGUgYW5pbWF0aW9uIGVuZHMuCi0gICAgaWYgKG1fdmlld3Bv cnRDb250cm9sbGVyLT5zY2FsZUFuaW1hdGlvbkFjdGl2ZSgpKQotICAgICAgICByZXR1cm47Ci0K ICAgICBRTGlzdDxRVG91Y2hFdmVudDo6VG91Y2hQb2ludD4gYWN0aXZlVG91Y2hQb2ludHM7CiAg ICAgUVRvdWNoRXZlbnQ6OlRvdWNoUG9pbnQgY3VycmVudFRvdWNoUG9pbnQ7CiAgICAgcWludDY0 IGV2ZW50VGltZXN0YW1wTWlsbGlzID0gZXZlbnQtPnRpbWVzdGFtcCgpOwpAQCAtNTY4LDkgKzU3 Niw2IEBAIHZvaWQgUXRXZWJQYWdlRXZlbnRIYW5kbGVyOjpoYW5kbGVJbnB1dEV2ZW50KGNvbnN0 IFFJbnB1dEV2ZW50KiBldmVudCkKICNpZiBFTkFCTEUoVE9VQ0hfRVZFTlRTKQogdm9pZCBRdFdl YlBhZ2VFdmVudEhhbmRsZXI6OmRvbmVXaXRoVG91Y2hFdmVudChjb25zdCBOYXRpdmVXZWJUb3Vj aEV2ZW50JiBldmVudCwgYm9vbCB3YXNFdmVudEhhbmRsZWQpCiB7Ci0gICAgaWYgKCFtX3ZpZXdw b3J0Q29udHJvbGxlcikKLSAgICAgICAgcmV0dXJuOwotCiAgICAgaWYgKHdhc0V2ZW50SGFuZGxl ZCB8fCBldmVudC50eXBlKCkgPT0gV2ViRXZlbnQ6OlRvdWNoQ2FuY2VsKSB7CiAgICAgICAgIG1f cGFuR2VzdHVyZVJlY29nbml6ZXIuY2FuY2VsKCk7CiAgICAgICAgIG1fcGluY2hHZXN0dXJlUmVj b2duaXplci5jYW5jZWwoKTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xh eW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA1ODgyMmE4NjFiZDg3MzljYjRmODMyZGY5MTE4NDBm MmUxY2E0ODNiLi5iNzU2NTg3NWVmZGI4MTJjZjI5NzdiODgzMDY2NTk3YmRjMTEwZGE0IDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTIgQEAKKzIwMTItMTAtMDkgIEpvY2VseW4gVHVyY290dGUgIDxqb2NlbHlu LnR1cmNvdHRlQGRpZ2lhLmNvbT4KKworICAgICAgICBbUXRdW1dLMl0gUkVHUkVTU0lPTihyMTMw NjI5KTogSXQgbWFkZSB0b3VjaGFkanVzdG1lbnQvZm9jdXNvdXQtb24tdG91Y2guaHRtbCBmYWkx CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05ODY0Mgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZv cm0vcXQtNS4wLXdrMi9UZXN0RXhwZWN0YXRpb25zOiBVbnNraXAgZm9jdXNvdXQtb24tdG91Y2gu aHRtbAorCiAyMDEyLTEwLTA5ICBBbGxhbiBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5A ZGlnaWEuY29tPgogCiAgICAgICAgIFtRdF0gVXBsb2FkaW5nIGltYWdlcyB0byBHb29nbGUrIHVz aW5nIFF0V2ViS2l0IGRvZXMgbm90IHdvcmsuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9xdC01LjAtd2syL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9x dC01LjAtd2syL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggYzMwYmE3ZWM5M2VjMmU3Y2E5ODE5NjJm NDAwMDY0OGY1NjNiMTI1Zi4uYWYwYmUxNjhkZWRhYTViOTJhZmRhNWFkMTVjOTgyMDNjZjFkNTk5 ZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQtNS4wLXdrMi9UZXN0RXhwZWN0 YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0LTUuMC13azIvVGVzdEV4cGVjdGF0 aW9ucwpAQCAtNTM0LDkgKzUzNCw2IEBAIHdlYmtpdC5vcmcvYi85ODUyNSBwbHVnaW5zL25wcnVu dGltZS9icm93c2VyLW9iamVjdC1pZGVudGl0eS5odG1sCiB3ZWJraXQub3JnL2IvOTg1MjUgcGx1 Z2lucy9ucHJ1bnRpbWUvZW1iZWQtcHJvcGVydHktZXF1YWxpdHkuaHRtbAogd2Via2l0Lm9yZy9i Lzk4NTI1IHBsdWdpbnMvcmVmY291bnQtbGVha3MuaHRtbAogCi0jIFtRdF1bV0syXSBSRUdSRVNT SU9OKHIxMzA2MjkpOiBJdCBtYWRlIHRvdWNoYWRqdXN0bWVudC9mb2N1c291dC1vbi10b3VjaC5o dG1sIGZhaWwKLXdlYmtpdC5vcmcvYi85ODY0MiB0b3VjaGFkanVzdG1lbnQvZm9jdXNvdXQtb24t dG91Y2guaHRtbAotCiAjIFtRdF1bV0syXSBSdWJ5IERPTSB0ZXN0cyBkaWZmZXIgb24gV0sxIGFu ZCBXSzIKIHdlYmtpdC5vcmcvYi85ODY4OCBmYXN0L3J1YnkvcnVieURPTS1pbnNlcnQtcnQuaHRt bAogd2Via2l0Lm9yZy9iLzk4Njg4IGZhc3QvcnVieS9ydWJ5RE9NLWluc2VydC10ZXh0MS5odG1s Cg==