98631 2012-10-07 23:48:59 -0700 Rename RenderObject::firstLineStyleSlowCase() to a more appropriate cachedFirstLineStyle() 2012-10-09 04:08:30 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 arpitabahuguna webkit-unassigned arpitabahuguna dbates eric esprehn webkit.review.bot oldest_to_newest 736529 0 arpitabahuguna 2012-10-07 23:48:59 -0700 Contrary to its name, firstLineStyleSlowCase() actually picks up the cached styles. We should thus rename it to cachedFirstLineStyle() (in keeping with RenderObject::uncachedFirstLineStyle()). 736652 1 167531 arpitabahuguna 2012-10-08 06:25:35 -0700 Created attachment 167531 Patch 736712 2 167531 eric 2012-10-08 09:03:26 -0700 Comment on attachment 167531 Patch It also fetches the first line style. m_style/style() is where it's cached. I don't think this change makes sense. 736736 3 esprehn 2012-10-08 09:45:46 -0700 (In reply to comment #2) > (From update of attachment 167531 [details]) > It also fetches the first line style. m_style/style() is where it's cached. I don't think this change makes sense. Can you explain what you mean? This is the same as getCachedPseudoStyle() and getUncachedPseudoStyle(). The naming right now doesn't make any sense to me because this isn't the slow case, it's just the default case when your document uses first line styles. 736737 4 esprehn 2012-10-08 09:47:12 -0700 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 167531 [details] [details]) > > It also fetches the first line style. m_style/style() is where it's cached. I don't think this change makes sense. > > Can you explain what you mean? This is the same as getCachedPseudoStyle() and getUncachedPseudoStyle(). The naming right now doesn't make any sense to me because this isn't the slow case, it's just the default case when your document uses first line styles. For reference, I requested this change because we have getUncached and getCached for pseudo styles, but first line has uncachedFirstLineStyle() and firstLineStyle() and firstLineStyleSlowCase of which the last one doesn't have a good name since it doesn't tell you what it's really doing. :) 737100 5 167531 eric 2012-10-08 15:07:16 -0700 Comment on attachment 167531 Patch OK. 737123 6 167531 webkit.review.bot 2012-10-08 15:30:16 -0700 Comment on attachment 167531 Patch Clearing flags on attachment: 167531 Committed r130694: <http://trac.webkit.org/changeset/130694> 737124 7 webkit.review.bot 2012-10-08 15:30:19 -0700 All reviewed patches have been landed. Closing bug. 737635 8 arpitabahuguna 2012-10-09 04:08:30 -0700 Thanks Eric and Elliott for the review. 167531 2012-10-08 06:25:35 -0700 2012-10-08 15:30:16 -0700 Patch bug-98631-20121008185833.patch text/plain 3115 arpitabahuguna SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMDYzNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBACisyMDEyLTEwLTA4ICBBcnBpdGEg QmFodWd1bmEgIDxhcnBpdGFiYWh1Z3VuYUBnbWFpbC5jb20+CisKKyAgICAgICAgUmVuYW1lIFJl bmRlck9iamVjdDo6Zmlyc3RMaW5lU3R5bGVTbG93Q2FzZSgpIHRvIGEgbW9yZSBhcHByb3ByaWF0 ZSBjYWNoZWRGaXJzdExpbmVTdHlsZSgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD05ODYzMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFJlbmFtaW5nIGZpcnN0TGluZVN0eWxlU2xvd0Nhc2UoKSB0byBjYWNo ZWRGaXJzdExpbmVTdHlsZSgpLgorCisgICAgICAgIFRoZSBjdXJyZW50IG5hbWUgaXMgY29uZnVz aW5nIHNpbmNlIHRoZSBmdW5jdGlvbiBhY3R1YWxseSBnZXRzIHRoZQorICAgICAgICB0aGUgY2Fj aGVkIGZpcnN0LWxpbmUgc3R5bGVzLgorICAgICAgICBJdCBhbHNvIG1ha2VzIHRoZSBuYW1lIG1v cmUgZGVzY3JpcHRpdmUgb2YgaXRzIGZ1bmN0aW9uYWxpdHkKKyAgICAgICAgYW5kIGluIGFjY29y ZGFuY2Ugd2l0aCBSZW5kZXJPYmplY3Q6OnVuY2FjaGVkRmlyc3RMaW5lU3R5bGUoKS4KKworICAg ICAgICBObyBuZXcgdGVzdHMgcmVxdWlyZWQgZm9yIHRoaXMgY2hhbmdlIHNpbmNlIG5vIGNoYW5n ZSBpbiBiZWhhdmlvciBpcyBleHBlY3RlZC4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJP YmplY3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyT2JqZWN0OjpjYWNoZWRGaXJzdExp bmVTdHlsZSk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlck9iamVjdC5oOgorICAgICAgICAo V2ViQ29yZTo6UmVuZGVyT2JqZWN0OjpmaXJzdExpbmVTdHlsZSk6CisgICAgICAgIChSZW5kZXJP YmplY3QpOgorICAgICAgICBSZW5hbWVkIFJlbmRlck9iamVjdDo6Zmlyc3RMaW5lU3R5bGVTbG93 Q2FzZSgpIHRvIGNhY2hlZEZpcnN0TGluZVN0eWxlKCkKKyAgICAgICAgYW5kIG1hZGUgdGhlIGFz c29jaWF0ZWQgY2hhbmdlcy4KKwogMjAxMi0xMC0wOCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxj Z2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gRml4IG1ha2UgZGlzdGNo ZWNrLgpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAJKHJl dmlzaW9uIDEzMDYzNSkKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3Qu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNjQzLDcgKzI2NDMsNyBAQCBQYXNzUmVmUHRyPFJlbmRl clN0eWxlPiBSZW5kZXJPYmplY3Q6OnVuCiAgICAgcmV0dXJuIGZpcnN0TGluZVN0eWxlRm9yQ2Fj aGVkVW5jYWNoZWRUeXBlKFVuY2FjaGVkLCB0aGlzLCBzdHlsZSk7CiB9CiAKLVJlbmRlclN0eWxl KiBSZW5kZXJPYmplY3Q6OmZpcnN0TGluZVN0eWxlU2xvd0Nhc2UoKSBjb25zdAorUmVuZGVyU3R5 bGUqIFJlbmRlck9iamVjdDo6Y2FjaGVkRmlyc3RMaW5lU3R5bGUoKSBjb25zdAogewogICAgIEFT U0VSVChkb2N1bWVudCgpLT5zdHlsZVNoZWV0Q29sbGVjdGlvbigpLT51c2VzRmlyc3RMaW5lUnVs ZXMoKSk7CiAKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmgJKHJl dmlzaW9uIDEzMDYzNSkKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3Qu aAkod29ya2luZyBjb3B5KQpAQCAtNzM4LDcgKzczOCw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFs IExheW91dFVuaXQgbWF4UHJlZmVycmVkTG9naWNhbFdpZHRoKCkgY29uc3QgeyByZXR1cm4gMDsg fQogCiAgICAgUmVuZGVyU3R5bGUqIHN0eWxlKCkgY29uc3QgeyByZXR1cm4gbV9zdHlsZS5nZXQo KTsgfQotICAgIFJlbmRlclN0eWxlKiBmaXJzdExpbmVTdHlsZSgpIGNvbnN0IHsgcmV0dXJuIGRv Y3VtZW50KCktPnN0eWxlU2hlZXRDb2xsZWN0aW9uKCktPnVzZXNGaXJzdExpbmVSdWxlcygpID8g Zmlyc3RMaW5lU3R5bGVTbG93Q2FzZSgpIDogc3R5bGUoKTsgfQorICAgIFJlbmRlclN0eWxlKiBm aXJzdExpbmVTdHlsZSgpIGNvbnN0IHsgcmV0dXJuIGRvY3VtZW50KCktPnN0eWxlU2hlZXRDb2xs ZWN0aW9uKCktPnVzZXNGaXJzdExpbmVSdWxlcygpID8gY2FjaGVkRmlyc3RMaW5lU3R5bGUoKSA6 IHN0eWxlKCk7IH0KICAgICBSZW5kZXJTdHlsZSogc3R5bGUoYm9vbCBmaXJzdExpbmUpIGNvbnN0 IHsgcmV0dXJuIGZpcnN0TGluZSA/IGZpcnN0TGluZVN0eWxlKCkgOiBzdHlsZSgpOyB9CiAKICAg ICAvLyBVc2VkIG9ubHkgYnkgRWxlbWVudDo6cHNldWRvU3R5bGVDYWNoZUlzSW52YWxpZCB0byBn ZXQgYSBmaXJzdCBsaW5lIHN0eWxlIGJhc2VkIG9mZiBvZiBhCkBAIC05NjUsNyArOTY1LDcgQEAg cHJvdGVjdGVkOgogICAgIHZpcnR1YWwgdm9pZCB3aWxsQmVSZW1vdmVkRnJvbVRyZWUoKTsKIAog cHJpdmF0ZToKLSAgICBSZW5kZXJTdHlsZSogZmlyc3RMaW5lU3R5bGVTbG93Q2FzZSgpIGNvbnN0 OworICAgIFJlbmRlclN0eWxlKiBjYWNoZWRGaXJzdExpbmVTdHlsZSgpIGNvbnN0OwogICAgIFN0 eWxlRGlmZmVyZW5jZSBhZGp1c3RTdHlsZURpZmZlcmVuY2UoU3R5bGVEaWZmZXJlbmNlLCB1bnNp Z25lZCBjb250ZXh0U2Vuc2l0aXZlUHJvcGVydGllcykgY29uc3Q7CiAKICAgICBDb2xvciBzZWxl Y3Rpb25Db2xvcihpbnQgY29sb3JQcm9wZXJ0eSkgY29uc3Q7Cg==