98629 2012-10-07 22:33:47 -0700 [Chromium]Android x86 content shell debug build warning for uninitialized value used as error with gcc 4.6 2012-10-10 10:42:54 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Android Android RESOLVED FIXED P2 Normal --- 1 james.wei james.wei abarth benjamin darin peter webkit.review.bot oldest_to_newest 736515 0 james.wei 2012-10-07 22:33:47 -0700 [Chromium]Debug build warning for uninitialized value used 736516 1 167505 james.wei 2012-10-07 22:36:31 -0700 Created attachment 167505 Patch 736519 2 james.wei 2012-10-07 22:39:39 -0700 In file included from ../../third_party/WebKit/Source/WTF/wtf/HashSet.h:25:0, from ../../third_party/WebKit/Source/WTF/wtf/ListHashSet.h:25, from ../../third_party/WebKit/Source/WebCore/dom/DocumentStyleSheetCollection.h:32, from ../../third_party/WebKit/Source/WebCore/rendering/RenderObject.h:30, from ../../third_party/WebKit/Source/WebCore/rendering/RenderLayerModelObject.h:26, from ../../third_party/WebKit/Source/WebCore/rendering/RenderBoxModelObject.h:28, from ../../third_party/WebKit/Source/WebCore/rendering/RenderBox.h:26, from ../../third_party/WebKit/Source/WebCore/rendering/RenderBlock.h:29, from ../../third_party/WebKit/Source/WebCore/rendering/RenderTable.h:30, from ../../third_party/WebKit/Source/WebCore/rendering/RenderTableSection.h:28, from ../../third_party/WebKit/Source/WebCore/rendering/RenderTableSection.cpp:27: ../../third_party/WebKit/Source/WTF/wtf/HashFunctions.h: In member function 'void WTF::HashTable<Key, Value, Extractor, HashFunctions, Traits, KeyTraits>::ch pTranslator<WTF::HashMapValueTraits<WTF::HashTraits<std::pair<const WebCore::RenderTableCell*, int> >, WTF::HashTraits<WebCore::CollapsedBorderValue> >, WTF: T = std::pair<const WebCore::RenderTableCell*, int>, Key = std::pair<const WebCore::RenderTableCell*, int>, Value = WTF::KeyValuePair<std::pair<const WebCore alue>, Extractor = WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<std::pair<const WebCore::RenderTableCell*, int>, WebCore::CollapsedBorderValue> >, HashFun ll*, int>, Traits = WTF::HashMapValueTraits<WTF::HashTraits<std::pair<const WebCore::RenderTableCell*, int> >, WTF::HashTraits<WebCore::CollapsedBorderValue> Core::RenderTableCell*, int> >]': ../../third_party/WebKit/Source/WTF/wtf/HashFunctions.h:158:115: error: 'deletedValueBuffer.WTF::KeyValuePair<std::pair<const WebCore::RenderTableCell*, int> onst WebCore::RenderTableCell*, int>::second' may be used uninitialized in this function [-Werror=uninitialized] ../../third_party/WebKit/Source/WTF/wtf/HashTable.h:589:67: note: 'deletedValueBuffer.WTF::KeyValuePair<std::pair<const WebCore::RenderTableCell*, int>, WebC ebCore::RenderTableCell*, int>::second' was declared here ../../third_party/WebKit/Source/WTF/wtf/HashFunctions.h: In member function 'void WTF::HashTable<Key, Value, Extractor, HashFunctions, Traits, KeyTraits>::ch tyHashTranslator<WTF::PairHash<const WebCore::RenderTableCell*, int> >, T = std::pair<const WebCore::RenderTableCell*, int>, Key = std::pair<const WebCore::R d::pair<const WebCore::RenderTableCell*, int>, WebCore::CollapsedBorderValue>, Extractor = WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<std::pair<const We rderValue> >, HashFunctions = WTF::PairHash<const WebCore::RenderTableCell*, int>, Traits = WTF::HashMapValueTraits<WTF::HashTraits<std::pair<const WebCore:: CollapsedBorderValue> >, KeyTraits = WTF::HashTraits<std::pair<const WebCore::RenderTableCell*, int> >]': ../../third_party/WebKit/Source/WTF/wtf/HashFunctions.h:158:115: error: 'deletedValueBuffer.WTF::KeyValuePair<std::pair<const WebCore::RenderTableCell*, int> onst WebCore::RenderTableCell*, int>::second' may be used uninitialized in this function [-Werror=uninitialized] ../../third_party/WebKit/Source/WTF/wtf/HashTable.h:589:67: note: 'deletedValueBuffer.WTF::KeyValuePair<std::pair<const WebCore::RenderTableCell*, int>, WebC ebCore::RenderTableCell*, int>::second' was declared here cc1plus: all warnings being treated as errors 736523 3 167509 james.wei 2012-10-07 22:47:44 -0700 Created attachment 167509 Patch 736526 4 167509 benjamin 2012-10-07 23:03:13 -0700 Comment on attachment 167509 Patch memset is a bad idea performance wise for small data structures. I also don't see why this needs to be initialized outside it's trait's constructDeletedValue. Zeroing memory is not free. 738470 5 james.wei 2012-10-09 20:21:40 -0700 (In reply to comment #4) > (From update of attachment 167509 [details]) > memset is a bad idea performance wise for small data structures. > > I also don't see why this needs to be initialized outside it's trait's constructDeletedValue. Zeroing memory is not free. benjamin, thanks for the review. further investigation shows that this building warning only appears in android x86 gcc 4.6 debug build. I can build it successfully with x86 gcc 4.4.3 and gcc 4.6 works well for arm platform. So i suspect it is an issue of x86 gcc instead of chromium code. So i added -Wno-uninitialized into cflags for webcore_rendering for andorid x86 with gcc 4.6. is it ok? thanks 738474 6 167903 james.wei 2012-10-09 20:25:02 -0700 Created attachment 167903 Patch 738546 7 benjamin 2012-10-09 22:12:04 -0700 > So i suspect it is an issue of x86 gcc instead of chromium code. > > So i added -Wno-uninitialized into cflags for webcore_rendering for andorid x86 with gcc 4.6. > > is it ok? thanks Yes, it is ok. It is not the first time we have to workaround compiler bugs. You probably need to mention it is a compiler bug in the comment, otherwise it looks like you disable a warning instead of fixing the bug. This becomes a Chromium-Android fix, I am not the right person to accept this in the tree. 738553 8 167924 james.wei 2012-10-09 22:16:22 -0700 Created attachment 167924 Patch 738557 9 james.wei 2012-10-09 22:18:26 -0700 (In reply to comment #7) > > So i suspect it is an issue of x86 gcc instead of chromium code. > > > > So i added -Wno-uninitialized into cflags for webcore_rendering for andorid x86 with gcc 4.6. > > > > is it ok? thanks > > Yes, it is ok. > It is not the first time we have to workaround compiler bugs. You probably need to mention it is a compiler bug in the comment, otherwise it looks like you disable a warning instead of fixing the bug. > > This becomes a Chromium-Android fix, I am not the right person to accept this in the tree. thanks! abarth, peter, could you help to review it? it blocks the building of chromium android x86. thanks 739094 10 167924 abarth 2012-10-10 10:35:30 -0700 Comment on attachment 167924 Patch This seems fine to me. 739098 11 167924 webkit.review.bot 2012-10-10 10:42:50 -0700 Comment on attachment 167924 Patch Clearing flags on attachment: 167924 Committed r130925: <http://trac.webkit.org/changeset/130925> 739099 12 webkit.review.bot 2012-10-10 10:42:54 -0700 All reviewed patches have been landed. Closing bug. 167505 2012-10-07 22:36:31 -0700 2012-10-07 22:47:39 -0700 Patch bug-98629-20121008133554.patch text/plain 1501 james.wei U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwNjA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGM3YTgxMTljMmYwN2I1NzZkY2Q3OTMy OThlNjNmYjJlMDg2ZDliODYuLjVhODRhZTVlYThlZTlmODdkZWFlZGJmOGRkYWM0NGNiNjlkYTZl NGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMTAtMDcgIFdlaSBKYW1lcyAgPGphbWVzLndl aUBpbnRlbC5jb20+CisKKyAgICAgICAgW0Nocm9taXVtXURlYnVnIGJ1aWxkIHdhcm5pbmcgZm9y IHVuaW5pdGlhbGl6ZWQgdmFsdWUgdXNlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9OTg2MjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBXYXJuaW5nIHdhcyB0YWtlbiBhcyBlcnJvciBmb3IgdW5pbml0aWFs aXplZCB2YWx1ZSBiZWluZyB1c2VkIHdoZW4KKyAgICAgICAgYnVpbGRpbmcgd2l0aCBnY2MgNC42 LjMgdW5kZXIgTGludXguCisKKyAgICAgICAgKiB3dGYvSGFzaFRhYmxlLmg6CisgICAgICAgIChX VEY6Ojo6Y2hlY2tLZXkpOgorCiAyMDEyLTEwLTA3ICBCZW5qYW1pbiBQb3VsYWluICA8YmVuamFt aW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBXVEZVUkw6IGltcGxlbWVudCBVUkwgcG9ydCByZW1v dmFsIGZvciBIVE1MQW5jaG9yRWxlbWVudApkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvSGFz aFRhYmxlLmggYi9Tb3VyY2UvV1RGL3d0Zi9IYXNoVGFibGUuaAppbmRleCAxY2UzYzVjZjY4OGVm MGE4MWUxMDYxYmM2Y2UyNjIwYmUzZDk4MDBlLi5lMzU1YmQzYThkZDA2YzAyYTZmZTBhZjUwNTg3 Mjc0MTU0NTQzZmViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9IYXNoVGFibGUuaAorKysg Yi9Tb3VyY2UvV1RGL3d0Zi9IYXNoVGFibGUuaApAQCAtNTg3LDYgKzU4Nyw3IEBAIG5hbWVzcGFj ZSBXVEYgewogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICBBU1NFUlQoIUhhc2hUcmFuc2xh dG9yOjplcXVhbChLZXlUcmFpdHM6OmVtcHR5VmFsdWUoKSwga2V5KSk7CiAgICAgICAgIEFsaWdu ZWRCdWZmZXI8c2l6ZW9mKFZhbHVlVHlwZSksIFdURl9BTElHTl9PRihWYWx1ZVR5cGUpPiBkZWxl dGVkVmFsdWVCdWZmZXI7CisgICAgICAgIG1lbXNldChkZWxldGVkVmFsdWVCdWZmZXIuYnVmZmVy LCAwLCBzaXplb2YoZGVsZXRlZFZhbHVlQnVmZmVyLmJ1ZmZlcikpOwogICAgICAgICBWYWx1ZVR5 cGUqIGRlbGV0ZWRWYWx1ZVB0ciA9IHJlaW50ZXJwcmV0X2Nhc3RfcHRyPFZhbHVlVHlwZSo+KGRl bGV0ZWRWYWx1ZUJ1ZmZlci5idWZmZXIpOwogICAgICAgICBWYWx1ZVR5cGUmIGRlbGV0ZWRWYWx1 ZSA9ICpkZWxldGVkVmFsdWVQdHI7CiAgICAgICAgIFRyYWl0czo6Y29uc3RydWN0RGVsZXRlZFZh bHVlKGRlbGV0ZWRWYWx1ZSk7Cg== 167509 2012-10-07 22:47:44 -0700 2012-10-09 20:24:58 -0700 Patch bug-98629-20121008134707.patch text/plain 1500 james.wei U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwNjA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGM3YTgxMTljMmYwN2I1NzZkY2Q3OTMy OThlNjNmYjJlMDg2ZDliODYuLmMzOTkxODUyNjUyNzM1YWE3ODUyODI4YzgwZGVlMmJhZTI3NGQy NzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMTAtMDcgIFdlaSBKYW1lcyAgPGphbWVzLndl aUBpbnRlbC5jb20+CisKKyAgICAgICAgW0Nocm9taXVtXURlYnVnIGJ1aWxkIHdhcm5pbmcgZm9y IHVuaW5pdGlhbGl6ZWQgdmFsdWUgdXNlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9OTg2MjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBXYXJuaW5nIHdhcyB0YWtlbiBhcyBlcnJvciBmb3IgdW5pbml0aWFs aXplZCB2YWx1ZSBiZWluZyB1c2VkIHdoZW4KKyAgICAgICAgYnVpbGRpbmcgY29udGVudCBzaGVs bCBmb3IgQW5kcm9pZC4KKworICAgICAgICAqIHd0Zi9IYXNoVGFibGUuaDoKKyAgICAgICAgKFdU Rjo6OjpjaGVja0tleSk6CisKIDIwMTItMTAtMDcgIEJlbmphbWluIFBvdWxhaW4gIDxiZW5qYW1p bkB3ZWJraXQub3JnPgogCiAgICAgICAgIFdURlVSTDogaW1wbGVtZW50IFVSTCBwb3J0IHJlbW92 YWwgZm9yIEhUTUxBbmNob3JFbGVtZW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9IYXNo VGFibGUuaCBiL1NvdXJjZS9XVEYvd3RmL0hhc2hUYWJsZS5oCmluZGV4IDFjZTNjNWNmNjg4ZWYw YTgxZTEwNjFiYzZjZTI2MjBiZTNkOTgwMGUuLmUzNTViZDNhOGRkMDZjMDJhNmZlMGFmNTA1ODcy NzQxNTQ1NDNmZWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0hhc2hUYWJsZS5oCisrKyBi L1NvdXJjZS9XVEYvd3RmL0hhc2hUYWJsZS5oCkBAIC01ODcsNiArNTg3LDcgQEAgbmFtZXNwYWNl IFdURiB7CiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIEFTU0VSVCghSGFzaFRyYW5zbGF0 b3I6OmVxdWFsKEtleVRyYWl0czo6ZW1wdHlWYWx1ZSgpLCBrZXkpKTsKICAgICAgICAgQWxpZ25l ZEJ1ZmZlcjxzaXplb2YoVmFsdWVUeXBlKSwgV1RGX0FMSUdOX09GKFZhbHVlVHlwZSk+IGRlbGV0 ZWRWYWx1ZUJ1ZmZlcjsKKyAgICAgICAgbWVtc2V0KGRlbGV0ZWRWYWx1ZUJ1ZmZlci5idWZmZXIs IDAsIHNpemVvZihkZWxldGVkVmFsdWVCdWZmZXIuYnVmZmVyKSk7CiAgICAgICAgIFZhbHVlVHlw ZSogZGVsZXRlZFZhbHVlUHRyID0gcmVpbnRlcnByZXRfY2FzdF9wdHI8VmFsdWVUeXBlKj4oZGVs ZXRlZFZhbHVlQnVmZmVyLmJ1ZmZlcik7CiAgICAgICAgIFZhbHVlVHlwZSYgZGVsZXRlZFZhbHVl ID0gKmRlbGV0ZWRWYWx1ZVB0cjsKICAgICAgICAgVHJhaXRzOjpjb25zdHJ1Y3REZWxldGVkVmFs dWUoZGVsZXRlZFZhbHVlKTsK 167903 2012-10-09 20:25:02 -0700 2012-10-09 22:16:17 -0700 Patch bug-98629-20121010112422.patch text/plain 1553 james.wei U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwODE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTg3ZTBlNWE0YzYyN2Qz NzdmZTdmYjI0MmMyZmRjODM1M2IzMDU0NC4uNDIzNDYxODllN2Q4NGI2Y2M1Y2M0ZDhmNGY2NjEy MDVjNWQ2NzYzMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEwLTA5ICBXZWkg SmFtZXMgIDxqYW1lcy53ZWlAaW50ZWwuY29tPgorCisgICAgICAgIFtDaHJvbWl1bV1BbmRyb2lk IHg4NiBjb250ZW50IHNoZWxsIGRlYnVnIGJ1aWxkIHdhcm5pbmcgZm9yIHVuaW5pdGlhbGl6ZWQg dmFsdWUgdXNlZCBhcyBlcnJvciB3aXRoIGdjYyA0LjYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4NjI5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgV2FybmluZyB3YXMgdGFrZW4gYXMgZXJyb3IgZm9yIHVu aW5pdGlhbGl6ZWQgdmFsdWUgYmVpbmcgdXNlZCB3aGVuCisgICAgICAgIGJ1aWxkaW5nIGNvbnRl bnQgc2hlbGwgZm9yIEFuZHJvaWQgeDg2IHdpdGggZ2NjIDQuNi4KKworICAgICAgICAqIFdlYkNv cmUuZ3lwL1dlYkNvcmUuZ3lwOgorCiAyMDEyLTEwLTA5ICBOYXRlIENoYXBpbiAgPGphcGhldEBj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgTWFrZSBDYWNoZWRSZXNvdXJjZUxvYWRlciBSZWZDb3Vu dGVkIGFuZCBoYXZlIGJvdGggRG9jdW1lbnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1dl YkNvcmUuZ3lwL1dlYkNvcmUuZ3lwIGIvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXAvV2ViQ29y ZS5neXAKaW5kZXggZTFhYjY1NDFmZTQ2MTc0ZWIzNWMzY2QxZWQ3ZmU0OTQxOWM4NzQxZS4uM2I5 MjM4YWU4NWE3MmRiYmU5ZjQ5OTBlZjQzMjdjYWQ2MDIzMWQ0MCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvV2ViQ29yZS5neXAvV2ViQ29yZS5neXAKKysrIGIvU291cmNlL1dlYkNvcmUvV2Vi Q29yZS5neXAvV2ViQ29yZS5neXAKQEAgLTE5ODAsNiArMTk4MCwxMCBAQAogICAgICAgICAgICMg d2FybmluZ3MgYWJvdXQgdW5pbml0aWFsaXplZCB0aGlzLgogICAgICAgICAgICdjZmxhZ3MnOiBb Jy1Xbm8tdW5pbml0aWFsaXplZCddLAogICAgICAgICB9XSwKKyAgICAgICAgWydPUyA9PSAiYW5k cm9pZCIgYW5kIHRhcmdldF9hcmNoID09ICJpYTMyIiBhbmQgZ2NjX3ZlcnNpb24gPT0gNDYnLCB7 CisgICAgICAgICAgIyBXaXRoIGdjYyA0LjYgaW4gYW5kcm9pZCBOREssIHdlIGdldCB3YXJuaW5n cyBhYm91dCB1bmluaXRpYWxpemVkIHZhcmlhYmxlLgorICAgICAgICAgICdjZmxhZ3MnOiBbJy1X bm8tdW5pbml0aWFsaXplZCddLAorICAgICAgICB9XSwKICAgICAgICAgWyd1c2VfeDExID09IDAn LCB7CiAgICAgICAgICAgJ3NvdXJjZXMvJzogWwogICAgICAgICAgICAgWydleGNsdWRlJywgJ0xp bnV4XFwuY3BwJCddLAo= 167924 2012-10-09 22:16:22 -0700 2012-10-10 10:42:50 -0700 Patch bug-98629-20121010131542.patch text/plain 1564 james.wei U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwODE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTg3ZTBlNWE0YzYyN2Qz NzdmZTdmYjI0MmMyZmRjODM1M2IzMDU0NC4uNDIzNDYxODllN2Q4NGI2Y2M1Y2M0ZDhmNGY2NjEy MDVjNWQ2NzYzMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEwLTA5ICBXZWkg SmFtZXMgIDxqYW1lcy53ZWlAaW50ZWwuY29tPgorCisgICAgICAgIFtDaHJvbWl1bV1BbmRyb2lk IHg4NiBjb250ZW50IHNoZWxsIGRlYnVnIGJ1aWxkIHdhcm5pbmcgZm9yIHVuaW5pdGlhbGl6ZWQg dmFsdWUgdXNlZCBhcyBlcnJvciB3aXRoIGdjYyA0LjYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4NjI5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgV2FybmluZyB3YXMgdGFrZW4gYXMgZXJyb3IgZm9yIHVu aW5pdGlhbGl6ZWQgdmFsdWUgYmVpbmcgdXNlZCB3aGVuCisgICAgICAgIGJ1aWxkaW5nIGNvbnRl bnQgc2hlbGwgZm9yIEFuZHJvaWQgeDg2IHdpdGggZ2NjIDQuNi4KKworICAgICAgICAqIFdlYkNv cmUuZ3lwL1dlYkNvcmUuZ3lwOgorCiAyMDEyLTEwLTA5ICBOYXRlIENoYXBpbiAgPGphcGhldEBj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgTWFrZSBDYWNoZWRSZXNvdXJjZUxvYWRlciBSZWZDb3Vu dGVkIGFuZCBoYXZlIGJvdGggRG9jdW1lbnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1dl YkNvcmUuZ3lwL1dlYkNvcmUuZ3lwIGIvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXAvV2ViQ29y ZS5neXAKaW5kZXggZTFhYjY1NDFmZTQ2MTc0ZWIzNWMzY2QxZWQ3ZmU0OTQxOWM4NzQxZS4uZWVl YzVlZmIzNTY1ZWI0YzVmZWNiNjkwMDNkMmFiZGNmZjU1YTJjMiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvV2ViQ29yZS5neXAvV2ViQ29yZS5neXAKKysrIGIvU291cmNlL1dlYkNvcmUvV2Vi Q29yZS5neXAvV2ViQ29yZS5neXAKQEAgLTE5ODAsNiArMTk4MCwxMCBAQAogICAgICAgICAgICMg d2FybmluZ3MgYWJvdXQgdW5pbml0aWFsaXplZCB0aGlzLgogICAgICAgICAgICdjZmxhZ3MnOiBb Jy1Xbm8tdW5pbml0aWFsaXplZCddLAogICAgICAgICB9XSwKKyAgICAgICAgWydPUyA9PSAiYW5k cm9pZCIgYW5kIHRhcmdldF9hcmNoID09ICJpYTMyIiBhbmQgZ2NjX3ZlcnNpb24gPT0gNDYnLCB7 CisgICAgICAgICAgIyBEdWUgdG8gYSBidWcgaW4gZ2NjIDQuNiBpbiBhbmRyb2lkIE5ESywgd2Ug Z2V0IHdhcm5pbmdzIGFib3V0IHVuaW5pdGlhbGl6ZWQgdmFyaWFibGUuCisgICAgICAgICAgJ2Nm bGFncyc6IFsnLVduby11bmluaXRpYWxpemVkJ10sCisgICAgICAgIH1dLAogICAgICAgICBbJ3Vz ZV94MTEgPT0gMCcsIHsKICAgICAgICAgICAnc291cmNlcy8nOiBbCiAgICAgICAgICAgICBbJ2V4 Y2x1ZGUnLCAnTGludXhcXC5jcHAkJ10sCg==