98610 2012-10-06 23:51:38 -0700 [EFL][WK2] Fix unused parameter compile warning. 2012-10-07 22:20:36 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 1 kangil.han kangil.han cdumez gyuyoung.kim haraken lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 736335 0 kangil.han 2012-10-06 23:51:38 -0700 Fixed unused parameter compile warning by removing initiatingPageRef parameter name. 736336 1 167470 kangil.han 2012-10-06 23:52:55 -0700 Created attachment 167470 patch 736468 2 167470 laszlo.gombos 2012-10-07 20:06:48 -0700 Comment on attachment 167470 patch r=me. Should we enable error on warning to find these earlier ? 736476 3 167470 webkit.review.bot 2012-10-07 20:40:46 -0700 Comment on attachment 167470 patch Clearing flags on attachment: 167470 Committed r130614: <http://trac.webkit.org/changeset/130614> 736477 4 webkit.review.bot 2012-10-07 20:40:50 -0700 All reviewed patches have been landed. Closing bug. 736495 5 haraken 2012-10-07 21:46:54 -0700 gyuyoung: BTW, what was the conclusion of the webkit-dev@ discussion about how to handle unused parameters? 736496 6 cdumez 2012-10-07 21:52:28 -0700 (In reply to comment #5) > gyuyoung: BTW, what was the conclusion of the webkit-dev@ discussion about how to handle unused parameters? 1. Omit argument name if its purpose is clear without name 2. Comment the argument name otherwise 3. Use UNUSED_PARAM() macro in the #else case if the argument is used only in the #ifdef case. 736497 7 gyuyoung.kim 2012-10-07 21:54:55 -0700 (In reply to comment #5) > gyuyoung: BTW, what was the conclusion of the webkit-dev@ discussion about how to handle unused parameters? Darin's suggestion was adopted. http://lists.webkit.org/pipermail/webkit-dev/2012-October/022369.html 736498 8 haraken 2012-10-07 21:55:29 -0700 Thanks! 736499 9 cdumez 2012-10-07 21:56:12 -0700 (In reply to comment #7) > (In reply to comment #5) > > gyuyoung: BTW, what was the conclusion of the webkit-dev@ discussion about how to handle unused parameters? > > Darin's suggestion was adopted. > > http://lists.webkit.org/pipermail/webkit-dev/2012-October/022369.html BTW, it does not seem that the coding style was updated. 736501 10 gyuyoung.kim 2012-10-07 22:06:22 -0700 (In reply to comment #9) > (In reply to comment #7) > > (In reply to comment #5) > > > gyuyoung: BTW, what was the conclusion of the webkit-dev@ discussion about how to handle unused parameters? > > > > Darin's suggestion was adopted. > > > > http://lists.webkit.org/pipermail/webkit-dev/2012-October/022369.html > > BTW, it does not seem that the coding style was updated. Though Ryosuke asked this if this coding style needs to be added, there is no reply about it. It would be good if someone adds this to coding style guide document. But, the mailing thread is enough for me now. http://lists.webkit.org/pipermail/webkit-dev/2012-October/022375.html 736503 11 gyuyoung.kim 2012-10-07 22:08:51 -0700 Kentaro, do you think this coding style should be added to the webkit style guide ? 736505 12 haraken 2012-10-07 22:15:25 -0700 (In reply to comment #11) > Kentaro, do you think this coding style should be added to the webkit style guide ? As far as I understood the discussion, people have reached a consensus on the conclusion. So let's add it to the coding style guide, and just reply to the thread saying "I added it". If someone replied "Don't add it", then let's continue the discussion:) 736508 13 gyuyoung.kim 2012-10-07 22:20:36 -0700 (In reply to comment #12) > (In reply to comment #11) > > Kentaro, do you think this coding style should be added to the webkit style guide ? > > As far as I understood the discussion, people have reached a consensus on the conclusion. So let's add it to the coding style guide, and just reply to the thread saying "I added it". If someone replied "Don't add it", then let's continue the discussion:) Do you know how to modify it ? It looks I don't have a permission to modify it. Or, Ryousuke can add this. 167470 2012-10-06 23:52:55 -0700 2012-10-07 20:40:46 -0700 patch fix_unused_parameter_build_warning_1.txt text/plain 1781 kangil.han ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBiYWU1M2YxLi5iMWQwZmQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTItMTAtMDYgIEthbmdpbCBIYW4gIDxrYW5naWwuaGFuQHNhbXN1bmcuY29tPgorCisg ICAgICAgIFtFRkxdW1dLMl0gRml4IHVudXNlZCBwYXJhbWV0ZXIgY29tcGlsZSB3YXJuaW5nLgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTg2MTAKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXhlZCB1bnVz ZWQgcGFyYW1ldGVyIGNvbXBpbGUgd2FybmluZyBieSByZW1vdmluZyBpbml0aWF0aW5nUGFnZVJl ZiBwYXJhbWV0ZXIgbmFtZS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL2V3a19jb250 ZXh0X3JlcXVlc3RfbWFuYWdlcl9jbGllbnQuY3BwOgorICAgICAgICAoZGlkUmVjZWl2ZVVSSVJl cXVlc3QpOgorCiAyMDEyLTEwLTA2ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAK ICAgICAgICAgV2ViS2l0MiBwYXJ0IG9mIDxyZGFyOi8vcHJvYmxlbS8xMjQ0NjUwNz4gW21hY10g V2ViS2l0IGNsaWVudHMgY2Fubm90IGNoYW5nZSB0aGUgYmVoYXZpb3Igb2YgdGV4dC1yZW5kZXJp bmc6IGF1dG8KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3 a19jb250ZXh0X3JlcXVlc3RfbWFuYWdlcl9jbGllbnQuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9lZmwvZXdrX2NvbnRleHRfcmVxdWVzdF9tYW5hZ2VyX2NsaWVudC5jcHAKaW5k ZXggMzQ0YzgxNi4uNWE3NzA3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9lZmwvZXdrX2NvbnRleHRfcmVxdWVzdF9tYW5hZ2VyX2NsaWVudC5jcHAKKysrIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX2NvbnRleHRfcmVxdWVzdF9tYW5hZ2Vy X2NsaWVudC5jcHAKQEAgLTM3LDcgKzM3LDcgQEAgc3RhdGljIGlubGluZSBFd2tfQ29udGV4dCog dG9Fd2tDb250ZXh0KGNvbnN0IHZvaWQqIGNsaWVudEluZm8pCiAgICAgcmV0dXJuIHN0YXRpY19j YXN0PEV3a19Db250ZXh0Kj4oY29uc3RfY2FzdDx2b2lkKj4oY2xpZW50SW5mbykpOwogfQogCi1z dGF0aWMgdm9pZCBkaWRSZWNlaXZlVVJJUmVxdWVzdChXS1NvdXBSZXF1ZXN0TWFuYWdlclJlZiBz b3VwUmVxdWVzdE1hbmFnZXJSZWYsIFdLVVJMUmVmIHVybFJlZiwgV0tQYWdlUmVmIGluaXRpYXRp bmdQYWdlUmVmLCB1aW50NjRfdCByZXF1ZXN0SUQsIGNvbnN0IHZvaWQqIGNsaWVudEluZm8pCitz dGF0aWMgdm9pZCBkaWRSZWNlaXZlVVJJUmVxdWVzdChXS1NvdXBSZXF1ZXN0TWFuYWdlclJlZiBz b3VwUmVxdWVzdE1hbmFnZXJSZWYsIFdLVVJMUmVmIHVybFJlZiwgV0tQYWdlUmVmLCB1aW50NjRf dCByZXF1ZXN0SUQsIGNvbnN0IHZvaWQqIGNsaWVudEluZm8pCiB7CiAgICAgRXdrX1VybF9TY2hl bWVfUmVxdWVzdCogc2NoZW1lUmVxdWVzdCA9IGV3a191cmxfc2NoZW1lX3JlcXVlc3RfbmV3KHNv dXBSZXF1ZXN0TWFuYWdlclJlZiwgdXJsUmVmLCByZXF1ZXN0SUQpOwogICAgIGV3a19jb250ZXh0 X3VybF9zY2hlbWVfcmVxdWVzdF9yZWNlaXZlZCh0b0V3a0NvbnRleHQoY2xpZW50SW5mbyksIHNj aGVtZVJlcXVlc3QpOwo=