98607 2012-10-06 16:01:55 -0700 Reduce calls to CGImageSourceCopyPropertiesAtIndex from frameSizeAtIndex 2012-10-06 17:10:44 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 psolanki psolanki koivisto psolanki thorton oldest_to_newest 736302 0 psolanki 2012-10-06 16:01:55 -0700 ImageSource::orientationAtIndex() always calls CGImageSourceCopyPropertiesAtIndex. However in cases where the call is made from frameSizeAtIndex() we already have image properties. We can refactor the code to avoid a second call to this function under frameSizeAtIndex() 736303 1 167463 psolanki 2012-10-06 16:05:10 -0700 Created attachment 167463 Patch 736304 2 psolanki 2012-10-06 16:06:09 -0700 <rdar://problem/12438025> 736310 3 psolanki 2012-10-06 17:10:44 -0700 Committed r130591: <http://trac.webkit.org/changeset/130591> 167463 2012-10-06 16:05:10 -0700 2012-10-06 16:18:05 -0700 Patch bug-98607-20121006160416.patch text/plain 3318 psolanki U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwNTc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzRlZDgwZDg3ZmEwMzM0 OGUyNDE4Mzk4NWMwMDJjMTcyMjgyMDljMi4uMTU0OWEwZjRjYjY2M2I0MjdhMmE0YTkwZTBhYmEw YTU5NWRjYWFkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTEwLTA2ICBQcmF0 aWsgU29sYW5raSAgPHBzb2xhbmtpQGFwcGxlLmNvbT4KKworICAgICAgICBSZWR1Y2UgY2FsbHMg dG8gQ0dJbWFnZVNvdXJjZUNvcHlQcm9wZXJ0aWVzQXRJbmRleCBmcm9tIGZyYW1lU2l6ZUF0SW5k ZXgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4NjA3 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVmYWN0 b3IgY29kZSBzbyB0aGF0IHdlIGF2b2lkIGEgc2Vjb25kIGNhbGwgdG8gQ0dJbWFnZVNvdXJjZUNv cHlQcm9wZXJ0aWVzQXRJbmRleCB1bmRlcgorICAgICAgICBJbWFnZVNvdXJjZTo6ZnJhbWVTaXpl QXRJbmRleCgpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBiZWNhdXNlIG5vIGZ1bmN0aW9uYWwg Y2hhbmdlLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2cvSW1hZ2VTb3VyY2VDRy5j cHA6CisgICAgICAgIChXZWJDb3JlOjpvcmllbnRhdGlvbkZyb21Qcm9wZXJ0aWVzKToKKyAgICAg ICAgKFdlYkNvcmUpOgorICAgICAgICAoV2ViQ29yZTo6SW1hZ2VTb3VyY2U6OmZyYW1lU2l6ZUF0 SW5kZXgpOgorICAgICAgICAoV2ViQ29yZTo6SW1hZ2VTb3VyY2U6Om9yaWVudGF0aW9uQXRJbmRl eCk6CisKIDIwMTItMTAtMDUgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAg ICAgICBbVjhdIHRvVjgoTm9kZSosIC4uLikgZG9lcyBtb3JlIHdvcmsgdGhhbiBuZWVkZWQgKDYl IGZhc3RlciBvbiBkb20tdHJhdmVyc2UpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jZy9JbWFnZVNvdXJjZUNHLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2NnL0ltYWdlU291cmNlQ0cuY3BwCmluZGV4IDY1YmNlNTIzMmY0MzE3YWU3 M2FlYWU3M2VlZTkwNTEwMDJhNGI3OTIuLjA2M2VmYzY1YzMwYTczZGRjNDdlNmQwYzFjMTc0YTRh ZjVjZjQ3OGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nn L0ltYWdlU291cmNlQ0cuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2NnL0ltYWdlU291cmNlQ0cuY3BwCkBAIC0xOTQsNiArMTk0LDE4IEBAIGJvb2wgSW1hZ2VTb3Vy Y2U6OmlzU2l6ZUF2YWlsYWJsZSgpCiAgICAgcmV0dXJuIHJlc3VsdDsKIH0KIAorc3RhdGljIElt YWdlT3JpZW50YXRpb24gb3JpZW50YXRpb25Gcm9tUHJvcGVydGllcyhDRkRpY3Rpb25hcnlSZWYg aW1hZ2VQcm9wZXJ0aWVzKQoreworICAgIEFTU0VSVChpbWFnZVByb3BlcnRpZXMpOworICAgIENG TnVtYmVyUmVmIG9yaWVudGF0aW9uUHJvcGVydHkgPSAoQ0ZOdW1iZXJSZWYpQ0ZEaWN0aW9uYXJ5 R2V0VmFsdWUoaW1hZ2VQcm9wZXJ0aWVzLCBrQ0dJbWFnZVByb3BlcnR5T3JpZW50YXRpb24pOwor ICAgIGlmICghb3JpZW50YXRpb25Qcm9wZXJ0eSkKKyAgICAgICAgcmV0dXJuIERlZmF1bHRJbWFn ZU9yaWVudGF0aW9uOworCisgICAgaW50IGV4aWZWYWx1ZTsKKyAgICBDRk51bWJlckdldFZhbHVl KG9yaWVudGF0aW9uUHJvcGVydHksIGtDRk51bWJlckludFR5cGUsICZleGlmVmFsdWUpOworICAg IHJldHVybiBJbWFnZU9yaWVudGF0aW9uOjpmcm9tRVhJRlZhbHVlKGV4aWZWYWx1ZSk7Cit9CisK IEludFNpemUgSW1hZ2VTb3VyY2U6OmZyYW1lU2l6ZUF0SW5kZXgoc2l6ZV90IGluZGV4LCBSZXNw ZWN0SW1hZ2VPcmllbnRhdGlvbkVudW0gc2hvdWxkUmVzcGVjdE9yaWVudGF0aW9uKSBjb25zdAog ewogICAgIFJldGFpblB0cjxDRkRpY3Rpb25hcnlSZWY+IHByb3BlcnRpZXMoQWRvcHRDRiwgQ0dJ bWFnZVNvdXJjZUNvcHlQcm9wZXJ0aWVzQXRJbmRleChtX2RlY29kZXIsIGluZGV4LCBpbWFnZVNv dXJjZU9wdGlvbnMoU2tpcE1ldGFkYXRhKSkpOwpAQCAtMjA5LDcgKzIyMSw3IEBAIEludFNpemUg SW1hZ2VTb3VyY2U6OmZyYW1lU2l6ZUF0SW5kZXgoc2l6ZV90IGluZGV4LCBSZXNwZWN0SW1hZ2VP cmllbnRhdGlvbkVudW0KICAgICBpZiAobnVtKQogICAgICAgICBDRk51bWJlckdldFZhbHVlKG51 bSwga0NGTnVtYmVySW50VHlwZSwgJmgpOwogCi0gICAgaWYgKChzaG91bGRSZXNwZWN0T3JpZW50 YXRpb24gPT0gUmVzcGVjdEltYWdlT3JpZW50YXRpb24pICYmIG9yaWVudGF0aW9uQXRJbmRleChp bmRleCkudXNlc1dpZHRoQXNIZWlnaHQoKSkKKyAgICBpZiAoKHNob3VsZFJlc3BlY3RPcmllbnRh dGlvbiA9PSBSZXNwZWN0SW1hZ2VPcmllbnRhdGlvbikgJiYgb3JpZW50YXRpb25Gcm9tUHJvcGVy dGllcyhwcm9wZXJ0aWVzLmdldCgpKS51c2VzV2lkdGhBc0hlaWdodCgpKQogICAgICAgICByZXR1 cm4gSW50U2l6ZShoLCB3KTsKIAogICAgIHJldHVybiBJbnRTaXplKHcsIGgpOwpAQCAtMjIxLDEz ICsyMzMsNyBAQCBJbWFnZU9yaWVudGF0aW9uIEltYWdlU291cmNlOjpvcmllbnRhdGlvbkF0SW5k ZXgoc2l6ZV90IGluZGV4KSBjb25zdAogICAgIGlmICghcHJvcGVydGllcykKICAgICAgICAgcmV0 dXJuIERlZmF1bHRJbWFnZU9yaWVudGF0aW9uOwogCi0gICAgQ0ZOdW1iZXJSZWYgb3JpZW50YXRp b25Qcm9wZXJ0eSA9IChDRk51bWJlclJlZilDRkRpY3Rpb25hcnlHZXRWYWx1ZShwcm9wZXJ0aWVz LmdldCgpLCBrQ0dJbWFnZVByb3BlcnR5T3JpZW50YXRpb24pOwotICAgIGlmICghb3JpZW50YXRp b25Qcm9wZXJ0eSkKLSAgICAgICAgcmV0dXJuIERlZmF1bHRJbWFnZU9yaWVudGF0aW9uOwotCi0g ICAgaW50IGV4aWZWYWx1ZTsKLSAgICBDRk51bWJlckdldFZhbHVlKG9yaWVudGF0aW9uUHJvcGVy dHksIGtDRk51bWJlckludFR5cGUsICZleGlmVmFsdWUpOwotICAgIHJldHVybiBJbWFnZU9yaWVu dGF0aW9uOjpmcm9tRVhJRlZhbHVlKGV4aWZWYWx1ZSk7CisgICAgcmV0dXJuIG9yaWVudGF0aW9u RnJvbVByb3BlcnRpZXMocHJvcGVydGllcy5nZXQoKSk7CiB9CiAKIEludFNpemUgSW1hZ2VTb3Vy Y2U6OnNpemUoUmVzcGVjdEltYWdlT3JpZW50YXRpb25FbnVtIHNob3VsZFJlc3BlY3RPcmllbnRh dGlvbikgY29uc3QK