98591 2012-10-06 02:03:02 -0700 [EFL][DRT] Switch default backing store to single 2012-10-09 16:01:11 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://lists.webkit.org/pipermail/webkit-efl/2012-October/000316.html P2 Normal --- 1 ryuan.choi ryuan.choi gyuyoung.kim kbalazs lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 736216 0 ryuan.choi 2012-10-06 02:03:02 -0700 As discussed in webkit-efl mailing list, I think that it is more suitable to use ewk_view_single as a default backing store of DRT. After running pixel-tests in my local, single has 49 image-only regressions and tiled has 54 regressions. Patch will be added. 736451 1 167492 ryuan.choi 2012-10-07 18:41:17 -0700 Created attachment 167492 Patch 736525 2 167511 ryuan.choi 2012-10-07 22:52:45 -0700 Created attachment 167511 Patch 736855 3 167511 eric 2012-10-08 11:41:30 -0700 Comment on attachment 167511 Patch rs=me. 736921 4 167511 webkit.review.bot 2012-10-08 12:18:31 -0700 Comment on attachment 167511 Patch Clearing flags on attachment: 167511 Committed r130673: <http://trac.webkit.org/changeset/130673> 736922 5 webkit.review.bot 2012-10-08 12:18:34 -0700 All reviewed patches have been landed. Closing bug. 738226 6 kbalazs 2012-10-09 14:59:53 -0700 By TBS, do you refer some EFL specific thingy or the TBS support in WebKit? In the second case I don't think it's wise to use another backend for testing that you actually ship. 738286 7 ryuan.choi 2012-10-09 16:01:11 -0700 (In reply to comment #6) > By TBS, do you refer some EFL specific thingy or the TBS support in WebKit? In the second case I don't think it's wise to use another backend for testing that you actually ship. This is only Efl specific. WebKit1/Efl has used its own TBS (not in WebCore). Tizen had used TBS of WebKit1/Efl but moved to WebKit2/Efl. In case of other Efl applications using WebKit1/Efl such as elm_web and eve, they have used SBS as a default backing store. So, I believe that testing SBS is more reasonable. Thank you. 167492 2012-10-07 18:41:17 -0700 2012-10-07 22:52:39 -0700 Patch bug-98591-20121008104020.patch text/plain 2434 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwNjEyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYWE3ZGJlNjJjOTYxZGE5OThhZTdkOTVhNWEyYTg4OGI2 ZmJjMDU3ZS4uMDQ0Y2FhNDBhNDIxNDQ3MWY2YmNlY2VjZmJiODkwYzQ2ODFhN2UwOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIz IEBACisyMDEyLTEwLTA3ICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKwor ICAgICAgICBbRUZMXVtEUlRdIFN3aXRjaCBkZWZhdWx0IGJhY2tpbmcgc3RvcmUgdG8gc2luZ2xl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05ODU5MQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZXJlIGFy ZSB0d28gYmFja2luZyBzdG9yZXMgZm9yIFdlYktpdC9FZmwsIFNpbmdsZSBCYWNraW5nIFN0b3Jl KFNCUykgYW5kCisgICAgICAgIFRpbGVkIEJhY2tpbmcgU3RvcmUoVEJTKSwgYW5kIERSVC9FZmwg aGFzIHVzZWQgVEJTLgorICAgICAgICBCdXQsIFRCUyBpcyBub3Qgc3VpdGFibGUgdG8gcnVuIHBp eGVsIHRlc3RzIGJlY2F1c2UgaXQgZG9lcyBub3QgaGF2ZSBhIGdvb2Qgd2F5CisgICAgICAgIHRv IHJlbmRlciBtb2NrIHNjcm9sbGJhcnMgd2VsbC4KKworICAgICAgICBTbywgVGhpcyBwYXRjaCBj aGFuZ2VzIHRoZSBkZWZhdWx0IGJhY2tpbmcgc3RvcmUgdG8gU0JTLgorICAgICAgICBJbiBhZGRp dGlvbiwgdGhpcyBjaGFuZ2VzIHRoZSBlbnZpcm9ubWVudCB2YXJpYWJsZSBmcm9tIERSVF9VU0Vf U0lOR0xFX0JBQ0tJTkdfU1RPUkUKKyAgICAgICAgdG8gRFJUX1VTRV9USUxFRF9CQUNLSU5HX1NU T1JFLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvZWZsL0R1bXBSZW5kZXJUcmVlVmlldy5j cHA6CisgICAgICAgIChzaG91bGRVc2VUaWxlZEJhY2tpbmdTdG9yZSk6CisgICAgICAgIChjaG9v c2VBbmRJbml0aWFsaXplQXBwcm9wcmlhdGVTbWFydENsYXNzKToKKwogMjAxMi0xMC0wNyAgQ2Fp byBNYXJjZWxvIGRlIE9saXZlaXJhIEZpbGhvICA8Y2Fpby5vbGl2ZWlyYUBvcGVuYm9zc2Eub3Jn PgogCiAgICAgICAgIFJlbmFtZSBmaXJzdC9zZWNvbmQgdG8ga2V5L3ZhbHVlIGluIEhhc2hNYXAg aXRlcmF0b3JzCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRl clRyZWVWaWV3LmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJlZVZp ZXcuY3BwCmluZGV4IGVkMzFkZTMyODI0ZGExNGViNDUyOWI4YjVmN2EyNTBlZGE3NjRmMDcuLmQy NGJmMzYwNmQyNDQ2OTJhNTNjZTBjYTQ3ZWEwOWRhNDY3ZjhhODMgMTAwNjQ0Ci0tLSBhL1Rvb2xz L0R1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJlZVZpZXcuY3BwCisrKyBiL1Rvb2xzL0R1 bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJlZVZpZXcuY3BwCkBAIC0xNTMsMTUgKzE1Mywx NSBAQCBzdGF0aWMgaW50NjRfdCBvbkV4Y2VlZGVkQXBwbGljYXRpb25DYWNoZVF1b3RhKEV3a19W aWV3X1NtYXJ0X0RhdGEqLCBFd2tfU2VjdXJpdAogICAgIHJldHVybiBkZWZhdWx0T3JpZ2luUXVv dGE7CiB9CiAKLXN0YXRpYyBib29sIHNob3VsZFVzZVNpbmdsZUJhY2tpbmdTdG9yZSgpCitzdGF0 aWMgYm9vbCBzaG91bGRVc2VUaWxlZEJhY2tpbmdTdG9yZSgpCiB7Ci0gICAgY29uc3QgY2hhciog dXNlU2luZ2xlQmFja2luZ1N0b3JlID0gZ2V0ZW52KCJEUlRfVVNFX1NJTkdMRV9CQUNLSU5HX1NU T1JFIik7Ci0gICAgcmV0dXJuIHVzZVNpbmdsZUJhY2tpbmdTdG9yZSAmJiAqdXNlU2luZ2xlQmFj a2luZ1N0b3JlID09ICcxJzsKKyAgICBjb25zdCBjaGFyKiB1c2VUaWxlZEJhY2tpbmdTdG9yZSA9 IGdldGVudigiRFJUX1VTRV9USUxFRF9CQUNLSU5HX1NUT1JFIik7CisgICAgcmV0dXJuIHVzZVRp bGVkQmFja2luZ1N0b3JlICYmICp1c2VUaWxlZEJhY2tpbmdTdG9yZSA9PSAnMSc7CiB9CiAKIHN0 YXRpYyBib29sIGNob29zZUFuZEluaXRpYWxpemVBcHByb3ByaWF0ZVNtYXJ0Q2xhc3MoRXdrX1Zp ZXdfU21hcnRfQ2xhc3MqIGFwaSkKIHsKLSAgICByZXR1cm4gc2hvdWxkVXNlU2luZ2xlQmFja2lu Z1N0b3JlKCkgPyBld2tfdmlld19zaW5nbGVfc21hcnRfc2V0KGFwaSkgOiBld2tfdmlld190aWxl ZF9zbWFydF9zZXQoYXBpKTsKKyAgICByZXR1cm4gIXNob3VsZFVzZVRpbGVkQmFja2luZ1N0b3Jl KCkgPyBld2tfdmlld19zaW5nbGVfc21hcnRfc2V0KGFwaSkgOiBld2tfdmlld190aWxlZF9zbWFy dF9zZXQoYXBpKTsKIH0KIAogLy8gVGFrZW4gZnJvbSB0aGUgZmlsZSAiV2ViS2l0L1Rvb2xzL0R1 bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlZpZXdIb3N0LmNwcCIuCg== 167511 2012-10-07 22:52:45 -0700 2012-10-08 12:18:31 -0700 Patch bug-98591-20121008145148.patch text/plain 2434 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwNjE2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYWE3ZGJlNjJjOTYxZGE5OThhZTdkOTVhNWEyYTg4OGI2 ZmJjMDU3ZS4uMzI2YjQwNmVhZDQ3ZWQ2ZjllOWNmOGJmNDQxZDkyNzg1M2IyOTgyZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIz IEBACisyMDEyLTEwLTA3ICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKwor ICAgICAgICBbRUZMXVtEUlRdIFN3aXRjaCBkZWZhdWx0IGJhY2tpbmcgc3RvcmUgdG8gc2luZ2xl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05ODU5MQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZXJlIGFy ZSB0d28gYmFja2luZyBzdG9yZXMgZm9yIFdlYktpdC9FZmwsIFNpbmdsZSBCYWNraW5nIFN0b3Jl KFNCUykgYW5kCisgICAgICAgIFRpbGVkIEJhY2tpbmcgU3RvcmUoVEJTKSwgYW5kIERSVC9FZmwg aGFzIHVzZWQgVEJTLgorICAgICAgICBCdXQsIFRCUyBpcyBub3Qgc3VpdGFibGUgdG8gcnVuIHBp eGVsIHRlc3RzIGJlY2F1c2UgaXQgZG9lcyBub3QgaGF2ZSBhIGdvb2Qgd2F5CisgICAgICAgIHRv IHJlbmRlciBtb2NrIHNjcm9sbGJhcnMgd2VsbC4KKworICAgICAgICBTbywgdGhpcyBwYXRjaCBj aGFuZ2VzIHRoZSBkZWZhdWx0IGJhY2tpbmcgc3RvcmUgdG8gU0JTLgorICAgICAgICBJbiBhZGRp dGlvbiwgdGhpcyBjaGFuZ2VzIHRoZSBlbnZpcm9ubWVudCB2YXJpYWJsZSBmcm9tIERSVF9VU0Vf U0lOR0xFX0JBQ0tJTkdfU1RPUkUKKyAgICAgICAgdG8gRFJUX1VTRV9USUxFRF9CQUNLSU5HX1NU T1JFLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvZWZsL0R1bXBSZW5kZXJUcmVlVmlldy5j cHA6CisgICAgICAgIChzaG91bGRVc2VUaWxlZEJhY2tpbmdTdG9yZSk6CisgICAgICAgIChjaG9v c2VBbmRJbml0aWFsaXplQXBwcm9wcmlhdGVTbWFydENsYXNzKToKKwogMjAxMi0xMC0wNyAgQ2Fp byBNYXJjZWxvIGRlIE9saXZlaXJhIEZpbGhvICA8Y2Fpby5vbGl2ZWlyYUBvcGVuYm9zc2Eub3Jn PgogCiAgICAgICAgIFJlbmFtZSBmaXJzdC9zZWNvbmQgdG8ga2V5L3ZhbHVlIGluIEhhc2hNYXAg aXRlcmF0b3JzCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRl clRyZWVWaWV3LmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJlZVZp ZXcuY3BwCmluZGV4IGVkMzFkZTMyODI0ZGExNGViNDUyOWI4YjVmN2EyNTBlZGE3NjRmMDcuLmQy NGJmMzYwNmQyNDQ2OTJhNTNjZTBjYTQ3ZWEwOWRhNDY3ZjhhODMgMTAwNjQ0Ci0tLSBhL1Rvb2xz L0R1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJlZVZpZXcuY3BwCisrKyBiL1Rvb2xzL0R1 bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJlZVZpZXcuY3BwCkBAIC0xNTMsMTUgKzE1Mywx NSBAQCBzdGF0aWMgaW50NjRfdCBvbkV4Y2VlZGVkQXBwbGljYXRpb25DYWNoZVF1b3RhKEV3a19W aWV3X1NtYXJ0X0RhdGEqLCBFd2tfU2VjdXJpdAogICAgIHJldHVybiBkZWZhdWx0T3JpZ2luUXVv dGE7CiB9CiAKLXN0YXRpYyBib29sIHNob3VsZFVzZVNpbmdsZUJhY2tpbmdTdG9yZSgpCitzdGF0 aWMgYm9vbCBzaG91bGRVc2VUaWxlZEJhY2tpbmdTdG9yZSgpCiB7Ci0gICAgY29uc3QgY2hhciog dXNlU2luZ2xlQmFja2luZ1N0b3JlID0gZ2V0ZW52KCJEUlRfVVNFX1NJTkdMRV9CQUNLSU5HX1NU T1JFIik7Ci0gICAgcmV0dXJuIHVzZVNpbmdsZUJhY2tpbmdTdG9yZSAmJiAqdXNlU2luZ2xlQmFj a2luZ1N0b3JlID09ICcxJzsKKyAgICBjb25zdCBjaGFyKiB1c2VUaWxlZEJhY2tpbmdTdG9yZSA9 IGdldGVudigiRFJUX1VTRV9USUxFRF9CQUNLSU5HX1NUT1JFIik7CisgICAgcmV0dXJuIHVzZVRp bGVkQmFja2luZ1N0b3JlICYmICp1c2VUaWxlZEJhY2tpbmdTdG9yZSA9PSAnMSc7CiB9CiAKIHN0 YXRpYyBib29sIGNob29zZUFuZEluaXRpYWxpemVBcHByb3ByaWF0ZVNtYXJ0Q2xhc3MoRXdrX1Zp ZXdfU21hcnRfQ2xhc3MqIGFwaSkKIHsKLSAgICByZXR1cm4gc2hvdWxkVXNlU2luZ2xlQmFja2lu Z1N0b3JlKCkgPyBld2tfdmlld19zaW5nbGVfc21hcnRfc2V0KGFwaSkgOiBld2tfdmlld190aWxl ZF9zbWFydF9zZXQoYXBpKTsKKyAgICByZXR1cm4gIXNob3VsZFVzZVRpbGVkQmFja2luZ1N0b3Jl KCkgPyBld2tfdmlld19zaW5nbGVfc21hcnRfc2V0KGFwaSkgOiBld2tfdmlld190aWxlZF9zbWFy dF9zZXQoYXBpKTsKIH0KIAogLy8gVGFrZW4gZnJvbSB0aGUgZmlsZSAiV2ViS2l0L1Rvb2xzL0R1 bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlZpZXdIb3N0LmNwcCIuCg==