98589 2012-10-06 00:30:02 -0700 [EFL][WK2] Provide implementation for PageClientImpl::toolTipChanged() 2012-10-15 13:23:58 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 1 jinwoo7.song jinwoo7.song cdumez gyuyoung.kim kenneth lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 736199 0 jinwoo7.song 2012-10-06 00:30:02 -0700 Implement PageClientImple::toolTipChanged() to emit signal 'tooltip,text,set' with a tooltip text, and if tooltip must be actually removed, text will be 0 or '\0'. 736200 1 167446 jinwoo7.song 2012-10-06 00:33:06 -0700 Created attachment 167446 Patch 736277 2 167446 rakuco 2012-10-06 13:23:21 -0700 Comment on attachment 167446 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167446&action=review > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:1080 > + * Emits signal: "tooltip,text,set" with a tooltip string. If tooltip must be actually removed, text will be 0 or '\0'. Isn't it better to emit a different signal for tooltip removal? 736279 3 167446 cdumez 2012-10-06 13:50:49 -0700 Comment on attachment 167446 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167446&action=review The use for this seems pretty limited (inexistent?) on mobile devices, isn't it? I mean there is no mouseover so when would we show tooltips? > Source/WebKit2/ChangeLog:8 > + Implement PageClientImple::toolTipChanged() to emit signal 'tooltip,text,set' with a tooltip text, "PageClientImpl" Why do we emit a signal on the view? It seems to me like the view should be able to take care of drawing tooltips by itself... Unless there is a good reason to delegate this to the browser, I would rather we keep as much functionality as possible in the view. Otherwise, it becomes painful to write a browser based on WebKit EFL. > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:1078 > + * @param text Text to set tooltip. "Tooltip text to set" ? > Source/WebKit2/UIProcess/API/efl/ewk_view.h:66 > + * - "tooltip,text,set", const char*: tooltip text is set. "Requests the given tooltip text to be shown" ? I would also indicate here that NULL will be passed if the tooltip text should be removed. 736324 4 167446 kenneth 2012-10-06 22:39:40 -0700 Comment on attachment 167446 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167446&action=review >> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:1080 >> + * Emits signal: "tooltip,text,set" with a tooltip string. If tooltip must be actually removed, text will be 0 or '\0'. > > Isn't it better to emit a different signal for tooltip removal? So what about info that you get a temporary string and that it must be copied or so? We dont document such things? 736329 5 cdumez 2012-10-06 23:05:39 -0700 (In reply to comment #4) > (From update of attachment 167446 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=167446&action=review > > >> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:1080 > >> + * Emits signal: "tooltip,text,set" with a tooltip string. If tooltip must be actually removed, text will be 0 or '\0'. > > > > Isn't it better to emit a different signal for tooltip removal? > > So what about info that you get a temporary string and that it must be copied or so? We dont document such things? I dont 't think this is an issue. The string will be available in the callback. If the app wants to keep the string after the callback is executed then its needs to strdup it. I think this is common practice. 740910 6 jinwoo7.song 2012-10-12 07:47:59 -0700 (In reply to comment #2) > (From update of attachment 167446 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=167446&action=review > > > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:1080 > > + * Emits signal: "tooltip,text,set" with a tooltip string. If tooltip must be actually removed, text will be 0 or '\0'. > > Isn't it better to emit a different signal for tooltip removal? From the application side, different signal may be preferable as they do not need to check the text. I'll change as your suggestion. 741723 7 167446 jinwoo7.song 2012-10-14 21:25:16 -0700 Comment on attachment 167446 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167446&action=review >> Source/WebKit2/ChangeLog:8 >> + Implement PageClientImple::toolTipChanged() to emit signal 'tooltip,text,set' with a tooltip text, > > "PageClientImpl" > > Why do we emit a signal on the view? It seems to me like the view should be able to take care of drawing tooltips by itself... > Unless there is a good reason to delegate this to the browser, I would rather we keep as much functionality as possible in the view. Otherwise, it becomes painful to write a browser based on WebKit EFL. In my thought, tooltip is a kind of UI element such as toolbar or status bar. Applications may want their own tooltip UX or even they do not want to show it. Also, I think applications can easily draw the tooltip with elm_object_tooltip_set() so it is not too painful. >> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:1078 >> + * @param text Text to set tooltip. > > "Tooltip text to set" ? I'll fix it. >> Source/WebKit2/UIProcess/API/efl/ewk_view.h:66 >> + * - "tooltip,text,set", const char*: tooltip text is set. > > "Requests the given tooltip text to be shown" ? I would also indicate here that NULL will be passed if the tooltip text should be removed. I'll add a "toolip,text,unset' signal for NULL case following Raphael's suggestion. 741773 8 168632 jinwoo7.song 2012-10-14 23:38:39 -0700 Created attachment 168632 Patch 741779 9 168632 kenneth 2012-10-14 23:46:25 -0700 Comment on attachment 168632 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=168632&action=review > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:1131 > + * Reports that the tooltip text was changed. > + * > + * Emits signal: "tooltip,text,set" with a tooltip text to set. > + * "tooltip,text,unset" if tooltip must be actually removed. I dont think we normally have to document internal methods. Internal methods tend to change so documentation becomes stale 741782 10 cdumez 2012-10-14 23:56:44 -0700 (In reply to comment #7) > (From update of attachment 167446 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=167446&action=review > > >> Source/WebKit2/ChangeLog:8 > >> + Implement PageClientImple::toolTipChanged() to emit signal 'tooltip,text,set' with a tooltip text, > > > > "PageClientImpl" > > > > Why do we emit a signal on the view? It seems to me like the view should be able to take care of drawing tooltips by itself... > > Unless there is a good reason to delegate this to the browser, I would rather we keep as much functionality as possible in the view. Otherwise, it becomes painful to write a browser based on WebKit EFL. > > In my thought, tooltip is a kind of UI element such as toolbar or status bar. Applications may want their own tooltip UX or even they do not want to show it. > Also, I think applications can easily draw the tooltip with elm_object_tooltip_set() so it is not too painful. If you would use smart functions instead of signals, this would allow apps to draw tooltips by themselves if they want to and we could fallback to a "default" tooltip drawing behavior in ewk_view. 741784 11 168632 cdumez 2012-10-14 23:59:38 -0700 Comment on attachment 168632 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=168632&action=review > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:1135 > + if (text && text[0] != '\0') if (text && *text) ? > Source/WebKit2/UIProcess/API/efl/ewk_view.h:68 > + * - "tooltip,text,unset", void: tooltip text must be actaully removed. "actually" 741820 12 167446 jinwoo7.song 2012-10-15 00:41:08 -0700 Comment on attachment 167446 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167446&action=review >>>> Source/WebKit2/ChangeLog:8 >>>> + Implement PageClientImple::toolTipChanged() to emit signal 'tooltip,text,set' with a tooltip text, >>> >>> "PageClientImpl" >>> >>> Why do we emit a signal on the view? It seems to me like the view should be able to take care of drawing tooltips by itself... >>> Unless there is a good reason to delegate this to the browser, I would rather we keep as much functionality as possible in the view. Otherwise, it becomes painful to write a browser based on WebKit EFL. >> >> In my thought, tooltip is a kind of UI element such as toolbar or status bar. Applications may want their own tooltip UX or even they do not want to show it. >> Also, I think applications can easily draw the tooltip with elm_object_tooltip_set() so it is not too painful. > > If you would use smart functions instead of signals, this would allow apps to draw tooltips by themselves if they want to and we could fallback to a "default" tooltip drawing behavior in ewk_view. Yes I know I can use the smart function if we want to support the tooltip in the webkit but it seems that tooltip is not an essential feature to support the fallback. 741821 13 168632 jinwoo7.song 2012-10-15 00:41:26 -0700 Comment on attachment 168632 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=168632&action=review >> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:1131 >> + * "tooltip,text,unset" if tooltip must be actually removed. > > I dont think we normally have to document internal methods. Internal methods tend to change so documentation becomes stale I see your point. I just added the document following the previous things. >> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:1135 >> + if (text && text[0] != '\0') > > if (text && *text) ? I'll fix. >> Source/WebKit2/UIProcess/API/efl/ewk_view.h:68 >> + * - "tooltip,text,unset", void: tooltip text must be actaully removed. > > "actually" I'll fix typo. 741825 14 168642 jinwoo7.song 2012-10-15 00:43:28 -0700 Created attachment 168642 patch for landing. 741851 15 168642 kenneth 2012-10-15 01:49:49 -0700 Comment on attachment 168642 patch for landing. View in context: https://bugs.webkit.org/attachment.cgi?id=168642&action=review > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:1131 > + * Reports that the tooltip text was changed. > + * > + * Emits signal: "tooltip,text,set" with a tooltip text to set. > + * "tooltip,text,unset" if tooltip must be actually removed. I would just remove this documentation. > Source/WebKit2/UIProcess/API/efl/ewk_view.h:68 > + * - "tooltip,text,unset", void: tooltip text must be actually removed. bad english: tooltip was unset? * - "tooltip,text,set", const char*: tooltip was set. * - "tooltip,text,unset", void: tooltip was unset. 741883 16 jinwoo7.song 2012-10-15 02:45:25 -0700 (In reply to comment #15) > (From update of attachment 168642 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=168642&action=review > > > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:1131 > > + * Reports that the tooltip text was changed. > > + * > > + * Emits signal: "tooltip,text,set" with a tooltip text to set. > > + * "tooltip,text,unset" if tooltip must be actually removed. > > I would just remove this documentation. > Done. > > Source/WebKit2/UIProcess/API/efl/ewk_view.h:68 > > + * - "tooltip,text,unset", void: tooltip text must be actually removed. > > bad english: tooltip was unset? > > * - "tooltip,text,set", const char*: tooltip was set. > * - "tooltip,text,unset", void: tooltip was unset. Fixed. 741884 17 168657 jinwoo7.song 2012-10-15 02:46:44 -0700 Created attachment 168657 patch Applied the comments by Kenneth. 742356 18 168657 webkit.review.bot 2012-10-15 13:23:52 -0700 Comment on attachment 168657 patch Clearing flags on attachment: 168657 Committed r131347: <http://trac.webkit.org/changeset/131347> 742357 19 webkit.review.bot 2012-10-15 13:23:58 -0700 All reviewed patches have been landed. Closing bug. 167446 2012-10-06 00:33:06 -0700 2012-10-15 00:41:08 -0700 Patch bug-98589-20121006163209.patch text/plain 4736 jinwoo7.song U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwNTY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMTMxYTM0ZGI4M2UwZTA0 MmU3OGNhZTQ1MTExZmY5ZGQwZDc0ZThmMS4uMTkxZDM5YWU4NzhkZDQzZjJlNjYyMDk3ZDk3ZDRl YThhZTgzNDgyYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTEwLTA2ICBKaW53 b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXVtXSzJd IFByb3ZpZGUgaW1wbGVtZW50YXRpb24gZm9yIFBhZ2VDbGllbnRJbXBsOjp0b29sVGlwQ2hhbmdl ZCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05ODU4 OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEltcGxl bWVudCBQYWdlQ2xpZW50SW1wbGU6OnRvb2xUaXBDaGFuZ2VkKCkgdG8gZW1pdCBzaWduYWwgJ3Rv b2x0aXAsdGV4dCxzZXQnIHdpdGggYSB0b29sdGlwIHRleHQsCisgICAgICAgIGFuZCBpZiB0b29s dGlwIG11c3QgYmUgYWN0dWFsbHkgcmVtb3ZlZCwgdG9vbHRpcCB0ZXh0IHdpbGwgYmUgMCBvciAn XDAnLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwvUGFnZUNsaWVudEltcGwuY3BwOgor ICAgICAgICAoV2ViS2l0OjpQYWdlQ2xpZW50SW1wbDo6dG9vbFRpcENoYW5nZWQpOgorICAgICAg ICAqIFVJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcDoKKyAgICAgICAgKGV3a192aWV3X3Rv b2x0aXBfdGV4dF9zZXQpOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3Lmg6 CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXdfcHJpdmF0ZS5oOgorCiAyMDEy LTEwLTA1ICBTdWRhcnNhbmEgTmFnaW5lbmkgIDxzdWRhcnNhbmEubmFnaW5lbmlAaW50ZWwuY29t PgogCiAgICAgICAgIFtXSzJdW1dUUl0gV2ViS2l0VGVzdFJ1bm5lciBuZWVkcyB0ZXN0UnVubmVy LnNldFNlcmlhbGl6ZUhUVFBMb2FkcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9lZmwvUGFnZUNsaWVudEltcGwuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9lZmwvUGFnZUNsaWVudEltcGwuY3BwCmluZGV4IDNiZjE5NGY1NzljZGE4NTZhOThiNzU1 NjA5OGNmYTM3NWU0NmNiMmMuLjk5M2Y4NjMwOTAzZjgzMzJjMzcwMjQxNDFmNDc5YzNmMzlhZjRh MzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL1BhZ2VDbGll bnRJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9QYWdlQ2xp ZW50SW1wbC5jcHAKQEAgLTEyMyw5ICsxMjMsOSBAQCB2b2lkIFBhZ2VDbGllbnRJbXBsOjpwYWdl Q2xvc2VkKCkKICAgICBub3RJbXBsZW1lbnRlZCgpOwogfQogCi12b2lkIFBhZ2VDbGllbnRJbXBs Ojp0b29sVGlwQ2hhbmdlZChjb25zdCBTdHJpbmcmLCBjb25zdCBTdHJpbmcmKQordm9pZCBQYWdl Q2xpZW50SW1wbDo6dG9vbFRpcENoYW5nZWQoY29uc3QgU3RyaW5nJiwgY29uc3QgU3RyaW5nJiBu ZXdUb29sVGlwKQogewotICAgIG5vdEltcGxlbWVudGVkKCk7CisgICAgZXdrX3ZpZXdfdG9vbHRp cF90ZXh0X3NldChtX3ZpZXdXaWRnZXQsIG5ld1Rvb2xUaXAudXRmOCgpLmRhdGEoKSk7CiB9CiAK IHZvaWQgUGFnZUNsaWVudEltcGw6OnNldEN1cnNvcihjb25zdCBDdXJzb3ImIGN1cnNvcikKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcCBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcAppbmRleCA3NGY1 ZWI5NmViYTE5ODk2Y2MwMzI3MmUwYTdlYjhiYTM3OGFkNmNhLi4xMGQxNmQwYTEzMmFjNDRmNWY4 MGVkODdjZTMyNTI4NDdhYTFmYWE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL2VmbC9ld2tfdmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9lZmwvZXdrX3ZpZXcuY3BwCkBAIC0xMDcwLDYgKzEwNzAsMjAgQEAgdm9pZCBld2tfdmlld190 aXRsZV9jaGFuZ2VkKEV2YXNfT2JqZWN0KiBld2tWaWV3LCBjb25zdCBjaGFyKiB0aXRsZSkKICAg ICBldmFzX29iamVjdF9zbWFydF9jYWxsYmFja19jYWxsKGV3a1ZpZXcsICJ0aXRsZSxjaGFuZ2Vk IiwgY29uc3RfY2FzdDxjaGFyKj4odGl0bGUpKTsKIH0KIAorLyoqCisgKiBAaW50ZXJuYWwKKyAq IFNldCB0b29sdGlwIHRleHQgYW5kIGRpc3BsYXkgaWYgaXQgaXMgY3VycmVudGx5IGhpZGRlbi4K KyAqCisgKiBAcGFyYW0gZXdrVmlldyBWaWV3LgorICogQHBhcmFtIHRleHQgVGV4dCB0byBzZXQg dG9vbHRpcC4KKyAqCisgKiBFbWl0cyBzaWduYWw6ICJ0b29sdGlwLHRleHQsc2V0IiB3aXRoIGEg dG9vbHRpcCBzdHJpbmcuIElmIHRvb2x0aXAgbXVzdCBiZSBhY3R1YWxseSByZW1vdmVkLCB0ZXh0 IHdpbGwgYmUgMCBvciAnXDAnLgorICovCit2b2lkIGV3a192aWV3X3Rvb2x0aXBfdGV4dF9zZXQo RXZhc19PYmplY3QqIGV3a1ZpZXcsIGNvbnN0IGNoYXIqIHRleHQpCit7CisgICAgZXZhc19vYmpl Y3Rfc21hcnRfY2FsbGJhY2tfY2FsbChld2tWaWV3LCAidG9vbHRpcCx0ZXh0LHNldCIsIGNvbnN0 X2Nhc3Q8Y2hhcio+KHRleHQpKTsKK30KKwogZG91YmxlIGV3a192aWV3X2xvYWRfcHJvZ3Jlc3Nf Z2V0KGNvbnN0IEV2YXNfT2JqZWN0KiBld2tWaWV3KQogewogICAgIEVXS19WSUVXX1NEX0dFVF9P Ul9SRVRVUk4oZXdrVmlldywgc21hcnREYXRhLCAtMS4wKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5oCmluZGV4IDA4M2U5MjM3OGQxYmM4Yjg0ZGY2NTIwN2Fk M2ZhZjc4OTU0NmUxYmUuLjFlOWI2NDY2NGU3YjlmNjE0YzAyYWVmMTZlYjc0NmM3MjBkZmZhY2Ig MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmgK KysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuaApAQCAtNjMs NiArNjMsNyBAQAogICogLSAicmVzb3VyY2UscmVxdWVzdCxzZW50IiwgY29uc3QgRXdrX1Jlc291 cmNlX1JlcXVlc3QqOiBhIHJlc291cmNlIHJlcXVlc3Qgd2FzIHNlbnQuCiAgKiAtICJ0ZXh0LGZv dW5kIiwgdW5zaWduZWQgaW50KjogdGhlIHJlcXVlc3RlZCB0ZXh0IHdhcyBmb3VuZCBhbmQgaXQg Z2l2ZXMgdGhlIG51bWJlciBvZiBtYXRjaGVzLgogICogLSAidGl0bGUsY2hhbmdlZCIsIGNvbnN0 IGNoYXIqOiB0aXRsZSBvZiB0aGUgbWFpbiBmcmFtZSB3YXMgY2hhbmdlZC4KKyAqIC0gInRvb2x0 aXAsdGV4dCxzZXQiLCBjb25zdCBjaGFyKjogdG9vbHRpcCB0ZXh0IGlzIHNldC4KICAqIC0gInVy aSxjaGFuZ2VkIiwgY29uc3QgY2hhcio6IHVyaSBvZiB0aGUgbWFpbiBmcmFtZSB3YXMgY2hhbmdl ZC4KICAqIC0gIndlYnByb2Nlc3MsY3Jhc2hlZCIsIEVpbmFfQm9vbCo6IGV4cGVjdHMgYSBAYyBF SU5BX1RSVUUgaWYgd2ViIHByb2Nlc3MgY3Jhc2ggaXMgaGFuZGxlZDsgQGMgRUlOQV9GQUxTRSwg b3RoZXJ3aXNlLgogICovCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L2VmbC9ld2tfdmlld19wcml2YXRlLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2Vm bC9ld2tfdmlld19wcml2YXRlLmgKaW5kZXggNDQxMmU0ZWI3YWQ5M2YzZTQ4M2EzYjZlMjc4MDNk NDQxNzllMTQ4MC4uMDc4MTU1MzI2ZjMyMzg3MzY2OWJmNzllMjBkZmU2ZmZiYjk2ODlkMSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXdfcHJpdmF0 ZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3X3ByaXZh dGUuaApAQCAtNzYsNiArNzYsNyBAQCB2b2lkIGV3a192aWV3X25ld193aW5kb3dfcG9saWN5X2Rl Y2lzaW9uKEV2YXNfT2JqZWN0KiBld2tWaWV3LCBFd2tfTmF2aWdhdGlvbl9Qbwogdm9pZCBld2tf dmlld19wYWdlX2Nsb3NlKEV2YXNfT2JqZWN0KiBld2tWaWV3KTsKIFdLUGFnZVJlZiBld2tfdmll d19wYWdlX2NyZWF0ZShFdmFzX09iamVjdCogZXdrVmlldyk7CiB2b2lkIGV3a192aWV3X3RpdGxl X2NoYW5nZWQoRXZhc19PYmplY3QqIGV3a1ZpZXcsIGNvbnN0IGNoYXIqIHRpdGxlKTsKK3ZvaWQg ZXdrX3ZpZXdfdG9vbHRpcF90ZXh0X3NldChFdmFzX09iamVjdCogZXdrVmlldywgY29uc3QgY2hh ciogdGV4dCk7CiB2b2lkIGV3a192aWV3X3Jlc291cmNlX2xvYWRfZmFpbGVkKEV2YXNfT2JqZWN0 KiBld2tWaWV3LCB1aW50NjRfdCByZXNvdXJjZUlkZW50aWZpZXIsIEV3a19FcnJvciogZXJyb3Ip Owogdm9pZCBld2tfdmlld19yZXNvdXJjZV9sb2FkX2ZpbmlzaGVkKEV2YXNfT2JqZWN0KiBld2tW aWV3LCB1aW50NjRfdCByZXNvdXJjZUlkZW50aWZpZXIpOwogdm9pZCBld2tfdmlld19yZXNvdXJj ZV9sb2FkX2luaXRpYXRlZChFdmFzX09iamVjdCogZXdrVmlldywgdWludDY0X3QgcmVzb3VyY2VJ ZGVudGlmaWVyLCBFd2tfUmVzb3VyY2UqIHJlc291cmNlLCBFd2tfVXJsX1JlcXVlc3QqIHJlcXVl c3QpOwo= 168632 2012-10-14 23:38:39 -0700 2012-10-15 00:43:28 -0700 Patch bug-98589-20121015153726.patch text/plain 4801 jinwoo7.song U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxMjg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZTY0YzYwMjczZTI2OGEx YmE4YmU3NDkyYzQ2OTY4NjQ4NzIxOWVkYi4uMDg4NWQ0Yzk5ODM0MzZlOWZmYmZkMDI4ZGQwNmVi OGY3NmI3MWRlNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTEwLTE0ICBKaW53 b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXVtXSzJd IFByb3ZpZGUgaW1wbGVtZW50YXRpb24gZm9yIFBhZ2VDbGllbnRJbXBsOjp0b29sVGlwQ2hhbmdl ZCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05ODU4 OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEltcGxl bWVudCBQYWdlQ2xpZW50SW1wbDo6dG9vbFRpcENoYW5nZWQoKSB0byBlbWl0IHNpZ25hbCAndG9v bHRpcCx0ZXh0LHNldCcgd2l0aCBhIHRvb2x0aXAgdGV4dCwKKyAgICAgICAgb3IgJ3Rvb2x0aXAs dGV4dCx1bnNldCcgaWYgdG9vbHRpcCBtdXN0IGJlIGFjdHVhbGx5IHJlbW92ZWQuCisKKyAgICAg ICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9QYWdlQ2xpZW50SW1wbC5jcHA6CisgICAgICAgIChXZWJL aXQ6OlBhZ2VDbGllbnRJbXBsOjp0b29sVGlwQ2hhbmdlZCk6CisgICAgICAgICogVUlQcm9jZXNz L0FQSS9lZmwvZXdrX3ZpZXcuY3BwOgorICAgICAgICAoZXdrX3ZpZXdfdG9vbHRpcF90ZXh0X3Nl dCk6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuaDoKKyAgICAgICAgKiBV SVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlld19wcml2YXRlLmg6CisKIDIwMTItMTAtMTQgIEFuZGVy cyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggdGhlIHdvcmxk LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvUGFnZUNsaWVu dEltcGwuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvUGFnZUNsaWVudElt cGwuY3BwCmluZGV4IDNiZjE5NGY1NzljZGE4NTZhOThiNzU1NjA5OGNmYTM3NWU0NmNiMmMuLjk5 M2Y4NjMwOTAzZjgzMzJjMzcwMjQxNDFmNDc5YzNmMzlhZjRhMzcgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL1BhZ2VDbGllbnRJbXBsLmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9QYWdlQ2xpZW50SW1wbC5jcHAKQEAgLTEyMyw5 ICsxMjMsOSBAQCB2b2lkIFBhZ2VDbGllbnRJbXBsOjpwYWdlQ2xvc2VkKCkKICAgICBub3RJbXBs ZW1lbnRlZCgpOwogfQogCi12b2lkIFBhZ2VDbGllbnRJbXBsOjp0b29sVGlwQ2hhbmdlZChjb25z dCBTdHJpbmcmLCBjb25zdCBTdHJpbmcmKQordm9pZCBQYWdlQ2xpZW50SW1wbDo6dG9vbFRpcENo YW5nZWQoY29uc3QgU3RyaW5nJiwgY29uc3QgU3RyaW5nJiBuZXdUb29sVGlwKQogewotICAgIG5v dEltcGxlbWVudGVkKCk7CisgICAgZXdrX3ZpZXdfdG9vbHRpcF90ZXh0X3NldChtX3ZpZXdXaWRn ZXQsIG5ld1Rvb2xUaXAudXRmOCgpLmRhdGEoKSk7CiB9CiAKIHZvaWQgUGFnZUNsaWVudEltcGw6 OnNldEN1cnNvcihjb25zdCBDdXJzb3ImIGN1cnNvcikKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcAppbmRleCAwN2E5NDIyNjRiM2YyNjA1ZGJjYmE2OTYz NzdjMTE0ZTA1OTczNjk3Li5hYjIzYTdkNWQ4MDgzN2UxOWQ4MTE2ZDRjODQ1MWE3MTM3NzQ1YjYz IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5j cHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuY3BwCkBA IC0xMTIzLDYgKzExMjMsMjEgQEAgdm9pZCBld2tfdmlld190aXRsZV9jaGFuZ2VkKEV2YXNfT2Jq ZWN0KiBld2tWaWV3LCBjb25zdCBjaGFyKiB0aXRsZSkKICAgICBldmFzX29iamVjdF9zbWFydF9j YWxsYmFja19jYWxsKGV3a1ZpZXcsICJ0aXRsZSxjaGFuZ2VkIiwgY29uc3RfY2FzdDxjaGFyKj4o dGl0bGUpKTsKIH0KIAorLyoqCisgKiBAaW50ZXJuYWwKKyAqIFJlcG9ydHMgdGhhdCB0aGUgdG9v bHRpcCB0ZXh0IHdhcyBjaGFuZ2VkLgorICoKKyAqIEVtaXRzIHNpZ25hbDogInRvb2x0aXAsdGV4 dCxzZXQiIHdpdGggYSB0b29sdGlwIHRleHQgdG8gc2V0LgorICogICAgICAgICAgICAgICAidG9v bHRpcCx0ZXh0LHVuc2V0IiBpZiB0b29sdGlwIG11c3QgYmUgYWN0dWFsbHkgcmVtb3ZlZC4KKyAq Lwordm9pZCBld2tfdmlld190b29sdGlwX3RleHRfc2V0KEV2YXNfT2JqZWN0KiBld2tWaWV3LCBj b25zdCBjaGFyKiB0ZXh0KQoreworICAgIGlmICh0ZXh0ICYmIHRleHRbMF0gIT0gJ1wwJykKKyAg ICAgICAgZXZhc19vYmplY3Rfc21hcnRfY2FsbGJhY2tfY2FsbChld2tWaWV3LCAidG9vbHRpcCx0 ZXh0LHNldCIsIGNvbnN0X2Nhc3Q8Y2hhcio+KHRleHQpKTsKKyAgICBlbHNlCisgICAgICAgIGV2 YXNfb2JqZWN0X3NtYXJ0X2NhbGxiYWNrX2NhbGwoZXdrVmlldywgInRvb2x0aXAsdGV4dCx1bnNl dCIsIDApOworfQorCiBkb3VibGUgZXdrX3ZpZXdfbG9hZF9wcm9ncmVzc19nZXQoY29uc3QgRXZh c19PYmplY3QqIGV3a1ZpZXcpCiB7CiAgICAgRVdLX1ZJRVdfU0RfR0VUX09SX1JFVFVSTihld2tW aWV3LCBzbWFydERhdGEsIC0xLjApOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9lZmwvZXdrX3ZpZXcuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZs L2V3a192aWV3LmgKaW5kZXggZTljYmU0ZTFmMDBmZDMwNjBhOWVhZDk4MzRjM2I3MzU2YjE3YmVj Mi4uODc1YmExZTFiZTE1MTNhNDgxYzg1NDkzNTBkYWVkOTgyZTY1MTg5MiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuaAorKysgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5oCkBAIC02NCw2ICs2NCw4IEBACiAg KiAtICJyZXNvdXJjZSxyZXF1ZXN0LHNlbnQiLCBjb25zdCBFd2tfUmVzb3VyY2VfUmVxdWVzdCo6 IGEgcmVzb3VyY2UgcmVxdWVzdCB3YXMgc2VudC4KICAqIC0gInRleHQsZm91bmQiLCB1bnNpZ25l ZCBpbnQqOiB0aGUgcmVxdWVzdGVkIHRleHQgd2FzIGZvdW5kIGFuZCBpdCBnaXZlcyB0aGUgbnVt YmVyIG9mIG1hdGNoZXMuCiAgKiAtICJ0aXRsZSxjaGFuZ2VkIiwgY29uc3QgY2hhcio6IHRpdGxl IG9mIHRoZSBtYWluIGZyYW1lIHdhcyBjaGFuZ2VkLgorICogLSAidG9vbHRpcCx0ZXh0LHNldCIs IGNvbnN0IGNoYXIqOiB0b29sdGlwIHRleHQgd2FzIGNoYW5nZWQuCisgKiAtICJ0b29sdGlwLHRl eHQsdW5zZXQiLCB2b2lkOiB0b29sdGlwIHRleHQgbXVzdCBiZSBhY3RhdWxseSByZW1vdmVkLgog ICogLSAidXJsLGNoYW5nZWQiLCBjb25zdCBjaGFyKjogdXJsIG9mIHRoZSBtYWluIGZyYW1lIHdh cyBjaGFuZ2VkLgogICogLSAid2VicHJvY2VzcyxjcmFzaGVkIiwgRWluYV9Cb29sKjogZXhwZWN0 cyBhIEBjIEVJTkFfVFJVRSBpZiB3ZWIgcHJvY2VzcyBjcmFzaCBpcyBoYW5kbGVkOyBAYyBFSU5B X0ZBTFNFLCBvdGhlcndpc2UuCiAgKi8KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvZWZsL2V3a192aWV3X3ByaXZhdGUuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvZWZsL2V3a192aWV3X3ByaXZhdGUuaAppbmRleCA4ZWM5MWMxM2M3ZWFiMDg0YjBiNzY0 OWNjZjgwZDhkNmY0Njc1N2JiLi5hNzUxODMwZTIwNmYzMDQwMWI2MzI3MzBlOTFjNDRhN2ZkNzA1 NmE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmll d19wcml2YXRlLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3Zp ZXdfcHJpdmF0ZS5oCkBAIC03Niw2ICs3Niw3IEBAIHZvaWQgZXdrX3ZpZXdfbmV3X3dpbmRvd19w b2xpY3lfZGVjaXNpb24oRXZhc19PYmplY3QqIGV3a1ZpZXcsIEV3a19OYXZpZ2F0aW9uX1BvCiB2 b2lkIGV3a192aWV3X3BhZ2VfY2xvc2UoRXZhc19PYmplY3QqIGV3a1ZpZXcpOwogV0tQYWdlUmVm IGV3a192aWV3X3BhZ2VfY3JlYXRlKEV2YXNfT2JqZWN0KiBld2tWaWV3KTsKIHZvaWQgZXdrX3Zp ZXdfdGl0bGVfY2hhbmdlZChFdmFzX09iamVjdCogZXdrVmlldywgY29uc3QgY2hhciogdGl0bGUp Owordm9pZCBld2tfdmlld190b29sdGlwX3RleHRfc2V0KEV2YXNfT2JqZWN0KiBld2tWaWV3LCBj b25zdCBjaGFyKiB0ZXh0KTsKIHZvaWQgZXdrX3ZpZXdfcmVzb3VyY2VfbG9hZF9mYWlsZWQoRXZh c19PYmplY3QqIGV3a1ZpZXcsIHVpbnQ2NF90IHJlc291cmNlSWRlbnRpZmllciwgRXdrX0Vycm9y KiBlcnJvcik7CiB2b2lkIGV3a192aWV3X3Jlc291cmNlX2xvYWRfZmluaXNoZWQoRXZhc19PYmpl Y3QqIGV3a1ZpZXcsIHVpbnQ2NF90IHJlc291cmNlSWRlbnRpZmllcik7CiB2b2lkIGV3a192aWV3 X3Jlc291cmNlX2xvYWRfaW5pdGlhdGVkKEV2YXNfT2JqZWN0KiBld2tWaWV3LCB1aW50NjRfdCBy ZXNvdXJjZUlkZW50aWZpZXIsIEV3a19SZXNvdXJjZSogcmVzb3VyY2UsIEV3a19VcmxfUmVxdWVz dCogcmVxdWVzdCk7Cg== 168642 2012-10-15 00:43:28 -0700 2012-10-15 02:46:44 -0700 patch for landing. tooltip4.patch text/plain 4445 jinwoo7.song ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBlNjRjNjAyLi45NjI1NzE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTItMTAtMTQgIEppbndvbyBTb25nICA8amlud29vNy5zb25nQHNhbXN1bmcuY29tPgor CisgICAgICAgIFtFRkxdW1dLMl0gUHJvdmlkZSBpbXBsZW1lbnRhdGlvbiBmb3IgUGFnZUNsaWVu dEltcGw6OnRvb2xUaXBDaGFuZ2VkKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTk4NTg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hk ZSBDaHJpc3RpYW5zZW4uCisKKyAgICAgICAgSW1wbGVtZW50IFBhZ2VDbGllbnRJbXBsOjp0b29s VGlwQ2hhbmdlZCgpIHRvIGVtaXQgc2lnbmFsICd0b29sdGlwLHRleHQsc2V0JyB3aXRoIGEgdG9v bHRpcCB0ZXh0LAorICAgICAgICBvciAndG9vbHRpcCx0ZXh0LHVuc2V0JyBpZiB0b29sdGlwIG11 c3QgYmUgYWN0dWFsbHkgcmVtb3ZlZC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL1Bh Z2VDbGllbnRJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6UGFnZUNsaWVudEltcGw6OnRvb2xU aXBDaGFuZ2VkKToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHA6Cisg ICAgICAgIChld2tfdmlld190b29sdGlwX3RleHRfc2V0KToKKyAgICAgICAgKiBVSVByb2Nlc3Mv QVBJL2VmbC9ld2tfdmlldy5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3 X3ByaXZhdGUuaDoKKwogMjAxMi0xMC0xNCAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBw bGUuY29tPgogCiAgICAgICAgIEZpeCB0aGUgd29ybGQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9QYWdlQ2xpZW50SW1wbC5jcHAgYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL2VmbC9QYWdlQ2xpZW50SW1wbC5jcHAKaW5kZXggM2JmMTk0Zi4uOTkz Zjg2MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvUGFnZUNs aWVudEltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL1BhZ2VD bGllbnRJbXBsLmNwcApAQCAtMTIzLDkgKzEyMyw5IEBAIHZvaWQgUGFnZUNsaWVudEltcGw6OnBh Z2VDbG9zZWQoKQogICAgIG5vdEltcGxlbWVudGVkKCk7CiB9CiAKLXZvaWQgUGFnZUNsaWVudElt cGw6OnRvb2xUaXBDaGFuZ2VkKGNvbnN0IFN0cmluZyYsIGNvbnN0IFN0cmluZyYpCit2b2lkIFBh Z2VDbGllbnRJbXBsOjp0b29sVGlwQ2hhbmdlZChjb25zdCBTdHJpbmcmLCBjb25zdCBTdHJpbmcm IG5ld1Rvb2xUaXApCiB7Ci0gICAgbm90SW1wbGVtZW50ZWQoKTsKKyAgICBld2tfdmlld190b29s dGlwX3RleHRfc2V0KG1fdmlld1dpZGdldCwgbmV3VG9vbFRpcC51dGY4KCkuZGF0YSgpKTsKIH0K IAogdm9pZCBQYWdlQ2xpZW50SW1wbDo6c2V0Q3Vyc29yKGNvbnN0IEN1cnNvciYgY3Vyc29yKQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuY3Bw IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuY3BwCmluZGV4IDA3 YTk0MjIuLjdkY2VhMTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv ZWZsL2V3a192aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9l d2tfdmlldy5jcHAKQEAgLTExMjMsNiArMTEyMywyMSBAQCB2b2lkIGV3a192aWV3X3RpdGxlX2No YW5nZWQoRXZhc19PYmplY3QqIGV3a1ZpZXcsIGNvbnN0IGNoYXIqIHRpdGxlKQogICAgIGV2YXNf b2JqZWN0X3NtYXJ0X2NhbGxiYWNrX2NhbGwoZXdrVmlldywgInRpdGxlLGNoYW5nZWQiLCBjb25z dF9jYXN0PGNoYXIqPih0aXRsZSkpOwogfQogCisvKioKKyAqIEBpbnRlcm5hbAorICogUmVwb3J0 cyB0aGF0IHRoZSB0b29sdGlwIHRleHQgd2FzIGNoYW5nZWQuCisgKgorICogRW1pdHMgc2lnbmFs OiAidG9vbHRpcCx0ZXh0LHNldCIgd2l0aCBhIHRvb2x0aXAgdGV4dCB0byBzZXQuCisgKiAgICAg ICAgICAgICAgICJ0b29sdGlwLHRleHQsdW5zZXQiIGlmIHRvb2x0aXAgbXVzdCBiZSBhY3R1YWxs eSByZW1vdmVkLgorICovCit2b2lkIGV3a192aWV3X3Rvb2x0aXBfdGV4dF9zZXQoRXZhc19PYmpl Y3QqIGV3a1ZpZXcsIGNvbnN0IGNoYXIqIHRleHQpCit7CisgICAgaWYgKHRleHQgJiYgKnRleHQp CisgICAgICAgIGV2YXNfb2JqZWN0X3NtYXJ0X2NhbGxiYWNrX2NhbGwoZXdrVmlldywgInRvb2x0 aXAsdGV4dCxzZXQiLCBjb25zdF9jYXN0PGNoYXIqPih0ZXh0KSk7CisgICAgZWxzZQorICAgICAg ICBldmFzX29iamVjdF9zbWFydF9jYWxsYmFja19jYWxsKGV3a1ZpZXcsICJ0b29sdGlwLHRleHQs dW5zZXQiLCAwKTsKK30KKwogZG91YmxlIGV3a192aWV3X2xvYWRfcHJvZ3Jlc3NfZ2V0KGNvbnN0 IEV2YXNfT2JqZWN0KiBld2tWaWV3KQogewogICAgIEVXS19WSUVXX1NEX0dFVF9PUl9SRVRVUk4o ZXdrVmlldywgc21hcnREYXRhLCAtMS4wKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L2VmbC9ld2tfdmlldy5oCmluZGV4IGU5Y2JlNGUuLmM2MDNlZWQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmgKKysrIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuaApAQCAtNjQsNiArNjQsOCBAQAogICogLSAi cmVzb3VyY2UscmVxdWVzdCxzZW50IiwgY29uc3QgRXdrX1Jlc291cmNlX1JlcXVlc3QqOiBhIHJl c291cmNlIHJlcXVlc3Qgd2FzIHNlbnQuCiAgKiAtICJ0ZXh0LGZvdW5kIiwgdW5zaWduZWQgaW50 KjogdGhlIHJlcXVlc3RlZCB0ZXh0IHdhcyBmb3VuZCBhbmQgaXQgZ2l2ZXMgdGhlIG51bWJlciBv ZiBtYXRjaGVzLgogICogLSAidGl0bGUsY2hhbmdlZCIsIGNvbnN0IGNoYXIqOiB0aXRsZSBvZiB0 aGUgbWFpbiBmcmFtZSB3YXMgY2hhbmdlZC4KKyAqIC0gInRvb2x0aXAsdGV4dCxzZXQiLCBjb25z dCBjaGFyKjogdG9vbHRpcCB0ZXh0IHdhcyBjaGFuZ2VkLgorICogLSAidG9vbHRpcCx0ZXh0LHVu c2V0Iiwgdm9pZDogdG9vbHRpcCB0ZXh0IG11c3QgYmUgYWN0dWFsbHkgcmVtb3ZlZC4KICAqIC0g InVybCxjaGFuZ2VkIiwgY29uc3QgY2hhcio6IHVybCBvZiB0aGUgbWFpbiBmcmFtZSB3YXMgY2hh bmdlZC4KICAqIC0gIndlYnByb2Nlc3MsY3Jhc2hlZCIsIEVpbmFfQm9vbCo6IGV4cGVjdHMgYSBA YyBFSU5BX1RSVUUgaWYgd2ViIHByb2Nlc3MgY3Jhc2ggaXMgaGFuZGxlZDsgQGMgRUlOQV9GQUxT RSwgb3RoZXJ3aXNlLgogICovCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL2VmbC9ld2tfdmlld19wcml2YXRlLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L2VmbC9ld2tfdmlld19wcml2YXRlLmgKaW5kZXggOGVjOTFjMS4uYTc1MTgzMCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXdfcHJpdmF0ZS5oCisr KyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3X3ByaXZhdGUuaApA QCAtNzYsNiArNzYsNyBAQCB2b2lkIGV3a192aWV3X25ld193aW5kb3dfcG9saWN5X2RlY2lzaW9u KEV2YXNfT2JqZWN0KiBld2tWaWV3LCBFd2tfTmF2aWdhdGlvbl9Qbwogdm9pZCBld2tfdmlld19w YWdlX2Nsb3NlKEV2YXNfT2JqZWN0KiBld2tWaWV3KTsKIFdLUGFnZVJlZiBld2tfdmlld19wYWdl X2NyZWF0ZShFdmFzX09iamVjdCogZXdrVmlldyk7CiB2b2lkIGV3a192aWV3X3RpdGxlX2NoYW5n ZWQoRXZhc19PYmplY3QqIGV3a1ZpZXcsIGNvbnN0IGNoYXIqIHRpdGxlKTsKK3ZvaWQgZXdrX3Zp ZXdfdG9vbHRpcF90ZXh0X3NldChFdmFzX09iamVjdCogZXdrVmlldywgY29uc3QgY2hhciogdGV4 dCk7CiB2b2lkIGV3a192aWV3X3Jlc291cmNlX2xvYWRfZmFpbGVkKEV2YXNfT2JqZWN0KiBld2tW aWV3LCB1aW50NjRfdCByZXNvdXJjZUlkZW50aWZpZXIsIEV3a19FcnJvciogZXJyb3IpOwogdm9p ZCBld2tfdmlld19yZXNvdXJjZV9sb2FkX2ZpbmlzaGVkKEV2YXNfT2JqZWN0KiBld2tWaWV3LCB1 aW50NjRfdCByZXNvdXJjZUlkZW50aWZpZXIpOwogdm9pZCBld2tfdmlld19yZXNvdXJjZV9sb2Fk X2luaXRpYXRlZChFdmFzX09iamVjdCogZXdrVmlldywgdWludDY0X3QgcmVzb3VyY2VJZGVudGlm aWVyLCBFd2tfUmVzb3VyY2UqIHJlc291cmNlLCBFd2tfVXJsX1JlcXVlc3QqIHJlcXVlc3QpOwo= 168657 2012-10-15 02:46:44 -0700 2012-10-15 13:23:52 -0700 patch tooltip5.patch text/plain 4209 jinwoo7.song ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBlNjRjNjAyLi5jYzdjN2E2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTItMTAtMTQgIEppbndvbyBTb25nICA8amlud29vNy5zb25nQHNhbXN1bmcuY29tPgor CisgICAgICAgIFtFRkxdW1dLMl0gUHJvdmlkZSBpbXBsZW1lbnRhdGlvbiBmb3IgUGFnZUNsaWVu dEltcGw6OnRvb2xUaXBDaGFuZ2VkKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTk4NTg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hk ZSBDaHJpc3RpYW5zZW4uCisKKyAgICAgICAgSW1wbGVtZW50IFBhZ2VDbGllbnRJbXBsOjp0b29s VGlwQ2hhbmdlZCgpIHRvIGVtaXQgc2lnbmFsICd0b29sdGlwLHRleHQsc2V0JyB3aXRoIGEgdG9v bHRpcCB0ZXh0LAorICAgICAgICBvciAndG9vbHRpcCx0ZXh0LHVuc2V0JyBpZiB0b29sdGlwIHdh cyB1bnNldC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL1BhZ2VDbGllbnRJbXBsLmNw cDoKKyAgICAgICAgKFdlYktpdDo6UGFnZUNsaWVudEltcGw6OnRvb2xUaXBDaGFuZ2VkKToKKyAg ICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHA6CisgICAgICAgIChld2tfdmll d190b29sdGlwX3RleHRfc2V0KToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmll dy5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3X3ByaXZhdGUuaDoKKwog MjAxMi0xMC0xNCAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAg ICAgIEZpeCB0aGUgd29ybGQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL2VmbC9QYWdlQ2xpZW50SW1wbC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L2VmbC9QYWdlQ2xpZW50SW1wbC5jcHAKaW5kZXggM2JmMTk0Zi4uOTkzZjg2MyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvUGFnZUNsaWVudEltcGwuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL1BhZ2VDbGllbnRJbXBsLmNwcApA QCAtMTIzLDkgKzEyMyw5IEBAIHZvaWQgUGFnZUNsaWVudEltcGw6OnBhZ2VDbG9zZWQoKQogICAg IG5vdEltcGxlbWVudGVkKCk7CiB9CiAKLXZvaWQgUGFnZUNsaWVudEltcGw6OnRvb2xUaXBDaGFu Z2VkKGNvbnN0IFN0cmluZyYsIGNvbnN0IFN0cmluZyYpCit2b2lkIFBhZ2VDbGllbnRJbXBsOjp0 b29sVGlwQ2hhbmdlZChjb25zdCBTdHJpbmcmLCBjb25zdCBTdHJpbmcmIG5ld1Rvb2xUaXApCiB7 Ci0gICAgbm90SW1wbGVtZW50ZWQoKTsKKyAgICBld2tfdmlld190b29sdGlwX3RleHRfc2V0KG1f dmlld1dpZGdldCwgbmV3VG9vbFRpcC51dGY4KCkuZGF0YSgpKTsKIH0KIAogdm9pZCBQYWdlQ2xp ZW50SW1wbDo6c2V0Q3Vyc29yKGNvbnN0IEN1cnNvciYgY3Vyc29yKQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuY3BwIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuY3BwCmluZGV4IDA3YTk0MjIuLmViNjc4MWEg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHAKQEAg LTExMjMsNiArMTEyMywxNyBAQCB2b2lkIGV3a192aWV3X3RpdGxlX2NoYW5nZWQoRXZhc19PYmpl Y3QqIGV3a1ZpZXcsIGNvbnN0IGNoYXIqIHRpdGxlKQogICAgIGV2YXNfb2JqZWN0X3NtYXJ0X2Nh bGxiYWNrX2NhbGwoZXdrVmlldywgInRpdGxlLGNoYW5nZWQiLCBjb25zdF9jYXN0PGNoYXIqPih0 aXRsZSkpOwogfQogCisvKioKKyAqIEBpbnRlcm5hbAorICovCit2b2lkIGV3a192aWV3X3Rvb2x0 aXBfdGV4dF9zZXQoRXZhc19PYmplY3QqIGV3a1ZpZXcsIGNvbnN0IGNoYXIqIHRleHQpCit7Cisg ICAgaWYgKHRleHQgJiYgKnRleHQpCisgICAgICAgIGV2YXNfb2JqZWN0X3NtYXJ0X2NhbGxiYWNr X2NhbGwoZXdrVmlldywgInRvb2x0aXAsdGV4dCxzZXQiLCBjb25zdF9jYXN0PGNoYXIqPih0ZXh0 KSk7CisgICAgZWxzZQorICAgICAgICBldmFzX29iamVjdF9zbWFydF9jYWxsYmFja19jYWxsKGV3 a1ZpZXcsICJ0b29sdGlwLHRleHQsdW5zZXQiLCAwKTsKK30KKwogZG91YmxlIGV3a192aWV3X2xv YWRfcHJvZ3Jlc3NfZ2V0KGNvbnN0IEV2YXNfT2JqZWN0KiBld2tWaWV3KQogewogICAgIEVXS19W SUVXX1NEX0dFVF9PUl9SRVRVUk4oZXdrVmlldywgc21hcnREYXRhLCAtMS4wKTsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmggYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5oCmluZGV4IGU5Y2JlNGUuLjEzNWE0 MzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3 LmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuaApAQCAt NjQsNiArNjQsOCBAQAogICogLSAicmVzb3VyY2UscmVxdWVzdCxzZW50IiwgY29uc3QgRXdrX1Jl c291cmNlX1JlcXVlc3QqOiBhIHJlc291cmNlIHJlcXVlc3Qgd2FzIHNlbnQuCiAgKiAtICJ0ZXh0 LGZvdW5kIiwgdW5zaWduZWQgaW50KjogdGhlIHJlcXVlc3RlZCB0ZXh0IHdhcyBmb3VuZCBhbmQg aXQgZ2l2ZXMgdGhlIG51bWJlciBvZiBtYXRjaGVzLgogICogLSAidGl0bGUsY2hhbmdlZCIsIGNv bnN0IGNoYXIqOiB0aXRsZSBvZiB0aGUgbWFpbiBmcmFtZSB3YXMgY2hhbmdlZC4KKyAqIC0gInRv b2x0aXAsdGV4dCxzZXQiLCBjb25zdCBjaGFyKjogdG9vbHRpcCB3YXMgc2V0LgorICogLSAidG9v bHRpcCx0ZXh0LHVuc2V0Iiwgdm9pZDogdG9vbHRpcCB3YXMgdW5zZXQuCiAgKiAtICJ1cmwsY2hh bmdlZCIsIGNvbnN0IGNoYXIqOiB1cmwgb2YgdGhlIG1haW4gZnJhbWUgd2FzIGNoYW5nZWQuCiAg KiAtICJ3ZWJwcm9jZXNzLGNyYXNoZWQiLCBFaW5hX0Jvb2wqOiBleHBlY3RzIGEgQGMgRUlOQV9U UlVFIGlmIHdlYiBwcm9jZXNzIGNyYXNoIGlzIGhhbmRsZWQ7IEBjIEVJTkFfRkFMU0UsIG90aGVy d2lzZS4KICAqLwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwv ZXdrX3ZpZXdfcHJpdmF0ZS5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdr X3ZpZXdfcHJpdmF0ZS5oCmluZGV4IDhlYzkxYzEuLmE3NTE4MzAgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3X3ByaXZhdGUuaAorKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlld19wcml2YXRlLmgKQEAgLTc2LDYg Kzc2LDcgQEAgdm9pZCBld2tfdmlld19uZXdfd2luZG93X3BvbGljeV9kZWNpc2lvbihFdmFzX09i amVjdCogZXdrVmlldywgRXdrX05hdmlnYXRpb25fUG8KIHZvaWQgZXdrX3ZpZXdfcGFnZV9jbG9z ZShFdmFzX09iamVjdCogZXdrVmlldyk7CiBXS1BhZ2VSZWYgZXdrX3ZpZXdfcGFnZV9jcmVhdGUo RXZhc19PYmplY3QqIGV3a1ZpZXcpOwogdm9pZCBld2tfdmlld190aXRsZV9jaGFuZ2VkKEV2YXNf T2JqZWN0KiBld2tWaWV3LCBjb25zdCBjaGFyKiB0aXRsZSk7Cit2b2lkIGV3a192aWV3X3Rvb2x0 aXBfdGV4dF9zZXQoRXZhc19PYmplY3QqIGV3a1ZpZXcsIGNvbnN0IGNoYXIqIHRleHQpOwogdm9p ZCBld2tfdmlld19yZXNvdXJjZV9sb2FkX2ZhaWxlZChFdmFzX09iamVjdCogZXdrVmlldywgdWlu dDY0X3QgcmVzb3VyY2VJZGVudGlmaWVyLCBFd2tfRXJyb3IqIGVycm9yKTsKIHZvaWQgZXdrX3Zp ZXdfcmVzb3VyY2VfbG9hZF9maW5pc2hlZChFdmFzX09iamVjdCogZXdrVmlldywgdWludDY0X3Qg cmVzb3VyY2VJZGVudGlmaWVyKTsKIHZvaWQgZXdrX3ZpZXdfcmVzb3VyY2VfbG9hZF9pbml0aWF0 ZWQoRXZhc19PYmplY3QqIGV3a1ZpZXcsIHVpbnQ2NF90IHJlc291cmNlSWRlbnRpZmllciwgRXdr X1Jlc291cmNlKiByZXNvdXJjZSwgRXdrX1VybF9SZXF1ZXN0KiByZXF1ZXN0KTsK