98584 2012-10-05 23:18:25 -0700 Fix weird use of KURL's protocolIs 2012-10-06 11:44:11 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin abarth eric.carlson feature-media-reviews japhet webkit.review.bot oldest_to_newest 736186 0 benjamin 2012-10-05 23:18:25 -0700 Implicit conversion to string is bad. 736190 1 167441 benjamin 2012-10-05 23:30:48 -0700 Created attachment 167441 Patch 736265 2 167441 webkit.review.bot 2012-10-06 11:44:08 -0700 Comment on attachment 167441 Patch Clearing flags on attachment: 167441 Committed r130586: <http://trac.webkit.org/changeset/130586> 736266 3 webkit.review.bot 2012-10-06 11:44:11 -0700 All reviewed patches have been landed. Closing bug. 167441 2012-10-05 23:30:48 -0700 2012-10-06 11:44:08 -0700 Patch bug-98584-20121005232954.patch text/plain 3437 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwNTc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzRlZDgwZDg3ZmEwMzM0 OGUyNDE4Mzk4NWMwMDJjMTcyMjgyMDljMi4uMzYwMzA2NTFlOGY3NzI0ODYzMTBiMzdlOTg0ZWIy NDdmY2JjMGU4YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTEwLTA1ICBCZW5q YW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBGaXggd2VpcmQg dXNlIG9mIEtVUkwncyBwcm90b2NvbElzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD05ODU4NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIENvbnZlcnRpbmcgYSBLVVJMIHRvIHN0cmluZyBpcyBhIGJhZCBpZGVh LgorCisgICAgICAgIEludmFsaWQgVVJMcyBjYW4gcmV0dXJuIGEgc3RyaW5nIHRoYXQgcGFzcyB0 aGUgdGVzdHMsIHdoaWxlIGFuCisgICAgICAgIGludmFsaWQgVVJMIHdpbGwgZmFpbCBwcm90b2Nv bElzKCkuCisKKyAgICAgICAgKiBsb2FkZXIvY2FjaGUvQ2FjaGVkUmVzb3VyY2UuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6Q2FjaGVkUmVzb3VyY2U6OnJlbW92ZUNsaWVudCk6CisgICAgICAgICog cGxhdGZvcm0vZ3JhcGhpY3MvTWVkaWFQbGF5ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVk aWFQbGF5ZXI6OmxvYWQpOgorICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvRGF0YVVSTC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpoYW5kbGVEYXRhVVJMKToKKwogMjAxMi0xMC0wNSAgQWRhbSBC YXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFtWOF0gdG9WOChOb2RlKiwgLi4u KSBkb2VzIG1vcmUgd29yayB0aGFuIG5lZWRlZCAoNiUgZmFzdGVyIG9uIGRvbS10cmF2ZXJzZSkK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRSZXNvdXJjZS5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmVzb3VyY2UuY3BwCmluZGV4 IDQyZTE4NjhiNGQwMjI4MGRhZTIxZmViMWY2NzIyNmY4NWRhYWNlYjEuLmVkN2Y5YjA2YjhjMWMx ZjM0ZWRmMzI0MWRhYjIxOTNjYzRkNDUzNmQgMTAwNzU1Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xv YWRlci9jYWNoZS9DYWNoZWRSZXNvdXJjZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVy L2NhY2hlL0NhY2hlZFJlc291cmNlLmNwcApAQCAtNDQ4LDcgKzQ0OCw3IEBAIHZvaWQgQ2FjaGVk UmVzb3VyY2U6OnJlbW92ZUNsaWVudChDYWNoZWRSZXNvdXJjZUNsaWVudCogY2xpZW50KQogICAg ICAgICAgICAgLy8gIm5vLXN0b3JlOiAuLi4gTVVTVCBtYWtlIGEgYmVzdC1lZmZvcnQgYXR0ZW1w dCB0byByZW1vdmUgdGhlIGluZm9ybWF0aW9uIGZyb20gdm9sYXRpbGUgc3RvcmFnZSBhcyBwcm9t cHRseSBhcyBwb3NzaWJsZSIKICAgICAgICAgICAgIC8vICIuLi4gSGlzdG9yeSBidWZmZXJzIE1B WSBzdG9yZSBzdWNoIHJlc3BvbnNlcyBhcyBwYXJ0IG9mIHRoZWlyIG5vcm1hbCBvcGVyYXRpb24u IgogICAgICAgICAgICAgLy8gV2UgYWxsb3cgbm9uLXNlY3VyZSBjb250ZW50IHRvIGJlIHJldXNl ZCBpbiBoaXN0b3J5LCBidXQgd2UgZG8gbm90IGFsbG93IHNlY3VyZSBjb250ZW50IHRvIGJlIHJl dXNlZC4KLSAgICAgICAgICAgIGlmIChwcm90b2NvbElzKHVybCgpLCAiaHR0cHMiKSkKKyAgICAg ICAgICAgIGlmICh1cmwoKS5wcm90b2NvbElzKCJodHRwcyIpKQogICAgICAgICAgICAgICAgIG1l bW9yeUNhY2hlKCktPnJlbW92ZSh0aGlzKTsKICAgICAgICAgfSBlbHNlCiAgICAgICAgICAgICBt ZW1vcnlDYWNoZSgpLT5wcnVuZSgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvTWVkaWFQbGF5ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvTWVkaWFQbGF5ZXIuY3BwCmluZGV4IDQ3ODM0ZDVhYjE1YzE1NmViNjYyYmMwZjhlMGJh NWEyZGJiNjAwYzMuLmZhMGRjNjgwMGYyMzQ3MDg1OWM4N2MwYTc0MjFkZWQxOGZhYmJjYzYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL01lZGlhUGxheWVyLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXllci5jcHAK QEAgLTM2MCw3ICszNjAsNyBAQCBib29sIE1lZGlhUGxheWVyOjpsb2FkKGNvbnN0IEtVUkwmIHVy bCwgY29uc3QgQ29udGVudFR5cGUmIGNvbnRlbnRUeXBlLCBjb25zdCBTdAogCiAgICAgLy8gSWYg dGhlIE1JTUUgdHlwZSBpcyBtaXNzaW5nIG9yIGlzIG5vdCBtZWFuaW5nZnVsLCB0cnkgdG8gZmln dXJlIGl0IG91dCBmcm9tIHRoZSBVUkwuCiAgICAgaWYgKG1fY29udGVudE1JTUVUeXBlLmlzRW1w dHkoKSB8fCBtX2NvbnRlbnRNSU1FVHlwZSA9PSBhcHBsaWNhdGlvbk9jdGV0U3RyZWFtKCkgfHwg bV9jb250ZW50TUlNRVR5cGUgPT0gdGV4dFBsYWluKCkpIHsKLSAgICAgICAgaWYgKHByb3RvY29s SXMobV91cmwuc3RyaW5nKCksICJkYXRhIikpCisgICAgICAgIGlmIChtX3VybC5wcm90b2NvbElz RGF0YSgpKQogICAgICAgICAgICAgbV9jb250ZW50TUlNRVR5cGUgPSBtaW1lVHlwZUZyb21EYXRh VVJMKG1fdXJsLnN0cmluZygpKTsKICAgICAgICAgZWxzZSB7CiAgICAgICAgICAgICBTdHJpbmcg bGFzdFBhdGhDb21wb25lbnQgPSB1cmwubGFzdFBhdGhDb21wb25lbnQoKTsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvRGF0YVVSTC5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9uZXR3b3JrL0RhdGFVUkwuY3BwCmluZGV4IGFhZTUyNWMyNTNlOWNhYTU0 MjgwYjlmMzQ3M2MyNzAxMTdmNGM5NjEuLjc3NjdmZTI2NDVmMTZlZTYxMGRkMTdlNTcwYWEzOGFj MmYyNDExNzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvRGF0 YVVSTC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9EYXRhVVJMLmNw cApAQCAtNDAsNyArNDAsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIHZvaWQgaGFuZGxlRGF0 YVVSTChSZXNvdXJjZUhhbmRsZSogaGFuZGxlKQogewotICAgIEFTU0VSVChoYW5kbGUtPmZpcnN0 UmVxdWVzdCgpLnVybCgpLnByb3RvY29sSXMoImRhdGEiKSk7CisgICAgQVNTRVJUKGhhbmRsZS0+ Zmlyc3RSZXF1ZXN0KCkudXJsKCkucHJvdG9jb2xJc0RhdGEoKSk7CiAgICAgU3RyaW5nIHVybCA9 IGhhbmRsZS0+Zmlyc3RSZXF1ZXN0KCkudXJsKCkuc3RyaW5nKCk7CiAKICAgICBpbnQgaW5kZXgg PSB1cmwuZmluZCgnLCcpOwo=