98561 2012-10-05 15:03:19 -0700 Perf test pesults page takes forever to load on a machine with a slow Internet connection 2012-10-08 12:01:52 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 77037 1 rniwa rniwa abarth arv ojan zoltan oldest_to_newest 736007 0 rniwa 2012-10-05 15:03:19 -0700 Right now, perf. tests' results page tries to load both local and remote files. As a result, when your computer is connected to a really slow network (e.g. public WiFi), it could take ages to load because it pauses the parser. We should dynamically load scripts asynchronously. 736009 1 167394 rniwa 2012-10-05 15:05:21 -0700 Created attachment 167394 Patch 736031 2 167394 ojan 2012-10-05 15:25:21 -0700 Comment on attachment 167394 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167394&action=review > PerformanceTests/resources/results-template.html:514 > +(function () { You probably want to move this whole block close to the top of the file so that we start doing the network request ASAP. > PerformanceTests/resources/results-template.html:538 > + loadScript(prefix + '/' + plugins[i], function () { > + numberOfLoadedPlugins++; > + if (numberOfLoadedPlugins == plugins.length) > + init(); > + }, (function (plugin) { > + return function () { alert("Failed to load " + plugin); } > + })(prefixes[i])); These nested function calls are really hard to read. Can you make a local named helper function? > PerformanceTests/resources/results-template.html:542 > + var prefixes = ['%AbsolutePathToWebKitTrunk%', 'https://svn.webkit.org/repository/webkit/trunk']; Instead of trying both, could you try the local one first and only do the network one if that fails? The local once should error out pretty quickly when it's not available. > PerformanceTests/resources/results-template.html:556 > + loadScript(prefixes[i] + '/' + jQuery, (function (prefix) { > + return function () { > + if (!startedLoadingPlugins) > + loadPlugins(prefix); > + startedLoadingPlugins = true; > + } > + })(prefixes[i]), function () { > + numberOfFailures++; > + if (numberOfFailures == prefixes.length) > + alert("Failed to load jQuery."); > + }); Ditto. Hard to read. It would also help if you put the second argument to loadScript on a newline after the comma. 736902 3 rniwa 2012-10-08 12:01:52 -0700 Committed r130669: <http://trac.webkit.org/changeset/130669> 167394 2012-10-05 15:05:21 -0700 2012-10-05 15:25:21 -0700 Patch bug-98561-20121005150428.patch text/plain 5080 rniwa SW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFBlcmZvcm1h bmNlVGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMzA1NTcpCisrKyBQZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEwLTA1ICBS eW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFBlcmYgdGVzdCBwZXN1 bHRzIHBhZ2UgdGFrZXMgZm9yZXZlciB0byBsb2FkIG9uIGEgbWFjaGluZSB3aXRoIGEgc2xvdyBJ bnRlcm5ldCBjb25uZWN0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD05ODU2MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRyeSBsb2FkaW5nIGpxdWVyeSBib3RoIGxvY2FsbHkgYW5kIHJlbW90ZWx5LCBh bmQgdXNlIHRoZSBzYW1lIG1ldGhvZCB0byBsb2FkIHRoZSByZW1haW5pbmcKKyAgICAgICAganF1 ZXJ5IHBsdWdpbnMgd2hlbiBlaXRoZXIgb25lIHN1Y2NlZWRzLgorCisgICAgICAgICogcmVzb3Vy Y2VzL3Jlc3VsdHMtdGVtcGxhdGUuaHRtbDoKKwogMjAxMi0xMC0wNCAgSGF5YXRvIEl0byAgPGhh eWF0b0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW1JlZmFjdG9yaW5nXSBJbnRyb2R1Y2UgYSB0 cmF2ZXJzYWwgc3RyYXRlZ3kgaW4gU2VsZWN0b3JDaGVja2VyCkluZGV4OiBQZXJmb3JtYW5jZVRl c3RzL3Jlc291cmNlcy9yZXN1bHRzLXRlbXBsYXRlLmh0bWwKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gUGVyZm9y bWFuY2VUZXN0cy9yZXNvdXJjZXMvcmVzdWx0cy10ZW1wbGF0ZS5odG1sCShyZXZpc2lvbiAxMzA1 MzEpCisrKyBQZXJmb3JtYW5jZVRlc3RzL3Jlc291cmNlcy9yZXN1bHRzLXRlbXBsYXRlLmh0bWwJ KHdvcmtpbmcgY29weSkKQEAgLTIsMTMgKzIsNiBAQAogPGh0bWw+CiA8aGVhZD4KIDx0aXRsZT5X ZWJLaXQgUGVyZm9ybWFuY2UgVGVzdCBSZXN1bHRzPC90aXRsZT4KLTxzY3JpcHQgc3JjPSIlQWJz b2x1dGVQYXRoVG9XZWJLaXRUcnVuayUvUGVyZm9ybWFuY2VUZXN0cy9Ecm9tYWVvL3Jlc291cmNl cy9kcm9tYWVvL3dlYi9saWIvanF1ZXJ5LTEuNi40LmpzIj48L3NjcmlwdD4KLTxzY3JpcHQgc3Jj PSJodHRwczovL3RyYWMud2Via2l0Lm9yZy9icm93c2VyL3RydW5rL1BlcmZvcm1hbmNlVGVzdHMv RHJvbWFlby9yZXNvdXJjZXMvZHJvbWFlby93ZWIvbGliL2pxdWVyeS0xLjYuNC5qcz9mb3JtYXQ9 dHh0Ij48L3NjcmlwdD4KLTxzY3JpcHQgc3JjPSIlQWJzb2x1dGVQYXRoVG9XZWJLaXRUcnVuayUv UGVyZm9ybWFuY2VUZXN0cy9yZXNvdXJjZXMvanF1ZXJ5LmZsb3QubWluLmpzIj48L3NjcmlwdD4K LTxzY3JpcHQgc3JjPSJodHRwczovL3RyYWMud2Via2l0Lm9yZy9icm93c2VyL3RydW5rL1BlcmZv cm1hbmNlVGVzdHMvcmVzb3VyY2VzL2pxdWVyeS5mbG90Lm1pbi5qcz9mb3JtYXQ9dHh0Ij48L3Nj cmlwdD4KLTxzY3JpcHQgc3JjPSIlQWJzb2x1dGVQYXRoVG9XZWJLaXRUcnVuayUvUGVyZm9ybWFu Y2VUZXN0cy9yZXNvdXJjZXMvanF1ZXJ5LnRhYmxlc29ydGVyLm1pbi5qcyI+PC9zY3JpcHQ+Ci08 c2NyaXB0IHNyYz0iaHR0cHM6Ly90cmFjLndlYmtpdC5vcmcvYnJvd3Nlci90cnVuay9QZXJmb3Jt YW5jZVRlc3RzL3Jlc291cmNlcy9qcXVlcnkudGFibGVzb3J0ZXIubWluLmpzP2Zvcm1hdD10eHQi Pjwvc2NyaXB0PgotPHNjcmlwdCBpZD0ianNvbiIgdHlwZT0iYXBwbGljYXRpb24vanNvbiI+JVBl Zm9ybWFuY2VUZXN0c1Jlc3VsdHNKU09OJTwvc2NyaXB0PgogPHN0eWxlIHR5cGU9InRleHQvY3Nz Ij4KIAogc2VjdGlvbiB7CkBAIC0xMzYsMjEgKzEyOSw2IEBAIHRkLndvcnNlIHsKIFJlc3VsdCA8 c3BhbiBpZD0idGltZS1tZW1vcnkiIGNsYXNzPSJjaGVja2JveCI+PHNwYW4gY2xhc3M9ImNoZWNr ZWQiPlRpbWU8L3NwYW4+PHNwYW4+TWVtb3J5PC9zcGFuPjwvc3Bhbj4KIFJlZmVyZW5jZSA8c3Bh biBpZD0icmVmZXJlbmNlIiBjbGFzcz0iY2hlY2tib3giPjwvc3Bhbj4KIDwvZGl2PgotPHNjcmlw dD4KLQotJChkb2N1bWVudCkucmVhZHkoZnVuY3Rpb24gKCkgewotICAgICQoJy5jaGVja2JveCcp LmVhY2goZnVuY3Rpb24gKGluZGV4LCBjaGVja2JveCkgewotICAgICAgICAkKGNoZWNrYm94KS5j aGlsZHJlbignc3BhbicpLmNsaWNrKGZ1bmN0aW9uIChldmVudCkgewotICAgICAgICAgICAgaWYg KCQodGhpcykuaGFzQ2xhc3MoJ2NoZWNrZWQnKSkKLSAgICAgICAgICAgICAgICByZXR1cm47Ci0g ICAgICAgICAgICAkKGNoZWNrYm94KS5jaGlsZHJlbignc3BhbicpLnJlbW92ZUNsYXNzKCdjaGVj a2VkJyk7Ci0gICAgICAgICAgICAkKHRoaXMpLmFkZENsYXNzKCdjaGVja2VkJyk7Ci0gICAgICAg ICAgICAkKGNoZWNrYm94KS50cmlnZ2VyKCdjaGFuZ2UnLCAkKHRoaXMpKTsKLSAgICAgICAgfSk7 Ci0gICAgfSk7Ci19KQotCi08L3NjcmlwdD4KIDx0YWJsZSBpZD0iY29udGFpbmVyIj48L3RhYmxl PgogPHNjcmlwdD4KIApAQCAtNDgwLDYgKzQ1OCwxNiBAQCBmdW5jdGlvbiBjcmVhdGVUYWJsZVJv dyh0ZXN0LCByZWZlcmVuY2VSCiB9CiAKIGZ1bmN0aW9uIGluaXQoKSB7CisgICAgJCgnLmNoZWNr Ym94JykuZWFjaChmdW5jdGlvbiAoaW5kZXgsIGNoZWNrYm94KSB7CisgICAgICAgICQoY2hlY2ti b3gpLmNoaWxkcmVuKCdzcGFuJykuY2xpY2soZnVuY3Rpb24gKGV2ZW50KSB7CisgICAgICAgICAg ICBpZiAoJCh0aGlzKS5oYXNDbGFzcygnY2hlY2tlZCcpKQorICAgICAgICAgICAgICAgIHJldHVy bjsKKyAgICAgICAgICAgICQoY2hlY2tib3gpLmNoaWxkcmVuKCdzcGFuJykucmVtb3ZlQ2xhc3Mo J2NoZWNrZWQnKTsKKyAgICAgICAgICAgICQodGhpcykuYWRkQ2xhc3MoJ2NoZWNrZWQnKTsKKyAg ICAgICAgICAgICQoY2hlY2tib3gpLnRyaWdnZXIoJ2NoYW5nZScsICQodGhpcykpOworICAgICAg ICB9KTsKKyAgICB9KTsKKwogICAgICQudGFibGVzb3J0ZXIuYWRkUGFyc2VyKHsKICAgICAgICAg aWQ6ICdjb21wYXJpc29uJywKICAgICAgICAgaXM6IGZ1bmN0aW9uKHMpIHsKQEAgLTUyMyw4ICs1 MTEsNTMgQEAgZnVuY3Rpb24gaW5pdCgpIHsKICAgICB9KTsKIH0KIAotaW5pdCgpOworKGZ1bmN0 aW9uICgpIHsKKyAgICB2YXIgalF1ZXJ5ID0gWydQZXJmb3JtYW5jZVRlc3RzL0Ryb21hZW8vcmVz b3VyY2VzL2Ryb21hZW8vd2ViL2xpYi9qcXVlcnktMS42LjQuanMnXTsKKyAgICB2YXIgcGx1Z2lu cyA9IFsnUGVyZm9ybWFuY2VUZXN0cy9yZXNvdXJjZXMvanF1ZXJ5LmZsb3QubWluLmpzJywgJ1Bl cmZvcm1hbmNlVGVzdHMvcmVzb3VyY2VzL2pxdWVyeS50YWJsZXNvcnRlci5taW4uanMnXTsKKwor ICAgIGZ1bmN0aW9uIGxvYWRTY3JpcHQoc3JjLCBsb2FkZWQsIGZhaWxlZCkgeworICAgICAgICB2 YXIgc2NyaXB0ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgnc2NyaXB0Jyk7CisgICAgICAgIHNj cmlwdC5hc3luYyA9IHRydWU7CisgICAgICAgIHNjcmlwdC5zcmMgPSBzcmM7CisgICAgICAgIHNj cmlwdC5vbmxvYWQgPSBsb2FkZWQ7CisgICAgICAgIGlmIChmYWlsZWQpCisgICAgICAgICAgICBz Y3JpcHQub25lcnJvciA9IGZhaWxlZDsKKyAgICAgICAgZG9jdW1lbnQuYm9keS5hcHBlbmRDaGls ZChzY3JpcHQpOworICAgIH0KKworICAgIGZ1bmN0aW9uIGxvYWRQbHVnaW5zKHByZWZpeCkgewor ICAgICAgICB2YXIgbnVtYmVyT2ZMb2FkZWRQbHVnaW5zID0gMDsKKworICAgICAgICBmb3IgKHZh ciBpID0gMDsgaSA8IHBsdWdpbnMubGVuZ3RoOyBpKyspIHsKKyAgICAgICAgICAgIGxvYWRTY3Jp cHQocHJlZml4ICsgJy8nICsgcGx1Z2luc1tpXSwgZnVuY3Rpb24gKCkgeworICAgICAgICAgICAg ICAgIG51bWJlck9mTG9hZGVkUGx1Z2lucysrOworICAgICAgICAgICAgICAgIGlmIChudW1iZXJP ZkxvYWRlZFBsdWdpbnMgPT0gcGx1Z2lucy5sZW5ndGgpCisgICAgICAgICAgICAgICAgICAgIGlu aXQoKTsKKyAgICAgICAgICAgIH0sIChmdW5jdGlvbiAocGx1Z2luKSB7CisgICAgICAgICAgICAg ICAgcmV0dXJuIGZ1bmN0aW9uICgpIHsgYWxlcnQoIkZhaWxlZCB0byBsb2FkICIgKyBwbHVnaW4p OyB9CisgICAgICAgICAgICB9KShwcmVmaXhlc1tpXSkpOworICAgICAgICB9CisgICAgfQorCisg ICAgdmFyIHByZWZpeGVzID0gWyclQWJzb2x1dGVQYXRoVG9XZWJLaXRUcnVuayUnLCAnaHR0cHM6 Ly9zdm4ud2Via2l0Lm9yZy9yZXBvc2l0b3J5L3dlYmtpdC90cnVuayddOworICAgIHZhciBudW1i ZXJPZkZhaWx1cmVzID0gMDsKKyAgICB2YXIgc3RhcnRlZExvYWRpbmdQbHVnaW5zID0gZmFsc2U7 CisgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBwcmVmaXhlcy5sZW5ndGg7IGkrKykgeworICAgICAg ICBsb2FkU2NyaXB0KHByZWZpeGVzW2ldICsgJy8nICsgalF1ZXJ5LCAoZnVuY3Rpb24gKHByZWZp eCkgeworICAgICAgICAgICAgcmV0dXJuIGZ1bmN0aW9uICgpIHsKKyAgICAgICAgICAgICAgICBp ZiAoIXN0YXJ0ZWRMb2FkaW5nUGx1Z2lucykKKyAgICAgICAgICAgICAgICAgICAgbG9hZFBsdWdp bnMocHJlZml4KTsKKyAgICAgICAgICAgICAgICBzdGFydGVkTG9hZGluZ1BsdWdpbnMgPSB0cnVl OyAgICAgICAgICAgICAgICAKKyAgICAgICAgICAgIH0KKyAgICAgICAgfSkocHJlZml4ZXNbaV0p LCBmdW5jdGlvbiAoKSB7CisgICAgICAgICAgICBudW1iZXJPZkZhaWx1cmVzKys7CisgICAgICAg ICAgICBpZiAobnVtYmVyT2ZGYWlsdXJlcyA9PSBwcmVmaXhlcy5sZW5ndGgpCisgICAgICAgICAg ICAgICAgYWxlcnQoIkZhaWxlZCB0byBsb2FkIGpRdWVyeS4iKTsKKyAgICAgICAgfSk7CisgICAg fQorfSkoKTsKIAogPC9zY3JpcHQ+Cis8c2NyaXB0IGlkPSJqc29uIiB0eXBlPSJhcHBsaWNhdGlv bi9qc29uIj4lUGVmb3JtYW5jZVRlc3RzUmVzdWx0c0pTT04lPC9zY3JpcHQ+CiA8L2JvZHk+CiA8 L2h0bWw+Cg==