98557 2012-10-05 14:32:08 -0700 Add a "non-zero" flag for CSSParser::validUnit() 2022-08-02 13:28:33 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED CONFIGURATION CHANGED P2 Normal --- 65159 1 tabatkins tabatkins bfulgham cmarcelo macpherson menard webkit.review.bot oldest_to_newest 735961 0 tabatkins 2012-10-05 14:32:08 -0700 CSSParser::validUnit() can currently take a "non-negative" flag, but some properties further need to be strictly positive. For example, "column-count" only accepts integers > 0, but currently we accept "0" as a valid value (see bug 65159). This patch adds a non-zero flag to the flag enum that validUnit() uses, so this can be easily checked. 735978 1 167384 tabatkins 2012-10-05 14:43:40 -0700 Created attachment 167384 Patch 736167 2 167435 tabatkins 2012-10-05 19:11:37 -0700 Created attachment 167435 Patch 736168 3 tabatkins 2012-10-05 19:13:49 -0700 Whoops, sorry for the noise. This patch is identical to the previous. I hadn't refreshed the bug page since before I uploaded the first patch, so I didn't realize it was already committed. :/ Anyway, r+ and cq+ please. ^_^ 736879 4 167435 eric 2012-10-08 11:52:11 -0700 Comment on attachment 167435 Patch It seems like for such a simple change we might want to just roll this into bug 65159. I also probably would have called this FPositive since non-zero could be negative, no? 736914 5 tabatkins 2012-10-08 12:11:15 -0700 Okay, I wasn't sure what the protocol was for this kind of thing. I went with NonZero rather than Positive because it might be useful to have non-zero behavior specifically. However, I don't know of any case where that's true, so I might as well just rename it and shorten its usage. Okay, so I'll fold this into bug 65159. 736948 6 167435 tabatkins 2012-10-08 12:56:32 -0700 Comment on attachment 167435 Patch Turning off cq? to see if this gets submitted as part of bug 65159 instead. If so, I'll just cancel this bug out entirely. 1888482 7 167435 bfulgham 2022-08-02 13:28:27 -0700 Comment on attachment 167435 Patch This code is no longer relevant. 167384 2012-10-05 14:43:40 -0700 2012-10-05 19:11:35 -0700 Patch bug-98557-20121005144247.patch text/plain 2216 tabatkins U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwNTUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTYxODExMDFlY2UwNmVj YWZiNGRiZWZkYTQ2N2UzNzhmODg5YjAwZi4uODg2YzA1MWNkYWU5MDAzMjg5YWRjZGFjNTY4NTQx MzhmMDVkM2QxYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTEwLTA1ICBUYWIg QXRraW5zICA8amFja2FsbWFnZUBnbWFpbC5jb20+CisKKyAgICAgICAgQWRkIGEgIm5vbi16ZXJv IiBmbGFnIGZvciBDU1NQYXJzZXI6OnZhbGlkVW5pdCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05ODU1NworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIENTU1BhcnNlcjo6dmFsaWRVbml0KCkgY2FuIGN1cnJl bnRseSB0YWtlIGEgIm5vbi1uZWdhdGl2ZSIgZmxhZywgYnV0IHNvbWUgcHJvcGVydGllcyBmdXJ0 aGVyIG5lZWQgdG8gYmUgc3RyaWN0bHkgcG9zaXRpdmUuICBGb3IgZXhhbXBsZSwgImNvbHVtbi1j b3VudCIgb25seSBhY2NlcHRzIGludGVnZXJzID4gMCwgYnV0IGN1cnJlbnRseSB3ZSBhY2NlcHQg IjAiIGFzIGEgdmFsaWQgdmFsdWUgKHNlZSBidWcgNjUxNTkpLgorICAgICAgICBUaGlzIHBhdGNo IGFkZHMgYSBub24temVybyBmbGFnIHRvIHRoZSBmbGFnIGVudW0gdGhhdCB2YWxpZFVuaXQoKSB1 c2VzLCBzbyB0aGlzIGNhbiBiZSBlYXNpbHkgY2hlY2tlZC4KKworICAgICAgICBObyB0ZXN0cyB5 ZXQgKG5vIHdlYi1mYWNpbmcgYmVoYXZpb3IgY2hhbmdlKSwgYnV0IHdoZW4gYnVnIDY1MTU5IGlz IGZpeGVkIGl0J2xsIGdhaW4gc29tZSB0ZXN0cyBvZiB0aGlzIGZ1bmN0aW9uYWxpdHkuCisKKyAg ICAgICAgKiBjc3MvQ1NTUGFyc2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU1BhcnNlcjo6 dmFsaWRVbml0KToKKyAgICAgICAgKiBjc3MvQ1NTUGFyc2VyLmg6CisKIDIwMTItMTAtMDUgIE9q YW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBEZXByZWNhdGVkIGZsZXhi b3hlcyBzdWJ0cmFjdCBzY3JvbGxiYXIgd2lkdGgvaGVpZ2h0IHR3aWNlCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQ YXJzZXIuY3BwCmluZGV4IGQzNTRjNGRhMDQzMWJkMWZlNjY3NjM5YjM3MjExNzk3M2YwMzhlZjAu LjliNDVlNjIzMmVkOTNhYjljZmZmN2YxM2E5NDI5ZmUyYzdiMjhmYWEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9D U1NQYXJzZXIuY3BwCkBAIC0xNTY2LDYgKzE1NjYsOCBAQCBib29sIENTU1BhcnNlcjo6dmFsaWRV bml0KENTU1BhcnNlclZhbHVlKiB2YWx1ZSwgVW5pdHMgdW5pdGZsYWdzLCBDU1NQYXJzZXJNb2Rl CiAgICAgfQogICAgIGlmIChiICYmIHVuaXRmbGFncyAmIEZOb25OZWcgJiYgdmFsdWUtPmZWYWx1 ZSA8IDApCiAgICAgICAgIGIgPSBmYWxzZTsKKyAgICBpZiAoYiAmJiB1bml0ZmxhZ3MgJiBGTm9u WmVybyAmJiAhdmFsdWUtPmZWYWx1ZSkKKyAgICAgICAgYiA9IGZhbHNlOwogICAgIHJldHVybiBi OwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmggYi9Tb3Vy Y2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmgKaW5kZXggZDgwNGY3ZTQ1OTVmOGI3ZWZmYWE3MWM0 ODhlYjdlZDgyNzg0ZjQwNC4uN2U2ZDZkYzMzMzM3NTAxOWNmMDc4YmE5NTgzYmJkNTg1YWJlMTc1 NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuaApAQCAtNTM5LDcgKzUzOSw4IEBAIHByaXZhdGU6CiAj aWYgRU5BQkxFKENTU19JTUFHRV9SRVNPTFVUSU9OKQogICAgICAgICBGUmVzb2x1dGlvbj0gMHgw MjAwLAogI2VuZGlmCi0gICAgICAgIEZOb25OZWcgICAgPSAweDA0MDAKKyAgICAgICAgRk5vbk5l ZyAgICA9IDB4MDQwMCwKKyAgICAgICAgRk5vblplcm8gICA9IDB4MDgwMAogICAgIH07CiAKICAg ICBmcmllbmQgaW5saW5lIFVuaXRzIG9wZXJhdG9yfChVbml0cyBhLCBVbml0cyBiKQo= 167435 2012-10-05 19:11:37 -0700 2022-08-02 13:28:27 -0700 Patch bug-98557-20121005191045.patch text/plain 2152 tabatkins U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwNTczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDIwZTFkNjdiZDQ0MDZm NjU1ZWQ4NDkxMzg3YzlkMzFlOWUzNmYzOS4uYjcwYWQ4YmE2ZDViYmQwNzhhOGM4N2E5NDZlZDQx YzFjZGYwZDM4NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTEwLTA1ICBUYWIg QXRraW5zICA8amFja2FsbWFnZUBnbWFpbC5jb20+CisKKyAgICAgICAgQWRkIGEgIm5vbi16ZXJv IiBmbGFnIGZvciBDU1NQYXJzZXI6OnZhbGlkVW5pdCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05ODU1NworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0Y2ggYWRkcyBhICJub24temVybyIgZmxh ZyB0byB0aGUgZW51bSB1c2VkIGJ5IENTU1BhcnNlcjo6dmFsaWRVbml0KCkgdG8gdmFsaWRhdGUg dmFsdWVzLgorICAgICAgICBTb21lIHByb3BlcnRpZXMsIHN1Y2ggYXMgJ2NvbHVtbi1jb3VudCcs IG5lZWQgdG8gYmUgPj0gMSwgYW5kIHRoZSBleGlzdGluZyAibm9uLW5lZ2F0aXZlIiBmbGFnIGRv ZXNuJ3QgY3V0IGl0LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyB5ZXQsIGFzIHRoaXMgaXMgYW4g aW50ZXJuYWwgY2hhbmdlIG5vdCBkZXRlY3RhYmxlIGZyb20gb3V0c2lkZSwgYnV0IGJ1ZyA2NTE1 OSB3aWxsIHVzZSB0aGlzIGNoYW5nZSBhbmQgd2lsbCBlbmQgdXAgdGVzdGluZyBpdC4KKworICAg ICAgICAqIGNzcy9DU1NQYXJzZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUGFyc2VyOjp2 YWxpZFVuaXQpOgorICAgICAgICAqIGNzcy9DU1NQYXJzZXIuaDoKKwogMjAxMi0xMC0wNSAgSHVh bmcgRG9uZ3N1bmcgIDxsdXh0ZWxsYUBjb21wYW55MTAwLm5ldD4KIAogICAgICAgICBbbWFjXSBS RUdSRVNTSU9OIChyMTIyMjE1KTogQW5pbWF0ZWQgR0lGIG91dHNpZGUgdGhlIHZpZXdwb3J0IGRv ZXNuJ3QgcGxheSB3aGVuIHNjcm9sbGVkIGludG8gdmlldy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5j cHAKaW5kZXggZDM1NGM0ZGEwNDMxYmQxZmU2Njc2MzliMzcyMTE3OTczZjAzOGVmMC4uOWI0NWU2 MjMyZWQ5M2FiOWNmZmY3ZjEzYTk0MjlmZTJjN2IyOGZhYSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNl ci5jcHAKQEAgLTE1NjYsNiArMTU2Niw4IEBAIGJvb2wgQ1NTUGFyc2VyOjp2YWxpZFVuaXQoQ1NT UGFyc2VyVmFsdWUqIHZhbHVlLCBVbml0cyB1bml0ZmxhZ3MsIENTU1BhcnNlck1vZGUKICAgICB9 CiAgICAgaWYgKGIgJiYgdW5pdGZsYWdzICYgRk5vbk5lZyAmJiB2YWx1ZS0+ZlZhbHVlIDwgMCkK ICAgICAgICAgYiA9IGZhbHNlOworICAgIGlmIChiICYmIHVuaXRmbGFncyAmIEZOb25aZXJvICYm ICF2YWx1ZS0+ZlZhbHVlKQorICAgICAgICBiID0gZmFsc2U7CiAgICAgcmV0dXJuIGI7CiB9CiAK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuaCBiL1NvdXJjZS9XZWJD b3JlL2Nzcy9DU1NQYXJzZXIuaAppbmRleCBkODA0ZjdlNDU5NWY4YjdlZmZhYTcxYzQ4OGViN2Vk ODI3ODRmNDA0Li43ZTZkNmRjMzMzMzc1MDE5Y2YwNzhiYTk1ODNiYmQ1ODVhYmUxNzU0IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmgKKysrIGIvU291cmNlL1dlYkNv cmUvY3NzL0NTU1BhcnNlci5oCkBAIC01MzksNyArNTM5LDggQEAgcHJpdmF0ZToKICNpZiBFTkFC TEUoQ1NTX0lNQUdFX1JFU09MVVRJT04pCiAgICAgICAgIEZSZXNvbHV0aW9uPSAweDAyMDAsCiAj ZW5kaWYKLSAgICAgICAgRk5vbk5lZyAgICA9IDB4MDQwMAorICAgICAgICBGTm9uTmVnICAgID0g MHgwNDAwLAorICAgICAgICBGTm9uWmVybyAgID0gMHgwODAwCiAgICAgfTsKIAogICAgIGZyaWVu ZCBpbmxpbmUgVW5pdHMgb3BlcmF0b3J8KFVuaXRzIGEsIFVuaXRzIGIpCg==