98533 2012-10-05 10:30:50 -0700 [BlackBerry] proxy auth regressed 2012-10-05 11:50:04 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Other Unspecified RESOLVED FIXED P2 Normal --- 1 joenotcharles joenotcharles mifenton rwlbuis webkit.review.bot oldest_to_newest 735741 0 joenotcharles 2012-10-05 10:30:50 -0700 After entering a password in the proxy auth dialog, we aren't actually sending that password to the server. 735746 1 167346 joenotcharles 2012-10-05 10:36:37 -0700 Created attachment 167346 fix 735779 2 167355 joenotcharles 2012-10-05 11:06:44 -0700 Created attachment 167355 revised fix 735787 3 167355 yong.li.webkit 2012-10-05 11:09:52 -0700 Comment on attachment 167355 revised fix assume proxyAddress() never return a null string? 735838 4 167355 webkit.review.bot 2012-10-05 11:50:01 -0700 Comment on attachment 167355 revised fix Clearing flags on attachment: 167355 Committed r130537: <http://trac.webkit.org/changeset/130537> 735839 5 webkit.review.bot 2012-10-05 11:50:04 -0700 All reviewed patches have been landed. Closing bug. 167346 2012-10-05 10:36:37 -0700 2012-10-05 11:06:44 -0700 fix 0001-BlackBerry-Fix-regression-in-proxy-auth.patch text/plain 2952 joenotcharles RnJvbSA0NTQyYWMzODBhMzA0NjkxZTEyMzczNGNhY2U2MzJiNmRmYmI0OTc3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb2UgTWFzb24gPGptYXNvbkByaW0uY29tPgpEYXRlOiBGcmks IDUgT2N0IDIwMTIgMTM6MzQ6NTQgLTA0MDAKU3ViamVjdDogW1BBVENIXSBbQmxhY2tCZXJyeV0g Rml4IHJlZ3Jlc3Npb24gaW4gcHJveHkgYXV0aAogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTk4NTMzCgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KClRoZSBwcm94 eSBhdXRoIGRpYWxvZyBnZXRzIHRoZSBwcm94eSBhZGRyZXNzIGZyb20KQmxhY2tCZXJyeTo6UGxh dGZvcm06OlNldHRpbmdzOjpwcm94eUFkZHJlc3MsIHdoaWNoIHJldHVybnMKImhvc3Q6cG9ydCIs IGJ1dCB3ZSB0cnkgdG8gcGFyc2UgaXQgd2l0aCBhIEtVUkwsIHdoaWNoIGV4cGVjdHMKInNjaGVt ZTovL2hvc3Q6cG9ydCIuICBTaW5jZSB0aGlzIGlzIGFuIGh0dHAgcHJveHksIGFkZCBodHRwOi8v IHRvIHRoZQp1cmwgdG8gZ2V0IGl0IHRvIHBhcnNlLgoKUFIgMjIwNTY3LgoKKiBwbGF0Zm9ybS9u ZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya0pvYi5jcHA6CihXZWJDb3JlOjpOZXR3b3JrSm9iOjpz ZW5kUmVxdWVzdFdpdGhDcmVkZW50aWFscyk6Ci0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n ICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDE4ICsrKysrKysrKysrKysrKysrKwogLi4u L3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9iLmNwcCAgICAgfCAgICA2ICsr KysrLQogMiBmaWxlcyBjaGFuZ2VkLCAyMyBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9ucygtKQoK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5M2RmZjQ3Li5hODc2ZTdkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTItMTAtMDUgIEpvZSBNYXNvbiAgPGptYXNvbkByaW0uY29tPgorCisgICAgICAgIFtC bGFja0JlcnJ5XSBGaXggcmVncmVzc2lvbiBpbiBwcm94eSBhdXRoCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05ODUzMworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBwcm94eSBhdXRoIGRpYWxvZyBnZXRz IHRoZSBwcm94eSBhZGRyZXNzIGZyb20KKyAgICAgICAgQmxhY2tCZXJyeTo6UGxhdGZvcm06OlNl dHRpbmdzOjpwcm94eUFkZHJlc3MsIHdoaWNoIHJldHVybnMKKyAgICAgICAgImhvc3Q6cG9ydCIs IGJ1dCB3ZSB0cnkgdG8gcGFyc2UgaXQgd2l0aCBhIEtVUkwsIHdoaWNoIGV4cGVjdHMKKyAgICAg ICAgInNjaGVtZTovL2hvc3Q6cG9ydCIuICBTaW5jZSB0aGlzIGlzIGFuIGh0dHAgcHJveHksIGFk ZCBodHRwOi8vIHRvIHRoZQorICAgICAgICB1cmwgdG8gZ2V0IGl0IHRvIHBhcnNlLgorCisgICAg ICAgIFBSIDIyMDU2Ny4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9O ZXR3b3JrSm9iLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok5ldHdvcmtKb2I6OnNlbmRSZXF1ZXN0 V2l0aENyZWRlbnRpYWxzKToKKwogMjAxMi0xMC0wMiAgQXJ2aWQgTmlsc3NvbiAgPGFuaWxzc29u QHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIEltcHJvdmUgY2hlY2tlcmJvYXJkIHN0 eWxpbmcgZm9yIExheWVyVGlsZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9iLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9iLmNwcAppbmRleCAyZGRkZjM4Li4zNTgz MTA1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVy cnkvTmV0d29ya0pvYi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9i bGFja2JlcnJ5L05ldHdvcmtKb2IuY3BwCkBAIC03MTUsNyArNzE1LDExIEBAIGJvb2wgTmV0d29y a0pvYjo6c2VuZFJlcXVlc3RXaXRoQ3JlZGVudGlhbHMoUHJvdGVjdGlvblNwYWNlU2VydmVyVHlw ZSB0eXBlLCBQcm90CiAgICAgU3RyaW5nIGhvc3Q7CiAgICAgaW50IHBvcnQ7CiAgICAgaWYgKHR5 cGUgPT0gUHJvdGVjdGlvblNwYWNlUHJveHlIVFRQKSB7Ci0gICAgICAgIFN0cmluZyBwcm94eUFk ZHJlc3MgPSBTdHJpbmcoQmxhY2tCZXJyeTo6UGxhdGZvcm06OlNldHRpbmdzOjppbnN0YW5jZSgp LT5wcm94eUFkZHJlc3MobmV3VVJMLnN0cmluZygpLmFzY2lpKCkuZGF0YSgpKS5jX3N0cigpKTsK KyAgICAgICAgLy8gcHJveHlBZGRyZXNzIHJldHVybnMgaG9zdDpwb3J0LCB3aXRob3V0IGEgcHJv dG9jb2wuIEtVUkwgY2FuJ3QgcGFyc2UgdGhpcywgc28gc3RpY2sgaHR0cAorICAgICAgICAvLyBv biB0aGUgZnJvbnQuCisgICAgICAgIC8vIChXZSBjb3VsZCBzcGxpdCBpbnRvIGhvc3QgYW5kIHBv cnQgYnkgaGFuZCwgYnV0IHRoYXQgZ2V0cyBoYXJkIHRvIHBhcnNlIHdpdGggSVB2NiB1cmxzLAor ICAgICAgICAvLyBzbyBiZXR0ZXIgdG8gcmV1c2UgS1VSTCdzIHBhcnNpbmcuKQorICAgICAgICBT dHJpbmcgcHJveHlBZGRyZXNzID0gU3RyaW5nOjpmb3JtYXQoImh0dHA6Ly8lcyIsIEJsYWNrQmVy cnk6OlBsYXRmb3JtOjpTZXR0aW5nczo6aW5zdGFuY2UoKS0+cHJveHlBZGRyZXNzKG5ld1VSTC5z dHJpbmcoKS5hc2NpaSgpLmRhdGEoKSkuY19zdHIoKSk7CiAgICAgICAgIEtVUkwgcHJveHlVUkwo S1VSTCgpLCBwcm94eUFkZHJlc3MpOwogICAgICAgICBob3N0ID0gcHJveHlVUkwuaG9zdCgpOwog ICAgICAgICBwb3J0ID0gcHJveHlVUkwucG9ydCgpOwotLSAKMS43LjUuNAoK 167355 2012-10-05 11:06:44 -0700 2012-10-05 11:50:01 -0700 revised fix 0001-BlackBerry-Fix-regression-in-proxy-auth.patch text/plain 2943 joenotcharles RnJvbSA2ZjU4Y2I5ODVmYmZkNTM5MzBkYjI0ZjQxN2RiYzFkMzMwYmMzNWEwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb2UgTWFzb24gPGptYXNvbkByaW0uY29tPgpEYXRlOiBGcmks IDUgT2N0IDIwMTIgMTM6MzQ6NTQgLTA0MDAKU3ViamVjdDogW1BBVENIXSBbQmxhY2tCZXJyeV0g Rml4IHJlZ3Jlc3Npb24gaW4gcHJveHkgYXV0aAogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTk4NTMzCgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KClRoZSBwcm94 eSBhdXRoIGRpYWxvZyBnZXRzIHRoZSBwcm94eSBhZGRyZXNzIGZyb20KQmxhY2tCZXJyeTo6UGxh dGZvcm06OlNldHRpbmdzOjpwcm94eUFkZHJlc3MsIHdoaWNoIHJldHVybnMKImhvc3Q6cG9ydCIs IGJ1dCB3ZSB0cnkgdG8gcGFyc2UgaXQgd2l0aCBhIEtVUkwsIHdoaWNoIGV4cGVjdHMKInNjaGVt ZTovL2hvc3Q6cG9ydCIuICBTaW5jZSB0aGlzIGlzIGFuIGh0dHAgcHJveHksIGFkZCBodHRwOi8v IHRvIHRoZQp1cmwgdG8gZ2V0IGl0IHRvIHBhcnNlLgoKUFIgMjIwNTY3LgoKKiBwbGF0Zm9ybS9u ZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya0pvYi5jcHA6CihXZWJDb3JlOjpOZXR3b3JrSm9iOjpz ZW5kUmVxdWVzdFdpdGhDcmVkZW50aWFscyk6Ci0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n ICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDE4ICsrKysrKysrKysrKysrKysrKwogLi4u L3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9iLmNwcCAgICAgfCAgICA2ICsr KysrLQogMiBmaWxlcyBjaGFuZ2VkLCAyMyBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9ucygtKQoK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5M2RmZjQ3Li5hODc2ZTdkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTItMTAtMDUgIEpvZSBNYXNvbiAgPGptYXNvbkByaW0uY29tPgorCisgICAgICAgIFtC bGFja0JlcnJ5XSBGaXggcmVncmVzc2lvbiBpbiBwcm94eSBhdXRoCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05ODUzMworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBwcm94eSBhdXRoIGRpYWxvZyBnZXRz IHRoZSBwcm94eSBhZGRyZXNzIGZyb20KKyAgICAgICAgQmxhY2tCZXJyeTo6UGxhdGZvcm06OlNl dHRpbmdzOjpwcm94eUFkZHJlc3MsIHdoaWNoIHJldHVybnMKKyAgICAgICAgImhvc3Q6cG9ydCIs IGJ1dCB3ZSB0cnkgdG8gcGFyc2UgaXQgd2l0aCBhIEtVUkwsIHdoaWNoIGV4cGVjdHMKKyAgICAg ICAgInNjaGVtZTovL2hvc3Q6cG9ydCIuICBTaW5jZSB0aGlzIGlzIGFuIGh0dHAgcHJveHksIGFk ZCBodHRwOi8vIHRvIHRoZQorICAgICAgICB1cmwgdG8gZ2V0IGl0IHRvIHBhcnNlLgorCisgICAg ICAgIFBSIDIyMDU2Ny4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9O ZXR3b3JrSm9iLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok5ldHdvcmtKb2I6OnNlbmRSZXF1ZXN0 V2l0aENyZWRlbnRpYWxzKToKKwogMjAxMi0xMC0wMiAgQXJ2aWQgTmlsc3NvbiAgPGFuaWxzc29u QHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIEltcHJvdmUgY2hlY2tlcmJvYXJkIHN0 eWxpbmcgZm9yIExheWVyVGlsZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9iLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9iLmNwcAppbmRleCAyZGRkZjM4Li41NjA1 ODhhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVy cnkvTmV0d29ya0pvYi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9i bGFja2JlcnJ5L05ldHdvcmtKb2IuY3BwCkBAIC03MTUsNyArNzE1LDExIEBAIGJvb2wgTmV0d29y a0pvYjo6c2VuZFJlcXVlc3RXaXRoQ3JlZGVudGlhbHMoUHJvdGVjdGlvblNwYWNlU2VydmVyVHlw ZSB0eXBlLCBQcm90CiAgICAgU3RyaW5nIGhvc3Q7CiAgICAgaW50IHBvcnQ7CiAgICAgaWYgKHR5 cGUgPT0gUHJvdGVjdGlvblNwYWNlUHJveHlIVFRQKSB7Ci0gICAgICAgIFN0cmluZyBwcm94eUFk ZHJlc3MgPSBTdHJpbmcoQmxhY2tCZXJyeTo6UGxhdGZvcm06OlNldHRpbmdzOjppbnN0YW5jZSgp LT5wcm94eUFkZHJlc3MobmV3VVJMLnN0cmluZygpLmFzY2lpKCkuZGF0YSgpKS5jX3N0cigpKTsK KyAgICAgICAgLy8gcHJveHlBZGRyZXNzIHJldHVybnMgaG9zdDpwb3J0LCB3aXRob3V0IGEgcHJv dG9jb2wuIEtVUkwgY2FuJ3QgcGFyc2UgdGhpcywgc28gc3RpY2sgaHR0cAorICAgICAgICAvLyBv biB0aGUgZnJvbnQuCisgICAgICAgIC8vIChXZSBjb3VsZCBzcGxpdCBpbnRvIGhvc3QgYW5kIHBv cnQgYnkgaGFuZCwgYnV0IHRoYXQgZ2V0cyBoYXJkIHRvIHBhcnNlIHdpdGggSVB2NiB1cmxzLAor ICAgICAgICAvLyBzbyBiZXR0ZXIgdG8gcmV1c2UgS1VSTCdzIHBhcnNpbmcuKQorICAgICAgICBT dHJpbmcgcHJveHlBZGRyZXNzID0gU3RyaW5nKCJodHRwOi8vIikgKyBCbGFja0JlcnJ5OjpQbGF0 Zm9ybTo6U2V0dGluZ3M6Omluc3RhbmNlKCktPnByb3h5QWRkcmVzcyhuZXdVUkwuc3RyaW5nKCku YXNjaWkoKS5kYXRhKCkpLmNfc3RyKCk7CiAgICAgICAgIEtVUkwgcHJveHlVUkwoS1VSTCgpLCBw cm94eUFkZHJlc3MpOwogICAgICAgICBob3N0ID0gcHJveHlVUkwuaG9zdCgpOwogICAgICAgICBw b3J0ID0gcHJveHlVUkwucG9ydCgpOwotLSAKMS43LjUuNAoK