<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>98526</bug_id>
          
          <creation_ts>2012-10-05 08:53:10 -0700</creation_ts>
          <short_desc>[chromium] Only define SK_SUPPORT_HINTING_SCALE_FACTOR when building for chromeOS</short_desc>
          <delta_ts>2012-10-10 15:45:17 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Platform</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>98166</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Terry Anderson">tdanderson</reporter>
          <assigned_to name="Terry Anderson">tdanderson</assigned_to>
          <cc>behdad</cc>
    
    <cc>rbyers</cc>
    
    <cc>reed</cc>
    
    <cc>senorblanco</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>735666</commentid>
    <comment_count>0</comment_count>
    <who name="Terry Anderson">tdanderson</who>
    <bug_when>2012-10-05 08:53:10 -0700</bug_when>
    <thetext>This is causing some problems with picture serialization between chrome and the mainline skia tools. (Once this change lands and is gardened in, I will make the corresponding change in chromium/skia/skia.gyp)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>735667</commentid>
    <comment_count>1</comment_count>
      <attachid>167333</attachid>
    <who name="Terry Anderson">tdanderson</who>
    <bug_when>2012-10-05 08:54:24 -0700</bug_when>
    <thetext>Created attachment 167333
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>735680</commentid>
    <comment_count>2</comment_count>
    <who name="Mike Reed">reed</who>
    <bug_when>2012-10-05 09:12:19 -0700</bug_when>
    <thetext>does this also require a similar change to chrome/src/skia/skia.gyp, or is this CL sufficient?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>735681</commentid>
    <comment_count>3</comment_count>
    <who name="Mike Reed">reed</who>
    <bug_when>2012-10-05 09:12:33 -0700</bug_when>
    <thetext>doh, I didn&apos;t read the first comment. sorry :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>735896</commentid>
    <comment_count>4</comment_count>
      <attachid>167333</attachid>
    <who name="Stephen White">senorblanco</who>
    <bug_when>2012-10-05 12:57:57 -0700</bug_when>
    <thetext>Comment on attachment 167333
Patch

OK.  r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>736011</commentid>
    <comment_count>5</comment_count>
      <attachid>167333</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-10-05 15:05:46 -0700</bug_when>
    <thetext>Comment on attachment 167333
Patch

Clearing flags on attachment: 167333

Committed r130558: &lt;http://trac.webkit.org/changeset/130558&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>736012</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-10-05 15:05:50 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>167333</attachid>
            <date>2012-10-05 08:54:24 -0700</date>
            <delta_ts>2012-10-05 15:05:46 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-98526-20121005115332.patch</filename>
            <type>text/plain</type>
            <size>1706</size>
            <attacher name="Terry Anderson">tdanderson</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwNTA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No
cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4
IGRiYThkN2MyNzY0NWE1ZjQ3Y2NlMDI2N2NhMmIwZWRmMTEwMmU2ODQuLjZhZjNmMzg5YzU1OTQ4
MWY3YzA0ODkzMzVmZjhlYmZjZmMzMGVhOTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy
b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA
IC0xLDMgKzEsMTYgQEAKKzIwMTItMTAtMDUgIFRlcnJ5IEFuZGVyc29uICA8dGRhbmRlcnNvbkBj
aHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBPbmx5IGRlZmluZSBTS19TVVBQT1JU
X0hJTlRJTkdfU0NBTEVfRkFDVE9SIHdoZW4gYnVpbGRpbmcgZm9yIGNocm9tZU9TCisgICAgICAg
IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05ODUyNgorCisgICAgICAg
IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgaXMgY2F1c2luZyBz
b21lIHByb2JsZW1zIHdpdGggcGljdHVyZSBzZXJpYWxpemF0aW9uIGJldHdlZW4gY2hyb21lIAor
ICAgICAgICBhbmQgdGhlIG1haW5saW5lIHNraWEgdG9vbHMuIChPbmNlIHRoaXMgY2hhbmdlIGxh
bmRzIGFuZCBpcyBnYXJkZW5lZCBpbiwgCisgICAgICAgIEkgd2lsbCBtYWtlIHRoZSBjb3JyZXNw
b25kaW5nIGNoYW5nZSBpbiBjaHJvbWl1bS9za2lhL3NraWEuZ3lwKQorCisgICAgICAgICogZmVh
dHVyZXMuZ3lwaToKKwogMjAxMi0xMC0wNSAgU2FkcnVsIEhhYmliIENob3dkaHVyeSAgPHNhZHJ1
bEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBBbGxvdyBkcmFnZ2luZyBpbnRv
IHBsdWdpbnMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL2ZlYXR1cmVzLmd5
cGkgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL2ZlYXR1cmVzLmd5cGkKaW5kZXggN2FlYmU1ZTc1
OTAzZDViN2UzYzQxOTc3NTg3YTk4ZjJlMzQ3NzRiOS4uNzBlMzBhOGZiYjQ3M2U4NDFkYjBjMTZl
YjkwNTExOGQyOTU5OTNhMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9mZWF0
dXJlcy5neXBpCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vZmVhdHVyZXMuZ3lwaQpAQCAt
MTE5LDcgKzExOSw2IEBACiAgICAgICAnRU5BQkxFX1dPUktFUlM9MScsCiAgICAgICAnRU5BQkxF
X1hIUl9SRVNQT05TRV9CTE9CPTEnLAogICAgICAgJ0VOQUJMRV9YU0xUPTEnLAotICAgICAgJ1NL
X1NVUFBPUlRfSElOVElOR19TQ0FMRV9GQUNUT1InLAogICAgICAgJ1dURl9VU0VfTEVWRUxEQj0x
JywKICAgICAgICdXVEZfVVNFX0JVSUxUSU5fVVRGOF9DT0RFQz0xJywKICAgICAgICMgV1RGX1VT
RV9EWU5BTUlDX0FOTk9UQVRJT05TPTEgbWF5IGJlIGRlZmluZWQgaW4gYnVpbGQvY29tbW9uLmd5
cGkKQEAgLTIyOCw2ICsyMjcsMTEgQEAKICAgICAgICAgICAnV1RGX1VTRV9IQVJGQlVaWl9ORz0x
JywKICAgICAgICAgXSwKICAgICAgIH1dLAorICAgICAgWydjaHJvbWVvcz09MScsIHsKKyAgICAg
ICAgJ2ZlYXR1cmVfZGVmaW5lcyc6IFsKKyAgICAgICAgICAnU0tfU1VQUE9SVF9ISU5USU5HX1ND
QUxFX0ZBQ1RPUicsCisgICAgICAgIF0sCisgICAgICB9XSwKICAgICBdLAogICB9LAogfQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>