98522 2012-10-05 08:32:53 -0700 No autorelease pool in place, causing buildup of autoreleased objects. 2012-10-05 11:34:05 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jer.noble jer.noble ap ggaren mrowe oldest_to_newest 735657 0 jer.noble 2012-10-05 08:32:53 -0700 No autorelease pool in place, causing buildup of autoreleased objects. 735659 1 167332 jer.noble 2012-10-05 08:36:42 -0700 Created attachment 167332 Patch 735753 2 167332 ap 2012-10-05 10:42:34 -0700 Comment on attachment 167332 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167332&action=review > Source/WebCore/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=98522 If there is a Radar bug tracking this, please post its number to Bugzilla and to ChangeLog. > Source/WebCore/platform/cf/RunLoopTimerCF.cpp:49 > + AutodrainedPool pool; This won't break Windows build, will it? With a cursory look, I couldn't find a no-op implementation of this class that Windows could be using. 735757 3 ap 2012-10-05 10:45:23 -0700 My mistake - I was looking at a wrong AutodrainedPool.h. 735790 4 jer.noble 2012-10-05 11:14:58 -0700 (In reply to comment #2) > (From update of attachment 167332 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=167332&action=review > > > Source/WebCore/ChangeLog:4 > > + https://bugs.webkit.org/show_bug.cgi?id=98522 > > If there is a Radar bug tracking this, please post its number to Bugzilla and to ChangeLog. Sure thing. > > Source/WebCore/platform/cf/RunLoopTimerCF.cpp:49 > > + AutodrainedPool pool; > > This won't break Windows build, will it? With a cursory look, I couldn't find a no-op implementation of this class that Windows could be using. Yep, as I think you discovered in comment #3, there's a no-op implementation for non-ObjC CF-ports. 735791 5 jer.noble 2012-10-05 11:15:49 -0700 <rdar://problem/11647950> 735818 6 jer.noble 2012-10-05 11:34:05 -0700 Committed r130534: <http://trac.webkit.org/changeset/130534> 167332 2012-10-05 08:36:42 -0700 2012-10-05 10:42:34 -0700 Patch bug-98522-20121005083550.patch text/plain 1864 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwNDI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTY2NjY0Njk3YTIxODRk OGJlODEwYTQ1MjExYmMyZDFlODI3NDk3Ni4uMDc5YTQzNGZkNzYxYjMxMWU2NTgxOWVhZmFlNWZl YWMzZWQ1M2M3YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEwLTA1ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIE5vIGF1dG9yZWxlYXNlIHBv b2wgaW4gcGxhY2UsIGNhdXNpbmcgYnVpbGR1cCBvZiBhdXRvcmVsZWFzZWQgb2JqZWN0cy4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4NTIyCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV3JhcCBlYWNoIHRp bWVyIGNhbGxiYWNrIGluIGFuIEF1dG9kcmFpblBvb2wsIGVuc3VyaW5nIGFuIGF1dG9yZWxlYXNl CisgICAgICAgIHBvb2wgaXMgcHJlc2VudCBkdXJpbmcgY2FsbHMgZnJvbSBDL0MrKyBpbnRvIE9i akMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9jZi9SdW5Mb29wVGltZXJDRi5jcHA6CisgICAgICAg IChXZWJDb3JlOjp0aW1lckZpcmVkKToKKwogMjAxMi0xMC0wNCAgUHJhdmluIEQgIDxwcmF2aW5k LjJrNEBnbWFpbC5jb20+CiAKICAgICAgICAgTGF5b3V0IGJyb2tlbiBhZnRlciBjbG9uaW5nIGFu ZCByZS1pbnNlcnRpbmcgYSB0YWJsZSB3aXRoIGEgbWlzcGxhY2VkIDxmb3JtPgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2YvUnVuTG9vcFRpbWVyQ0YuY3BwIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vY2YvUnVuTG9vcFRpbWVyQ0YuY3BwCmluZGV4IGY2MjI5OWVkNjc3 M2M1Y2RhZjZiY2NlZTZkNDFiZjMzNDdkNjUzYTQuLjZiOGNjZTUyMGVkYThiZmQxMzIyYWM4Yjg1 ZWNmN2M3YWEwZTY0ZTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2NmL1J1 bkxvb3BUaW1lckNGLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jZi9SdW5Mb29w VGltZXJDRi5jcHAKQEAgLTMxLDYgKzMxLDcgQEAKICNpZiBQTEFURk9STShNQUMpICYmIEhBVkUo UlVOTE9PUF9USU1FUikKIAogI2luY2x1ZGUgIlJ1bkxvb3BUaW1lci5oIgorI2luY2x1ZGUgIkF1 dG9kcmFpbmVkUG9vbC5oIgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKQEAgLTQxLDYgKzQyLDEx IEBAIFJ1bkxvb3BUaW1lckJhc2U6On5SdW5Mb29wVGltZXJCYXNlKCkKIAogc3RhdGljIHZvaWQg dGltZXJGaXJlZChDRlJ1bkxvb3BUaW1lclJlZiwgdm9pZCogY29udGV4dCkKIHsKKyAgICAvLyBD RlJ1bkxvb3BUaW1lciBkb2VzIG5vdCBjcmVhdGUgYW4gTlNBdXRvcmVsZWFzZVBvb2wsIGxpa2Ug TlNUaW1lciBkb2VzLiBUaGlzIGNhbiBsZWFkIHRvCisgICAgLy8gYXV0b3JlbGVhc2VkIG9iamVj dHMgYmVpbmcgcHVzaGVkIGludG8gTlNBdXRvcmVsZWFzZVBvb2xzIHVuZGVybmVhdGggdGhlIHJ1 biBsb29wLCB3aGljaAorICAgIC8vIGFyZSB2ZXJ5IGluZnJlcXVlbnRseSBkcmFpbmVkLiBDcmVh dGUgYSBuZXcgYXV0b3JlbGVhc2UgcG9vbCBoZXJlIHRvIGdpdmUgYXV0b3JlbGVhc2VkIG9iamVj dHMKKyAgICAvLyBhIHBsYWNlIHRvIGNvbGxlY3QuCisgICAgQXV0b2RyYWluZWRQb29sIHBvb2w7 CiAgICAgUnVuTG9vcFRpbWVyQmFzZSogdGltZXIgPSBzdGF0aWNfY2FzdDxSdW5Mb29wVGltZXJC YXNlKj4oY29udGV4dCk7CiAgICAgdGltZXItPmZpcmVkKCk7CiB9Cg==