98520 2012-10-05 08:09:37 -0700 Web Inspector: Semantically incorrect CSS rules result in broken source code data 2012-10-10 03:50:16 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 98246 1 apavlov apavlov apavlov bweinstein cmarcelo joepeck keishi loislo macpherson menard pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 735640 0 apavlov 2012-10-05 08:09:37 -0700 For example, an @import rule following a style rule results in inability to edit all following style rules through the model. 735715 1 167338 apavlov 2012-10-05 09:37:04 -0700 Created attachment 167338 Patch 735721 2 167338 vsevik 2012-10-05 09:44:16 -0700 Comment on attachment 167338 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167338&action=review > Source/WebCore/css/CSSParser.cpp:10134 > + popRuleData(); Is this one tested? 735758 3 167338 apavlov 2012-10-05 10:49:23 -0700 Comment on attachment 167338 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167338&action=review >> Source/WebCore/css/CSSParser.cpp:10134 >> + popRuleData(); > > Is this one tested? The "if (pageSelector)" check is extraneous - the grammar guarantees that we never get a NULL pageSelector. I added the call for consistency. 738812 4 167338 webkit.review.bot 2012-10-10 03:50:12 -0700 Comment on attachment 167338 Patch Clearing flags on attachment: 167338 Committed r130883: <http://trac.webkit.org/changeset/130883> 738813 5 webkit.review.bot 2012-10-10 03:50:16 -0700 All reviewed patches have been landed. Closing bug. 167338 2012-10-05 09:37:04 -0700 2012-10-10 03:50:12 -0700 Patch bug-98520-20121005203611.patch text/plain 5313 apavlov U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwNTExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTBkYzFkYjBmYTQwZTZl ZWMxMWFkMjhmZGE2NjgzMGE1NjIwNzc1MC4uYzlkM2JmMDk4MzcwYzA2MWI3OTUxYzM4NTI2YWM1 MDQ2ZjRkYTc4NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDEyLTEwLTA1ICBBbGV4 YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgV2ViIEluc3Bl Y3RvcjogU2VtYW50aWNhbGx5IGluY29ycmVjdCBDU1MgcnVsZXMgcmVzdWx0IGluIGJyb2tlbiBz b3VyY2UgY29kZSBkYXRhCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD05ODUyMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFBvcCBhbmQgdGhyb3cgYXdheSBydWxlIGRhdGEgZnJvbSB0aGUgc3RhY2sgd2hlbiBk YXRhIGhhdmUgYmVlbiBjb2xsZWN0ZWQgZm9yIGEgc2VtYW50aWNhbGx5IGludmFsaWQgQ1NTIHJ1 bGUKKyAgICAgICAgKHdoaWNoIGlzIG5vdCBnb2luZyB0byBiZSBjcmVhdGVkKS4KKworICAgICAg ICAqIGNzcy9DU1NQYXJzZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUGFyc2VyOjpjcmVh dGVJbXBvcnRSdWxlKToKKyAgICAgICAgKFdlYkNvcmU6OkNTU1BhcnNlcjo6Y3JlYXRlRm9udEZh Y2VSdWxlKToKKyAgICAgICAgKFdlYkNvcmU6OkNTU1BhcnNlcjo6Y3JlYXRlUGFnZVJ1bGUpOgor ICAgICAgICAoV2ViQ29yZTo6Q1NTUGFyc2VyOjpjcmVhdGVSZWdpb25SdWxlKToKKworMjAxMi0x MC0wNSAgQWxleGFuZGVyIFBhdmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgorCiAgICAgICAg IFdlYiBJbnNwZWN0b3I6IFtTdHlsZXNdIFVuYWJsZSB0byBlZGl0IHByb3BlcnRpZXMgaW4gYnJv a2VuIHN0eWxlc2hlZXRzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD05ODI0NgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2Vy LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCmluZGV4IGQzNTRjNGRhMDQz MWJkMWZlNjY3NjM5YjM3MjExNzk3M2YwMzhlZjAuLjI1OGYyMTgxNWVhOTEwOWZlMThmMDJiZTg2 MTRlYzJhZGRlNjdiOGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCkBAIC05OTI1LDggKzk5 MjUsMTAgQEAgTWVkaWFRdWVyeVNldCogQ1NTUGFyc2VyOjpjcmVhdGVNZWRpYVF1ZXJ5U2V0KCkK IAogU3R5bGVSdWxlQmFzZSogQ1NTUGFyc2VyOjpjcmVhdGVJbXBvcnRSdWxlKGNvbnN0IENTU1Bh cnNlclN0cmluZyYgdXJsLCBNZWRpYVF1ZXJ5U2V0KiBtZWRpYSkKIHsKLSAgICBpZiAoIW1lZGlh IHx8ICFtX2FsbG93SW1wb3J0UnVsZXMpCisgICAgaWYgKCFtZWRpYSB8fCAhbV9hbGxvd0ltcG9y dFJ1bGVzKSB7CisgICAgICAgIHBvcFJ1bGVEYXRhKCk7CiAgICAgICAgIHJldHVybiAwOworICAg IH0KICAgICBSZWZQdHI8U3R5bGVSdWxlSW1wb3J0PiBydWxlID0gU3R5bGVSdWxlSW1wb3J0Ojpj cmVhdGUodXJsLCBtZWRpYSk7CiAgICAgU3R5bGVSdWxlSW1wb3J0KiByZXN1bHQgPSBydWxlLmdl dCgpOwogICAgIG1fcGFyc2VkUnVsZXMuYXBwZW5kKHJ1bGUucmVsZWFzZSgpKTsKQEAgLTEwMDM4 LDYgKzEwMDQwLDcgQEAgU3R5bGVSdWxlQmFzZSogQ1NTUGFyc2VyOjpjcmVhdGVGb250RmFjZVJ1 bGUoKQogICAgICAgICAgICAgLy8gaGF2ZSAnaW5pdGlhbCcgdmFsdWUgYW5kIGNhbm5vdCAnaW5o ZXJpdCcgZnJvbSBwYXJlbnQuCiAgICAgICAgICAgICAvLyBTZWUgaHR0cDovL2Rldi53My5vcmcv Y3Nzd2cvY3NzMy1mb250cy8jZm9udC1mYW1pbHktZGVzYwogICAgICAgICAgICAgY2xlYXJQcm9w ZXJ0aWVzKCk7CisgICAgICAgICAgICBwb3BSdWxlRGF0YSgpOwogICAgICAgICAgICAgcmV0dXJu IDA7CiAgICAgICAgIH0KICAgICB9CkBAIC0xMDEyNyw3ICsxMDEzMCw4IEBAIFN0eWxlUnVsZUJh c2UqIENTU1BhcnNlcjo6Y3JlYXRlUGFnZVJ1bGUoUGFzc093blB0cjxDU1NQYXJzZXJTZWxlY3Rv cj4gcGFnZVNlbGVjCiAgICAgICAgIHBhZ2VSdWxlID0gcnVsZS5nZXQoKTsKICAgICAgICAgbV9w YXJzZWRSdWxlcy5hcHBlbmQocnVsZS5yZWxlYXNlKCkpOwogICAgICAgICBwcm9jZXNzQW5kQWRk TmV3UnVsZVRvU291cmNlVHJlZUlmTmVlZGVkKCk7Ci0gICAgfQorICAgIH0gZWxzZQorICAgICAg ICBwb3BSdWxlRGF0YSgpOwogICAgIGNsZWFyUHJvcGVydGllcygpOwogICAgIHJldHVybiBwYWdl UnVsZTsKIH0KQEAgLTEwMTQwLDggKzEwMTQ0LDEwIEBAIHZvaWQgQ1NTUGFyc2VyOjpzZXRSZXVz YWJsZVJlZ2lvblNlbGVjdG9yVmVjdG9yKENTU1NlbGVjdG9yVmVjdG9yKiBzZWxlY3RvcnMpCiAK IFN0eWxlUnVsZUJhc2UqIENTU1BhcnNlcjo6Y3JlYXRlUmVnaW9uUnVsZShWZWN0b3I8T3duUHRy PENTU1BhcnNlclNlbGVjdG9yPiA+KiByZWdpb25TZWxlY3RvciwgUnVsZUxpc3QqIHJ1bGVzKQog ewotICAgIGlmICghY3NzUmVnaW9uc0VuYWJsZWQoKSB8fCAhcmVnaW9uU2VsZWN0b3IgfHwgIXJ1 bGVzKQorICAgIGlmICghY3NzUmVnaW9uc0VuYWJsZWQoKSB8fCAhcmVnaW9uU2VsZWN0b3IgfHwg IXJ1bGVzKSB7CisgICAgICAgIHBvcFJ1bGVEYXRhKCk7CiAgICAgICAgIHJldHVybiAwOworICAg IH0KIAogICAgIG1fYWxsb3dJbXBvcnRSdWxlcyA9IG1fYWxsb3dOYW1lc3BhY2VEZWNsYXJhdGlv bnMgPSBmYWxzZTsKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGMzMjJlZWM3MTY2NWI1NzUxMjg1NmU1MDczYTIyZDI2YjQ1 MDBiYmIuLmVmNTczNmFiM2YwYjM1MGNhN2U4ZjE1OGJlZDY5OTI5MzgwNTA0NjUgMTAwNjQ0Ci0t LSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAg LTEsNSArMSwxNSBAQAogMjAxMi0xMC0wNSAgQWxleGFuZGVyIFBhdmxvdiAgPGFwYXZsb3ZAY2hy b21pdW0ub3JnPgogCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFNlbWFudGljYWxseSBpbmNvcnJl Y3QgQ1NTIHJ1bGVzIHJlc3VsdCBpbiBicm9rZW4gc291cmNlIGNvZGUgZGF0YQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTg1MjAKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rvci9zdHlsZXMv cGFyc2Utc3R5bGVzaGVldC1lcnJvcnMtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGluc3BlY3Rv ci9zdHlsZXMvcGFyc2Utc3R5bGVzaGVldC1lcnJvcnMuaHRtbDoKKworMjAxMi0xMC0wNSAgQWxl eGFuZGVyIFBhdmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgorCiAgICAgICAgIFdlYiBJbnNw ZWN0b3I6IFtTdHlsZXNdIFVuYWJsZSB0byBlZGl0IHByb3BlcnRpZXMgaW4gYnJva2VuIHN0eWxl c2hlZXRzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05 ODI0NgogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3Ivc3R5bGVzL3BhcnNlLXN0 eWxlc2hlZXQtZXJyb3JzLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9zdHls ZXMvcGFyc2Utc3R5bGVzaGVldC1lcnJvcnMtZXhwZWN0ZWQudHh0CmluZGV4IDAxOGJmOGM0NDVl ZDQyMzVlNDRiMGExN2VhZjlhNWRkOGZmZmY5ZDEuLmMxN2MzNDQ4NjEzNDFiNTVkMmY4MmM5M2Y1 MTdhMDVmMzM2OTdkN2QgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9zdHlsZXMv cGFyc2Utc3R5bGVzaGVldC1lcnJvcnMtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2lu c3BlY3Rvci9zdHlsZXMvcGFyc2Utc3R5bGVzaGVldC1lcnJvcnMtZXhwZWN0ZWQudHh0CkBAIC0y MSw0ICsyMSwxNiBAQCBib2R5OiBbcmVndWxhcl0gewogYm9keTogW3JlZ3VsYXJdIHsKICAgICBb J2NvbG9yJzoncGFnZS1ibG9jaycgbm9uLXBhcnNlZF0gQFs1LTIzXSBhY3RpdmUKIH0KK2JvZHk6 IFtyZWd1bGFyXSB7CisgICAgWydjb2xvcic6J2JlZm9yZS1pbXBvcnQnIG5vbi1wYXJzZWRdIEBb NS0yNl0gYWN0aXZlCit9Citib2R5OiBbcmVndWxhcl0geworICAgIFsnY29sb3InOidhZnRlci1p bXBvcnQnIG5vbi1wYXJzZWRdIEBbNS0yNV0gYWN0aXZlCit9Citib2R5OiBbcmVndWxhcl0gewor ICAgIFsnY29sb3InOidhZnRlci1pbnZhbGlkLWZvbnQtZmFjZScgbm9uLXBhcnNlZF0gQFs1LTM2 XSBhY3RpdmUKK30KK2JvZHk6IFtyZWd1bGFyXSB7CisgICAgWydjb2xvcic6J2FmdGVyLWludmFs aWQtcmVnaW9uJyBub24tcGFyc2VkXSBAWzUtMzNdIGFjdGl2ZQorfQogCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9pbnNwZWN0b3Ivc3R5bGVzL3BhcnNlLXN0eWxlc2hlZXQtZXJyb3JzLmh0bWwg Yi9MYXlvdXRUZXN0cy9pbnNwZWN0b3Ivc3R5bGVzL3BhcnNlLXN0eWxlc2hlZXQtZXJyb3JzLmh0 bWwKaW5kZXggMzVhZjcyNzZlODE4NjA2NzQ4M2IyMTY0NDdhNTNhYmIzZDkzNDIxYS4uOTk4OGE0 NGU2ZmNlMTVhMzk4YWI0MzRhMGYxYTY3ZmY5Mjc5ZGM5NiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvaW5zcGVjdG9yL3N0eWxlcy9wYXJzZS1zdHlsZXNoZWV0LWVycm9ycy5odG1sCisrKyBiL0xh eW91dFRlc3RzL2luc3BlY3Rvci9zdHlsZXMvcGFyc2Utc3R5bGVzaGVldC1lcnJvcnMuaHRtbApA QCAtODUsNiArODUsMzAgQEAgYm9keSB7CiAgICAgY29sb3I6IHBhZ2UtYmxvY2s7CiB9CiA8L3N0 eWxlPgorPHN0eWxlPgorYm9keSB7CisgICAgY29sb3I6IGJlZm9yZS1pbXBvcnQ7Cit9CitAaW1w b3J0ICJmb28iOworYm9keSB7CisgICAgY29sb3I6IGFmdGVyLWltcG9ydDsKK30KKzwvc3R5bGU+ Cis8c3R5bGU+CitAZm9udC1mYWNlIHsKKyAgICBmb250LWZhbWlseTogaW5pdGlhbDsKK30KK2Jv ZHkgeworICAgIGNvbG9yOiBhZnRlci1pbnZhbGlkLWZvbnQtZmFjZTsKK30KKzwvc3R5bGU+Cis8 c3R5bGU+CitALXdlYmtpdC1yZWdpb24gJV4lIHsKK30KK2JvZHkgeworICAgIGNvbG9yOiBhZnRl ci1pbnZhbGlkLXJlZ2lvbjsKK30KKzwvc3R5bGU+CiA8L2hlYWQ+CiAKIDxib2R5IG9ubG9hZD0i cnVuVGVzdCgpIj4K